- 17 Nov, 2020 40 commits
-
-
arthursonzogni authored
Turn the IPC struct: FrameHostMsg_DidCommitProvisionalLoad_Params Into a mojo struct mojom::DidCommitProvisionalLoadParams This is mostly straigforward, except: 1. The functions have been updated to correctly specify whether ownership over this struct is passed or not. Use one of "const T&" / "T*", "TPtr*". 2. Mojo checks the required params are populated. This forced me to update several unittests to construct the required params. Like the referrer or the navigation_token. 3. blink::mojom::Referrer is used instead of the old content::Referrer This required adding (temporarily) the conversion between both when needed. Fixed: 1145888 Bug: 1145888 Change-Id: Ib94cff3921d0212d8c1556062326d6cb6d0dcba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529096Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#828123}
-
Wolfgang Beyer authored
Send a `Page.DocumentOpened` event via CDP when an iframe's content is edited via JS. Writing to an iframe's document via JS is not considered a navigation, therefore no `Page.Navigated` CDP event is emitted. But since writing to an iframe's document can change attributes which DevTools needs to be informed about, the `Page.DocumentOpened` event is emitted instead. Previously only a refresh of DevTools would let DevTools know about changes to an iframe caused by JS manipulation of said iframe. Example (see http://doc/1gczarAME7AATGHwqm_IDqcGFlOM6DLAoX9rqetv4Rx0): There is a 'frameNavigated' event for the initial load of an iframe. If there is a 'document.write' for this iframe right away, there is no 'frameNavigated' event for this iframe at all. Frontend CL: https://crrev.com/c/2507793 (needs to be merged first, this will fix the failing tests, which fail because the frontend cannot handle unknown CDP events) Bug: chromium:1140540, chromium:1140481 Change-Id: I92a659b7ab8b1cb7ae50e28df40b8ca9b0bf8c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498482 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Wolfgang Beyer <wolfi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#828122}
-
Sreeja Kamishetty authored
In order to send different detached notifications, we need to make sure that WebContents is associated with will_delete. This becomes essential with the new ClosedTabCache feature, which changes the assumption that the WebContents will be deleted after detaching. We do the following in this CL to fix this scenario: - Removes ‘will_delete’ from TabStripModel::DetachNotifications struct and Move it to TabStripModel::DetachedWebContents. - Move TabStripModelChange::Remove ‘will_be_deleted’ member to TabStripModelChange::Removed contents with addition of will_be_deleted to ContentsWithIndex. ContentsWithIndexAndWillBeDeleted is added to TabStripModelChange to associate WebContents with will_be_deleted used inside Remove struct. BUG=1146370 Change-Id: Ifa2d1378449e057e8ce297ce6f8f6e31bed90d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522585Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#828121}
-
Antonio Sartori authored
CSPEE (Content-Security-Policy: Embedded Enforcement) is a mechanism for a parent frame to enforce some Content Security Policies on a child frame. This was originally implemented in Blink, and later moved to the Browser. The Blink implementation has been put behind a feature flag and deactivated. Since it seems that the new implementation in the Browser is working correctly, the old Blink code and the feature flag are now safe to remove. Bug: 1094909 Change-Id: If299c5561b9f55330234c6fdf85d3faf2c4462d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410408Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#828120}
-
Maggie Chen authored
GPU.SupportsDX12 GPU.D3D12FeatureLevel Viz.DisplayCompositor.RootDamageRect.Underlay Viz.DisplayCompositor.RootDamageRect.Overlay Bug: 1149513, 1140045 Change-Id: If7abff2968708f2f4c234d87f55d6bb26b25c2ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543184 Auto-Submit: Maggie Chen <magchen@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#828119}
-
Leo Lai authored
EULA screen doesn't fetch the password anymore and the removed class doesn't have any other consumers. BUG=b:172748724 BUG=b:168852740 TEST=browser_tests. Change-Id: Ic72312280fd7768b36ebba6aff476eb7aec50f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536658 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#828118}
-
Camillo Bruni authored
Remove v8::ScriptCompiler::CompileOptions option that is no longer supported from ScriptStreamer. The V8-side changes have landed in 8.8: https://crrev.com/c/2498698 Bug: 1061857, v8:11165 Change-Id: I06b8c23cfb1ed3b397c0df024366848f8b7c1636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540453Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#828117}
-
Pavol Marko authored
This CL contains a few changes to make working with poilcy-recommended (marked as "Recommended" in ONC) IP and Namserver settings possible in the Chrome OS network settings UI. (1) ui/webui/resources/cr_components/chromeos/network/ network_nameservers.js (1.1) When selecting 'custom' in the UI, introduce explicit priority among the nameservers to display: policy-enforced > previously user-entered > recommended > active (getCustomNameServers) (1.2) |savedCustomNameservers_|: Keep track of the most recent manually selected nameservers type, to be able to handle the case of 'google' nameservers coming in from the backend by selecting 'custom' (if the user last selected 'custom') or 'google' if the user never selected anything or something else than 'custom'. (1.3) setNameservers_(): Get rid of async hack. (2) ui/webui/resources/cr_components/chromeos/network/ network_ip_config.js Correctly merge saved/backend-provided IPv4 settings with defaults on changing to "automatic". Bug: 1108922, 1109660, 1109670 Change-Id: I18c2ab5ae69a4922f3d63584975f6f3424dee9e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449449 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#828116}
-
Leo Lai authored
Making "override"s explicit for future proof. BUG=None TEST=build ok. Change-Id: I4cd0eda8fb5a979e86900579a83dd93d565efca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543723 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605538580-853d8fcb404f37acc68f0179b58be2e881687944.profdata to chrome-win32-master-1605560272-3c812cc827eaf1991f3c05cfa46c3374e2d6a16e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I822b6cde6eabf1214573b4c5627c273e100e2115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542590Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828114}
-
Jérémie Boulic authored
Bug: 1133186 Change-Id: If8ad75ab5b8d70b470deb3821bbe084990c4288e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542939 Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#828113}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605571148-8e0456d32b4535b8a26e31eb6f964ebd3417aaef.profdata to chrome-linux-master-1605592392-dc172d915909da26cabde4fc0f34ef46d817ea1e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I29a6f8fdd5e4bd17a07a53cddfdc60d1c4cdf68b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543982Reviewed-by:
-
Marc Treib authored
Remove mathp who isn't working on this anymore, and instead add mahmadi and tiborg. Bug: none Change-Id: If79cb03d1fbe3891db3d8df9b54f03bf8b707d97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540450Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#828111}
-
Maggie Chen authored
GPU.GPUChannelHostWaitTime2 is used for the gpu watchdog finch and has a histogram range from 1 second to 120 seconds. Now, it's removed at the end of the finch. A new histogram GPU.GPUChannelHostWaitTime3 is added to record the normal time the browser UI thread spends blocked after GpuChannelHost sends IPC message to the GPU process. The histogram range is from 5 microsecond to 1 second. Also restore the original pending_sync.done_event->Wait() in GpuChannelHost::Send() Bug: 1140089 Change-Id: I46c8028fe26ce4cf206a90150f39d135f411ed19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489022Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Liquan (Max) Gu authored
Changes: * PRService takes over the handling of the not-show error. Before the CL, triggerPaymentAppUiSkipIfApplicable(), continueShow() handles the not-show error (e.g., log, disconnect) in CPRService. After the CL, the not show error is handled in PRService; the methods simply returns the error, if any, to PRService. Behaviour changes: * When MINIMAL_UI_SUPPRESSED happens, these two behaviours are added to the error handling: (1) the journey logger logs a not-show event, (2) sObserverForTest.onPaymentRequestServiceShowFailed() is invoked. * When continueShow() fails, this behaviour is added to the error handling: sObserverForTest.onPaymentRequestServiceShowFailed() is invoked. Bug: 1148902 Change-Id: Ib67e630c14c07da29e9821c5d94a44e895bb2106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537118 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#828109}
-
Michael Lippautz authored
Scan should know what it needs for book keeping. Bug: 11297512 Change-Id: Ie73d362a9632f5b5eb365c0ce1fba72c62887f44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541864Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Melissa Zhang authored
This CL adds animation to Sharesheet appear and disappear. Appear has a opacity fade in from 0 - 100 in 100ms with linear curve and scale fade in 80-100% in 150ms with curve (0.4,0,0.2,1). Disappear is a 100-0 in 80ms linear opacity fade out. In this CL we also disable sharesheet close on deactivate when ShareActions have been selected. Bug: 1148692 Change-Id: Id6a360438271ad62f5911ed97984c3230a448332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537502 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#828107}
-
Jiewei Qian authored
This CL adds the necessary logic to ensure system web apps are launched to the active desktop, if the launch is initiated by a profile whose desktop is inactive (e.g. in the background). This scenario can occur on a multi-user ChromeOS logins, where the user logs in multiple accounts and switches the desktop among them. Fixed: 1114939 Change-Id: Ieeb101c196bed5b4533e1f56e72df628ef50c61b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532143 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#828106}
-
danielng authored
Test images don't actually download the DLC, so installing while offline works. Normal images, however, do need to download the DLC when installing Borealis. Adding an extra check to ensure that users are online and also attached a new error to this case. Bug: b/171672034 Change-Id: I351c23f361a9857b4783973820d9f2c4f244a64d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539866 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#828105}
-
Eric Orth authored
Created a new DnsResponseResultExtractor class to handle the higher- level parsing of finding and extracting the applicable results from a DnsResponse object. Logic generally moved over from HostResolverManager::DnsTask without any functional change except that nullptr DnsResponse no longer allowed for experimental query types (INTEGRITY and HTTPS). Because these types should not be fatal for a DnsTask, code would previously continue into DnsTask::Parse{Integrity|Https}DnsResponse() even if there was no DnsResponse (e.g. due to connection error), and the parse method would be responsible for inventing the relevant non-fatal result. Now with the new independent extractor class, it would be too inconsistent for it to sometimes require a DnsResponse and sometimes not, so I made it always required and created a new GetExperimentalDefaultResults() method for HostResolverManager::DnsTask to call when it doesn't have a DnsResponse. Address extraction still has its special case extraction logic in DnsResponse (TODO to convert over to those going through the new class). This is unchanged except that the DnsResponse::Result enum has been replaced by the equivalent result enum from the new class (so that DnsTask only needs to deal with 1 result type). Bug: 1147247 Change-Id: Ibb1b4b56ab04d7d85755bb05fd4c8ab915b38709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531115Reviewed-by:Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#828104}
-
Yury Khmel authored
This extends autotest API to return pre-start and start times as ARC state. Pre-start time means mini-ARC start time when we initiate the initial ARC setup process that finally starts Android root init (and on P, other processes like Zygote too). Using pre-start time allows to calculate the overhead time for Android start preparation as a difference between pre-start time and start time of the root Android process init. For the container it includes arc_setup activity and for VM it includes concierge start and booting guest Linux kernel. BUG=b:172851375 TEST=Browser test and in context of tast test Change-Id: Ieb299941849456ecc51de7d3b3d447b67b210fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536078 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Auto-Submit: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#828103}
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/foreground/js/metadata: - content_metadata_provider.js - content_metadata_provider_unittest.js - id3_parser.js - metadata_cache_set.js - metadata_cache_set_unittest.js - metadata_dispatcher.js - metadata_model.js - metadata_model_unittest.js - multi_metadata_provider.js - multi_metadata_provider_unittest.js In //ui/file_manager/file_manager/foreground/js: - thumbnail_loader.js - thumbnail_loader_unittest.js Bug: 1133186 Change-Id: I5d6c9408bdccdfc6fd70a3f34775c528ca5aa914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543722 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
-
Darwin Huang authored
Bug: 1145787 Change-Id: I8d4b1edfbdf2dc739d2b545cb828c35b62a5cfd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520321 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#828101}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b7e7aba113f5..67c1571570a0 2020-11-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8749cb8f182d9a6e54bfd71c3077208830753abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543826Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f92a7636da65..808ef50106ef 2020-11-17 hypan@google.com Add "third_party/gsutil" to cipd.yaml for devil 2020-11-16 bsheedy@chromium.org [typ] Use requests for ResultSink 2020-11-13 hypan@google.com Add CIPD create instruction cipd.yaml that packages devil If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1108014,chromium:1147992 Tbr: rmhasan@google.com Change-Id: I3f3bbd92222e9e80c84939f0bdbfab39d4379318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542748Reviewed-by:
-
David Van Cleve authored
We rolled out ReducedReferrerGranularity, which changes the default referrer policy to strict-origin-when-cross-origin, to 100% in M85 stable. To clean up the experiment, we need to enable the behavior by default. This will take effect in M88; we'll follow up by removing the flag, the corresponding enterprise policy, and the corresponding field trial testing configuration. Changing this base::Feature's default value entails cleaning up the remaining tests that weren't within the field trial testing config's scope. These changes are mostly straightforward, involving updating expectations of full-URL referrers to expectations of the corresponding origins, but some tests require logic changes to make sure that they still cover the desired behavior. (For instance, multiple tests previously expected origins in order to test that a particular, arbitrary, non-default referrer policy took effect: to achieve a similar effect, this CL updates these tests to now expect full URLs and swaps in non-default full-URL-generating policies for the prior non-default origin-generating policies.) Launch approval: crbug.com/1019930 Spec change: https://github.com/w3c/webappsec-referrer-policy/pull/142 Bug: 1014207, 1131688 Change-Id: Ib575af6a858641fb1fe2c8de73941f5702d88191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429247Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#828098}
-
Jan Wilken Dörrie authored
This change makes use of the recently added base::fixed_flat_map in cpp_bundle_generator. The generated code for GeneratedSchemas::Get will now look as follows: // static base::StringPiece GeneratedSchemas::Get(base::StringPiece name) { static constexpr auto kSchemas = base::MakeFixedFlatMap<base::StringPiece, base::StringPiece>({ ... {"namespace", kNamespace}, ... }); auto it = kSchemas.find(name); return it != kSchemas.end() ? it->second : base::StringPiece(); } Change-Id: I73ced3f7f40eacbd630089968ad46a6e664743a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532076Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#828097}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c669bf529619..4f96bf19941b 2020-11-17 m.maiya@samsung.com Remove duplicate entry of glProgramUniformMatrix4fvEXT in gl.xml If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I5b39327a8c04066a3f18fb0a4be8705d31418264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543823Reviewed-by:
-
Takashi Sakamoto authored
This reverts commit 527ae681. Reason for revert: suspect causing chrome_all_tast_tests failure on chromeos-kevin-chrome - ui.ShelfLaunchedApps First detected build: https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-chrome/10864 Sample log: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8863425670685038096/+/steps/chrome_all_tast_tests_on_ChromeOS/0/logs/Deterministic_failure:_ui.ShelfLaunchedApps__status_FAILURE_/0 -- Unexpected apps in the shelf. Expected only Chrome: [0x2f76930 0x2f76960] -- Original change's description: > Reland "CrOS: Add Files app to default shelf pins in second position" > > This is a reland of 5d6ecbfb > > The failing Tast test (ui.ShelfLaunchedApps) has been updated to > ensure it continues passing after this CL is landed. > > This is the second of a chain of 3 CLs: > > 1. crrev.com/c/2538305: Allow Files app to be pinned by default in > ui.ShelfLaunchedApps > 2. crrev.com/c/2538857: Add Files app to default shelf pins in second > position > 3. crrev.com/c/2538307: Update ui.ShelfLaunchedApps to ensure Chrome and > Files are always pinned > > Original change's description: > > CrOS: Add Files app to default shelf pins in second position > > > > This adds the Files app to the spot after the Chrome icon, for new users > > only. There's also some variations of the default pin layout controlled > > by a Finch experiment, I've moved the Files app up in those layouts for > > consistency. > > > > This change was requested for M88 and will be merged back. > > > > Bug: 1148519 > > Change-Id: Iae54561fec599b813ba97e82a5678fa834a02db2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537214 > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > > Auto-Submit: Tim Sergeant <tsergeant@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#827272} > > Bug: 1148519 > Change-Id: I9186b43a651dea4c4de9e46f849d35da9cc6062c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538857 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Tim Sergeant <tsergeant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827981} TBR=xiyuan@chromium.org,tsergeant@chromium.org Change-Id: I36e3778d368973d250824541c422d68b1679babd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1148519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543883Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#828095}
-
Melissa Zhang authored
This CL updates browser tests to accommodate for motion when the |sharesheet_bubble_view| appears and disappears. Bug: 1148692 Change-Id: I5ca2eafc2bc5bc2392657d21c39998e532b1a7f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543529 Auto-Submit: Melissa Zhang <melzhang@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#828094}
-
Swapnil authored
We check the list of enabled and disabled extensions in ExtensionPolicyTest.ExtensionRecommendedInstallationMode browsertest. In Windows, the extension is disabled by default as the user is prompted before enabling the extension. On other platforms, the extension is enabled by default. This CL overrides the prompting flag to false. Bug: 1006342 Change-Id: I1d783a8fc381b50e84e5ba85b5c9f37e58b7a986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537641Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#828093}
-
Melissa Zhang authored
This reverts commit ebc8ccab. Reason for revert: Enabling flag for M89 Original change's description: > Revert "[Sharesheet] Turn on flags to enable sharesheet by default." > > This reverts commit 2374eacf. > > Reason for revert: Punting sharesheet to 89 so flags need to be disabled. > > Original change's description: > > [Sharesheet] Turn on flags to enable sharesheet by default. > > > > This CL turns on the kIntentHandlingSharing and kSharesheet flags to > > enable sharesheet feature by default. > > > > BUG=1097623 > > > > Change-Id: Idff4e37934fb730b7f83b86206d555a8c049f12e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460206 > > Commit-Queue: Maggie Cai <mxcai@chromium.org> > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#816071} > > TBR=dominickn@chromium.org,mxcai@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1097623 > Change-Id: I4d4914ad4ec363c2a63fdaaf7c55163dd1205f99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501161 > Reviewed-by: Melissa Zhang <melzhang@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Maggie Cai <mxcai@chromium.org> > Commit-Queue: Melissa Zhang <melzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821103} TBR=dominickn@chromium.org,mxcai@chromium.org,melzhang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1097623 Change-Id: I47b8cbcc1f05a6092db13b0fe645aad6f06c0325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543530Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#828092}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I55a92613e86231ee5c0e67873c8ee45160de4d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542581Reviewed-by:
-
Philipp Hancke authored
BUG=webrtc:12181 Change-Id: Ifaa94e2ac7124a7c275093059c7f67790009aacc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542382 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#828090}
-
Takashi Sakamoto authored
This reverts commit 86556051. Reason for revert: suspect causing "generate_build_files" failure on builder "win-chrome" and "win64-chrome" First detected build: https://ci.chromium.org/p/chrome/builders/ci/win64-chrome/10142 https://ci.chromium.org/p/chrome/builders/ci/win-chrome/17094 Sample log: --- ERROR at //chrome/browser/win/conflicts/incompatible_applications_browsertest.cc:21:11: Can't include this header from here. #include "chrome/browser/browser_process.h" ^------------------------------- The target: //chrome/browser/win/conflicts:browser_tests is including a file from the target: //chrome/browser:browser_process --- Original change's description: > Extract browser_process.h/cc into own gn target > > This CL pulls out browser_process.h and browser_process.cc into their > own gn target so that other gn targets can depend on it without creating > cyclic dependencies with //chrome/browser:browser. > > This is required for CL: > https://chromium-review.googlesource.com/c/chromium/src/+/2528519 > > Bug: 1147410, 883570, 925153 > Change-Id: I17ef1f0b1683c4abb7588a6ef24ec89f15647545 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529309 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Reviewed-by: Glen Robertson <glenrob@chromium.org> > Auto-Submit: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828077} TBR=fgorski@chromium.org,alancutter@chromium.org,glenrob@chromium.org Change-Id: Idbbe592586e2469f59b9d7b51bf584bd94aa86e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1147410 Bug: 883570 Bug: 925153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543169Reviewed-by:
-
Keishi Hattori authored
Use nullptr instead of NULL for places that gives errors when we do the MiraclePtr rewrite. The error is error: conversion from 'int' to 'CheckedPtr<>' is ambiguous Bug: 1073933 Change-Id: Idcdbf9cc986bd03080d0d00ad0556ee80fc4fcdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537451 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#828088}
-
Melissa Zhang authored
This reverts commit f878d2a2. Reason for revert: Re-enabling flag for M89 Original change's description: > Revert "[Sharesheet] Run file manager browser tests with sharesheet enable." > > This reverts commit efbf947b. > > Reason for revert: Reverting because we are disabling sharesheet flags by default. > Original change's description: > > [Sharesheet] Run file manager browser tests with sharesheet enable. > > > > This CL updates the option.enable_sharesheet default value to be true to > > run all tests with sharesheet enabled. This is because we turn on the > > sharesheet flags by default. > > > > BUG=1097623 > > > > Change-Id: I8714da4bffa30992ca0caf40a34b5237423c34b3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461666 > > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > > Commit-Queue: Maggie Cai <mxcai@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#816074} > > TBR=lucmult@chromium.org,mxcai@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1097623 > Change-Id: I48580601e1287ae27b3c8be32e199963b8cdc713 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501164 > Reviewed-by: Melissa Zhang <melzhang@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Maggie Cai <mxcai@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Commit-Queue: Melissa Zhang <melzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821095} TBR=noel@chromium.org,lucmult@chromium.org,mxcai@chromium.org,melzhang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1097623 Change-Id: I58c0f13790f66cf337058864eec850078a7ecfa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543862Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/89e3ceea..15247228 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I42812930272783c750b5448cc2318e2d9f1d869b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543316Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828086}
-
Ryan Keane authored
This CL adds DEPS for CmaBackendProxy: - Protobuf is needed for processing of messages sent to/from gRPC (in a future CL) - Openscreen is needed for proto files Change-Id: I376015023915d4ba96a77fee6604726d3b450a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537231Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Ryan Keane <rwkeane@google.com> Cr-Commit-Position: refs/heads/master@{#828085}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605538580-6a865849c18026af9e6bfd8c91f845d03275941b.profdata to chrome-win64-master-1605560272-77c0d8d0117a28bac6ffdb0ad2fa6b677cbad6f9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3ed12a38b3649cf90286526a677f16b760a01765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543446Reviewed-by:
-
