- 23 May, 2017 2 commits
-
-
michaeln authored
This CL adds several Storage.BytesRead.XXX and Storage.BytesWritten.XXX histograms. The size of each read or write is logged at a low level for: CacheStorage, IndexedDB, ServiceWorker, and AppCache. Storage.BytesXXX.LevelDBEnv.IDB corresponds to IndexedDB. Some other leveldb consumers are also instrumented, for example LevelDBEnv.ServiceWorker, but not all of them are differentiated from one another, they are logged as LevelDBEnv, and some aren't instrumented at all. Here are the labels... <histogram_suffixes name="Storage.Bytes" separator="."> <suffix name="DiskCache.AppCache" label="AppCache usage."/> <suffix name="DiskCache.CacheStorage" label="CacheStorage usage."/> <suffix name="DiskCache.ServiceWorker" label="ServiceWorker scriptcache usage."/> <suffix name="LevelDBEnv" label="Undifferentiated leveldb usage."/> <suffix name="LevelDBEnv.IDB" label="IndexedDB usage."/> <suffix name="LevelDBEnv.ServiceWorker" label="ServiceWorker database usage."/> <suffix name="MojoLevelDBEnv" label="Mojo leveldb component usage."/> <affected-histogram name="Storage.BytesRead"/> <affected-histogram name="Storage.BytesWritten"/> </histogram_suffixes> BUG=605758 Review-Url: https://codereview.chromium.org/2858133002 Cr-Commit-Position: refs/heads/master@{#473752}
-
twellington authored
Removes the flags guarding the new NTP over the tab switcher design and replaces ChromeHomeNewTabPageTest with BottomSheetNewTabControllerTest. BUG=695973 Review-Url: https://codereview.chromium.org/2891343003 Cr-Commit-Position: refs/heads/master@{#473751}
-
- 22 May, 2017 38 commits
-
-
jialiul authored
BUG=724905 Review-Url: https://codereview.chromium.org/2895323002 Cr-Commit-Position: refs/heads/master@{#473750}
-
ios-autoroller authored
TBR=smut Review-Url: https://codereview.chromium.org/2896113002 Cr-Commit-Position: refs/heads/master@{#473749}
-
phulce authored
* Uses window.location.href over mainTarget.inspectedURL when available BUG=724558 R=dgozman,paulirish Review-Url: https://codereview.chromium.org/2895913003 Cr-Commit-Position: refs/heads/master@{#473748}
-
chengx authored
This change defers syncing TopSites with history until the first tab closure and ignores any TopSites updates that arrive before that time. It also makes the category titles ever-present in the JumpList and removes the old balancing strategy that used to show more most visited items when there were fewer than 3 recently closed items. The JumpList will now retain its items from a previous launch until the first tab closure, making it more useful early on in the browser's lifetime. Also, there will be no unnecessary TopSites syncs now if an user launches Chrome but shuts it down before opening any tabs. After that initial tab closure, all old recently closed items are lost as it is not possible to query Windows for them. Removal of the balancing strategy trims out waste resulting from fetching 9 items initially, which are then trimmed down as tabs are closed. BUG=721484, 721486 Review-Url: https://codereview.chromium.org/2865133003 Cr-Commit-Position: refs/heads/master@{#473747}
-
yolandyan authored
For more on JUnit4 migration, please check src/testing/android/docs/junit4.md BUG=640116 Review-Url: https://codereview.chromium.org/2875393003 Cr-Commit-Position: refs/heads/master@{#473746}
-
Stephen Martinis authored
There were issues in the past, I think, so this might not work, but we do need release builds. Bug: Change-Id: I29306490e9cb322fd136613b90478b3900b8e725 Reviewed-on: https://chromium-review.googlesource.com/511224Reviewed-by:
rnephew <rnephew@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#473745}
-
tombergan authored
Not enabled on Android because it requires calling video.play(). BUG=717732 Review-Url: https://codereview.chromium.org/2886893010 Cr-Commit-Position: refs/heads/master@{#473744}
-
Sam McNally authored
Change-Id: I27b300eeb8d08b0deba54393cf872b54afbf8714 Reviewed-on: https://chromium-review.googlesource.com/509333Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#473743}
-
renjieliu authored
As it caused if there's cache, even translation succeeded it will still reports failure. :( We will revisit the fix after googleo@'s refactoring. BUG=724355 Review-Url: https://codereview.chromium.org/2897573002 Cr-Commit-Position: refs/heads/master@{#473742}
-
rlanday authored
I previously changed all the header includes in third_party/WebKit/public/web that started with "../" to no longer use relative paths because include paths of this pattern can include headers that aren't actually specified as build dependencies (and also, engineers adding new includes of this form can run into lint errors in some cases). aelias@ pointed out on crbug/724264 that there are only a small number of these relative include paths in other directories (ignoring other repos that get pulled in). This CL fixes these remaining includes. BUG=724264 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2897503002 Cr-Commit-Position: refs/heads/master@{#473741}
-
rhalavati authored
Network traffic annotation is added to network requests of: chrome/browser/net/proxy_browsertest.cc chrome/browser/predictors/resource_prefetch_predictor_unittest.cc chrome/browser/prerender/prerender_resource_throttle_unittest.cc chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc BUG=656607 Review-Url: https://codereview.chromium.org/2895173002 Cr-Commit-Position: refs/heads/master@{#473740}
-
yusufo authored
For security reasons, we only accept https postMessage origins verified through Digital Asset Links for postMessage. Add a way to early reject all other origins. BUG=719096 Review-Url: https://codereview.chromium.org/2893483007 Cr-Commit-Position: refs/heads/master@{#473739}
-
rbpotter authored
Move NativeLayerStub to a separate file and use the same stub for both the PrintPreviewDestinationSearchTests and the PrintPreviewWebUITests. Also move all print_preview related tests into a subfolder of chrome/test/data/webui/ with the new native_layer_stub.js file. BUG=717296 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2893003003 Cr-Commit-Position: refs/heads/master@{#473738}
-
dpapad authored
BUG=720034 Review-Url: https://codereview.chromium.org/2867663004 Cr-Commit-Position: refs/heads/master@{#473737}
-
spqchan authored
The preference is deprecated and has been replaced by kShowFullscreenToolbar. BUG=590827 Review-Url: https://codereview.chromium.org/2896763003 Cr-Commit-Position: refs/heads/master@{#473736}
-
erg authored
Also removes everything that depends on it, including its inclusion in chrome, where it was never used, along with two subdirectories in mash/, which appeared to be defunct. BUG=722546 Review-Url: https://codereview.chromium.org/2901613002 Cr-Commit-Position: refs/heads/master@{#473735}
-
sky authored
TouchDeviceServer is necessary for hooking up AshTouchTransformController in mus/mash. BUG=705686 TEST=covered by tests R=erg@chromium.org,rockot@chromium.org,tsepez@chromium.org Review-Url: https://codereview.chromium.org/2901563002 Cr-Original-Commit-Position: refs/heads/master@{#473651} Committed: https://chromium.googlesource.com/chromium/src/+/68e20f488cc2ea0216832c8fe3640d9b748595d2 Review-Url: https://codereview.chromium.org/2901563002 Cr-Commit-Position: refs/heads/master@{#473734}
-
pcc authored
Revert of Enable LLD for POSIX LTO builds on Linux. (patchset #1 id:1 of https://codereview.chromium.org/2877913003/ ) Reason for revert: Breaks crash reporting. BUG=716484 Original issue's description: > Enable LLD for POSIX LTO builds on Linux. > > This is a stripped down version of (reverted) > change: https://codereview.chromium.org/2831213006/ > > That change was reverted because ThinLTO regresses the binary > size too much. LLD was a harmless part of the change, > so it's worth enabling it. > > Based on https://codereview.chromium.org/2844883002/ by > krasin@chromium.org, who is no longer with Google. > > BUG=607968 > R=dpranke@chromium.org,thakis@chromium.org > > Review-Url: https://codereview.chromium.org/2877913003 > Cr-Commit-Position: refs/heads/master@{#471532} > Committed: https://chromium.googlesource.com/chromium/src/+/e6a66337552cfd9a9af9471775ad5b67ee588b88 TBR=dpranke@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=607968 Review-Url: https://codereview.chromium.org/2900883002 Cr-Commit-Position: refs/heads/master@{#473733}
-
takumif authored
This CL Adds an UMA metric to record the outcome whenever the Media Route Provider attempts to create a media route controller. BUG=707326 Review-Url: https://codereview.chromium.org/2894623002 Cr-Commit-Position: refs/heads/master@{#473732}
-
rbpotter authored
Start replacing some chrome.send calls with cr.sendWithPromise in print preview by using cr.sendWithPromise for the getInitialSettings message. To avoid breaking tests during transition, also: - Change NativeLayerStub in PrintPreviewWebUITests to inherit from settings.TestBrowserProxy. - Change NativeLayer so that it no longer inherits from cr.EventTarget. - Add an EventTarget member to NativeLayer for dispatching and receiving the print preview messages that have not yet been migrated to use cr.sendWithPromise (will be removed when all messages have been changed). BUG=717296 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2881213003 Cr-Commit-Position: refs/heads/master@{#473731}
-
sbc authored
This fixes the SDK build which was broken when these libraries were moved. BUG=724707 Review-Url: https://codereview.chromium.org/2896703005 Cr-Commit-Position: refs/heads/master@{#473730}
-
eugenebut authored
This is needed because window.hashchange message may not arrive on time and navigation will not be marked as "IsCreatedFromHashChange". This will result in going through "loadURL" flow for the same document navigaitons, which is not correct. BUG=None Review-Url: https://codereview.chromium.org/2898633003 Cr-Commit-Position: refs/heads/master@{#473729}
-
eugenebut authored
This new API will allow removing -[CRWNativeContentProvider controllerForURL:withError:isPost:] callback and replacing it with general purpose WebStateObserver::DidFinishNavigation that takes NavigationContext. BUG=725241 TBR=droger@chromium.org Review-Url: https://codereview.chromium.org/2901633002 Cr-Commit-Position: refs/heads/master@{#473728}
-
jsbell authored
Speculative fix for "bad message" crash that started with removal of these checks. This is a partial revert of https://codereview.chromium.org/2818173003 BUG=724868 R=dmurph@chromium.org Review-Url: https://codereview.chromium.org/2900863002 Cr-Commit-Position: refs/heads/master@{#473727}
-
jzeisloft authored
BUG= Review-Url: https://codereview.chromium.org/2902563003 Cr-Commit-Position: refs/heads/master@{#473726}
-
engedy authored
SuppressedHTTPSFormFetcher is a helper used by FormFetcherImpl to fetch credentials stored for the HTTPS counterpart of a non-secure (i.e HTTP) origin, when the FormFetcherImpl itself is created for an HTTP origin. The suppressed forms are fetched asynchronously, without blocking Consumer::ProcessMatches. This data will be used to measure how often HTTPS credentials cannot be filled on HTTP sites. When no matching HTTP credentials exist for a non-secure origin, but there are suppressed HTTPS credentials, that could indicate a premature `move-to-HTTPS` migration, or simply that the site serves its sign-up or some of its sign-in forms over HTTPS, while others still over HTTP. BUG=720599 Review-Url: https://codereview.chromium.org/2878463003 Cr-Commit-Position: refs/heads/master@{#473725}
-
twellington authored
Increase the max duration recorded for MobileStartup.IntentToCreationTime.ChromeTabbedActivity. BUG=709240 Review-Url: https://codereview.chromium.org/2897573005 Cr-Commit-Position: refs/heads/master@{#473724}
-
qyearsley authored
Specifically, this removes the skip lines added in http://crrev.com/c/490551. This import included the addition of one new directory that has no owners, so it is added to the list in NeverFixTests. The purpose of this is to clean up TestExpectations. Review-Url: https://codereview.chromium.org/2895853002 Cr-Commit-Position: refs/heads/master@{#473723}
-
qinmin authored
All DownloadController java method can be static. So there is no point to hold a java reference. Review-Url: https://codereview.chromium.org/2902453003 Cr-Commit-Position: refs/heads/master@{#473722}
-
pavely authored
Currently client sets insert_after_item_id, but doesn't properly order commit entries with respect to this field. It causes commit to fail on the server under certain conditions: - Two new sibling bookmarks are committed - They get broken into different commit messages with second bookmark being sent in the first message In this case server either expects server id in the field or bookmark being referred to in insert_after_item_id being present in the same message. This field was deprecated since before M26, therefore I'm simply removing the code that sets this field on the client. BUG=722487 R=pnoland@chromium.org Review-Url: https://codereview.chromium.org/2895933003 Cr-Commit-Position: refs/heads/master@{#473721}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/edf8a762190e..bcd8637772e3 $ git log edf8a7621..bcd863777 --date=short --no-merges --format='%ad %ae %s' 2017-05-22 brianosman Revert "Revert "fix ubsan warning"" 2017-05-22 brianosman Revert "fix ubsan warning" 2017-05-22 brianosman Revert "We can mask load and store with just AVX." 2017-05-22 brianosman Revert "add tilers against 1" 2017-05-22 brianosman Revert "mark SkRasterPipelineBlitter final" 2017-05-22 brianosman Revert "fix ubsan warning" 2017-05-22 bsalomon Remove kZeroCopy_GrSurfaceFlag 2017-05-22 msarett Blacklist memory instensive tests on 32-bit bots (part 2) Bug: skia: 2017-05-22 mtklein fix ubsan warning Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I9be699fe612c0027e3194d170126858b41467708 Reviewed-on: https://chromium-review.googlesource.com/510943Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#473720}
-
mdjones authored
This change extends the peeking behavior when there are multiple infobars attempting to show simultaneously. When a new infobar is added, it will peek above the existing ones giving a brief view of it's contents and bringing more attention to it. BUG=721389 Review-Url: https://codereview.chromium.org/2846663002 Cr-Commit-Position: refs/heads/master@{#473719}
-
tonikitoo authored
This only fails when no X11 headers are present on the system and use_ozone = true ozone_platform_wayland = true ozone_platform_x11 = false use_sysroot = false BUG=295089 Review-Url: https://codereview.chromium.org/2892343002 Cr-Commit-Position: refs/heads/master@{#473718}
-
nick authored
Functional changes here are: - Treating an extension-origin "about:blank" iframe as extension, for the purposes of the web_accessible_resources ancestor check. - Treating nested URLs as non-web_accessible_resources for the purposes of subframe navigation (this fixes 661324) These should both be minor, and are incidental. Pure refactoring here is: - Preferring url::Origin() checks (which leads to the functional changes above). - Renaming of variables for clarity. - Hoisting the extension lookup to the top of the function, and eliminating !extension and !registry checks after dealing with the lookup result. - A more efficient lookup of the parent frame, in a way that shouldn't require an "this is safe" apology comment. - Reflow control logic in anticipation of adding new BLOCK cases for platform apps (in a follow-on CL). BUG=661324 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2830893002 Cr-Commit-Position: refs/heads/master@{#473717}
-
Maksim Ivanov authored
It's better to leave this test app mainly for the manual testing purposes and for the whitelist tests, but place the code for the automated tests in another test app. The reason for that is the complexity of updating it: besides changes in the source tree, each updated version has to be published on the Web Store and then the CRX file has to be fetched from it. Therefore this CL makes this decision explicit by reflecting it in the file names, readme file and the constant names. Also an OWNERS file is introduced for it, in order to make the ownership of this code clearer. Bug: chromium:626343 Change-Id: Ic644b55379c45fa2da79db2df2e65c802778a2cc Reviewed-on: https://chromium-review.googlesource.com/509512Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#473716}
-
estade authored
Also remove the function completely where it makes the code simpler: - FrameCaptionButton - ExitWarningWidgetDelegateView - UserCardView BUG=none Review-Url: https://codereview.chromium.org/2901503003 Cr-Commit-Position: refs/heads/master@{#473715}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/671630e52cda..ed75ee25f40a $ git log 671630e52..ed75ee25f --date=short --no-merges --format='%ad %ae %s' 2017-05-22 tsepez CFX_ByteStringC: avoid taking unreferenceable vector::data() ptr. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I4dc5ce447a5f84ed238fb6fd7642d1c017bc53a0 Reviewed-on: https://chromium-review.googlesource.com/511162 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#473714}
-
Bo Liu authored
BUG=689758 Change-Id: Iab841c65ab1a5acdd81b7e3e41015b16edd7ef30 Reviewed-on: https://chromium-review.googlesource.com/511302Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Bo Liu <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#473713}
-