- 14 Jun, 2018 40 commits
-
-
Chris Hamilton authored
This is necessary in order for it to work when the PageAlmostIdle feature is enabled. BUG=829933 Change-Id: Ic3158a984713ceef849788eaa758ecaa255eba5a Reviewed-on: https://chromium-review.googlesource.com/1097421Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#567484}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/75359664993b..9491e5ebed98 git log 75359664993b..9491e5ebed98 --date=short --no-merges --format='%ad %ae %s' 2018-06-14 geofflang@chromium.org Generate framebuffer IDs used in DXGISwapChainWindowSurfaceWGL. Created with: gclient setdep -r src/third_party/angle@9491e5ebed98 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:852399 TBR=cwallez@chromium.org Change-Id: I6616599386646d5d6fc021fdb20052993c4aef84 Reviewed-on: https://chromium-review.googlesource.com/1101717Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567483}
-
Ryan Hansberry authored
PromotionManager is no longer used, and there are no future plans to use it. This CL also removes the flag that controlled the feature, and its associated metadata. R=khorimoto@chromium.org TBR=jhawkins@chromium.org Bug: 824568, 752273 Change-Id: I6ac7cfe8391ce050b1d1f9217ffc6ec95160746d Reviewed-on: https://chromium-review.googlesource.com/1101703Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#567482}
-
Kyle Horimoto authored
This function was already implemented in the .cc file, but it was not declared in the .h file. Bug: 824568, 752273 Change-Id: I5b8471bf5bd7bff54384696b38b10bb5523c82cf Reviewed-on: https://chromium-review.googlesource.com/1101823 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#567481}
-
Chris Mumford authored
Replaced DatabaseExists with new leveldb_chrome::PossiblyValidDB. Bug: None Change-Id: Iecb181588355c3f59953230ad0946f8e531c8a3f Reviewed-on: https://chromium-review.googlesource.com/1090998Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#567480}
-
Nico Weber authored
Now we know why they didn't run there. TBR=jbudorick Bug: 852895 Change-Id: I907a26d4035e4f6f3942838cc48befe00cae5c9c Reviewed-on: https://chromium-review.googlesource.com/1101838Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#567479}
-
Maria Khomenko authored
These histograms used to be recorded in google3, but are now used in public codebase. Move them to chromium. Bug: 852832 Change-Id: Ib5969f0b3476feb24db33362a787197f93c2151a Reviewed-on: https://chromium-review.googlesource.com/1101314Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#567478}
-
codeimpl authored
The spec[1] says that the boundingBox attribute should be DOMRectReadOnly instead of DOMRect. [1] https://wicg.github.io/shape-detection-api/#detectedface Bug: 852838 Change-Id: I10714b27ea5cf62c27c3b4c550e3e62b9f1936d2 Reviewed-on: https://chromium-review.googlesource.com/1094674Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#567477}
-
Scott Violet authored
BUG=none TEST=none Change-Id: I9f8d95661e1916b86f6e57f673f2d3b17118231d Reviewed-on: https://chromium-review.googlesource.com/1101303Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#567476}
-
Koji Ishii authored
'break-word' is different from other line breaking options in that it needs to redo the line break if the line overflows. A very long line such as URL or data can be expensive, because its 2nd and all following lines will also need this 2-pass line breaking. After CL:1095894, NextBreakOpportunity() consumes 21% and ShapeToEnd() 28%. Mostly these are to create ShapeResult that overflows in the first pass and thus will be discarded. This patch suppresses creating such ShapeResult by adding a new option to ShapingLineBreaker. Current engine: 469ms Before: 26,644ms CL:1095894: 2,250ms This patch: 1,060ms Profile (debug) of perf_tests/layout/word-break-break-word.html after this patch: ShapingLineBreaker::ShapeLine: 78% RunInfo::CharacterIndexForXPosition: 39% RunInfo::XPositionForOffset: 28% RunInfo::NextSafeToBreakOffset: 7% Emil is working on these 3 RunInfo functions, and they consume 74% out of ShapeLine's 78%. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I5bae7fe4e8256d4efaff91803690b33acd902706 Reviewed-on: https://chromium-review.googlesource.com/1100716 Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#567475}
-
Kyle Horimoto authored
This class disconnects cryptauth::SecureChannel objects, which have an asynchronous disconnection flow. It is an error to delete cryptauth::SecureChannel objects before they are fully disconnected, as this can cause the underlying connection to remain open. Bug: 824568, 752273 Change-Id: I42ebf3814f27f9f45c6d90173cb3cb8513bc800b Reviewed-on: https://chromium-review.googlesource.com/1101515 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#567474}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/de5f8a610a0a..54899e2b1191 git log de5f8a610a0a..54899e2b1191 --date=short --no-merges --format='%ad %ae %s' 2018-06-14 dgarrett@google.com chromeos_config: Make master-full internal. Created with: gclient setdep -r src/third_party/chromite@54899e2b1191 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:851183 TBR=chrome-os-gardeners@chromium.org Change-Id: I9b361d8a58e4d7ed2d365fed15745286938f444d Reviewed-on: https://chromium-review.googlesource.com/1101659Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567473}
-
Findit authored
This reverts commit e6db40d9. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 567445 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2U2ZGI0MGQ5MWQwYmQyYWZlYjM5Zjc4ZjZkMjI0MDRjMzUyNWI2M2MM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Builder%20%28dbg%29%2832%29/83483 Sample Failed Step: compile Original change's description: > Update fontconfig to 6cc99d6a > > Changelog [1]. This is necessary to pick up [2] for fixing undefined-shift > UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround, > [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to > fix a use-after-free. > > Fontconfig also now requires libuuid as a dependency, so whitelist it as a > dependency since we statically link fontconfig. > > [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde > [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e > [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914 > [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74 > [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c > [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde > > BUG=831146,822737,787020,829890,847323 > TBR=thestig,dnicoara > > Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec > Reviewed-on: https://chromium-review.googlesource.com/1095538 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567445} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=831146,822737,787020,829890,847323 Change-Id: I47d475941350efc76370fa5eb5043c80c5063495 Reviewed-on: https://chromium-review.googlesource.com/1101759 Cr-Commit-Position: refs/heads/master@{#567472}
-
Maks Orlovich authored
Use it to implement StoragePartitionImpl::URLLoaderFactoryForBrowserProcess::Clone() Bug: 850089 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I53798149efc69bd2566175bb248c462a2e5f4486 Reviewed-on: https://chromium-review.googlesource.com/1097214 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#567471}
-
James Cook authored
Document which are singletons vs. per-profile. Collapse all the chromeos stuff into one block. Bug: none Change-Id: I869c1ad4b1dd889de017743571b41f3ce31affb3 Reviewed-on: https://chromium-review.googlesource.com/1101829Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#567470}
-
Sky Malice authored
Previously if you had an empty lambda, Android Studio would insert a new line, and then git cl format would remove the newline, and the two would fight forever. This makes them both agree that no newline is better. git cl format and new Android Studio format: obj.foo(ignored -> {}); old Android Studio format: obj.foo(ignored -> { }); Bug: 852962 Change-Id: I785e3264454efbf0118d5fcc36c43ca88076a624 Reviewed-on: https://chromium-review.googlesource.com/1101715Reviewed-by:agrieve <agrieve@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#567469}
-
Ted Choc authored
BUG= Change-Id: I88dd7bada07824769b07d71b8669d7ba2ebe6e69 Reviewed-on: https://chromium-review.googlesource.com/1101702Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#567468}
-
Boris Sazonov authored
This CL replaces setPaddingRelative, getPaddingStart and getPaddingEnd from ApiCompatibilityUtils with their ViewCompat equivalents. Bug: 852891 Change-Id: I566d9dd8ae890611dfdd2223d5b4154a7278672d Reviewed-on: https://chromium-review.googlesource.com/1098928Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#567467}
-
Min Qin authored
DownloadCreateInfo contains both downloadId and Guid. Since both can be used to find a download, there is no need to keep DownloadId. Passing Guid in DownloadUrlParameters should be enough for resuming a download. BUG=851652 Change-Id: If7faa264b7e8b413eab932e76b65bfbaebf5e206 Reviewed-on: https://chromium-review.googlesource.com/1095777 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#567466}
-
Yi Gu authored
Previously we assume that LayerTreeHostImpl::InvalidatecontentOnImplSide is called only when it's in the impl frame. Actually for devices with synchronous compositor, e.g. Android Webview, that's not the case as it may ask for a frame at any time. Updating the DCHECK to fix the crash. Bug: 832072 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I96c88bf3589aa65eab02ff40bebb9a826cd0266b Reviewed-on: https://chromium-review.googlesource.com/1101544Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#567465}
-
Ryan Landay authored
In https://chromium-review.googlesource.com/c/1096489/, I added this line to NonOverlappingStack#runSwitchAwayAnimation() to fix another bug (tabs getting stuck in a partially-discarded state): startAnimation(0, OverviewAnimationType.UNDISCARD); It turns out that if this is called while the tabs are scrolling, StackScroller subtracts the scroller start time from 0 and ends up looking up a negative value in the SPLINE_POSITION array. This CL fixes this crash by passing the correct time here. Bug: 852995,831359 Change-Id: I0186cb9180ef4fff84bf1440acdfd87bc63c47f2 Reviewed-on: https://chromium-review.googlesource.com/1101906Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#567464}
-
David Black authored
Was previously defaulted to voice input modality. Later there will be a user preference that we defer to. Bug: b:110174827 Change-Id: I1a0eac49f76a53145589c0095df82b4a2d673d03 Reviewed-on: https://chromium-review.googlesource.com/1100300Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#567463}
-
Sammie Quon authored
Finishes up a few left behind works from the first cl. 1. Handles window items that are still alive but only for animation purposes by ignoring them in PositionWindows. Previously had some indexing errors and the windows would bounce around if swipe was used too quickly. 2. Handles one more case where nudge should not occur - when an item from the previous row drops down to the nudging row, which looks funny. 3. Use the nudging function described in the bug instead of just linear interpolation. Test: added tests Bug: 843273 Change-Id: I9d2088083a71779fc78f72309b5674f35bc162c7 Reviewed-on: https://chromium-review.googlesource.com/1100389 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#567462}
-
Ryan Hansberry authored
This log is not informative, and spams hundreds of lines in the logs. TBR=jhawkins@chromium.org Bug: 824568, 752273 Change-Id: I7dbce85d6b0bd7f9a4389466dad79af5299085e5 Reviewed-on: https://chromium-review.googlesource.com/1101932Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#567461}
-
sczs@chromium.org authored
- Creates TableViewTextLinkItem, which is a text item with link support. - Uses this item on HistoryTableVC and re-writes updateEntriesStatusMessage to reflect this. Screenshot: https://drive.google.com/open?id=1r6hQfWx_Yu8QC32F3hH7_TDq6ZkumHUh Bug: 805200 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8ac8ad0329f9e0a6e38f9ef7b8f72d5bf0a1c899 Reviewed-on: https://chromium-review.googlesource.com/1094557 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#567460}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/78a0b0424642..42e9609fc92e git log 78a0b0424642..42e9609fc92e --date=short --no-merges --format='%ad %ae %s' 2018-06-14 eyaich@google.com Telemetry tests output SKIP when telemetry fails to run them 2018-06-14 benjhayden@chromium.org Update soundwave and benchmark_health_report to use the new /api/alerts. 2018-06-14 dtu@chromium.org [pinpoint] Pull values comparison out to a separate folder. Created with: gclient setdep -r src/third_party/catapult@42e9609fc92e The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:850503 TBR=sullivan@chromium.org Change-Id: I6aaa2a1bd056ed30634641d5d314340efdbbe2a1 Reviewed-on: https://chromium-review.googlesource.com/1101658Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567459}
-
Tobias Sargeant authored
Bug: 852920 Change-Id: Icb2e276b25d51958cb1da4865b267212114b41ab Reviewed-on: https://chromium-review.googlesource.com/1101680 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#567458}
-
Kevin Marshall authored
Part of a larger effort to use Fuchsia native zx::channel objects for smoother integration with FIDL types and API calls. Bug: 852541 Change-Id: I421819558de9a20fe9e5fa24f083b103b46bd654 Reviewed-on: https://chromium-review.googlesource.com/1101461 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#567457}
-
Dominic Battre authored
Bug: 846694 Change-Id: Ib34a6256bbd7bc5358497101968839d26b5051ff Reviewed-on: https://chromium-review.googlesource.com/1100821 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#567456}
-
Sky Malice authored
Bug: 831648 Change-Id: Ibfc47c24b658a40f7a8f1586a88c5bd2093abed9 Reviewed-on: https://chromium-review.googlesource.com/1091113Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#567455}
-
Ryan Hansberry authored
Inject SecureChannelClient into TetherService, but not TetherComponent yet. Injection into TetherComponent and subsequent SecureChannelClient usage will come in subsequent CLs. This change has allowed me to manually verify that SecureChannelService is correctly registered at the login screen. This CL features a small change to FakeSecureChannelClient needed to fix a build error -- somehow it slipped by before. Bug: 824568, 752273 Change-Id: I9ba2c35f2ed05ebc3c92b1817e54e8161512f6a8 Reviewed-on: https://chromium-review.googlesource.com/1100481 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#567454}
-
Dmitry Gozman authored
This allows us to reuse dispatching on a custom channel talking to some DevTools backend. This needs follow up to remove ExternalHost and unnecessary methods in HeadlessDevToolsTarget once clients migrate away from it. Change-Id: Ia32d8feef4dc3f9d85db75b556242f0fbd9428ff Reviewed-on: https://chromium-review.googlesource.com/1097951Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#567453}
-
Tom Anderson authored
* Changes usages of "test" to "[". * Removes interactive prompts * Most developers don't need debug symbols (as indicated by the message that used to get printed out). Now --syms must be passed. This follows the convention of all of the other options, like --lib32, --arm, --nacl, etc. * A message is printed out to rerun the script with --add-deb-cross-tool-repo if the host machine is Debian Jessie. * Adds libstdc++ debugging symbols for more versions of gcc including 4.7, 5, 7, and 8. BUG=None R=dpranke Change-Id: Ia6e941b4f78c3fc4540bcfa23c45885dc402db98 Reviewed-on: https://chromium-review.googlesource.com/1100131 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#567452}
-
Javier Fernandez authored
We have landed several patches with refactoring and new logic in order to integrate the baseline alignment into the track sizing algorithm. We need to run this new logic both during layout and intrinsic size. Additionally, the CSS WG resolved that when the baseline alignment cause a cyclic sizing dependency, such items should not participate in such baseline alignment. One of the pre-conditions for the above mentioned cyclic dependency is the need of a synthesized baseline. There are several scenarios that may lead to this pre-condition, but most of them can be detected by calling FirstLineBoxBaseline() on the item under evaluation; if we get -1 as result it means that the item has no baseline and it needs to synthesize it. However, the FirstLineBoxBaseline always returns -1 if the item was not laid out yet. The bug we are trying resolve has its root cause in this scenario. We are working assuming that an item doesn't participate, while we request for its Baseline Context during layout, since the result of the FirstLineBaseline call is different during this phase. This CL ensures the item is laid our before it's evaluated to participate in the baseline alignment. Bug: 850510 Change-Id: I94823f08c8268e36926b074e9f84e67fb9c49baa Reviewed-on: https://chromium-review.googlesource.com/1096041 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#567451}
-
Bret Sepulveda authored
Refresh implies that Harmony is enabled, so these tests began failing. They can be safely skipped, as there are equivalent tests for Harmony. Bug: 846410 Change-Id: I6c6211d4ea99b6df0a4ba9620217574760ba723c Reviewed-on: https://chromium-review.googlesource.com/1100390Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#567450}
-
Quinten Yearsley authored
By default, keep lines for tests that have no results; Add a flag to turn on the removal of tests that have no results. Reason: For Android-only expectations for tests that aren't in the SmokeTests file, we probably usually want to keep the lines. But for lines for tests that actually don't exist anymore, we may want to actually remove the lines, so I wanted to keep the option of possibly trying to remove such lines (added a flag --remove-missing). Bug: 850204 Change-Id: I2eabca25ef59373aedb84ec2165271302ddd50a2 Reviewed-on: https://chromium-review.googlesource.com/1089642 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#567449}
-
Matt Menke authored
This covers both enabling it, and enabling DNS over HTTPS. DNS over HTTPS requires a global URLRequestContext. To handle that, DNS over HTTPS now also uses the "use_to_validate_certs" NetworkContext, which has been renamed the "primary" NetworkContext. Bug: 846883 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Idff65040dd67853efd6aa98fdfbeb06b6bd86778 Reviewed-on: https://chromium-review.googlesource.com/1093158 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#567448}
-
Ted Meyer authored
Bug: 827648 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie5ada63305913f3a0c8fe1986390ae80db253e4c Reviewed-on: https://chromium-review.googlesource.com/1092079Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#567447}
-
Greg Thompson authored
BUG=none R=gab@chromium.org Change-Id: Iad412f446261c0d14867079f60ce553c72a0849f Reviewed-on: https://chromium-review.googlesource.com/1101328 Commit-Queue: Greg Thompson <grt@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#567446}
-
Tom Anderson authored
Changelog [1]. This is necessary to pick up [2] for fixing undefined-shift UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround, [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to fix a use-after-free. Fontconfig also now requires libuuid as a dependency, so whitelist it as a dependency since we statically link fontconfig. [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914 [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74 [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde BUG=831146,822737,787020,829890,847323 TBR=thestig,dnicoara Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec Reviewed-on: https://chromium-review.googlesource.com/1095538 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#567445}
-