- 15 May, 2015 40 commits
-
-
tobiasjs authored
Motivation is for android webview where compositor swaps is not controlled by chromium code, but activations are. Add a DidActivate to SwapPromise. This is an additional call before DidSwap. It is not meant to be the end of a SwapPromise as either DidSwap or DidNotSwap can still be called afterwards. Then modify the message queue to mark VISUAL_STATE messages as ready to deliver in DidActivate. On chrome, the messages are still delivered in swap, so there is no additional IPCs. In webview, they can be delivered in the activation callback. BUG=431166 Review URL: https://codereview.chromium.org/1126963006 Cr-Commit-Position: refs/heads/master@{#330128}
-
dglazkov authored
This is part 2 of removing WebElement::innerText. BUG=488088 R=jochen@chromium.org Review URL: https://codereview.chromium.org/1131993009 Cr-Commit-Position: refs/heads/master@{#330127}
-
skyostil authored
This test is failing reliably on the Windows GPU bots. BUG=488493 NOTRY=true CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Review URL: https://codereview.chromium.org/1145583002 Cr-Commit-Position: refs/heads/master@{#330126}
-
dnicoara authored
Holding on to the DRM FD means we're leaking scanout buffers when the GPU process crashes. BUG=487630,445773 Review URL: https://codereview.chromium.org/1125283012 Cr-Commit-Position: refs/heads/master@{#330125}
-
gunsch authored
Cast Linux is on the chromium.linux waterfall, not chromium.fyi. R=thakis@chromium.org BUG=488533 Review URL: https://codereview.chromium.org/1144573002 Cr-Commit-Position: refs/heads/master@{#330124}
-
nednguyen authored
Since recording should work for all user_story, not just page. And the logic of record_wpr should be very similar to telemetry/benchmark_runner.py, we would want them to be a sibling in the directory hierarchy. BUG=470865 Review URL: https://codereview.chromium.org/1140243002 Cr-Commit-Position: refs/heads/master@{#330123}
-
maxbogue authored
Add tests to make sure the encryption UI shows the correct options by default, and that those options are enabled. BUG=480604 Review URL: https://codereview.chromium.org/1124073004 Cr-Commit-Position: refs/heads/master@{#330122}
-
nyquist authored
There is already functionality to check whether Chrome can reach the Internet by using the Chrome network stack. This adds the functionality to use the Android system network stack to do the same check, which is helpful for feedback reports in case something is awry with the Chrome network stack. The Chrome network stack support was added in: https://codereview.chromium.org/1127983002/ BUG=386395 Review URL: https://codereview.chromium.org/1147533002 Cr-Commit-Position: refs/heads/master@{#330121}
-
shrike authored
When the download shelf appears the Show All button at the far right is very dark, almost as if its been drawn several times on top of itself (see the original bug report for a screenshot of the problem). The problem is that the Show All button is layer backed (because the shelf is), so it caches its contents. The Show All button also declares itself to be opaque but wants the shelf background texture to show through. It accomplishes this by simulating a lock focus onto the shelf from within its drawRect:, and calling the shelf's drawRect:. Unfortunately, when the button first draws (into its layer) the shelf is hidden and so the shelf's height is 0.0. The shelf's drawing routines restrict themselves to the shelf's bounds rect - that works most of the time because if the shelf has 0 height there should be no drawing to be done. This optimization doesn't work for the Show All button when it uses the zero-height shelf to draw its background. The proposed fix is to detect the zero-height shelf from within drawRect:, and to use a frame-changed notification from the shelf as the signal to request a redraw. BUG=485782 Review URL: https://codereview.chromium.org/1125363005 Cr-Commit-Position: refs/heads/master@{#330120}
-
vabr authored
R=engedy@chromium.org BUG=400674, 486739 Review URL: https://codereview.chromium.org/1139953004 Cr-Commit-Position: refs/heads/master@{#330119}
-
bnc authored
Implement per-server ProofVerifyDetails in MockCryptoClientStreamFactory, and use them in QuicStreamFactoryTest.NoHttpsPoolingWithDifferentPins. This is in preparation for an upcoming change that will check certificates in QuicStreamRequest(), therefore every test will have to provide valid certificates (and pin configurations). BUG=474217 Review URL: https://codereview.chromium.org/1140173002 Cr-Commit-Position: refs/heads/master@{#330118}
-
felt authored
We want to be able to distinguish between subresource and non- subresource warnings in UMA stats. This separates them out. It slightly changes the definition of interstitial.*.malware because it no longer includes subresource-only interstitials, but I'm OK with that. BUG=464719 Review URL: https://codereview.chromium.org/1134553005 Cr-Commit-Position: refs/heads/master@{#330117}
-
tfarina authored
That code has been componentized and does not interact directly with Profile anymore. With that we were also able to move the member functions into the unnamed namespace. BUG=None TEST=components_unittests --gtest_filter=*Bookmark* R=sky@chromium.org Review URL: https://codereview.chromium.org/1126933003 Cr-Commit-Position: refs/heads/master@{#330116}
-
torne authored
Brings in: 22bb108 Fix unknown option '-msse2' warning on Windows. e5266fb Remove indirection of cpufeatures.gypi. 1cab0ec Add a codereview.settings file for openmax. BUG=488225 Review URL: https://codereview.chromium.org/1145533002 Cr-Commit-Position: refs/heads/master@{#330115}
-
binjin authored
This CL adds the invalidator class for remote commands service. BUG=480982 Review URL: https://codereview.chromium.org/1094493003 Cr-Commit-Position: refs/heads/master@{#330114}
-
rdevlin.cronin authored
Adjust the string for single extensions ("the following extension" instead of "some extensions"), and point the link to the proper place. BUG=474091 TBR=avi@chromium.org (micro cocoa change) Review URL: https://codereview.chromium.org/1137503006 Cr-Commit-Position: refs/heads/master@{#330113}
-
tbarzic authored
This enables 'Printer detected' notification, clicking on which launches Chrome Web Store widget app showing list of apps that support the detected printer. BUG=439448 Review URL: https://codereview.chromium.org/1123143004 Cr-Commit-Position: refs/heads/master@{#330112}
-
miguelg authored
Values entered with the on-screen keyboard are only accepted once the focus has been cleared from the element. BUG=457116 Review URL: https://codereview.chromium.org/1139663004 Cr-Commit-Position: refs/heads/master@{#330111}
-
antrim authored
BUG=484690,484734 R=nkostylev@chromium.org Committed: https://crrev.com/71ede7fdaf6404ec0f70a60d60f679fee07902a9 Cr-Commit-Position: refs/heads/master@{#329868} Review URL: https://codereview.chromium.org/1129293004 Cr-Commit-Position: refs/heads/master@{#330110}
-
robertphillips authored
These should've been rebaselined by https://codereview.chromium.org/1136913003/ (Rebaseline images fixed by Skia roll) and can now be removed. BUG=487587 Review URL: https://codereview.chromium.org/1130783005 Cr-Commit-Position: refs/heads/master@{#330109}
-
jam authored
Disable flaky RenderFrameHostImplBrowserTest.IsFocused_AtLoad and RenderFrameHostImplBrowserTest.IsFocused_Widget See http://chromium-try-flakes.appspot.com/search?q=RenderFrameHostImplBrowserTest.IsFocused_AtLoad http://chromium-try-flakes.appspot.com/search?q=RenderFrameHostImplBrowserTest.IsFocused_Widget http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/59522/steps/content_browsertests%20%28with%20patch%29/logs/stdio BUG=452631 TBR=mlamouri@chromium.org Review URL: https://codereview.chromium.org/1146533004 Cr-Commit-Position: refs/heads/master@{#330108}
-
halliwell authored
Ensure that aura::Env is destroyed after CastBrowserProcess's members. During shutdown, CastBrowserProcess destructor can end up calling aura::Window::~Window (via application destruction and RenderWidgetHostImpl::Destroy), which needs access to the aura::Env instance. BUG= internal b/21156227 Review URL: https://codereview.chromium.org/1139823005 Cr-Commit-Position: refs/heads/master@{#330107}
-
tbarzic authored
BUG=477106 Review URL: https://codereview.chromium.org/1129083006 Cr-Commit-Position: refs/heads/master@{#330106}
-
yfriedman authored
Defines a list 'net_test_extra_libs' that is included in net_java_test_support. org.apache.http is deprecated and being removed. This enables temporary inclusion of a replacement jar until the dependency is removed. BUG=488192 Review URL: https://codereview.chromium.org/1138013007 Cr-Commit-Position: refs/heads/master@{#330105}
-
vmiura authored
GrContext::Create may return NULL if the base GL context was lost. - Check for the NULL case in GlRenderer. - For the GPU rasterizer, don't allow GPU rasterization to be initialized with a NULL GrContext. BUG=464892 Review URL: https://codereview.chromium.org/1135743004 Cr-Commit-Position: refs/heads/master@{#330104}
-
yfriedman authored
Remaps status codes to ones from HttpURLConnection. Changes ConnectTimoutException to SocketTimeoutException. BUG=468861 Review URL: https://codereview.chromium.org/1141943003 Cr-Commit-Position: refs/heads/master@{#330103}
-
jam authored
Revert of Re-enable local video test with better logging and higher tolerance. (patchset #4 id:60001 of https://codereview.chromium.org/1108803002/) Reason for revert: still flaky, see http://chromium-try-flakes.appspot.com/search?q=WebRtcBrowserTest.CanSetupVideoCallAndDisableLocalVideo and http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/59522 Original issue's description: > Re-enable local video test with better logging and higher tolerance. > > The test appears to get stuck on waiting for black frames. This patch > adds some logging so we perhaps can learn more where in the image we > find the nonblack pixels. Also trying to increase tolerance for > rounding errors somewhat to see if that helps. > > BUG=477498 > > Committed: https://crrev.com/839a0eb5f8aeff1de8263eff28e55cb8b5fe7396 > Cr-Commit-Position: refs/heads/master@{#329616} TBR=kjellander@chromium.org,tommi@chromium.org,phoglund@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=477498 Review URL: https://codereview.chromium.org/1142643004 Cr-Commit-Position: refs/heads/master@{#330102}
-
engedy authored
Add support for trimming no longer needed data from the AffiliationDatabase's cache SQL database; and for wiping the database if affiliated matches are disabled. BUG=479507 Review URL: https://codereview.chromium.org/1072413003 Cr-Commit-Position: refs/heads/master@{#330101}
-
jonross authored
This change is intended to M-43. Currently screen rotation animations expose a bug, causing the login screen to not be useable. Disable rotation animations while a user is not logged in. This will be later reverted on M-44 where a fix to the underlying issue will be landed. TEST=manual testing on device BUG=chrome-os-partner:40118 Review URL: https://codereview.chromium.org/1139793003 Cr-Commit-Position: refs/heads/master@{#330100}
-
bruthig authored
TEST=TaskSwitchMetricsRecorderTest.VerifyTaskSwitchesForWindowCycleControllerAreRecorded BUG=478946 Review URL: https://codereview.chromium.org/1126333005 Cr-Commit-Position: refs/heads/master@{#330099}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/4a0f1d2..2e3aab2 TBR=timvolodine@chromium.org,kbr@chromium.org Review URL: https://codereview.chromium.org/1137433006 Cr-Commit-Position: refs/heads/master@{#330098}
-
skyostil authored
Did 50 runs locally to confirm that this is working. BUG=455796 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect NOTRY=true Review URL: https://codereview.chromium.org/1129203004 Cr-Commit-Position: refs/heads/master@{#330097}
-
rogerta authored
Since refresh tokens are now tagged with device id, this will invalidate the new refresh token as well. BUG=398971 Review URL: https://codereview.chromium.org/1129903006 Cr-Commit-Position: refs/heads/master@{#330096}
-
anthonyvd authored
BUG=466799 Review URL: https://codereview.chromium.org/1130853003 Cr-Commit-Position: refs/heads/master@{#330095}
-
iclelland authored
This correctly assigns ownership of the callbacks_ object to the closure created by base::Bind when posting the success/error handling task to the correct thread. BUG=488452 Review URL: https://codereview.chromium.org/1139643008 Cr-Commit-Position: refs/heads/master@{#330094}
-
dzhioev authored
BUG=487972 Review URL: https://codereview.chromium.org/1137843005 Cr-Commit-Position: refs/heads/master@{#330093}
-
deepak.m1 authored
BUG=487618 Review URL: https://codereview.chromium.org/1140023002 Cr-Commit-Position: refs/heads/master@{#330092}
-
dzhioev authored
BUG=488345 NOTRY=true Review URL: https://codereview.chromium.org/1134233004 Cr-Commit-Position: refs/heads/master@{#330091}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/85f7e6e..4a0f1d2 TBR=timvolodine@chromium.org Review URL: https://codereview.chromium.org/1140233002 Cr-Commit-Position: refs/heads/master@{#330090}
-
kkimlabs authored
Summary of changes available at: https://chromium.googlesource.com/android_tools/+log/0c03d3bfef..3445d55bd6 BUG=487391 Review URL: https://codereview.chromium.org/1142583002 Cr-Commit-Position: refs/heads/master@{#330089}
-