- 16 Mar, 2017 40 commits
-
-
zqzhang authored
This CL addes flag for enabling/disabling video fullscreen detection. So we can reduce the overhead of MediaCustomControlsFullscreenDetector if the client side doesn't need it. The downstream change will be in the subclass of AppHooks.java. BUG=699565 Review-Url: https://codereview.chromium.org/2738893002 Cr-Commit-Position: refs/heads/master@{#457412}
-
dtapuska authored
This restores the old logic we had for blink to deal with these as mouse move events but keeping the mouseleave events when we leave the window. NotifyInferior messages are already dropped at the X11 desktop tree host but I didn't want to risk breaking any views with addressing this release block stable issue. BUG=701637,450631,240300,352106,386896,569998,575208 Review-Url: https://codereview.chromium.org/2751833006 Cr-Commit-Position: refs/heads/master@{#457411}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/b66fa526b882..f49b1e0ad955 $ git log b66fa526b..f49b1e0ad --date=short --no-merges --format='%ad %ae %s' 2017-03-15 halcanary FuzzCanvas: only valid ChannelSelectors 2017-03-15 iannucci Update recipes.py to f605e5c0bc2e748170ca851383cb552c7225316b Created with: roll-dep src/third_party/skia BUG=699379 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=borenet@chromium.org Change-Id: I75b38ce9077100e93ad1c685382099face7c3f75 Reviewed-on: https://chromium-review.googlesource.com/455992Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#457410}
-
yukishiino authored
Both of LocalFrame and RemoteFrame have a WindowProxyManager. We can move it into a base class Frame. windowProxy->initializedIfNeeded() is moved into WindowProxyManager from ScriptController and RemoteFrame. WindowProxyManager::windowProxy(world) now always returns an initialized global proxy. It's safer than before, I think. (But no behavioral change in this CL at all.) Also the following renaming is done in order to emphasize that the returned object may not be initialized. WindowProxyManagerBase => WindowProxyManager (Same naming as Frame, DOMWindow and WindowProxy) WindowProxyManager::mainWorldProxy => mainWorldProxyMaybeUninitialized WindowProxyManager::windowProxy => windowProxyMaybeUninitialized By the way, we don't much use RemoteWindowProxyManager. We can simply remove the class in a follow-up CL. BUG= Review-Url: https://codereview.chromium.org/2702273004 Cr-Commit-Position: refs/heads/master@{#457409}
-
cblume authored
Revert of [Cronet] Write effective experimental options to NetLog (patchset #5 id:80001 of https://codereview.chromium.org/2738813004/ ) Reason for revert: The bot Android Cronet Builder Asan is reporting Failed steps failed cronet_unittests failed cronet_test_instrumentation_apk I suspect this patch might be why. https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cronet%20Builder%20Asan/builds/1791 Original issue's description: > [Cronet] Write effective experimental options to NetLog > > This CL does the following: > (1) Have a warning in Experimental Options parsing code if there is an > unrecognized option. > (2) Make cronet_url_request_context_adapter use the new FileNetLogObserver which > allows writing polled data. > (3) Put the effective experimental options in the polled data. > > BUG=584806,699567 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester > > Review-Url: https://codereview.chromium.org/2738813004 > Cr-Commit-Position: refs/heads/master@{#457158} > Committed: https://chromium.googlesource.com/chromium/src/+/3c275e0a2333511ec831b3c396dc9f38a161a8c6 TBR=kapishnikov@chromium.org,mgersh@chromium.org,xunjieli@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=584806,699567 Review-Url: https://codereview.chromium.org/2751113004 Cr-Commit-Position: refs/heads/master@{#457408}
-
rhalavati authored
Network traffic annotation is added to network request of components/autofill/core/browser/autofill_download_manager.cc. BUG=656607 Review-Url: https://codereview.chromium.org/2740213003 Cr-Commit-Position: refs/heads/master@{#457407}
-
lizeb authored
BUG=631966 Review-Url: https://codereview.chromium.org/2749583003 Cr-Commit-Position: refs/heads/master@{#457406}
-
bashi authored
Before this CL we used "memory-infra" category for memory coordinator related events. Enabling "memory-infra" category triggers memory dump tasks but in some cases we just want to record memory coordinator related events without memory dumps to investigate performace impact of memory coordinator (e.g. how purging memory affects tab switching). This CL changes the category of memory coordinator related events to "memory_coordinator" so that we can recard traces without memory dumps. BUG=617492 Review-Url: https://codereview.chromium.org/2752153002 Cr-Commit-Position: refs/heads/master@{#457405}
-
raphael.kubo.da.costa authored
While https://codereview.chromium.org/2749253002 took care of adding all required includes and forward-declarations for unions inside records inside other unions, it did not solve it for unions inside records which were _not_ inside other unions: in this case, v8_union is not used at all, so we need to patch code_generator_v8.depending_union_type() instead. BUG=685754 R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org Review-Url: https://codereview.chromium.org/2752223002 Cr-Commit-Position: refs/heads/master@{#457404}
-
fhorschig authored
In order to disable the global static defaults while having popular sites enabled, a separate flag is necessary. BUG=700872 Review-Url: https://codereview.chromium.org/2741413008 Cr-Commit-Position: refs/heads/master@{#457403}
-
clamy authored
Reland of [Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part 2/3 (patchset #1 id:1 of https://codereview.chromium.org/2757563002/ ) Reason for revert: The CL reverted was part of a two-sided CL, and the downstream part landed just before this got reverted. So the Android ToT roller bot is broken again. Let's land this CL again, so that everything goes back to green. Original issue's description: > Revert of [Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part 2/3 (patchset #2 id:20001 of https://codereview.chromium.org/2728053002/ ) > > Reason for revert: > This is causing build failures on clang-clankium-tot-builder > See: > https://crbug.com/702086 > https://uberchromegw.corp.google.com/i/internal.client.clank_tot/builders/clang-clankium-tot-builder/builds/43251 > > Original issue's description: > > [Android:WebAPK] Don't add webapp to homescreen if WebAPK install times out part 2/3 > > > > This CL: > > - Changes GooglePlayWebApkInstallDelegate#installAsync() to return a > > WebApkInstallResult in the callback. > > - Deletes unused GooglePlayWebApkInstallDelegate#canInstallWebApk(). > > > > BUG=696132 > > > > Review-Url: https://codereview.chromium.org/2728053002 > > Cr-Commit-Position: refs/heads/master@{#457300} > > Committed: https://chromium.googlesource.com/chromium/src/+/19d929ae378491116d7683764baa6365d1ddd50d > > TBR=dominickn@chromium.org,pkotwicz@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=696132 > > Review-Url: https://codereview.chromium.org/2757563002 > Cr-Commit-Position: refs/heads/master@{#457361} > Committed: https://chromium.googlesource.com/chromium/src/+/6da294d05e78dcdd1109ae8dc763ea0485c714af TBR=dominickn@chromium.org,pkotwicz@chromium.org,aelias@chromium.org,cblume@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=696132 Review-Url: https://codereview.chromium.org/2757543003 Cr-Commit-Position: refs/heads/master@{#457402}
-
raphael.kubo.da.costa authored
Replace occurrences of "raise 'foo bar'" with "raise ValueError('foo bar')", otherwise we get another exception ourselves: TypeError: exceptions must be old-style classes or derived from BaseException, not str R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org Review-Url: https://codereview.chromium.org/2751063004 Cr-Commit-Position: refs/heads/master@{#457401} -
fukino authored
Though there seems to be a shared issue which makes many tests flaky, we should disable each one for now not to slow down the CQ. BUG=702119,699534,699978,700156,699083,698834,698772,699171 TEST=none Review-Url: https://codereview.chromium.org/2754003003 Cr-Commit-Position: refs/heads/master@{#457400}
-
kochi authored
FlatTreeTraversal::nextSibling()/previousSibling() didn't handle fallback content (nodes in <slot> where nothing is distributed). This CL adds fallback content handling and a unit test case. BUG=683776 Review-Url: https://codereview.chromium.org/2749033006 Cr-Commit-Position: refs/heads/master@{#457399}
-
guidou authored
BUG=701718 TBR=schenney@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2754813002 Cr-Commit-Position: refs/heads/master@{#457398}
-
sakal authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/7867a4e..c0a0f8d $ git log 7867a4e..c0a0f8d --date=short --no-merges --format=%ad %ae %s 2017-03-16 solenberg@webrtc.org (Re)move VoE specific enums from common_types.h. 2017-03-15 zijiehe@chromium.org DxgiOutputDuplicator should initialize num_frames_captured_ 2017-03-15 pbos@webrtc.org Use VPX_ERROR_RESILIENT_DEFAULT constant. 2017-03-15 pbos@webrtc.org Remove unused RealTimeTemporalLayers. 2017-03-15 pbos@webrtc.org Remove dead VP8SequenceCoder. 2017-03-15 ehmaldonado@webrtc.org Add traces for some video events. 2017-03-15 jansson@webrtc.org Improve error handling for ffmpeg operations 2017-03-15 alessiob@webrtc.org Revert of C++ porting of the initial python script for conversational speech generation. (patchset #2 id:100001 of https://codereview.webrtc.org/2740063004/ ) 2017-03-15 philipel@webrtc.org Release the critial section between recursive calls in FrameBuffer::NextFrame. 2017-03-15 solenberg@webrtc.org Remove VoEHardware interface. 2017-03-15 alessiob@webrtc.org C++ porting of the initial python script for conversational speech generation. 2017-03-15 ilnik@webrtc.org Reland of write frame generator capturer to use TaskQueue instead of EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2748643002/ ) 2017-03-15 tommi@webrtc.org Return a long timeout value from TimeUntilNextProcess when the PacedSender is paused 2017-03-15 elad.alon@webrtc.org R/PLR calculation - time-based window 2017-03-15 philipel@webrtc.org Revert of Save width/height of SPS nalus and restore them on the first packet of an IDR. (patchset #6 id:100001 of https://codereview.webrtc.org/2750633003/ ) 2017-03-15 solenberg@webrtc.org Remove VoEHardware interface usage. 2017-03-15 alessiob@webrtc.org FileUtilsTest DirExists function added 2017-03-15 sakal@webrtc.org Better handling of error condition in MediaCodecVideoEncoder. 2017-03-15 sakal@webrtc.org Try re-enabling two PeerConnectionClientTests: 2017-03-15 stefan@webrtc.org Fix broken test landed in r17243. 2017-03-15 stefan@webrtc.org Ignore packets sent on old network route when receiving feedback. 2017-03-15 tommi@webrtc.org TaskQueue[Win] DOS handling 2017-03-15 ilnik@webrtc.org Fix crash in vie_encoder when encoder configure fails Bad changes are from CL 2745523002. 2017-03-15 philipel@webrtc.org Save width/height of SPS nalus and restore them on the first packet of an IDR. 2017-03-15 terelius@webrtc.org Pass label and plot style to the TimeSeries' constructor. 2017-03-14 zijiehe@chromium.org Ignore unmoved moved_rects in DxgiOutputDuplicator 2017-03-14 minyue@webrtc.org Fixing a few tests for the upcoming Opus 1.2-alpha. 2017-03-14 tommi@webrtc.org Remove ReceiveCodec() getters from VideoCodingModule. 2017-03-14 dkirovbroadsoft@gmail.com Fixed problems in neteq when RTP and decoder timestamps increment with different sample rate frequency. 2017-03-14 oprypin@webrtc.org Add the ability to read/write to WAV files in FakeAudioDevice 2017-03-14 nisse@webrtc.org Delete support for sending RTCP RPSI and SLI messages. 2017-03-14 tommi@webrtc.org Change FrameBuffer::Stop to not require a critical section. TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review-Url: https://codereview.chromium.org/2754773002 Cr-Commit-Position: refs/heads/master@{#457397}
-
mvanouwerkerk authored
BUG=697709 Review-Url: https://codereview.chromium.org/2749943003 Cr-Commit-Position: refs/heads/master@{#457396}
-
altimin authored
This is the refactoring needed for new wakeup-based throttling mechanism. Remove friendship between BudgetPools and TaskQueueThrottler. R=skyostil@chromium.org,alexclarke@chromium.org BUG=699541 Review-Url: https://codereview.chromium.org/2742383005 Cr-Commit-Position: refs/heads/master@{#457395}
-
ksakamoto authored
This rewrites FirstMeaningfulPaintDetectorTest's test case for the network quiet timers, using TestingPlatformSupportWithMockScheduler. Now it verifies that the timers are actually fired. This also changes other test cases to use mock timer provided by TestingPlatformSupportWithMockScheduler. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2755873002 Cr-Commit-Position: refs/heads/master@{#457394}
-
tkent authored
There are no problems with adding arbitrary content to an element with display:table if it's not <table>. This CL fixes broken editing/deleting/display-table.html. Because we don't want to change TextIterator behavior, this CL copies the old implementation of isDispalyInsideTable() to TextIterator.cpp. BUG=697315 Review-Url: https://codereview.chromium.org/2757553002 Cr-Commit-Position: refs/heads/master@{#457393}
-
hjd authored
Fixes a bug in ProcessMetricsMemoryDumpProvider::RegisterForProcess where if we get a duplicate pid we register an MDP but then immediately destroy it. This later causes a crash. Instead we should not register the MDP if we get a duplicate pid. This won't help the root problem of why we are getting duplicate pids which will now just cause information loss instead of crashing. BUG=695731 Review-Url: https://codereview.chromium.org/2753723003 Cr-Commit-Position: refs/heads/master@{#457392}
-
hayato authored
The SVG 2's spec is: https://svgwg.org/svg2-draft/struct.html#UseElement Because SVG spec has been updated to clarify that SVG's <use> element should use a shadow tree as its implementation, we must use the *standard* shadow tree which DOM Standard defines its behavior. That is either an open shadow root or a closed shadow root. It should not be a user-agent shadow root because it is UA's internal concept. Though the SVG spec says nothing about which type of Shadow Root should be used, this CL chose "closed" because it is more compatible to the behavior of user-agent shadow root. Eventually, the spec should clarify the type. BUG=670572 Review-Url: https://codereview.chromium.org/2752763002 Cr-Commit-Position: refs/heads/master@{#457391}
-
oka authored
BUG=699426,701922,701923 TEST=None Review-Url: https://codereview.chromium.org/2747423003 Cr-Commit-Position: refs/heads/master@{#457390}
-
bauerb authored
BUG=698235 Review-Url: https://codereview.chromium.org/2743203004 Cr-Commit-Position: refs/heads/master@{#457389}
-
ichikawa authored
BUG= Review-Url: https://codereview.chromium.org/2747683002 Cr-Commit-Position: refs/heads/master@{#457388}
-
arthursonzogni authored
This CL adds support for blocking requests in NavigationRequest during redirects. It also fixes an issue in NavigationHandle, without PlzNavigate activated, where the NavigationHandle would not be properly recognized at error page commit if the navigation was blocked by a NavigationThrottle during a redirect. BUG=685074, 695421 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2698623006 Cr-Commit-Position: refs/heads/master@{#457387}
-
tasak authored
Design doc: https://docs.google.com/document/d/1L5qRmCwjidiZWKmQRiuqMjZivBWV7XSW9RTypg9XxlI/edit?usp=sharing BUG=635419 Review-Url: https://codereview.chromium.org/2711093002 Cr-Commit-Position: refs/heads/master@{#457386}
-
arthursonzogni authored
This test shows that the CSP of the navigating frame are used instead of the CSP of the frame that has initiated the navigation. This is a reland of: https://crrev.com/2747823002/ BUG=700964 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation,linux_chromium_browser_side_navigation_rel Review-Url: https://codereview.chromium.org/2749233002 Cr-Commit-Position: refs/heads/master@{#457385}
-
toyoshim authored
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation TBR=kinuko@chromium.org BUG=671545, 670237 Review-Url: https://codereview.chromium.org/2752073005 Cr-Commit-Position: refs/heads/master@{#457384}
-
rune authored
Whether the StyleResolver is created or not does no longer tell if we have usable invalidation sets or not. Removing SubtreeStyleChange which is presumably not necessary anymore. Add a check for not scheduling any invalidation sets if the document is already marked for full recalc. Review-Url: https://codereview.chromium.org/2749273004 Cr-Commit-Position: refs/heads/master@{#457383}
-
gambard authored
The custom accessibility actions check for the existence of the ReadingListModel entry when configuring a cell. This CL changes this behavior to do nothing when the entry does not exist instead of reloading the UI. BUG=676290, 701956 Review-Url: https://codereview.chromium.org/2750623006 Cr-Commit-Position: refs/heads/master@{#457382}
-
raphael.kubo.da.costa authored
Prior to this CL, an IDL construct like this: void func((boolean or sequence<Element>) arg); would generate two union files, BooleanOrElementSequence.cpp and BooleanOrElementSequence.h. BooleanOrElementSequence.h contains declarations such as: const HeapVector<Member<Element>>& getAsElementSequence() const; HeapVector<Member<Element>> m_elementSequence; However, it does not forward-declare Element, nor does it include Element.h (or V8Element.h). Only BooleanOrElementSequence.cpp includes V8Element.h, leading to build failures. This affected any types inside unions that require forward declarations and additional headers to be included which were inside a container type, such as a record or a sequence. For instance, the constructs below were all problematic: * (boolean or sequence<Element>) * (float or sequence<(boolean or long)>) * (double or record<ByteString, Element>) Solve this by expanding v8_union._update_includes_and_forward_decls() and making it more similar to code_generator_v8's depending_union_type() and TypedefResolver: * If we're parsing a container type (ie. a record or a sequence), we call the function recursively to make sure all headers/forward declarations are taken care of. * If we're parsing a union type, the union was inside a container type (as otherwise it would have been broken up by us looping through flattened union members), in which case we forward-declare the union and include its header in the outer union's .cpp file. BUG=701410 R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org Review-Url: https://codereview.chromium.org/2750003003 Cr-Commit-Position: refs/heads/master@{#457381} -
eustas authored
https://github.com/google/brotli/commit/1ff78b877f0138064f0a0513267e8355affd4be8 Move fuzzer to third_party/brotli/fuzz. BUG=700667 Review-Url: https://codereview.chromium.org/2748323002 Cr-Commit-Position: refs/heads/master@{#457380}
-
olivierrobin authored
When URL is used as title, show the full URL as it is used to recognise the entry. BUG=694549 Review-Url: https://codereview.chromium.org/2749193004 Cr-Commit-Position: refs/heads/master@{#457379}
-
rockot authored
The only reliable way to inquire about handle signals now is to MojoWait (for e.g. 0 deadline). As a precursor to removing the wait APIs in favor of watchers, we need to retain the ability to efficiently query a handle's signals state. Rather than trying to retrofit the watcher APIs to support this use case in similar fashion to the wait APIs, this adds an API explicitly for the purpose of querying signals state. Adds a corresponding method to the C++ mojo::Handle and moves the EDK's internal HandleSignalsState helper class to mojo/public/cpp/system, adding some convenient accessors. Also introduces the API to the JS and Java libraries, and replaces any 0-deadline waits in those languages with usage of this new API. Because waitMany is not used in these languages (except for tests which test waitMany...) it has been removed. wait() is unused in Java after this change, so it has also been removed. Finally, this moves several tests away from calling MojoWait directly, instead using a simplified Watcher-based wait implementation in MojoTestBase. BUG=700171 TBR=jam@chromium.org Review-Url: https://codereview.chromium.org/2741033003 Cr-Original-Commit-Position: refs/heads/master@{#457315} Committed: https://chromium.googlesource.com/chromium/src/+/853496a78ae997c2d8b80f3cd8fabf9423fb3361 Review-Url: https://codereview.chromium.org/2741033003 Cr-Commit-Position: refs/heads/master@{#457378}
-
raphael.kubo.da.costa authored
Prior to this commit, the IDL compiler was failing to resolve typedefs in unions before generating new union code. In practice, this meant an IDL construct such as: typedef boolean Foo; void func((Foo or long) arg); Generated FooOrLong.cpp and FooOrLong.h, and "Foo" was considered an IDL interface instead of a simple bool. Since Foo.cpp and Foo.h do not exist, and neither does the Foo class, this caused build failures. We now resolve the typedefs earlier, and in the example above we would now generate BooleanOrLong.cpp and BooleanOrLong.h, which works as expected. Fixing this requires a few separate, intertwined changes: * IdlUnionType.resolve_typedefs() was broken: the |typedefs| argument it receives is a dictionary whose keys are typedef names, not IdlTypeBase-derived objects, so |typedefs.get()| was always failing and returning the original, unresolved member objects. * CodeGeneratorUnionType actually needs to call resolve_typedefs(). It was the only generator class not doing so. The mechanism needs to be different from the other classes though, as IdlUnionType is not a type defined in idl_definitions.py as is the case for the types handled by the other generators. Instead of using TypedefResolver, we simply call the relevant parts of it manually. * The code manually adding union header includes to interfaces and partial interfaces has been dropped: there isn't enough information to resolve the typedefs at that point, which meant interface .cpp files would include FooOrLong.h, while interface .h files include BooleanOrLong.h. The test expectations IDL files show a reduction in unneeded includes, and the build seems to work fine. BUG=701411 R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org Review-Url: https://codereview.chromium.org/2749253002 Cr-Commit-Position: refs/heads/master@{#457377} -
yoichio authored
This CL avoids VisibleSelectionInFlatTree creation if VSInDOMTree is none in SelectionEditor.cpp. This reduces redundant canonicalization because VSInFlatTree availability == VSInDOMTree availability BUG=668122 TEST= 1. Open the page on comment#21 described at the bug. 2. Open also chrome://tracing/ and record Input Latency. 3. Confirm Messaseloop::RunTask blocking time gets faster 3.7 times(from 64ms to 17ms). Review-Url: https://codereview.chromium.org/2741173002 Cr-Commit-Position: refs/heads/master@{#457376}
-
tkent authored
This CL has no behavior changes. Review-Url: https://codereview.chromium.org/2755713003 Cr-Commit-Position: refs/heads/master@{#457375}
-
noel authored
Add ExtensionUnpacker mojo, used to (unzip and) unpack a chrome extension, and expose it to the browser via the utility process policy file. Make callers use a utility process mojo client. Add [Native] IPC enum param traits via a mojo typemap to handle extensions::Manifest::Location. Set the wire limit for the enum value to one less than Manifest::NUM_LOCATIONS (for compat with the pre-existing custom traits removed in this patch since this patch auto-generates them: manifest_location_param_traits.cc). In the extensions/utility/utility_handler.cc, retain the CHECKs on the Manifest::Location enum limits while bug 692069 is still being investigated. Move DecodeImages declarations from the extension messages-file into its own file (extension_utility_types.h) to decouple those declarations from this messages-file. A follow-up patch deletes the messages-file so DecodeImages needs a new home. Update all BUILD.gn for using clients to directly depend on the //extensions/common:common target (and hence, its :mojo) to fix post-compile step failures (warning about under-specified BUILD files via "targets is_dirty" errors, see review comment #169). Add TestContentBrowserClient to the extension test harness, and also an overlay file in test/data (needed to expose the mojo in the extension test harness to the unit tests listed below). Covered by existing unit tests: {sandboxed_unpacker, zipfile_installer}_unittest.cc BUG=691410 Review-Url: https://codereview.chromium.org/2697463002 Cr-Commit-Position: refs/heads/master@{#457374} -
scottchen authored
Primarily to address an issue we're seeing in Settings where initial clicks on certain row items aren't being registered. BUG=697353 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2751523005 Cr-Commit-Position: refs/heads/master@{#457373}
-