1. 26 Jan, 2020 1 commit
    • David Trainor's avatar
      Modularize ThumbnailProvider · 940160d8
      David Trainor authored
      This CL moves ThumbnailProvider.java and all associated Java/C++ files to a
      separate chrome/browser/thumbnail directory.  This CL pulls in all obvious
      dependencies and splits them to a modularized build target.
      
      Files moved:
      download.DownloadMediaData.java
      download.DownloadMediaParserBridge.java
      download.DownloadMediaParserTest.java
      widget.ThumbnailDiskStorage.java
      widget.ThumbnailGenerator.java
      widget.ThumbnailGeneratorCallback.java
      widget.ThumbnailProvider.java
      widget.ThumbnailProviderImpl.java
      widget.ThumbnailStorageDelegate.java
      widget.ThumbnailDiskStorageTest.java
      widget.ThumbnailProviderImplTest.java
      widget.thumbnail_cache_entry.proto
      
      download/download_media_parser.cc
      download/download_media_parser.h
      download/download_media_parser_bridge.cc
      download/download_media_parser_bridge.h
      download/image_thumbnail_request.cc
      download/image_thumbnail_request.h
      download/local_media_data_source_factory.cc
      download/local_media_data_source_factory.h
      download/thumbnail_util.cc
      download/thumbnail_util.h
      thumbnail/scoped_ptr_expiring_cache.h
      thumbnail/scoped_ptr_expiring_cache_unittest.cc
      thumbnail/thumbnail.cc
      thumbnail/thumbnail.h
      thumbnail/thumbnail_cache.cc
      thumbnail/thumbnail_cache.h
      widget/thumbnail_generator.cc
      widget/thumbnail_generator.h
      
      chrome/browser/image_decoder.cc
      chrome/browser/image_decoder.h
      chrome/browser/image_decoder_browsertest.cc
      
      data/android/thumbnail_provider/test_image_10x10.jpg
      data/android/thumbnail_provider/test_image_10x20.jpg
      data/android/thumbnail_provider/test_image_20x10.jpg
      data/android/thumbnail_provider/test_image_20x20.jpg
      
      Conceptual targets pulled into chrome/browser/thumbnail:
      - C++ target
      - Java target
      - proto target
      - JNI target
      - javatests
      - junit tests
      - browsertests
      - unit tests
      - test data
      
      Extra notes:
      - chrome/browser/thumbnail/generator/stats.h/cc contains functions/enums from
      download_stats.h/cc
      - Fixed presubmit warnings on NULL vs. nullptr
      - Fixed presubmit warnings on using content::MessageLoopRunner vs. base::RunLoop.
      
      Bug:1018427
      
      Change-Id: I81c48e427fd135c7b4e9e0791b5e74ca951fa62b
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865624
      Commit-Queue: David Trainor <dtrainor@chromium.org>
      Reviewed-by: default avatarScott Violet <sky@chromium.org>
      Reviewed-by: default avatarTommy Nyquist <nyquist@chromium.org>
      Reviewed-by: default avatarMin Qin <qinmin@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#735252}
      940160d8
  2. 25 Jan, 2020 39 commits