Commits · 94017db5a581fad2cfb5423bfe3454ba66d8a602 · eriksson monteiro / tangled

16 Jan, 2020 40 commits

Roll src/third_party/swiftshader 5349f3c9d904..5fc197dc7669 (1 commits) · 94017db5

chromium-autoroll authored Jan 16, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/5349f3c9d904..5fc197dc7669

git log 5349f3c9d904..5fc197dc7669 --date=short --first-parent --format='%ad %ae %s'
2020-01-15 jonahr@google.com Disable MSVC warning 4065

Created with:
gclient setdep -r src/third_party/swiftshader@5fc197dc7669

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I5bc6ff9222582f95ee298713328785964c8895f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003488Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732294}

94017db5

service worker: Check installing registrations in ServiceWorkerRegistry (1 of 3) · 24bdb34a

Kenichi Ishibashi authored Jan 16, 2020

Before this CL, FindRegistrationForClientUrl() worked like the below:
1. Initialize database if it's not via LazyInitialize().
   LazyInitialize() initializes |registered_origins_|.
2. Check if |registered_origins_| contains registration(s).
   If not, try to find registrations from installing ones.
3. If |registered_origins_| contains registration(s), try to
   find registrations from database.

This ordering doesn't fit well for the storage service migration
because step 2 depends on in-memory representation of registrations
but we want to move step 1 and 3 to the storage service. Keeping
this ordering will require exposing low-level methods like
LazyInitialize() to content/.

This CL changes the ordering as the blow so that we don't have to
expose low-level methods:
1. Initialize database if it's not via LazyInitialize().
2. Check |registered_origins_| if there is stored registration(s).
   If not exists, skip database lookup and go to step 4.
3. Try to find registrations from database.
4. If NOT_FOUND is returned from database, try to find registrations
   from installing ones.

The semantics changed slightly but it should be almost the same.

There will be two following CLs which do the same for
FindRegistrationForScope() and FindRegistrationForId{,Only}().

Bug: 1039200
Change-Id: I97a7821f9c534faae6ab4a638da6d731a4455a6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999974
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732293}

24bdb34a

Update V8 to version 8.1.188. · d797e5d9

v8-ci-autoroll-builder authored Jan 16, 2020

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/cd341453..3b5fd175

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I2b1feb0251cbdfcfc09f52797884417e2401dd08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003874Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732292}

d797e5d9

infra: Set `enable_ats` value in builders.star · ef0778c7

Simon Que authored Jan 16, 2020

We want to enable ATS for all builders using an RBE backend.

This will be done programmatically in builders.star, so that we don't
have to update builder configs individually.

In this CL, we test out this feature on Windows builders currently using
RBE.

This should be a no-op for generated builder configs. The only changes
in cr-buildbucket.cfg are to these builders' configs:
- win-celab-tester-rel: test-only, unaffected by goma flags
- win-pixel-builder-rel: did not explicitly specify because it is
  assigned a Windows 10 bot elsewhere, added explicit Windows 10 value.

R=agable@chromium.org, gbeaty@chromium.org, tikuta@chromium.org

Bug: 1040754
Change-Id: If7e97e1a444527b5e72413988f02108b06870ac6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004186Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732291}

ef0778c7

[FirstScrollDelay] Run queued presentation callbacks. · f7ec1ec5

Tom McKee authored Jan 16, 2020

The PresentationTimeCallbackBuffer now supports callbacks that expect
to be run on the compositor thread. They need to be run once the
corresponding frame has been presented. This CL makes sure these
callbacks get run on the right thread at the right time.

This is preparatory work needed to support First Scroll Delay which will
use compositor-side callbacks to track presentation timestamps.

Bug: 922980
Change-Id: I4d1f7056510793ecaac1e96e89b6d7d5084d37f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835150
Commit-Queue: Tom McKee <tommckee@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732290}

f7ec1ec5

Roll src/third_party/googletest/src/ 5395345ca..306f3754a (123 commits) · 27a51812

Ilia Samsonov authored Jan 16, 2020

https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/5395345ca4f0..306f3754a71d

$ git log 5395345ca..306f3754a --date=short --no-merges --format='%ad %ae %s'
2019-12-30 absl-team Googletest export
2019-12-30 absl-team Googletest export
2019-12-26 absl-team Googletest export
2019-12-19 absl-team Googletest export
2019-12-18 absl-team Googletest export
2019-12-18 absl-team Googletest export
2019-12-20 kontakt Make move operation noexcept.
2019-12-20 kontakt Define default destructor for test classes
2019-12-20 kontakt Deleted functions as part of public interface
2019-12-20 kontakt Review notes: Return T& from assignment operators
2019-12-17 kontakt Disable move constructor and assignment operator for test classes.
2019-12-16 krzysio Googletest export
2019-12-10 syoussefi Revert "Googletest export": disallow empty prefix
2019-12-10 syoussefi Revert "Googletest export": Remove test for empty prefix
2019-12-16 syoussefi Workaround VS bug w.r.t empty arguments to macros
2019-12-12 absl-team Googletest export
2019-12-11 absl-team Googletest export
2019-12-10 absl-team Googletest export
2019-12-06 misterg Googletest export
2019-12-13 kravlala.1 Activate GNU extensions in case of MSYS generator
2019-12-05 absl-team Googletest export
2019-12-05 absl-team Googletest export
2019-12-05 absl-team Googletest export
2019-12-02 absl-team Googletest export
2019-11-27 krystian.kuzniarek Revert "remove MSVC workaround: wmain link error in the static library"
2019-11-27 krystian.kuzniarek Revert "unify googletest and googlemock main functions"
2019-11-27 Oleksandr.Yefremov Rename test case to test suite
2019-11-26 absl-team Googletest export
2019-11-25 absl-team Googletest export
2019-11-25 mate.pek README.md: added Catch2 and Google Test Explorer
2019-11-25 maximilianschwab Fixed typo
2019-11-22 absl-team Googletest export
2019-11-20 absl-team Googletest export
2019-11-17 krystian.kuzniarek unify googletest and googlemock main functions
2019-11-17 krystian.kuzniarek remove MSVC workaround: wmain link error in the static library
2019-11-22 krystian.kuzniarek remove Nokia's Symbian compiler workaround: SafeMatcherCastImpl
2019-11-22 krystian.kuzniarek consistency fix for SafeMatcherCastImpl member functions
2019-11-17 krystian.kuzniarek remove MSVC workaround: cease const dropping
2019-11-17 krystian.kuzniarek remove MSVC workaround: warning 4355
2019-11-14 krystian.kuzniarek remove MSVC workaround: error C2665
2019-11-14 krystian.kuzniarek remove MSVC workaround: accessing namespace scope from within nested classes
2019-11-22 krystian.kuzniarek remove stale comments about older GCC versions
2019-11-22 krystian.kuzniarek remove g++ 2.95.0 workaround: no space after first comma in macros
2019-11-22 krystian.kuzniarek remove g++ 3.3 workaround: using on operator<<
2019-11-21 Christoph.Strehle Fix compile break for Microsoft Visual Studio 2017 v141
2019-11-19 absl-team Googletest export
2019-11-18 absl-team Googletest export
2019-11-16 xyb Fix internal memory leak in Windows _Crt report.
2019-11-15 b.gianfo Fix FlatTuple compilation on older msvc.
2019-11-08 absl-team Googletest export
(...)
2019-10-25 piotrwn1 Apply 80chars limit
2019-10-24 piotrwn1 Tests simplified and names corrected (POD->scalar)
2019-09-10 krystian.kuzniarek remove BiggestInt
2019-10-23 absl-team Googletest export
2019-10-23 joshdcannon Revert "Merge pull request #2498 from thejcannon:noexcept_spec"
2019-10-22 absl-team Googletest export
2019-10-22 absl-team Googletest export
2019-10-23 piotrwn1 Added more tests to verify: ReturnRef not accept temporary
2019-10-22 piotrwn1 Added tests verifying that temporaries are accepted by ReturnRef
2019-10-22 absl-team Googletest export
2019-10-22 piotrwn1 Prevent using ReturnRef on reference to temporary
2019-10-21 absl-team Googletest export
2019-10-18 absl-team Googletest export
2019-10-19 41349879+cloudrex Remove extra space
2019-10-18 dieter.gnaier Fix Issue 2418
2019-10-18 misterg Googletest export
2019-10-17 absl-team Googletest export
2019-10-17 absl-team Googletest export
2019-10-17 lesha [googletest] Output skip message
2019-10-16 absl-team Googletest export
2019-10-11 joshdcannon Avoid recursive macros
2019-10-09 robert Add more override keywords
2019-10-07 chrisjohnsonmail Update to distinguish prelease purpose of this fork.
2019-10-11 joshdcannon Removing extraneous parenthesis
2019-10-11 joshdcannon Evaluate and cat NARG in different macros
2019-08-29 chrisjohnsonmail Add ESP8266 configs to PlatformIO build
2019-08-28 chrisjohnsonmail feat: Add support for ESP8266 platform
2019-10-11 joshdcannon Removing extraneous test
2019-10-11 joshdcannon Replace compile-test with preprocessor test
2019-10-11 joshdcannon Fix preprocessor tests
2019-10-11 joshdcannon Add a compile test
2019-10-11 joshdcannon Workaround MSVC VA_ARGS weirdness
2019-10-11 misterg Googletest export
2019-10-10 absl-team Googletest export
2019-10-10 absl-team Googletest export
2019-10-11 krystian.kuzniarek clean-up broken paths for PlatformIO
2019-10-10 chrisjohnsonmail chore:  update version
2019-10-10 joshdcannon Made noexcept condition more exciting
2019-10-09 absl-team Googletest export
2019-10-09 zeb Mention Cornichon as a related open source project
2019-10-07 joshdcannon Use declval in noexcept expression
2019-10-07 joshdcannon Switch to free function to avoid GCC bug
2019-10-07 joshdcannon Avoid comma operator
2019-10-07 joshdcannon Fix spacing
2019-10-07 joshdcannon Use the verbatim noexcept spec in MOCKED_METHOD
2019-09-05 krystian.kuzniarek remove GTEST_ARRAY_SIZE_
2019-08-22 krystian.kuzniarek mention the existing support for wide strings in string matchers
2019-08-22 krystian.kuzniarek change usings
2019-09-10 krystian.kuzniarek change includes in gtest-port.h
2019-09-10 krystian.kuzniarek remove GTEST_HAS_STD_STRING
2019-09-10 krystian.kuzniarek remove a dead function
Created with:
  roll-dep src/third_party/googletest/src

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel,mac_optional_gpu_tests_rel
Bug: 1023677, 1039450
Change-Id: I17509b0e81b34f33e9f210042aa462da55578913
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955786Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#732289}

27a51812

Settings Chrome OS Printing Page: Fix test · 3e960bc6

rbpotter authored Jan 16, 2020

Unclear how this test passed when landing:
https://chromium-review.googlesource.com/c/chromium/src/+/1994261

but it calls a method that no longer exists. Test was recently updated,
so it is likely there was an issue with auto-merge.

Bug: 967861
Change-Id: Iec8495e5253fe92dda1be5da87aa369ea86483bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003012
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732288}

3e960bc6

Remove LayoutFileUploadControl::PositionForPoint(). · 5e349bbb

Kent Tamura authored Jan 16, 2020

The function was added in crrev.com/fa5be439.
File upload controls are still non-selectable after this change.

Bug: 1040828
Change-Id: Ibb25b67a319ee21163df592b124b406dba96ebe3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002269Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732287}

5e349bbb

Roll src/third_party/webrtc ccab06fb72be..5b8d2fcb2c08 (9 commits) · 978a4668

chromium-autoroll authored Jan 16, 2020

https://webrtc.googlesource.com/src.git/+log/ccab06fb72be..5b8d2fcb2c08

git log ccab06fb72be..5b8d2fcb2c08 --date=short --first-parent --format='%ad %ae %s'
2020-01-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2bc032e8..1d541bc5 (732049:732155)
2020-01-15 srte@webrtc.org Cleanup: Using RtpRtcp directly from AudioSendStream
2020-01-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2638d764..2bc032e8 (731908:732049)
2020-01-15 jtteh@webrtc.org Reland "Reland "Extracts ssrc based feedback tracking from feedback adapter.""
2020-01-15 jtteh@webrtc.org Revert "Reland "Extracts ssrc based feedback tracking from feedback adapter.""
2020-01-15 jonaso@webrtc.org GOOG_PING: improve handshake
2020-01-15 hta@webrtc.org Change rate stats classes to use int64_t not size_t
2020-01-15 ilnik@webrtc.org Deflake CpuTimeTest.TwoThreads
2020-01-15 srte@webrtc.org Reland "Extracts ssrc based feedback tracking from feedback adapter."

Created with:
gclient setdep -r src/third_party/webrtc@5b8d2fcb2c08

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ib995260a719692f47b55208379f3d8f6daac0f56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003914Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732286}

978a4668

ui/base/clipboard: Remove redundant ANSI format functions · a29382f4

Darwin Huang authored Jan 16, 2020

Windows is the only platform where available ANSI and UNICODE
ClipboardFormatType's are different. These functions were likely added in other
platforms to mirror the Windows clipboard's ANSI functions. Remove these
unnecessary ANSI functions outside Windows.

In addition, ANSI functions are now labelled with an "A", and UNICODE functions
have had their "W" removed. This should help normalize UNICODE functions as the
"default" option to use, and make it more explicit that ANSI functions are only
to be used if the UNICODE equivalent isn't available.

This simplifies ClipboardFormatType, and removes extra checks for ANSI formats
on non-Windows platforms. That said, this does also expose this extra complexity
of different ANSI/UNICODE only on Windows more transparently.

See clipboard_format_type.h for an overview of what changed.

Change-Id: I5d365267269447a8c4861183d5d1064971b1030a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992015
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732285}

a29382f4

Wrangle names of incognito theme CSS · e5fdb462

Dan Beam authored Jan 16, 2020

R=pkasting@chromium.org

Bug: none
Change-Id: I32b7d2101115e5c82450f188a7aba98446a7a976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003222
Commit-Queue: Dan Beam <dbeam@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732284}

e5fdb462

Added underline style and text color for styleable markers. · 614b7ad7

Anupam Snigdha authored Jan 16, 2020

Some IMEs and text input clients on Windows use a different underline style
(dots, dash etc) compared to the default style(solid) on other platforms during
an active composition. This patch adds these two new fields in ImeTextSpan so
when TSF or any other text input client send this data, it gets applied
on the actively composed text through styleable markers. Currently, this is
only applicable to TSF based IMEs on Windows and I haven't changed anything on
other platforms except the changes that we were required due to dependencies.
But, the plumbing of these fields would also allow other platforms to leverage
this use case so it would be beneficial for them in the future if they decide
to add new formats to the composed text. For now, the default underline style
is solid on other platforms like it was before.

Bug: 1033764

Change-Id: I3bed31fd6b87e2a0e5b11db4ebcdacdcd9e77f24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992518
Commit-Queue: Anupam Snigdha <snianu@microsoft.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yohei Yukawa <yukawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732283}

614b7ad7

Fix canvas rate limiting for certain canvas scenarios. · 8f2a0ab1

Kenneth Russell authored Jan 16, 2020

In certain situations the "SetIsBeingDisplayed" notification for
CanvasRenderingContext2D - coming from HTMLCanvasElement - occurs
before the Canvas2DLayerBridge is allocated. In order to reliably
allocate the rate limiter when needed, set the display status of the
Canvas2DLayerBridge upon its allocation / installation.

Bug: 1038670
Tbr: fserb@chromium.org
Change-Id: I8029462ec7c94f4644763cd8b662471b69a7d64b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999085
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732282}

8f2a0ab1

Bresenham video frame cadence algorithm · 92e35fbe

Eugene Zemtsov authored Jan 16, 2020

Choosing how many render intervals a given frame needs to be shown
is very much like drawing a line on a 2D pixel grid.
That’s why this algorithm is inspired by Bresenham's line algorithm,
although it is simpler for using FP arithmetic.

It's gated by a feature switch and intended for lab tests and
later maybe a canary\beta experiment.

Bug: 1042111
Change-Id: I1d4e54252d904dd80f37e4542aa4b6950a527c4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994546Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732281}

92e35fbe

Convert ==/!= to ===/!== in: //content/browser/resources/ · 26d7374f

Dan Beam authored Jan 16, 2020

CL generated with:

$ git ls-files 'content/browser/resources/*.js' | xargs grep -l -P ' [!=]= (?!null)' | xargs perl -p -i -e 's/ ([!=])= (?!null)/ \1== /g'

Bug: 720034
Change-Id: Ib22149854033d71daf6c3041b4f3f747e9113ffa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003793Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732280}

26d7374f

Roll src/third_party/catapult f7d73bb52028..e5b0598dee84 (1 commits) · 9ab7c98e

chromium-autoroll authored Jan 16, 2020

https://chromium.googlesource.com/catapult.git/+log/f7d73bb52028..e5b0598dee84

git log f7d73bb52028..e5b0598dee84 --date=short --first-parent --format='%ad %ae %s'
2020-01-16 fancl@chromium.org Switch default to sheriff-config

Created with:
gclient setdep -r src/third_party/catapult@e5b0598dee84

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC wenbinzhang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:953181
Tbr: wenbinzhang@google.com
Change-Id: Id01e057ea564c3552684ab194d215ddf14df9b06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003644Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732279}

9ab7c98e

Move TextAndButtonPreference to autofill/ · b2632461

Natalie Chouinard authored Jan 16, 2020

TextAndButtonPreference is unlikely to be a useful reusable component
for future settings screens (over ButtonPreference or
HyperlinkPreference), so make its specificity explicit and move it
alongside other Autofill Settings code.

Change-Id: I7b76e30024f433c74188d2e0c4e1561033d4e5c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003688Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732278}

b2632461

WebApp: Implement deletion of OS shortcuts for the new web apps system. · 160206ba

Alexey Baskakov authored Jan 16, 2020

Delete OS shortcuts in OnWebAppWillBeUninstalled observation.

The bookmark app uninstallation case is currently handled in
::AppShortcutManager::OnExtensionUninstalled()
located in
chrome/browser/apps/platform_apps/shortcut_manager.h|cc.

Bug: 860581
Change-Id: Id501151011998b49d971cf09a5ebab7f985de8e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000448Reviewed-by: Jay Harris <harrisjay@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732277}

160206ba

Revert "Adding a FTT config for PreconnectSameOriginDesktop" · 63f19936

Trent Apted authored Jan 16, 2020

This reverts commit 4e23e8e8.

Reason for revert: 

Causing flaky failures on inux-chromeos-rel since

https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/33779

got deterministic in https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/33781

e.g.
LoadingPredictorBrowserTestWithProxy.PrepareForPageLoadWithoutPrediction

errors like

../../chrome/browser/predictors/loading_predictor_browsertest.cc:164: Failure
Expected: (num_connections) >= (sockets_.size()), actual: 2 vs 4
Stack trace:
#0 0x5578dc920ba5 predictors::ConnectionTracker::WaitForAcceptedConnections()

Original change's description:
> Adding a FTT config for PreconnectSameOriginDesktop
> 
> This experiment is in canary/dev and should be moved to Beta.
> 
> Bug: 1038774
> Change-Id: I4fc9c44e2b68aa58f9eee7210a625103f45edb01
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992684
> Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
> Reviewed-by: Alex Ilin <alexilin@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#732219}

TBR=isherman@chromium.org,tbansal@chromium.org,ryansturm@chromium.org,alexilin@chromium.org

Change-Id: I6ccc34cb80ca6da3b1b3b40d29d6c4e5dd8e65f7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1038774
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004181Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732276}

63f19936

Remove GLSurface::GetCompatibilityKey · 4aa353f4

Kramer Ge authored Jan 16, 2020

We use one X visual and thus all GLContexts are compatible with each
other and this method is not needed.

Bug: 902943
Change-Id: I51d8f7527b52117c0b1535cc7f3d706030c3ffda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001397
Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732275}

4aa353f4

Roll src/third_party/pdfium de6595c71442..c86e356c31a9 (17 commits) · a13341ac

chromium-autoroll authored Jan 16, 2020

https://pdfium.googlesource.com/pdfium.git/+log/de6595c71442..c86e356c31a9

git log de6595c71442..c86e356c31a9 --date=short --first-parent --format='%ad %ae %s'
2020-01-16 thestig@chromium.org Roll tools/clang/ 57e481c48..42fbdfef1 (13 commits)
2020-01-16 thestig@chromium.org Roll build/ 4f02786ee..1bee638a8 (246 commits)
2020-01-16 thestig@chromium.org Roll v8/ 724fd9f1e..cd3414532 (360 commits)
2020-01-16 thestig@chromium.org Roll buildtools/ 6b3e658d6..1f38b432e (4 commits)
2020-01-16 thestig@chromium.org Roll third_party/depot_tools/ 603782044..e9730d75a (43 commits; 11 trivial rolls)
2020-01-16 tsepez@chromium.org Remove unused CXFA_GEColor no-arg ctor.
2020-01-16 thestig@chromium.org Roll third_party/catapult/ 32775164b..f7d73bb52 (148 commits)
2020-01-15 thestig@chromium.org Roll third_party/icu/ 88ea42af7..dbd3825b3 (1 commit)
2020-01-15 tsepez@chromium.org Remove unused CFFL_FormFiller::GetSystemHandler().
2020-01-15 thestig@chromium.org Roll third_party/zlib/ f262c1b3c..814da1f38 (3 commits)
2020-01-15 thestig@chromium.org Roll base/trace_event/common/ 5e4fce17a..81c050f85 (1 commit)
2020-01-15 thestig@chromium.org Roll third_party/android_ndk/ 89e8db0cd..27c0a8d09 (1 commit)
2020-01-15 tsepez@chromium.org Move PDFSDK_XFAAActionType from cpdfsdk_fieldaction.h to cpdfsdk_widget.h
2020-01-15 thestig@chromium.org Refactor CFX_ImageTransformer::Continue().
2020-01-15 tsepez@chromium.org Unify PWL right click handling under xfa/non-xfa.
2020-01-15 thestig@chromium.org Add a pixel test that uses type 3 font.
2020-01-15 dhoss@chromium.org Update pdfium_diff printf messages to use the current binary name

Created with:
gclient setdep -r src/third_party/pdfium@c86e356c31a9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I5c9d4fc6b4738ced8b4d3ea694ac6ef72cd7da82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003643Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732274}

a13341ac

Fix crash about popup tab strip when current tab is null · 3dedd81e

Yue Zhang authored Jan 16, 2020

Bug: 1035869
Change-Id: If0af6b3bc0f9730f3962e06e21df00b837d6a784
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003908
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Auto-Submit: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732273}

3dedd81e

[webnfc] NDEFRecordInit#encoding is only applicable for BufferSource data source · d1d6f118

Leon Han authored Jan 16, 2020

DOMString data source is always encoded as utf-8.

The spec change:
https://github.com/w3c/web-nfc/pull/522

BUG=520391

Change-Id: Iec3d923d169f7a61937eda5249a57c6803598678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991972
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#732272}

d1d6f118

Add crostini app list menu items to AppService. · 7d9744e6

nancy authored Jan 16, 2020

This CL is used to integrate Crostini's context menus for app list to
AppService:
https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/crostini/crostini_app_context_menu.cc?l=57
https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/crostini/crostini_app_context_menu.cc?l=34

BUG=1038487

Change-Id: Icde50aaf93cd961476f46a6652112005fe4a3ae4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002554Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732271}

7d9744e6

Implement WebXR lighting estimation API · 404c7994

Will Cassella authored Jan 16, 2020

This implements the API outlined in the explainer here:
https://github.com/immersive-web/lighting-estimation

Initial components of this implementation were done by bialpio@.

Bug: 1034135
Change-Id: I98ba7d3e7c166c6ac2254efae4f5b79e4bb95f48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965850Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Will Cassella <cassew@google.com>
Cr-Commit-Position: refs/heads/master@{#732270}

404c7994

Roll src/third_party/skia 4cf1874981c3..7edb0eb8a458 (8 commits) · 453258c6

chromium-autoroll authored Jan 16, 2020

https://skia.googlesource.com/skia.git/+log/4cf1874981c3..7edb0eb8a458

git log 4cf1874981c3..7edb0eb8a458 --date=short --first-parent --format='%ad %ae %s'
2020-01-15 jvanverth@google.com Revert "Reland "Add new method for storing DrawOpAtlas texture index.""
2020-01-15 jlavrova@google.com RTL Paragraph + all it causes
2020-01-15 herb@google.com Redo glyph quad regeneration
2020-01-15 mtklein@google.com fix SkMatrixConvolutionImageFilter unpremul
2020-01-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-15 csmartdalton@google.com Add a temporary job to test GrGpuTessellationPathRenderer
2020-01-15 reed@google.com experimental: saveCamera()
2020-01-15 halcanary@google.com docs/examples: REG_FIDDLE_ANIMATED

Created with:
gclient setdep -r src/third_party/skia@7edb0eb8a458

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: mtklein@google.com
Change-Id: I88382145ebaf55ecd4405fafa9894a9d905fa201
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003755Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732269}

453258c6

Reformat all gn files in /chrome/browser/resources/management. · 24d8f730

Nico Weber authored Jan 16, 2020

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=emaxx@chromium.org

Bug: 1041419
Change-Id: I1bc4cdc82b44fbc1da1cedc429708e0aa58717ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998264
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732268}

24d8f730

Add a Feature, kEnablePalmOnMaxTouchMajor to change max_major behavior. · 398a52ea

Rob Schonberger authored Jan 16, 2020

By default, we mark any touch that has a ABS_MT_TOUCH_MAJOR ==
major_max (as given in device info) to be a palm.

For some experimental situations, we often receive a genuine
TOUCH_MAJOR of this magnitude. We want to be able to treat that as normal.

Adds a Feature, and set it at construction time - this avoids looking
through features on every single touch. Adds a unit test appropriately
to test for this change in behavior (and that current behavior is
maintained).

Bug: 1009290
Change-Id: I4f1c3b2d4733ff00cb13814db4dad834baeb8977
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003166Reviewed-by: Thanh Nguyen <thanhdng@chromium.org>
Commit-Queue: Rob Schonberger <robsc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732267}

398a52ea

Revert "tablet: Fix double shelf when entering guest mode." · 23821832

Meredith Lane authored Jan 16, 2020

This reverts commit b1af29a5.

Reason for revert: Crashes ash_unittests on linux-chromeos-dbg

First failure: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/16451

Original change's description:
> tablet: Fix double shelf when entering guest mode.
> 
> The issue was the window was created on startup, then OnGetSwitchStates
> triggers TabletMode to start and create the screenshot since it detects
> a window animating. But the window doesn't destroy the screenshot because
> a |fps_counter_| is not detected on animation end because it is created
> in on animation schedules which happened before entering tablet mode.
> 
> This CL aims to prevent this and similar bugs by not taking the screenshot
> if a window is already animating, so the only observed animation is the
> one triggered by entering tablet mode. This may have missed data or
> performance in some cases, but will prevent similar bugs.
> 
> Test: ash_unittests TabletModeControllerScreenshotTest.EnterTabletModeWhileAnimating
> Bug: 1035356
> Change-Id: I601d08ef50f214dbd262e5eea6baed40e5596270
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999241
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#732159}

TBR=xdai@chromium.org,sammiequon@chromium.org

Change-Id: I738e9d46e2a9c7aa00305ba5ecf3c203ac872ecb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1035356
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004177Reviewed-by: Meredith Lane <meredithl@chromium.org>
Commit-Queue: Meredith Lane <meredithl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732266}

23821832

[video-raf] Add WebMediaPlayerMS::RequestAnimationFrame() · 9a6a9283

Thomas Guilbert authored Jan 16, 2020

Callbacks passed to video.requestAnimationFrame are never called when
using webRTC. This is because webRTC uses WebMediaPlayerMS instead of
WebMediaPlayerImpl, and it does not override the RequestAnimationFrame()
method. This CL implements the method and fixes the issue.

Bug: 1035028, 1012063
Change-Id: I1792dfd6f6077e6e49c39f23e607e7868611293e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987069
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732265}

9a6a9283

Move the WebView instance count to native · 5912a82a

Tao Bai authored Jan 16, 2020

This
- reduces unnecessary calls from native to java.
- makes it possible to add observer in native side.

Bug: 1042048
Change-Id: I0e5c32b98adfb56ac408556f9a0fcbd209b5813c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001747Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732264}

5912a82a

[QuickView] Add tab-index focus test for video files · 28814b23

Rachel Sugrono authored Jan 16, 2020

Add a test that tab-index key focus works correctly (the tab-indexable
elements are cycled through in order) when Quick View is displaying a
video file in its content panel.

Tab past the content panel to skip over checking the focus on the content
webview/video: these can have multiple internal elements that can
take the focus and our test should be independent of that.

Bug: 907380
Change-Id: Ie7f6de4a4ab5487ed62fc30361674ac1d55de057
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004172
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732263}

28814b23

Convert ==/!= to ===/!== in: //components/ · c117d8c5

Dan Beam authored Jan 16, 2020

CL generated with:

$ git ls-files 'components/*.js' | xargs grep -l -P ' [!=]= (?!null)' | xargs perl -p -i -e 's/ ([!=])= (?!null)/ \1== /g'

Bug: 720034
Change-Id: Ie01258dadf0dea819405a03d064c6767d8da96e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003638
Commit-Queue: Dan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732262}

c117d8c5

Roll src/third_party/boringssl/src cb3f04f58..98b4cdba1 · f7a4166c

David Benjamin authored Jan 16, 2020

https://boringssl.googlesource.com/boringssl/+log/cb3f04f584a53844546aaa32e949534c453185aa..98b4cdba1e4ede26d845bcae8185ddb5b2feea93

The following commits have update notes:
  0df6edff4 Split BN_prime_checks into two constants for generation and validation.

Bug: none
Change-Id: Ia16ddb85756277144fc0ea410fb2b31840bf9332
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998162
Commit-Queue: David Benjamin <davidben@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732261}

f7a4166c

[QuickView] Add tab-index focus test for audio files · ea8536ef

Rachel Sugrono authored Jan 16, 2020

Add a test that tab-index key focus works correctly (the tab-indexable
elements are cycled through in order) when Quick View is displaying a
audio file in its content panel.

Tab past the content panel to skip over checking the focus on the content
webview/audio: these can have multiple internal elements that can
take the focus and our test should be independent of that.

Bug: 907380
Change-Id: Ifd8b298865c05cbfcc318e63b0d701fb6ca8f7d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004171Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Commit-Queue: Rachel Sugrono <rsugrono@google.com>
Cr-Commit-Position: refs/heads/master@{#732260}

ea8536ef

media/gpu/v4l2(s)vda: recreate image processor device on resolution change · 9e2856b7

Alexandre Courbot authored Jan 16, 2020

When the resolution changes, we recreate the image processor device
entirely. However we used to do so while reusing the same V4L2Device
instance, which is not supported and triggers a DCHECK() with Debug
builds.

This behavior is wrong anyway since we might want to use another image
processor device with the new resolution.

This also seems to be effective in fixing bug 1029396.

BUG=chromium:1029396
TEST=video.DecodeAccel.h264_resolution_switch passes 100 times in a row
on Hana.
TEST=video.DecodeAccel.h264_resolution_switch passes on Hana without
triggering DCHECK().

Change-Id: Ib506d9f038810a0683b806f8385746dce16ecd56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002250
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Auto-Submit: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732259}

9e2856b7

Fix crash in ExtensionUninstallDialogViews::Show · 0b2495a7

Peter Boström authored Jan 16, 2020

Fixes regression in r728281. The code started assuming that a
BrowserActionsContainer always existed, this is not true for windows
without a tab strip.

Bug: chromium:1042419
Change-Id: Ia69257972ebe08d58a878722a42821730ebcc7b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003220
Commit-Queue: Peter Boström <pbos@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732258}

0b2495a7

Convert ==/!= to ===/!== in: //chrome/renderer/ · ed31a5a6

Dan Beam authored Jan 16, 2020

CL generated with:

$ git ls-files 'chrome/renderer/*.js' | xargs grep -l -P ' [!=]= (?!null)' | xargs perl -p -i -e 's/ ([!=])= (?!null)/ \1== /g'

Bug: 720034
Change-Id: I64e170031fdd2087dd3adf50276228fbfaf6fd57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003917
Commit-Queue: Dan Beam <dbeam@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732257}

ed31a5a6

Updating trunk VERSION from 4029.0 to 4030.0 · 5e341638

chrome-release-bot authored Jan 16, 2020

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=kariah@chromium.org

Change-Id: I6de271cd0349c33500203d3d4d87d2600932bbd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003084Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732256}

5e341638

Reformat all gn files in /content/browser. · 374f209d

Nico Weber authored Jan 16, 2020

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=boliu@chromium.org

Bug: 1041419
Change-Id: Ied9d082ee57276d5b82983e6b42ee7914dea9eff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998672
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732255}

374f209d