GitLab

Added functionality for editing the title and URL of a custom link. If
the new URL already exists as a custom link, the edit is not applied.

Bug: 851293, 856394
Change-Id: I8a5351644370b6f91ef4376e7b336dce6831acbd
Reviewed-on: https://chromium-review.googlesource.com/1152495
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579093}

A CL adding new headers without corresponding GN changes is likely
wrong.

Bug: 661774
Change-Id: I11da5615b36ebc7b9f60490beb3a39874bd74ac2
Reviewed-on: https://chromium-review.googlesource.com/1152126
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579092}

Bug: None
Change-Id: Idc9656daa337ffc73466a66a60965a1b7420079c
Reviewed-on: https://chromium-review.googlesource.com/1153429Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579091}

This reverts commit 0f6c2c59.

Reason for revert: crash on OnFocusTabScoreAdjustmentTimeout

Bug: 869037

Original change's description:
> Set oom_score_adj of chrome processes directly
> 
> Setting oom_score_adj directly is faster and doesn't have to involve
> debugd when ARC++ is disabled.
> 
> Bug: 868249
> Change-Id: Ifeda6cd1d393c85f373928aafadd4ec3d3941a92
> Reviewed-on: https://chromium-review.googlesource.com/1152751
> Reviewed-by: Cheng-Yu Lee <cylee@chromium.org>
> Commit-Queue: Vovo Yang <vovoy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578987}

TBR=cylee@chromium.org,vovoy@chromium.org

Change-Id: Iafc37f22743479ba558fcc520bd24e7a30bcc693
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 868249
Reviewed-on: https://chromium-review.googlesource.com/1155327Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Vovo Yang <vovoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579090}

ErrorRetryStateMachine is meant to manage the displaying of error pages
when a navigation fails and retrying the original URL when user
navigates back to an error page. SSL interstitial and other errors that
do not load error page (e.g. canceled navigation) should not modify an
item's ErrorRetryStateMachine to avoid trigger the error retry logic
when user navigates back to such an item.

Bug: 837210
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8dfd11821dfb8cb9ee6f10820b88499c915d1994
Reviewed-on: https://chromium-review.googlesource.com/1151949
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579089}

With this change, no caching headers are sent for icons, which is a
default of in-memory caching.

Bug: 868432
Test: None
Change-Id: I8dedb6a33035dd7e6cf32479921c0e6180e9ad03
Reviewed-on: https://chromium-review.googlesource.com/1154362Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579088}

R=cmasso@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib54d1eb04f8f7f6103eb3f3be3afc910445f160c
Reviewed-on: https://chromium-review.googlesource.com/1155260Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579087}

Passing pinpoint job here:
https://pinpoint-dot-chromeperf.appspot.com/job/16e3abd5a40000

Bug: 673775
Change-Id: I98cb4f3099b25512e0dc36c3adbc6f8b890fe46d
Reviewed-on: https://chromium-review.googlesource.com/1143596
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579086}

Turns this:

separator = {
  <std::__1::__basic_string_common<true>> = {<No data fields>},
  members of std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >:
  static __short_mask = 1,
  static __long_mask = 1,
  __r_ = {
    <std::__1::__compressed_pair_elem<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::__rep, 0, false>> = {
      __value_ = {
        {
          __l = {
            __cap_ = 2108420,
            __size_ = 0,
            __data_ = 0x0
          },
          __s = {
            {
              __size_ = 4 '\004',
              __lx = 4 '\004'
            },
            __data_ = ", ", '\000' <repeats 20 times>
          },
          __r = {
            __words = {[0] = 2108420, [1] = 0, [2] = 0}
          }
        }
      }
    },
    <std::__1::__compressed_pair_elem<std::__1::allocator<char>, 1, true>> = {
      <std::__1::allocator<char>> = {<No data fields>}, <No data fields>}, <No data fields>},
  static npos = 18446744073709551615
}

Into this:

separator = ", "

BUG=866697
R=thakis
CC=leszeks

Change-Id: I4b35799c6023743b5876aa89a2448b8f841c7751
Reviewed-on: https://chromium-review.googlesource.com/1152087Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579085}

Disabling test on linux.

BUG=868956
TBR=qyearsley@chromium.org,jeffcarp@chromium.org,dpranke@chromium.org,tkent@chromium.org
NOTRY=true

Change-Id: I7b1639a1dc94ff139b696633209fb72e75f92338
Reviewed-on: https://chromium-review.googlesource.com/1155103
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579084}

This CL adds the class MessageLoopObserver, which forwards events from the UI
and IO thread message loop task runners to the responsiveness Watcher and
Calculator.

Bug: 859155
Change-Id: Ie492f1fbc26940007cb303bdc5cdbdb59d887c19
Reviewed-on: https://chromium-review.googlesource.com/1149042
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579083}

This CL does a few things:
1. Updates the PerfBenchmark to pull the fieldtrial config from
   chrome_root, if it is specified instead of using the location of
   the python file itself as reference.

2. Make FixupTargetOS public, so tests can reliably compute the
   platform that variations code expects.

3. Alter the actual test to pull variations params from a test file,
   so we can actually expect the exact arguments added to extra_args.

Bug: 844863
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: Ia2a0b77246de6362321bd36eabc13f840d7b5c1b
Reviewed-on: https://chromium-review.googlesource.com/1151447
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579082}

Adds a missing data entry to the chrome_test_ar_java target that was
causing the bot that runs the test to fail due to being unable to find
the ArCore APK.

TBR=agrieve@chromium.org

Bug: 851020
Change-Id: Ib96b57fe46a7e2ef73501d98deb5eacaa71cead3
Reviewed-on: https://chromium-review.googlesource.com/1155155Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579081}

This reverts commit 98cfabe9.

Reason for revert: Still reporting as flaky.

Bug: chromium:868921, chromium:662160

Original change's description:
> Enable WebNavigationApiTest.UserAction test.
> 
> There have been various fixes in navigation code that have helped deflake
> webNavigationApi tests. The goal of this CL is to enable the
> WebNavigationApiTest.UserAction test and see if it has benefited from
> these fixes and is no longer flaky.
> 
> Bug: 662160
> Change-Id: Ia463d32f425b9e366c5879d4f297a521c8c28260
> Reviewed-on: https://chromium-review.googlesource.com/1153394
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Commit-Queue: Nasko Oskov <nasko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578835}

TBR=nasko@chromium.org,alexmos@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 662160
Change-Id: I57be2c1d1224720820efeb0204950b15f75d6731
Reviewed-on: https://chromium-review.googlesource.com/1155072Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579080}

This reverts commit 443c01a0.

Reason for revert: Didn't stop the crashes

Original change's description:
> Revert BrowserCompositorMac parts of https://crrev.com/574738
> 
> TBR=lgrey
> 
> Bug: 863817
> Change-Id: I64bb71603eb5fba012d17c953e61481c7ee5182b
> Reviewed-on: https://chromium-review.googlesource.com/1154357
> Reviewed-by: ccameron <ccameron@chromium.org>
> Commit-Queue: ccameron <ccameron@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578952}

TBR=ccameron@chromium.org,lgrey@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 863817
Change-Id: Ie9d42cb0f24bbf7f78d2f0597ee761067a5ec026
Reviewed-on: https://chromium-review.googlesource.com/1155050Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579079}

"intersects_viewport" is implemented for sub frames as whether it
intersects with the root document viewport. Note this is independent
of page/tab visibility, a frame can be in a background tab can still
have intersects_viewport be true. It's always true for the root frame.

On Android, drop processes that are visible but does not intersect
with viewport down to waived binding (ignoring binding management).

Bug: 855037
Change-Id: Ib912418bb0cf82d001b6fd50077fb81425093436
Reviewed-on: https://chromium-review.googlesource.com/1132468Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579078}

Rename-only follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1088762
(made that CL's diff simpler to rename independently).

R=kylechar@chromium.org

Bug: 860252, 708584
Change-Id: I3c5e2187b05a4966f7de718fe81c18b09d4e47ec
Reviewed-on: https://chromium-review.googlesource.com/1153458
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579077}

This reverts commit 7b49cfc4.

Reason for revert: AdaptiveToolbarViewControllerTest.DetectForceTouch and ForceTouchLongPressGestureRecognizerTest.DetectForceTouch crash when running on iPhone 5 iOS 10.3 simulator.

Original change's description:
> Reland "Add unit test for toolbars' force touch gestures"
> 
> This CL adds a unit test for the force touch gesture recognizer added
> to the toolbar buttons, triggering the popup menu.
> 
> Bug: 864430
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I756b16fea096cda8b1f3f1e563236d12e2d11e34
> Reviewed-on: https://chromium-review.googlesource.com/1152926
> Reviewed-by: Mark Cogan <marq@chromium.org>
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579043}

TBR=marq@chromium.org,gambard@chromium.org

Change-Id: I890f1e44f3aeb92a3258df1b372a0901cb5251c6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 864430
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1155052Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579076}

Using wpt-import in Chromium 2f3eb070.
With Chromium commits locally applied on WPT:
7dad0f17 "Added new Sec-Metadata Web Platform Tests."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22121

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
hbos@chromium.org, hta@chromium.org:
  external/wpt/webrtc

TBR=robertma

No-Export: true
Change-Id: I5cc63387047eb2ac75a7b4683029d0ad014d8097
Reviewed-on: https://chromium-review.googlesource.com/1154996
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579075}

The previous CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1102729
was reverted. The reason is that in the test we have two gesture scroll,
and the second gesture starts before the first TapDown finishes.

This CL solve the problem. PS#1 is exactly the same as the previous CL
which was reverted, so that it is easier for review.

TBR=creis@chromium.org

Bug: 851644
Change-Id: Ife9bf8f9a37892380e6587b80bcc03366cc0e80d
Reviewed-on: https://chromium-review.googlesource.com/1151094
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579074}

The reason of flakiness is the following:
1.SendKeyToPopup(ui::VKEY_RETURN) initiates sending MOJO message with a
generated password to the renderer.
2.And then immediate GetFieldValue("password_field") runs JavaScript for
extracting of value of password field, which might be not filled yet, depending
on timing of MOJO from 1 and executing JavaScript.

This CL fixes this with the same approach as in
PasswordManagerBrowserTestBase::WaitForElementValue namely waiting for filling
password field value.

The flakiness of this test becomes especially bad after CL
https://chromium-review.googlesource.com/c/chromium/src/+/1146724 . Because
that CL makes renderer part significantly faster, as result the test fails in
about 50% of cases.

Bug: 866444


Change-Id: Ifbe521bf824a1055d9955a7764e5d1cae11307aa
Reviewed-on: https://chromium-review.googlesource.com/1154914
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579073}

Fix button click in RTL mode by changing GetCloseControlsBounds()
to use GetMirroredBounds(). Also removes the OnMouseEvent button
handlers as Button will do this.

BUG=867389

Change-Id: Iaeb8a8059593592da2ad59c57cf0d98b128a47ca
Reviewed-on: https://chromium-review.googlesource.com/1153783Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579072}

The test is failing flakily, at least on Win7.

Bug: 868667
Change-Id: If9604610aa51a5754795bc6e5b6b44c06f486af8
Reviewed-on: https://chromium-review.googlesource.com/1155093Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579071}

To expand the Always-on VPN feature on Android to apply
to chrome, we need to know what VPN package to apply it to.
Then we store that information in a pref in chrome, so
that it is available after restart, even before ARC++
has started.

BUG=b:72861260
TEST=unit tests

Change-Id: I2096acb14f74316186a83e76547bd6e9d0c116b7
Reviewed-on: https://chromium-review.googlesource.com/1052507Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Philipp Weiß <phweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579070}

This cl adds additional tracing for smooth scrolling path in cc. A
NOTREACHED is also added to the invalid case that the scrolling node
exists in layer tree host impl, but the animation update fails.

Bug: 797708
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If17af64781e78d02f09433e1c0e479231e69b4c2
Reviewed-on: https://chromium-review.googlesource.com/1145736Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579069}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/74c725b6..5e5144a5

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia6ec3f742cdd7e83097b9c32b4da5070f61ee3f3
Reviewed-on: https://chromium-review.googlesource.com/1155000Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579068}

The items in the bulleted lists on the NTP are indented with eight
leading spaces.  This causes issues when text wraps to multiple lines,
as the subsequent lines are not indented.  Mitigate the impact of this
behavior by manually removing the leading whitespace from bulleted list
items, so that when text wraps, subsequent lines do not look as bad.

BUG=860500
TEST=The incognito NTP bulleted lists should not be indented.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibbb44f33bbd5bf5c98e7c1d14814b8f183613f63
Reviewed-on: https://chromium-review.googlesource.com/1155090Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579067}

In RenderWidgetHostInputEventRouter::DispatchTouchpadGestureEvent,
we set |touchpad_gesture_target_| for kGesturePinchBegin and
kGestureFlingStart events, but don't clear it until we receive
another such event. So if we perform such a gesture over a parent
RenderWidgetHostView and then scroll a child frame, scroll bubbling
will be prevented because the RenderWidgetHostInputEventRouter
believes that the parent has unrelated gesture events in progress.

Now when we set |touchpad_gesture_target_| from a pinch begin, we
clear it when we receive the pinch end.

For touchpad gesture flings, they should really be associated with
the mouse wheel events of the user's gesture, so we won't target them
separately and instead just use the existing target for the mouse
wheels.

We also correct the targeting of fling cancel events so that they
are sent to the same target that received the fling start (if it
exists).

Bug: 855840
Change-Id: Ie5b2e35dd8f50a98d503fad26f6897cec834b01f
Reviewed-on: https://chromium-review.googlesource.com/1126454Reviewed-by: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579066}

https://webrtc.googlesource.com/src.git/+log/009d0969867e..1bd66642c370


git log 009d0969867e..1bd66642c370 --date=short --no-merges --format='%ad %ae %s'
2018-07-30 nisse@webrtc.org Set RtpReceiverAudio::telephone_event_forward_to_decoder_ true on construction.


Created with:
  gclient setdep -r src/third_party/webrtc@1bd66642c370

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ic2fe2e7cc64854548f5247bcc466fe5850a09f92
Reviewed-on: https://chromium-review.googlesource.com/1155010Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579065}

This does two things:
1. Allows a new formatting context to be sized and positioned outside
   its layout opportunity when negative margins are present.
   This occurs when a layout opportunity inline dimensions matches the
   initial child available space (ignoring floats).
   Additionally when a new formatting context "jumps out" of its layout
   opportunity it ignores any floats which might impede it.
2. Performs layout inside an opportunity, and then checks if the result
   can fit within the same opportunity. Previously we were trying to
   position in an arbitrary layout opportunity, which fails the
   new-fc-relayout.html test.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I6b44b6273be5c0f633e39a8875cc54ea0bc54480
Bug: 635619
Reviewed-on: https://chromium-review.googlesource.com/1150849
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579064}

The MachineLevelCloudPolicy needs to support extension cloud policy
with a new policy type kChromeMachineLevelExtensionCloudPolicyType.
The ComponentCloudPolicyStore/Service has been created earlier for
the new type but the store class doesn't aware of the new type.

Add this type into the store class so that
MachineLevelExtensionCloudPolicy can be applied to the extensions.

1) Update DomainConstants so that the new policy type is mapped to
   POLICY_DOMAIN_EXTENSIONS.
2) Append policy type as the new parameter of ctor.
3) Using the policy type from ctor to verify the policy data.
4) The policy type must match its associated policy domain.
5) The new policy type's scope is machine.
6) Load() and Clear() function only works on the policy data that is
   owned by the instance of ComponentCloudPolicyStore.

Also refactor associated unit test and add test for the new type.


Bug: 867028
Change-Id: I2117906153d0135b1372ae42bb884abce72fc9d6
Reviewed-on: https://chromium-review.googlesource.com/1148883Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579063}

Form Parsing might be unsuccessful. This CL implements graceful behaviour
in NewPasswordFormManager::CreatePendingCredentialsForNewCredentials
when it happens.

Bug: 831123
Change-Id: Ie354bfcfbb751569ffa326691f8ba90f5fbff42e
Reviewed-on: https://chromium-review.googlesource.com/1154913
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579062}

This is a thread-safe validity check for WeakPtr-based Callbacks using the recently added WeakPtr::MaybeValid().

Bug: 730693
Change-Id: I174efb30bb16d2776e33ec64d48a913943e770a0
Reviewed-on: https://chromium-review.googlesource.com/1144208
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579061}

This aims to fix the case in which when moving focus to a different
field (for which the action doesn't apply), the accessory is first
shown and then the action is removed. When this happens, there is
a perceivable delay before the action button disappears.

Bug: 856971
Change-Id: I1dfb63c513d109b74592870d3d63277b8237df25
Reviewed-on: https://chromium-review.googlesource.com/1142150
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579060}

This issue is due to a limitation in the tool used to curtain the
session (CGSession).  This is a known limitation which has existed
for at least 10 years.  Due to this platform problem, we cannot
ensure success when in headless mode (in fact it is practically
guaranteed to fail).  My approach is to still try to curtain but
disconnect the session with a host configuration error if it is
running headless.  If CGSession somehow succeeds, then the session
will be curtained and the user can reconnect and the second
attempt will succeed.

Note that I am not adding a new error code for this condition yet.
I'd like to avoid updating the web app / other clients until we
know how often users actually encounter this issue.

BUG=832748

Change-Id: Ic07c280b19d9dc44e290585e1a16bae835d37851
Reviewed-on: https://chromium-review.googlesource.com/1153560
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579059}

This CL adds a trigger to the InProductHelp for the LongPress menu when
a new Tab is opened from the TabGrid.

Bug: 868789
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1fb6b128a4fc59c6f6c349f4cbe01d9c64bf94bf
Reviewed-on: https://chromium-review.googlesource.com/1154908
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579058}

This change contains updates to the test app to cope with interface
changes introduced in crrev.com/c/1147754.

Bug: None
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia2491fd96819ba2f4fc95ab2cbaec2aedcee05f5
Reviewed-on: https://chromium-review.googlesource.com/1155003Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579057}

Fix clang/scripts/update.py failure with DEPOT_TOOLS_WIN_TOOLCHAIN=0
and non-standard VS install location.

If GYP_MSVS_OVERRIDE_PATH is set that value should be used instead of
calling vs_toolchain.DetectVisualStudioPath().

R=brucedawson@chromium.org

Bug: 863130
Change-Id: Id72b1a22f74c5fa9174a76d611fef9ca69bb8319
Reviewed-on: https://chromium-review.googlesource.com/1135761Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Marshall Greenblatt <marshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579056}

As decided in https://goo.gl/g5Srzn, we're no longer doing BattOr power
measurement on the waterfall and consequently can't justify maintaining
the significant C++ code required to do interactive BattOr tracing.

This is the first Chrome-side CL to delete that code.

(For additional context, see https://goo.gl/P9AR84 (google internal)
or ping me to chat.)

TBR=avi for BUILD.gn

Bug: 859514
Change-Id: I4b6c0c6ac40abe9c593ce24e1bb0d68a4eeacd42
Reviewed-on: https://chromium-review.googlesource.com/1122489
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579055}

a11y article contained outdated links and information.
This gives a small update to content and links.

Bug: none
Change-Id: Ic820abc9aff3290043d346da20a01472e4c04bf3
Reviewed-on: https://chromium-review.googlesource.com/1101485
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579054}