- 08 Oct, 2019 40 commits
-
-
Ken MacKay authored
Merge-With: eureka-internal/321778 Bug: internal b/127963522 Bug: internal b/141138924 Change-Id: I08813895e48ea3e983258e3e0d316b8acda740b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842677Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#703747}
-
Joshua Peraza authored
Change-Id: I8d424c224d0fca78135749fb415f47a92da830f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836000Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#703746}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/199e8ee06a7a..e600ac2a03bb git log 199e8ee06a7a..e600ac2a03bb --date=short --no-merges --format='%ad %ae %s' 2019-10-08 timvp@google.com Create test to validate scissor size is correct Created with: gclient setdep -r src/third_party/angle@e600ac2a03bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: I134151f7c8ea7c23729dcb1e5d144b7266df689c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846758Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703745}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a9e7e778b1db..457b1b9115f5 Created with: gclient setdep -r src-internal@457b1b9115f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ief8b236d84d131126eca40b153444ec283b55d0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846760Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703744}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I751eaf5cb696b1d22a496a7a2ce4aa4e1b050071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847489Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#703743}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a6f07c5b5c7e..7efb1a6dbcff git log a6f07c5b5c7e..7efb1a6dbcff --date=short --no-merges --format='%ad %ae %s' 2019-10-08 egdaniel@google.com Move vulkan BytesPerPixel to format table. Created with: gclient setdep -r src/third_party/skia@7efb1a6dbcff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: I44ea24c2cf0d574d5fdcce8cfa810343eb4359e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846757Reviewed-by:
-
Boris Sazonov authored
Adds XML illustration to TouchToFill bottom sheet and updates the layout to match the mocks. Screenshots: https://crbug.com/1009331#c12. Bug: 1009331 Change-Id: I3d274542cef1ae8ab5ee743d7292ccf78988b892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847282 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#703741}
-
Santiago Aboy Solanes authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Bug: 878390 Change-Id: I4542da64c15feb4a72e5a6cefd9204ce0bfb0f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816551 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#703740}
-
deepak1556 authored
Bug: none Change-Id: If878b3a7f5bb051c6e99c617418475c12754ae90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845624Reviewed-by:
-
Ben Kelly authored
Bug: 960012 Change-Id: Ia1c56eedf82376542b2d143692e133a173bd0653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845856Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#703738}
-
Dmitry Gozman authored
It has a single callsite only. Drive-by: use WebHTTPResponse::HttpStatusCode() instead of custom stored one. Bug: none Change-Id: I08a566cadcff6ecb0dc5022db8da306f89b0c3ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843967Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#703737}
-
Dave Tapuska authored
RevocableInterfacePtr was never completed to provide what it needed to. As well it needed to be written to use new mojo definitions. It was decided to just remove its use at this time. BUG=978694 Change-Id: I7632be4f8d6f164fd47c1cf985f3a52978b02999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841736 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#703736}
-
sczs authored
Adds a background to the Banner icon per the latest design. Might update some constants later on once we have mocks. Screenshot: https://drive.google.com/open?id=1QC-4fhRow-s8Ar1eYxhlW1vOu6vriEzQ Bug: 961343 Change-Id: I7cee0a8b00d21dccbe58898286e13385e7d8a199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845877Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#703735}
-
John Chen authored
These failures might be due to crrev.com/692284, which has been reverted. Re-enabling the tests. Bug: 1000734 Change-Id: I8d4c7bfdce6be7f64ee08f83de08a134a45a41e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846815Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703734}
-
Sami Kyostila authored
When emitting trace events for blame contexts, first check whether tracing is enabled. If tracing is disabled, we can avoid some of the overhead associated with preparing to log a trace event (e.g., timestamp lookup). Bug: 678143 Change-Id: I6ca2ebf897d88eec7f8ad4b8557136af87524487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847300 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#703733}
-
Emircan Uysaler authored
This is a reland of a2c0ced3 Original change's description: > [Fuchsia] Reenable protected mode in WebEngine > > Bug: 982922, fuchsia:24570 > Change-Id: If9fb495249488c43f97e4451a14f0193911d600f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804527 > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Commit-Queue: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697683} Bug: 982922, fuchsia:24570 Change-Id: I8bd4459d54e7d4aab6e839916a6de2263c4ee242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841770Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#703732}
-
Antonio Gomes authored
This reverts commit 62fa86d3. Reason for revert: This is a reland of https://crrev.com/c/1813306 now that the test failures on dbg component builds were fixed. Original change's description: > Revert PeerConnectionDependencyFactory Onion Soup CLs > > This CL reverts several Onion Soup CLs related to PeerConnectionDependencyFactory. > The first one in the chain is the culprit for causing failures in some bots, > but in order to revert it, it is necessary to revert several follow-up CLs. > > > Revert "Onion soup PeerConnectionDependencyFactory and its direct dependencies" > > This reverts commit 7e1e15c3. > > Revert "Move filtering_network_manager.h and network_manager_uma.h out of the Blink API" > > This reverts commit 8f18d55d. > > Revert "Move stun_field_trial.h out of the Blink API" > > This reverts commit e8cd34ee. > > Revert "Move {ipc,empty}_network_manager.h and out of Blink API" > > This reverts commit 2dc64b39. > > Revert "Move socket_client.h out of the Blink API" > > This reverts commit b2223b28. > > Revert "Remove rtc_video_{encoder,decoder}_factory_util.h from Blink API" > > This reverts commit a438dfe1. > > Revert "Move video_codec_factory.h out of the Blink API" > > This reverts commit 2fa285a7. > > Revert "Change blink::PeerConnectionDependencyFactory ownership" > > This reverts commit a1ac2f02. > > Revert "Replace uses of blink::Platform::GetWebRtcAudioDevice" > > This reverts commit c19364a1. > > Revert "Remove left-over //content/renderer/p2p/" > > This reverts commit f4bbeac1. > > > Bug: 1005604 > TBR: treib@chromium.org > > Change-Id: I6d287dc1d141721496d5e058639f268b73b1ab09 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813306 > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Auto-Submit: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698024} TBR=guidou@chromium.org Change-Id: I191ee9c271047f5c02971b8f7c4ea3d6d0460dbd Bug: 1005604 Change-Id: I191ee9c271047f5c02971b8f7c4ea3d6d0460dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814600Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Gavin Williams authored
New screen: http://screen/GY3MX8BhZoW Bug: 1003036 Change-Id: If70d82bfc93707ec85dd8b3123369f402bdca328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809611Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#703730}
-
Alexander Timin authored
Do not cache the page if we have we have pending permission requests as we would lose a part of the state of the page. Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 R=carlscab@chromium.org,engedy@chromium.org CC=bfcache-bugs@chromium.org BUG=1001087 Change-Id: Ib3d2619333767b141d25d23e015deaf2a06b5b1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827432Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#703729}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/720988d878a1..e986cb92544a git log 720988d878a1..e986cb92544a --date=short --no-merges --format='%ad %ae %s' 2019-10-08 cwallez@chromium.org Vulkan: Add proper error handling for all regular object creation. 2019-10-08 bryan.bernhart@intel.com Fix MSVC build error due to implicit descriptor heap offset cast. 2019-10-08 cwallez@chromium.org Guard macOS or iOS specific code in #if guards 2019-10-08 cwallez@chromium.org Make dawn.h closer to webgpu.h 2019-10-08 cwallez@chromium.org Remove stray push constant code. 2019-10-08 cwallez@chromium.org Allow ResultOrError to downcast from backend to frontend types 2019-10-08 cwallez@chromium.org Fix RenderPassDescriptor to be extensible. Created with: gclient setdep -r src/third_party/dawn@e986cb92544a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I5bedebf75c0f8f3a0a98cc63c1650d53e1e4ab18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847329Reviewed-by:
-
arthursonzogni authored
Following the discussion in: https://chromium-review.googlesource.com/c/chromium/src/+/1827280/16/content/public/browser/back_forward_cache.h#51 The previous API was very verbose to use. A second one was added in: https://chromium-review.googlesource.com/c/chromium/src/+/1827280 This CL removes update the first one to match the second. Design for the new content public API https://docs.google.com/document/d/1brlmAs1mMumbGwgwdE_M_VGR81YbArzeViI0P-Uak14 Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 TBR=dominikn@chromium.org (for the name change in AppBanner) Bug: 1001087 Change-Id: Idd39dff370bd45f7006318b2a1bbad9fec1baa24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835617 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#703727}
-
Sadrul Habib Chowdhury authored
Use RenderProcessHostObserver and RenderProcessHostCreationObserver APIs to replace the usage of NotificationService. BUG=357627 Change-Id: Idae690c3cc8bb7fffdca0558301b938df3ea1441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844274Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#703726}
-
Sidney San Martín authored
Previously, while an Incognito window was active, the History menu on Mac showed items from the original profile but always opened them in a non-Incognito window. Now, they open in the Incognito window. Bug: 973029 Change-Id: I50040b6c05ae3425335e577656daaec486dbc391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842431Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Auto-Submit: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#703725}
-
Roman Sorokin authored
Files found with: grep -L oobe_dialog_host `git grep --files-with-matches oobe-dialog | grep html` Bug: 1000606 Change-Id: I9d7f12253b1e9508a4a9f7096aa0ce2fc0e8fcc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844963Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#703724}
-
Francois Doray authored
With this CL, we store the render_process_id and render_frame_id (if any) associated with each IndexedDBConnection. This is a prerequisite to notify content::LockObserver when frames must not be frozen because they hold IndexedDB locks. Bug: 980533 Change-Id: I474cb3079abc87d62b4785e3858f7bfca540b37c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822824 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#703723}
-
Mike West authored
The conversation in https://github.com/whatwg/fetch/pull/948 makes me curious about how locked-in we are to the existing behavior around both `<embed>` and `<object>` when used for non-plugin content. They're basically strange `<iframe>`s, and it might be reasonable to push them closer towards _being_ `<iframe>` elements, or to push them further away, depending on how usage numbers look. Change-Id: I843ae37ae74033fdb3ea9b920ce3932004a067b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847291 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#703722}
-
chrome://omniboxTibor Goldschwendt authored
Moves resources used in chrome://omnibox out of browser_resources.grd into its own GRD file. Moves those resources into the Dev UI DFM to save binary size on Chrome Android. Bug: 927131 Change-Id: Iabef47e999a5504969595b1d403123157fc338fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845823Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#703721}
-
ckitagawa authored
Adds the ability to inject paint_preview::PaintPreviewTracker into blink::GraphicsContext to act similarly to printing::MetafileSkia. This class will track various metadata about the Paint Preview capture process. Design Doc: go/fdt-design (internal) Part of Landing: crrev/1786583 Bug: 1008885 Change-Id: Iba2819491bee7b284de62a1bf888aa9486c788cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829277 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#703720}
-
arthursonzogni authored
The back-forward cache is a content/ layer feature and it is tested on this layer. For instance, this file contains a lot of tests: content/browser/back_forward_cache_browsertest.cc We also want to have some basic tests at the chrome layer to catch trivial regressions. In particular, there is now an API available to chrome/ to disable the BackForwardCache on arbitrary page. See: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 Bug: 1010932 Change-Id: Ic0f0fc667f0d1de5157f95aea5f0558bc3d8557d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836413Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Saman Sami authored
This CL reverts https://crrev.com/c/1724558 which has increased the number of crashes in SchedulePageFlip. TBR=sammc@chromium.org Bug: 1006847 Change-Id: Ib1edf3d16f4a0f9141f37e5bd76f8ba969c7b9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841663 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#703718}
-
Marc Treib authored
This is a followup to crrev.com/c/1844969. GetBestMatches now returns the best matches in a vector, instead of in a map keyed by username. For now, PasswordFormManager still sorts the matches by username; that'll be addressed in another followup. TBRing simple call site update in website_login_fetcher_impl.cc TBR=arbesser@google.com Bug: 1011399 Change-Id: Iaefbe3a29603ea319adcbeddadd6b908d029ab74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845225Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#703717}
-
Tim van der Lippe authored
- Rename Workspace.js to WorkspaceImpl.js to not name clash with workspace.js in the Grit localization generation. Bug: 1006759 Change-Id: I56a496d866e4a453cd3ef84a24c29f8baa296876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847280 Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#703716}
-
Roman Sorokin authored
In OOBE handled by container In the session should be handled by DiscoverWindowManager Bug: 1001475 Change-Id: I3b63726bfcedcefca636ad51de993202693018f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844959Reviewed-by:
-
Friedrich Horschig authored
Currently, the sheet is asked to skip the peeking. Since this doesn't seem to work as intended (see https://crbug.com/1012231), we expand this sheet. Expanding immediately might have no effect — most likely a timing issue (see first screenshot in linked bug). Therefore, this CL allows the peek state and expands the sheet as soon as the peek state is shown. Bug: 1011856 Change-Id: I63cc403a9acc93f2e4f90c2549c32cf39757f042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847294Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#703714}
-
arthursonzogni authored
The goal is to fix a big class of URL spoof issues. They happen when a NavigationRequest is canceled, but the associated pending navigation entry remains. This causes the wrong URL to be displayed in the omnibox. To fix it, delete the matching pending NavigationEntry in the NavigationRequest's destructor. This is a bit more complex: 1) During an history navigation, several NavigationRequest can starts at the same time for iframes. All of them are associated with the same pending NavigationEntry. 2) A pending NavigationEntry can be used, discarded and reused. It can is used twice, but not associated with the same NavigationRequest(s) on every use. The class PendingEntryRef is used to track one NavigationRequest being associated with a pending NavigationEntry for a given history navigation. Bug: 999932 Change-Id: I14582fd1d954a6f831959db0bb5d96eb1f5d53b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815129 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#703713}
-
Elly Fong-Jones authored
This method is not safe to use in test contexts sometimes: it assumes that browser->window() is a BrowserView in Views builds, when in fact it is sometimes a TestBrowserWindow instead. Bug: None Change-Id: I1304eb1cc508d7a76c9a4cbc6954f69a7bcb1637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845955Reviewed-by:
-
Yann Dago authored
Policy conflicts used to be deep copied when merging policies, they are now simply moved using std::move instead of being deep copied. Bug: 1006422 Change-Id: I71239424fd7c2b31fc39c56e6f703bf68b6bd241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827545Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#703711}
-
Jan Wilken Dörrie authored
TBR=dvadym Bug: 957532 Change-Id: Id30d89d634c5645d29c5f110797afdf35bd62afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826788 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Charlie Hu authored
The renaming is because ParsedFeaturePolicy not necessarily represent a feature policy header. Previously the function is hardcoded to accept 2 declaration object as params. The new version accepts a vector of declarations, which makes it more generic. Change-Id: I9e6dfa828f0579776c941734c50c09c0b54194de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836373Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#703709}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0b1af463167a..2d30369ce6b1 git log 0b1af463167a..2d30369ce6b1 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 dberris@chromium.org Do not use Datastore as a cache 2019-10-08 dberris@chromium.org Fix results2 dependency on internal functions 2019-10-08 khokhlov@google.com [Telemetry] Move --verbose option to run_tests Created with: gclient setdep -r src/third_party/catapult@2d30369ce6b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:1006888,chromium:1012187,chromium:985712 Change-Id: I5f446ec608b9ffa499c9217bc2734fd38852592c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847316Reviewed-by:
-
