- 16 Dec, 2020 40 commits
-
-
Fabio Rocha authored
This CL changes GetAppProtocolHandlerInfos to be virtual and adds web_app_protocol_handler_manager. This mimics the design of other components and avoids a layer of indirection between web_applications and web_applications/components. Bug: 1019239 Change-Id: Ibf9abbe66a4bf1addb13955040889b740cf578bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577888 Commit-Queue: Fabio Rocha <fabio.rocha@microsoft.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#837767}
-
Michael Bai authored
Add the AutofillHintsService related aidls. Bug: 1151542 Change-Id: Ic1c2c21c78a6305706613a7eb8e0693c608a6054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592330 Commit-Queue: Michael Bai <michaelbai@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#837766}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/958f1e8ca769..91beff4e632a 2020-12-16 vigeni@google.com Internal change If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I3369745a53dba5177cfb951514fe9f20bf4ced00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595702Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837765}
-
Yu Su authored
1. Add a ShopWithGoogleLensChip metric to ukm.xml - go/ukm-collection-review-lens-chrome 2. Fix the merging logic for onClick callbacks. 3. Remove an unused field from LensQueryParams. 4. Fix direct intent enablement check in LensUtils. 5. Update the Classification UMA histogram to show EarlyTerminatedMs and SuccessOnQueryResultMs data. 6. Add a label to the ResultState UMA histogram to show a newly added enum value. 7. Update the ResultState UMA histogram labels for 'not shoppy image' cases. Change-Id: Id00133ceb9039fb479dfa646570fe38c1a0bece3 Bug: b/166648354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586221Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Reviewed-by:
Ben Goldberger <benwgold@google.com> Commit-Queue: Yu Su <yusuyoutube@google.com> Cr-Commit-Position: refs/heads/master@{#837764}
-
Matt Menke authored
The feature it's meant to help evaluate hasn't been enabled on pre-release channels yet, let alone on stable, so we'll need it around a fair bit longer than its original expiration date. We're planning on enabling the feature on pre-release channels in January, after the field trial freeze ends. Bug: 969893 Change-Id: Iee2d0238978050cfb2f108693a6f571758052e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596127Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#837763}
-
Koji Ishii authored
This patch moves selection functions that are not related with |NGPaintFragment| to |NGInlineCursor|, in preparation of removing |ng_paint_fragment.cc|. Bug: 1154531 Change-Id: I6c1849ab443b04ac6c7c608c800b568a69d3b7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595748 Auto-Submit: Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#837762}
-
Adam Langley authored
I plan on continuing the rollout of this in 2021, really. BUG=930812 Change-Id: I8e7f3128ec143439428fda340a58bec151204ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595920 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#837761}
-
Xianzhu Wang authored
It was very hot at least for crbug.com/1154746, taking about 30% of the frame CPU time. By inlining it and checking HasDisplayLockContext, the function disappeared from the CPU profiling result. Checking HasRareData() is not enough because most elements in test case have rare data due to Element::classList(). Bug: 1154746 Change-Id: I2cff6567d081e559190c052b4176dae53e1fd9ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594431 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#837760}
-
Shubham Aggarwal authored
Migrate uses of the relevant set_* functions on the sql::Database object to use the new DatabaseOptions constructor instead. This change should have no intended behavioral effect. Bug: 1126968 Change-Id: I03f0317eba59b68463a753fcd9c10f3dc4a19525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594116 Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#837759}
-
Mason Freed authored
This also removes all blink core owners from the email list. Change-Id: If38edec90c3ca9214e02ef78da714545dce8ca5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595520 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#837758}
-
Ken Buchanan authored
For the purposes of testing on WebID-supporting IdP services running on private infrastructure, this adds cookies to the requests to /.well-known/webid. Bug: 1159177 Change-Id: I507c461bc8d87d91f8d8d8d25565e1402b053999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593696Reviewed-by:
Sam Goto <goto@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#837757}
-
Xing Liu authored
When we are inside the reading list folder, the empty view string is changed to a reading list specific string. The search string doesn't change. Bug: 1148877 Change-Id: I521c988f5a2eda7744feb41d05cac0fe4cee9a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595918Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837756}
-
Morten Stenshorne authored
This used to fail a DCHECK when nested multicol was specified on a fieldset at an outer fragmentainer boundary, but apart from that, it worked fine, because BreakBeforeChildIfNeeded() correctly detects the situation (abortion) and inserts a break before. Just move the DCHECK a bit down. No code changes are required for legends, as they are monolithic. Just replace the TODO with a proper comment, and keep the DCHECK (the legend test also passes without the code changes in this CL). Bug: 829028 Change-Id: I62bf97f9bd04c185f86e93103f204cc6d872c438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595288Reviewed-by:
Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#837755}
-
anthonyvd authored
Because paths are case-insensitive on Windows, the DM server normalizes profile paths to lower-case when they are reported. This breaks the Clear Browsing Data remote command because it uses that path to find the profile into which it'll clear the data. This CL makes it so the path is compared in a case-insensitive manner on Windows in order to find the correct profile. Bug: 1159450 Change-Id: I07ebb206049ee848e1aae9e2059c3c69a4b367d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595728 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#837754}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f600415e9265..92c77100518e 2020-12-16 bsheedy@chromium.org Revert "Reland "Switch to vpython version of mock"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1156832 Tbr: skyostil@google.com Change-Id: Id7edbfdaf1b1bea09833490858e7bd3a00842328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595696Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837753}
-
Joe Downing authored
The RemoteCommand logic will not be supported server-side in the near future so I'm removing it from M89. I don't think we can remove it from the protos or we will break back compat so for now the host will just log an error message if it receives a remote command. Change-Id: Ieee15b0d225f645dff40b297f6fc3cce5f887f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596109Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#837752}
-
Michael Crouse authored
This change loads the model from the file provided by the Opt Guide and returns it via callback to any requestor of the model. A future change will provide the model to the content translate driver and the translate agent via mojo. Bug: 1151406 Change-Id: If09871f3ad04a674d964a467586cfb0f24fd4708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593589Reviewed-by:
Trevor Perrier <perrier@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#837751}
-
Nicholas Hollingum authored
Figured this would be a useful API extension while refactoring. Bug: b/175360169 Change-Id: If6490aefacdb5110d3fe5dc423d311e6f7618c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584434 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#837750}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Id349b468a1136388693ddf52ec5b78a7acb89a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596128Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#837749}
-
Matt Menke authored
In particular, add DCHECKs when an empty NIK is passed when sending a report, or when verifying a signed exchange's cert (which can send a report of another type). The DCHECK is only enabled when require_network_isolation_key is set. Actually respecting the received NIK is disabled by default, but all consumers outside the network service should now always be passing a non-empty NIK when using these APIs. Bug: 993805, 1087091 Change-Id: I5f4eef6f9f7b3b4faaaedca62e110e695ccabf2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595630Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#837748}
-
Salvador Guerrero authored
This CL disabled the following tests on Android. * SingleClientTypedUrlsSyncTest.DeleteNonTyped * SingleClientTypedUrlsSyncTest.TwoVisits * SingleClientTypedUrlsSyncTest.DeleteTyped * SingleClientTypedUrlsSyncTest.Sanity TBR=mastiz@chromium.org Bug: 1159479 Change-Id: I49a93df85f6e48bbd661e77e41c467787c4e8b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596119Reviewed-by:
Salvador Guerrero <salg@google.com> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#837747}
-
Yue Zhang authored
This CL * Adds a CartHandler mojo interface that will be used to provide info needed to render chrome cart module. * Adds the basic HTML and JS code to render the skeleton of the cart module. More details will be added in later patches. * Adds a dummy implementation of CartHandler that will later be hooked with cart backend infra to get real data. Screenshot with fake data: https://drive.google.com/file/d/1WtYz9aEj0PKhiqn-eZupREv5WfQ0MA-7/view?usp=sharing&resourcekey=0-g9LEGFm9bLfl5HAtro0oUw Bug: 1157892 Change-Id: Ic8dc20f4be347c97ff99d44717408ce5f182b765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587099Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#837746}
-
David Reveman authored
Vulkan memory usage has spikes as a result of caches not taking the full lifetime of GPU resources into account. This introduces two limits for Vulkan memory to mitigate the problem: --vulkan-sync-cpu-memory-limit-mb - Triggers synchronization with the CPU in order to allow unused resources to be freed immediately. --vulkan-heap-memory-limit-mb - Makes Vulkan allocations fail. These two limits provide an effective way to reduce the harm of the problem. The soft limit affects GPU work submission and trade performance for reducing spikes as early as possible without causing a severe impact on the user experience. The hard limit is immediate and prevent spikes from causing greater harm to the rest of the system. No change in behavior unless new command line flags are used. Bug: 1158000 Change-Id: I8e990d71aac780426b0398510c147af295c54f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587431Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#837745}
-
Emily Stark authored
Change-Id: Iafa21bda8d69d50dd5f78667ab6d21c616748fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595514Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#837744}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/772ccd850137..0e7eec75ab9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC davidbienvenu@google.com,smcgruer@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: davidbienvenu@google.com,smcgruer@google.com Change-Id: Ibb9eb2ef06bdc50daf382bab8c05480777284574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595995Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837743}
-
Cheick Cisse authored
This change only handles links but we will add support for images and images link later. Bug: 1140387 Change-Id: I83289a9deefbe346343bc3649ffa2c015bd20ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584604 Commit-Queue: Cheick Cisse <cheickcisse@google.com> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#837742}
-
David Black authored
Since holding space only supports a specific list of allowed volumes, its welcome banner should only be shown on those volumes which the feature supports. Note that the holding space banner is also explicitly disallowed from showing on Drive per UX request. Bug: 1154347 Change-Id: I89e0c14ec9a6d1ec01700bd084e769d349243330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594314 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#837741}
-
David Bokan authored
https://crrev.com/ff530f772caac made explicit that this callback is a RepeatedCallback. We forgot to change the associated Bind call. Bug: 1152268 Change-Id: I1b9320ed117a2a2426e8a80ac02ea7ba41901fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595592 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#837740}
-
Sushanth Rajasankar authored
There are crashes in GetLastPresentedFrameMetadata(), due to a null |current_frame_|. This is probably happening when a pending call to VideoFrameCallbackRequesterImpl::OnExecution() runs after HTMLVideoElement creates a new WebMediaPlayer, and the first frame is not not yet available. This CL fixes the issue by using a WeakPtrFactory to invalidate pending OnExecution() calls, when HTMLMediaElement gets a new WebMediaPlayer. VideoFrameCallbackRequesterImpl should automatically call RequestVideoFrameCallback() on this new player when it is created, rescheduling the OnExecution() calls when the first frame becomes available. Bug: 1158160 Change-Id: I4c4228aa9d9769f728d639a94f067ccf84eb1151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585917Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Sushanth Rajasankar <Sushraja@microsoft.com> Cr-Commit-Position: refs/heads/master@{#837739}
-
Richard Coles authored
Change-Id: I1f42684060ee5416c8e68ad639e37f69b943c7e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590868 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#837738}
-
Xiaohui Chen authored
Clean up launched feature flag. Bug: None Change-Id: I205696223fd6db4136220f145c5237273df07037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590709Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#837737}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0c031adc5339..0da7da798b33 2020-12-16 treehugger-gerrit@google.com Merge "trace_to_text: add an option to convert perf profiles to pprof" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7085cd5a81165187edfa1e24fa4197fb8401c429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595693Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837736}
-
Yi Gu authored
Bug: 1152282 Change-Id: I9f0e5c0082634d3389cd3af49cda522e08a0e8f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590058Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837735}
-
Gavin Williams authored
Histogram records the number of pages scanned in a successful scan. Bug: 1059779 Change-Id: I19b326432cfc4f8ff95b3f23354a3cd39a72b592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588648Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#837734}
-
Robert Ogden authored
When the network process encounters an error when setting up the tunnel connection, it sends that information to the proxy configurator. That will determine a reasonable Retry-After value, either from headers, or a random value between 1m-5m. Also adds Histograms to track the responses from the proxy. A Retry-After header is accepted on any non-200 response code since the proxy is a Google owned service with its own protocol. Bug: 1136114 Change-Id: If44786869268f22db7b836ebadf29b624c6cfd60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587713 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#837733}
-
Jamie Madill authored
Re-land includes missing headers directory. This replaces several grouped dependencies with one meta-repo. The meta-repo will allow us to group multiple inter-dependent deps rolls into one single roll. This solves the problem of separate rollers breaking because of the inter-dependencies. It also allows ANGLE and Chrome to share common bits like the README and .gitignore files. Bug: angleproject:5390 Bug: 1153258 Change-Id: I22cefb1bfeeec656c2dbb173701a87a6db9cb8ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593888 Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#837732}
-
Leonard Grey authored
Also removes ref counting since the dialog is never reused (plumbing for this was added in r174683 but both current uses are one shots). Bug: 1152274 Change-Id: I8ca68395f5fa0596d81af8abe92b536eb1129b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593929 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#837731}
-
Sigurdur Asgeirsson authored
Add missing sequence checks where the compiler complained. Change-Id: I0b8a61b41720709d01d28796c57f71e4635dbcd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590325 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#837730}
-
Regan Hsu authored
PhoneHub features will be set to FeatureState::kNotSupportedByChromebook if the current logged in user is secondary. Fixed: 1156309 Change-Id: Iea97c13c3fa2fe9edc103b00df8aa21b9447cef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590492 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#837729}
-
Robert Sesek authored
Bug: 915934 Change-Id: I0c67c1d1ddc446581783c3322be9da97652eb84f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595594Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#837728}
-