GitLab

loadUrl(String) has an early return if url == null, this is just adding the same early return to loadUrl(String, Map<String,String>). This should prevent sending null values to AwContents::SetExtraHeadersForUrl and then to ConvertJavaStringToUTF8.

Bug: 864708
Change-Id: If169dbc89dfdf745e7fa27921fa7624abed40a84
Reviewed-on: https://chromium-review.googlesource.com/c/1283449Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600338}

Bug: 715640, 846235
Change-Id: I49ed8a5a3bc5962cd52e24ab734b00fdfdd7b32d
Reviewed-on: https://chromium-review.googlesource.com/c/1286238
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600337}

This fixes ServiceWorkerRequestHandlerTest.InitializeForNavigation_ExternalFileScheme
when ServiceWorkerServicification or NetworkService is enabled.

It's the same fix as the non-servicification path, done in r528590.

Bug: 895187,896157
Change-Id: I8949c0bf002b329a01b1755913d16634dd80e7cd
Reviewed-on: https://chromium-review.googlesource.com/c/1286021Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600336}

This change makes use of the updated semantics of PasswordUiEntry.id
to simplify the update list behavior of passwords_section.js.

Bug: 892260
Change-Id: Icfde6048049edd6e418580660b34928db798764d
Reviewed-on: https://chromium-review.googlesource.com/c/1283013
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600335}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/extensions/api/gcm.

This CL was uploaded by git cl split.

R=jianli@chromium.org

Bug: 809610
Change-Id: I2467157d104d74299ab12f1ced3bbe0245a48b68
Reviewed-on: https://chromium-review.googlesource.com/c/1258905Reviewed-by: Jian Li <jianli@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600334}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/safe_browsing.

This CL was uploaded by git cl split.

R=nparker@chromium.org

Bug: 809610
Change-Id: I95c33ffc6a6d7699e0c1813ea7f760b7a9654d83
Reviewed-on: https://chromium-review.googlesource.com/c/1259043
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600333}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/chrome_content_browser_client_unittest.cc.

This CL was uploaded by git cl split.

R=<anyone>

Bug: 809610
Change-Id: I845dacbc5ee28e89ab69bf2bebaf5700f931b6fb
Reviewed-on: https://chromium-review.googlesource.com/c/1258170Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600332}

Get rid of CrosSettings::Get()->Set...() usage in tests.
This CL changes all such calls to ScopedCrosSettingsTestHelper::Set.
This call does the same thing as before, but it means there is only
one call to CrosSettings->Set that will need to be changed in order
to separate the read and write APIs.

This is part of an ancient bug to make CrosSettings read-only -
the equivalent API for writing is OwnerSettingsService.
It will also be useful for moving CrosSettings out of chrome/browser
without having to move all of OwnerSettingsService.

Another minor clean up:
There are two different ways to have a test setup CrosSettings -
one way is to use ScopedCrosSettingsTestHelper, which sets up
InstallAttributes, DeviceSettings, and CrosSettings.
The other way to set them all up using individual helper classes,
including ScopedDeviceSettingsTestHelper. What is not obvious, is that
the first way sets up a real session manager, but the second way
sets up a fake session manager. This CL also changes
existing_user_controller_auto_login_unittest.cc to use the first way
for consistency, and adds the call "SetFakeSessionManager()" which
is more explicit, instead of having different helper classes set
things up in subtly different ways.


BUG=433840

Change-Id: I0c84af93d446ce8f82d1aabbf070195abea24dd4
Reviewed-on: https://chromium-review.googlesource.com/c/1256966
Commit-Queue: A Olsen <olsen@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600331}

Using wpt-import in Chromium c4d25f5b.
With Chromium commits locally applied on WPT:
612705b6 "Only update intrinsic_content_logical_height_ if we don't have an override height"
a7da8836 "Convert 'Sec-Metadata' dictionary values to identifiers."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26351

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: Iffc5c7ee944e2e1dbbbd35af91033dfd9816c564
Reviewed-on: https://chromium-review.googlesource.com/c/1286430
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600330}

It's currently using the SigninManager API to retrieve the currently
authenticated account's email. Replaced by the IdentityManager
equivalent API so it could eventually use the identity service.

Bug: 890777
Change-Id: Ib2b8b46f529424dd413d843fb89deb5a493a599c
Reviewed-on: https://chromium-review.googlesource.com/c/1280426Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#600329}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//extensions/browser/api/idle.

This CL was uploaded by git cl split.

R=dcheng@chromium.org

Bug: 809610
Change-Id: I6799d0c1c8e61ccfa4fb5c07155deb4258a22e85
Reviewed-on: https://chromium-review.googlesource.com/c/1259045Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600328}

This reverts commit b9f37385.

Reason for revert: Suspected of breaking performance_test_suite on Win7 Tests (dbg)

Bug: 896178

Original change's description:
> [Perf] Delete dummy_benchmark.histogram_benchmark_1
> 
> No longer needed.
> 
> Change-Id: I48e7073aba7861d7265337996c3ce6146d972f50
> Reviewed-on: https://chromium-review.googlesource.com/c/1282220
> Commit-Queue: Ethan Kuefner <eakuefner@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#600169}

TBR=eakuefner@chromium.org,nednguyen@google.com

Change-Id: I0358e9aaf36257b7a6f43d900361d75d04b95c21
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1286457Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600327}

Bug: 174301
Change-Id: Ifc0618729a545d6b45ccfc9c339b656e065efa22
Reviewed-on: https://chromium-review.googlesource.com/c/1282951
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600326}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/ash/multi_user.

This CL was uploaded by git cl split.

R=skuhne@chromium.org

Bug: 809610
Change-Id: Iee592c3978d52e0f213f2cb752cd4317bcd65b21
Reviewed-on: https://chromium-review.googlesource.com/c/1258764
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600325}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/extensions/api/networking_private/networking_private_apitest.cc.

This CL was uploaded by git cl split.

R=tbarzic@chromium.org

Bug: 809610
Change-Id: Id109a7d2bf008951e3a1ad9bf6370a281523c515
Reviewed-on: https://chromium-review.googlesource.com/c/1258354Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600324}

Analytics is disabled in these CrOS apps, and isn't going to be re-enabled.

Generally, "metrics.js" is analytics. Restrict dependencies on it to the
files app only. "metrics_base.js" is UMA and is fine to depend on, but it
needs an attached file that provides a UMA prefix. Add missing methods,
which were incorrectly using the files app UMA config.

Remove metrics.js AND metrics_base from the shared,
background_common_scripts.js. audio_player doesn't use metrics_base (UMA)
and doesn't declare the API permission in its manifest.

Audit things still in background_common_scripts.js to ensure they don't
use analytics/metrics. There's just one: volumeManagerUtil.reportMountError.
Delete it. Note the file_manager/foreground/js/directory_model.js still uses
getFileSystemProviderName from metrics_events.js.

Other notes:
 - Remove the single analytics call in image_loader
 - Remove metricsPrivate from the image_loader extension manifest (only the
image_loader_client depends on this, which is loaded into other component
apps - not the image loader)
 - Remove unused dependencies from manifest files.
 - Bump manifest versions to update cached extension permissions.

Bug: 847729
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ifb5d306b38ba8bc0759ac56080855abe78f09b88
Reviewed-on: https://chromium-review.googlesource.com/c/1280064
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600323}

https://skia.googlesource.com/skia.git/+log/63bc5891e49e..0a8faf3f557d


git log 63bc5891e49e..0a8faf3f557d --date=short --no-merges --format='%ad %ae %s'
2018-10-17 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@0a8faf3f557d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=egdaniel@chromium.org

Change-Id: I4aee0232ba23f6e9430b5056e5d7d395085c79e9
Reviewed-on: https://chromium-review.googlesource.com/c/1286070Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600322}

Off-the-main-thread WebSocket was enabled by default in M68, so this flag is no
longer necessary.

Bug: 825740
Change-Id: I87615e7c7687f92252914221b077ea5cadd7ddec
Reviewed-on: https://chromium-review.googlesource.com/c/1286095Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600321}

Bug: 843903
Change-Id: Ia1b60e3a4ee2aa239e3fad7bea198c38484b2840
Reviewed-on: https://chromium-review.googlesource.com/c/1282953Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600320}

In DriveFS mode most sections are irrelevant or not implemented. Omit
them to make debug page more concise.

BUG=chromium:883637

Change-Id: Ic4e3813d033bcbc778cbb5604a6a4abaa0f7e9b3
Reviewed-on: https://chromium-review.googlesource.com/c/1286012Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600319}

This patch fixes MarkLineBoxesDirtyFor to stop at inline block
when it looks for the inline ancestor chain.

When looking for line boxes to mark dirty, it should not cross
an inline formatting context boundary.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic89a3ea8ea31cb4d0d6ddd3ef224872c0b8b140e
Reviewed-on: https://chromium-review.googlesource.com/c/1286096Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600318}

Bug: 806868
Change-Id: Iab9ba207f35618201c6137699ccaebe9afc95127
Reviewed-on: https://chromium-review.googlesource.com/c/1283023
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600317}

This reverts commit 5628afcc.

Reason for revert: suspected of breaking tons of tests across many builders
E.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29615

Bug: 896163

Original change's description:
> Enable the DriveFS experiment in fieldtrial_testing_config.json.
> 
> Bug: 819822, 891197
> Change-Id: Ie8daa2f97af0c0eadd4661ea4b28bbaa6a326839
> Reviewed-on: https://chromium-review.googlesource.com/c/1278431
> Commit-Queue: Sam McNally <sammc@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Reviewed-by: Sergei Datsenko <dats@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600222}

TBR=sammc@chromium.org,holte@chromium.org,dats@chromium.org

Change-Id: I8d45f9db89a7da5d48ecc2275ab08aefa4728a5b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 819822, 891197
Reviewed-on: https://chromium-review.googlesource.com/c/1286130Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600316}

This reverts commit 9ecd2358.

Reason for revert: Failing DriveFileSystemExtensionApiTest.FileWatch (https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8932445106075351296/+/steps/browser_tests/0/logs/DriveFileSystemExtensionApiTest.FileWatch/0)

Original change's description:
> Turn DriveFS directory deletes into moves into a trash directory.
> 
> Change NativeFileUtil to allow moving a directory to an existing
> directory.
> 
> Bug: 829696
> Change-Id: I6e233fa2a9ad161d1457d06fc6b6eda3ab3955d7
> Reviewed-on: https://chromium-review.googlesource.com/c/1278624
> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> Reviewed-by: Sergei Datsenko <dats@chromium.org>
> Commit-Queue: Sam McNally <sammc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600283}

TBR=nhiroki@chromium.org,sammc@chromium.org,dats@chromium.org

Change-Id: Id42f9ce8f14163797f05e032e6b8a28ecf4f551c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 829696
Reviewed-on: https://chromium-review.googlesource.com/c/1286100Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600315}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/106ca1145918..7740403f4852


Created with:
  gclient setdep -r src-internal@7740403f4852

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I22b5230fbd8afb5cf40f216673afefd2938767cd
Reviewed-on: https://chromium-review.googlesource.com/c/1286469Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600314}

Before S13nServiceWorker, SWVersion::RemoveControllee() immendiately and
synchronously triggered activation. However, after S13nServiceWorker, activation
happens only after the renderer reports the worker's idle and it successfully
finishes. Currently some unit tests assume that RemoveControllee() triggers
activation, so this CL makes sure all tasks for activation run by calling
RequestTermination() and task runner's methods like RunUntilIdle() and
RunPendingTasks().

Bug: 895187
Change-Id: I9cc73d97299a781a366e7f22e2ded90e17a8d367
Reviewed-on: https://chromium-review.googlesource.com/c/1286234
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600313}

Appliy ES6 features to the DirectoryModel.onVolumeInfoListUpdated_ and
FileManager.setupCurrentDirectory_.

ES6 styles:
- Change var to const or let.
- Change anonymous functions+bind(this) to arrow functions.

Remove a TODO that linked to a closed bug.

Move comment to be before queue.run() to match the style of the
previous lines.

Apply the formatting from git cl format, which is slightly uglier, but
at least automatic. :-)

Test: No change in behaviour.
Change-Id: I5564263d44f8639d97fc86d7add5a59e8938be6d
Reviewed-on: https://chromium-review.googlesource.com/c/1286239Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600312}

Entities fed to the worker by the USS migrator should not contribute to
a UMA histogram that is about interactions with the server. Otherwise,
it is difficult to evaluate the impact of a USS rollout and do A/B
testing.

Implementation-wise, the code avoids abstractions and injects a boolean
to distinguish the USS migrator as a special caller, which seems to be
the simplest way and the easiest one to be cleaned up after the code
for the USS migrator itself is deleted.

Bug: 895899
Change-Id: Ie3f4aed51da37780945f1e75ffd2be05063526fb
Reviewed-on: https://chromium-review.googlesource.com/c/1283041
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600311}

Describes how to dump the compiled code with symbols to reconstruct
the full stack.

Change-Id: I9c9b80e3316bb55404bbcc1fca1fe3ea424de887
Reviewed-on: https://chromium-review.googlesource.com/c/1278643
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600310}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/02bb0496ed00..106ca1145918


Created with:
  gclient setdep -r src-internal@106ca1145918

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: If674383273aa74a40eccc47bb429eae7fc0a81ae
Reviewed-on: https://chromium-review.googlesource.com/c/1286270Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600309}

Bug: 893430
Change-Id: I4cb8149eaec9c9ab22700905dae804ac893fdb6c
Reviewed-on: https://chromium-review.googlesource.com/c/1282517Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600308}

Avoid sending out updates to NetworkCertLoader's Observers when the
browser is being shut down.

Bug: 894867
Test: chromeos_unittests --gtest_filter=*NetworkCertLoader*
Change-Id: Idff4a45f575c594c1c68ca1139ed0ab37f985acc
Reviewed-on: https://chromium-review.googlesource.com/c/1280424
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600307}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I2b34e72f0e038005ec7bef2707be19c5e1a33981
Reviewed-on: https://chromium-review.googlesource.com/c/1286370Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600306}

Add prefix [unhandled-error] for logs via console.error() to make them
easier to identify among other console.log() messages.

Add error stack for console.error() and console.assert() to make easier
to identify which code actually issued the call.

Bug: 893430
Change-Id: I3ab98f6d40c76ee1fb8f5eebce2ad4911ac4e7e0
Reviewed-on: https://chromium-review.googlesource.com/c/1282686
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600305}

Spec changes:

* https://github.com/mikewest/sec-metadata/commit/4e80053af5a7494bc0f34afd30f990e5a79ae2ee
* https://github.com/mikewest/sec-metadata/commit/279d75c9dc1117fb75581970e9fd1335e329b63c

Bug: 861678
Change-Id: I7f272ba2e923a0d219e7a8ba62072860ba3d8319
Reviewed-on: https://chromium-review.googlesource.com/c/1282603Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600304}

This CL applies //tools/clang/base_bind_rewriters to //content to
rewrite base::Bind to base::BindOnce, where we can rewrite mechanically.

Change-Id: I1e31cce5f508bd407149a6affc2f736d5fc892e0
Reviewed-on: https://chromium-review.googlesource.com/c/1282692Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600303}

It needs to SetNetworkFactoryForTesting when S13nSW is on, so it can
intercept prefetch requests which go to a special factory since
r598636. This fixes the following browser tests when S13nSW is enabled:
RequestDataBrowserTest.LinkRelPrefetchReferrerPolicy
RequestDataBrowserTest.BasicCrossSite
RequestDataBrowserTest.LinkRelPrefetch
RequestDataBrowserTest.Basic

BUG=861644

Change-Id: Id4982b70d6633ecf2bd44c4afb8f5649cf801f21
Reviewed-on: https://chromium-review.googlesource.com/c/1285789
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600302}

No-presubmit: true
Bug: 895703
Change-Id: Ia8322806f4c2b584536065f35429466ab0a22ba4
Reviewed-on: https://chromium-review.googlesource.com/c/1285254
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600301}

No-presubmit: true
Bug: 895703
Change-Id: If777a1a20b66411d99a5655b72c9a1b957670201
Reviewed-on: https://chromium-review.googlesource.com/c/1285909
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600300}

This code has been unused since https://crrev.com/402189.

BUG=622314
R=pmonette@chromium.org

Change-Id: I375cfc911f0c05753476a58f3f5c9dff72b5f181
Reviewed-on: https://chromium-review.googlesource.com/c/1283070Reviewed-by: Patrick Monette <pmonette@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600299}