- 23 Sep, 2014 19 commits
-
-
tbarzic authored
The method will return the user email and whether the user's logged in, i.e. whether the app is running on signin screen. Adds an event that's triggered when the user focused on login screen changes. While here, add logic to unload the app and reset signin profile EasyUnlockService when user logs in. Create the signin service only if enable-easy-signin switch is set. BUG=401634 Review URL: https://codereview.chromium.org/576343002 Cr-Commit-Position: refs/heads/master@{#296120}
-
weiliangc authored
Revert of Class for allocating a chunk of memory for RenderPass (patchset #31 id:660001 of https://codereview.chromium.org/400463002/) Reason for revert: Broke cc_unittest for Linux ASan bot Original issue's description: > Class for allocating a chunk of memory for RenderPass > > For DrawQuads and SharedQuadState, RenderPass used allocate them one by > one whenever needed. This new class helps RenderPass manages allocation > and iteration of those two types. This container allocates a chunk of > memory at one time and hands out raw pointers. It also provides iterator > and reverse iterators for going through its contents. > > Unittest for ListContainer makes sure the raw pointers it hands out are > valid and iterator has same behavior as vector iterators. > > Follows 398533002, and 404563005. > > BUG=344962 > > Committed: https://crrev.com/6ae8c50c839a8c0d8fb399578256c754ed3ce39a > Cr-Commit-Position: refs/heads/master@{#296100} TBR=danakj@chromium.org,jamesr@chromium.org NOTREECHECKS=true NOTRY=true BUG=344962 Review URL: https://codereview.chromium.org/595733002 Cr-Commit-Position: refs/heads/master@{#296119}
-
skuhne authored
A visibile to invisible state change will also release memory and should therefore wait as an unload does A visibility change will also release memory and should therefore also stall an immediate unload. Updated comments and cleaned up the ResourceManager function. BUG=414918 TEST=unittest Review URL: https://codereview.chromium.org/588823002 Cr-Commit-Position: refs/heads/master@{#296118}
-
Paweł Hajdan, Jr authored
- add -o pipefail - do not hide stderr BUG=none R=thestig@chromium.org Review URL: https://codereview.chromium.org/582293002 Cr-Commit-Position: refs/heads/master@{#296117}
-
mattm authored
BUG=176648 Review URL: https://codereview.chromium.org/586793003 Cr-Commit-Position: refs/heads/master@{#296116}
-
erikchen authored
The test NSMenuItemAdditionsTest.TestMOnDifferentLayouts was failing because a new French keyboard layout was added that the test logic failed to account for. BUG=390276 Review URL: https://codereview.chromium.org/585913004 Cr-Commit-Position: refs/heads/master@{#296115}
-
erikchen authored
Once the Address Book prompt has been shown on 5 times (repeatedly being shown on the same form doesn't count), don't show it ever again. This CL also re-enables the access Address Book prompt, which was disabled due to bugs in the implementation. BUG=414359 Review URL: https://codereview.chromium.org/578383002 Cr-Commit-Position: refs/heads/master@{#296114}
-
vitalyp authored
BUG=393873 R=dbeam@chromium.org Review URL: https://codereview.chromium.org/585153002 Cr-Commit-Position: refs/heads/master@{#296113}
-
jrummell authored
Due to GetResolveParameterType(), the template was specialized for all the cases used. Adding CdmPromiseTraits so that the specializations are not needed, and the type set in the constructor appropriately. BUG=358271 TEST=existing EME tests still pass Review URL: https://codereview.chromium.org/567123002 Cr-Commit-Position: refs/heads/master@{#296112}
-
jbauman authored
Avoid queueing up too many swaps on the GPU. BUG= Review URL: https://codereview.chromium.org/578383004 Cr-Commit-Position: refs/heads/master@{#296111}
-
thestig authored
Multiple tests cases in these tests fail. Mass disabling rather than playing whack-a-mole. BUG=416620,416621 TBR=davemoore@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/591293002 Cr-Commit-Position: refs/heads/master@{#296110}
-
slamm authored
BUG=414501 Review URL: https://codereview.chromium.org/572793002 Cr-Commit-Position: refs/heads/master@{#296109}
-
sky authored
On the windows side (and likely chromeos for some devices) we can end up in a situation where the pixel bounds is not an even multiple of the scale factor. This means when TiledLayer calculates the scale it ends up off. BUG=416655 TEST=added test coverage R=danakj@chromium.org Review URL: https://codereview.chromium.org/567743003 Cr-Commit-Position: refs/heads/master@{#296108}
-
wuhu authored
BUG=412126 Committed: https://crrev.com/01c68e8765254d9971296b291ff718b4f6af3004 Cr-Commit-Position: refs/heads/master@{#295591} Review URL: https://codereview.chromium.org/565803002 Cr-Commit-Position: refs/heads/master@{#296107}
-
vitalybuka authored
I don't know how to fix this issue yet. UMA is not worth of crashes. BUG=406227 Review URL: https://codereview.chromium.org/590373002 Cr-Commit-Position: refs/heads/master@{#296106}
-
ericwilligers authored
These have recently been retired from Valgrind, and are also being retired from Dr Memory: bug_108147 bug_108620 bug_109496 bug_116475 bug_122245a bug_122245b BUG=108147,108620,109496,116475,122245 R=bruening@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/587133002 Cr-Commit-Position: refs/heads/master@{#296105}
-
raymes authored
This fixes a bug introduced in https://codereview.chromium.org/588643002 which caused a crash if NULL response_headers were passed to StreamhandleImpl. Review URL: https://codereview.chromium.org/587173002 Cr-Commit-Position: refs/heads/master@{#296104}
-
tedchoc authored
Only used in tests currently, so we need to prevent it from being removed. BUG= NOTRY=true Review URL: https://codereview.chromium.org/591283002 Cr-Commit-Position: refs/heads/master@{#296103}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/cc0d970..fdec548 TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org Review URL: https://codereview.chromium.org/595573003 Cr-Commit-Position: refs/heads/master@{#296102}
-
- 22 Sep, 2014 21 commits
-
-
jfroy authored
required by media/cast. The full media target cannot be easily built for some platform (namely iOS aarch64), typically because of assembly code. The new target has no such issues. The change also includes modifications to the media/cast build file to simplify the dependency list and enable builds using the media_cast component via a build variable. BUG=415335 Review URL: https://codereview.chromium.org/581803003 Cr-Commit-Position: refs/heads/master@{#296101}
-
weiliangc authored
For DrawQuads and SharedQuadState, RenderPass used allocate them one by one whenever needed. This new class helps RenderPass manages allocation and iteration of those two types. This container allocates a chunk of memory at one time and hands out raw pointers. It also provides iterator and reverse iterators for going through its contents. Unittest for ListContainer makes sure the raw pointers it hands out are valid and iterator has same behavior as vector iterators. Follows 398533002, and 404563005. BUG=344962 Review URL: https://codereview.chromium.org/400463002 Cr-Commit-Position: refs/heads/master@{#296100}
-
xhwang authored
This is a follow up of 37e3ddb2, which introduced the InitSegmentReceived() call. Since StartPipelineWithEncryptedMedia() also uses MockMediaSource, we should also expect InitSegmentReceived() to be called. Otherwise, we'll receive warnings about uninterested mock calls of InitSegmentReceived(). BUG=249428 TEST=This fixes expectations in existing tests. Review URL: https://codereview.chromium.org/588573003 Cr-Commit-Position: refs/heads/master@{#296099}
-
johannkoenig authored
The compatibility layer has been removed upstream: https://gerrit.chromium.org/gerrit/gitweb?p=webm%2Flibvpx.git;a=commit;h=9cdaa3d72eade9ad162ef8f78a93bd8f85c6de10 BUG=webrtc:3839 Review URL: https://codereview.chromium.org/590363002 Cr-Commit-Position: refs/heads/master@{#296098}
-
jln authored
Remove markus@ and add mdempsky@ as a Zygote owner. Review URL: https://codereview.chromium.org/589293002 Cr-Commit-Position: refs/heads/master@{#296097}
-
dhnishi authored
Review URL: https://codereview.chromium.org/586563002 Cr-Commit-Position: refs/heads/master@{#296096}
-
vitalybuka authored
Revert of Temporary allocation of 20Mb before and after call to ServiceProcessControl::GetHistograms. (patchset #4 id:60001 of https://codereview.chromium.org/510563004/) Reason for revert: We have gathered enough evidence. Original issue's description: > Temporary allocation of 20Mb before and after call to ServiceProcessControl::GetHistograms. > > BUG=406227 > > Committed: https://crrev.com/f89ce26c97949d224441ed45644a7d41b89bcf69 > Cr-Commit-Position: refs/heads/master@{#292325} TBR=tapted@chromium.org NOTREECHECKS=true NOTRY=true BUG=406227 Review URL: https://codereview.chromium.org/595673003 Cr-Commit-Position: refs/heads/master@{#296095}
-
vitalybuka authored
BUG=415753 Review URL: https://codereview.chromium.org/581813004 Cr-Commit-Position: refs/heads/master@{#296094}
-
thestig authored
BUG=413775 TBR=jkarlin@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/592233003 Cr-Commit-Position: refs/heads/master@{#296093}
-
jamiewalch authored
BUG=416540 Review URL: https://codereview.chromium.org/592163002 Cr-Commit-Position: refs/heads/master@{#296092}
-
jiayl authored
BUG=414919 Review URL: https://codereview.chromium.org/590353002 Cr-Commit-Position: refs/heads/master@{#296091}
-
Hans Wennborg authored
Clang should be built with the same toolchain used to build Chromium, which is typically the one in depot_tools/win_toolchain. BUG=82385 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/587383003 Cr-Commit-Position: refs/heads/master@{#296090}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/c064824..76ce81e CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=borenet@google.com Review URL: https://codereview.chromium.org/593823003 Cr-Commit-Position: refs/heads/master@{#296089}
-
ckocagil authored
BUG=244679 R=msw Review URL: https://codereview.chromium.org/594683002 Cr-Commit-Position: refs/heads/master@{#296088}
-
ben authored
Replace most uses of ViewManagerInitService with client lib ViewManager::Embed() to offer the same API exposed via View::Embed() R=sky@chromium.org BUG=none Review URL: https://codereview.chromium.org/591633002 Cr-Commit-Position: refs/heads/master@{#296087}
-
bshe authored
Touch view uses virtual_keyboard_window_controller to enable/disable virtual keyboard. However, virtual_keyboard_window_controller is specific for a Touch Usability mode which nobody uses and is removed. This CL adds a VirtualKeyboardObserver to replace virtual_keyboard_window_controller. BUG=416495 Review URL: https://codereview.chromium.org/592753004 Cr-Commit-Position: refs/heads/master@{#296086}
-
adamk authored
Topeka is updated to Polymer 0.4.1, while Pica is from tip-of-tree. TBR=ykyyip@chromium.org,tonyg@chromium.org Review URL: https://codereview.chromium.org/592843004 Cr-Commit-Position: refs/heads/master@{#296085}
-
jamesr authored
This fixes the flaky compilation error seen here: http://build.chromium.org/p/chromium.lkgr/builders/Win%20x64/builds/2616/steps/compile/logs/stdio FAILED: ninja -t msvc -e environment.x64 -- "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\media\mojo\services\media_mojo_lib.mojo_renderer_impl.obj.rsp /c ..\..\media\mojo\services\mojo_renderer_impl.cc /Foobj\media\mojo\services\media_mojo_lib.mojo_renderer_impl.obj /Fdobj\media\media_mojo_lib.cc.pdb c:\b\build\slave\win_x64\build\src\mojo\public\cpp\application\connect.h(8) : fatalerror C1083: Cannot open include file: 'mojo/public/interfaces/application/service_provider.mojom.h': No such file or directory ninja: build stopped: subcommand failed. and makes (ToT) gn check media/mojo/services:* pass R=scherkus@chromium.org Review URL: https://codereview.chromium.org/592863002 Cr-Commit-Position: refs/heads/master@{#296084}
-
fgorski authored
Updating relevant tests. BUG=413801 R=jianli@chromium.org,zea@chromium.org,scheib@chromium.org Review URL: https://codereview.chromium.org/589663004 Cr-Commit-Position: refs/heads/master@{#296083}
-
chirantan authored
The dark_resume_always workaround is necessary for testing wake-on-packets functionality because the mechanism to actually query the wakeup source is not ready yet. This workaround tells the kernel to always enter dark resume and rely on chrome and powerd to detect user activity and transition into fully resumed. BUG=414949 Signed-off-by:
Chirantan Ekbote <chirantan@chromium.org> Review URL: https://codereview.chromium.org/589723003 Cr-Commit-Position: refs/heads/master@{#296082}
-
Daniel Cheng authored
This patch adds the CMakeLists.txt necessary to build clang tools using CMake. The build files have also been refactored by creating a top-level CMakeLists.txt. The list of tools to be built can be controlled by setting ${CHROMIUM_TOOLS}. Tools are now installed with a CMake rule rather than a manual cp, which should make this logic a little more platform independent. R=hans@chromium.org Review URL: https://codereview.chromium.org/583143002 Cr-Commit-Position: refs/heads/master@{#296081}
-