GitLab

Prefer DCHECK_EQ(a, b) over DCHECK(a == b) when possible as this
provides more data on a failure. Similar for other operators such as
>=, <, !=, etc.

This also applies to CHECK, EXPECT, and ASSERT macros.

R=Nico
BUG=464816

Review URL: https://codereview.chromium.org/985723003

Cr-Commit-Position: refs/heads/master@{#319751}

When a ConnectJob failed and there was another socket request pending
for the same group, a new ConnectJob would always be created, even if
the pending request already had its own ConnectJob.

BUG=463960

Review URL: https://codereview.chromium.org/981643002

Cr-Commit-Position: refs/heads/master@{#319750}

Previously, the historic network stats values on the net-internals
page were only updated every hour. Now, instead of using local
prefs, HistoricNetworkStatsInfoToValue reads from statistics prefs,
and the values are up to date.

BUG=403867

Review URL: https://codereview.chromium.org/989663002

Cr-Commit-Position: refs/heads/master@{#319749}

Make the chrome://extensions page use chrome.developerPrivate API for
'inspect' calls.
Also convert the api function to a UIThreadExtensionFunction.

BUG=461039

Review URL: https://codereview.chromium.org/989843002

Cr-Commit-Position: refs/heads/master@{#319748}

New component extensions should default to the front of the visible icons. The
user can still reposition them, but for the first startup, they will now appear
at the beginning.

BUG=463938

Review URL: https://codereview.chromium.org/981603002

Cr-Commit-Position: refs/heads/master@{#319747}

between what Chrome thinks and what the driver is.

This is caused by we intercept invalid program and generate an error on
LinkProgram rather than passing it to the driver, so the driver still have
a valid program if the previous link succeeds.

BUG=463599
TEST=test case in the bug
R=sievers@chromium.org

Review URL: https://codereview.chromium.org/978193003

Cr-Commit-Position: refs/heads/master@{#319746}

BUG=454983

Review URL: https://codereview.chromium.org/993703002

Cr-Commit-Position: refs/heads/master@{#319745}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/719867b..796d284

TBR=jbroman@chromium.org,dstockwell@chromium.org

Review URL: https://codereview.chromium.org/993683002

Cr-Commit-Position: refs/heads/master@{#319744}

Add a map from stream ID to priority to track which stream IDs are already in
the write blocked list.  And git cl format.

This CL lands server change 86595615 by birenroy.

BUG=

Review URL: https://codereview.chromium.org/989523005

Cr-Commit-Position: refs/heads/master@{#319743}

BUG=None
R=msw@chromium.org

Review URL: https://codereview.chromium.org/968923004

Cr-Commit-Position: refs/heads/master@{#319742}

The script follows mojo/services/html_viewer/view_url.py. See the script for
how to use it.

BUG=410451
TEST=Run the script to test.

Review URL: https://codereview.chromium.org/991963003

Cr-Commit-Position: refs/heads/master@{#319741}

Revert of Roll src/third_party/skia 86e31a1:d2737ad (patchset #1 id:1 of https://codereview.chromium.org/995473002/)

Reason for revert:
The font patch included in this roll seems to be causing a crash on the N7 GPU bot.

http://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%207%29/builds/18522/steps/webgl_conformance_tests/logs/stdio

(search for GrBitmapTextContext::onDrawPosText)

Original issue's description:
> Roll src/third_party/skia 86e31a1:d2737ad
>
> Summary of changes available at:
> https://chromium.googlesource.com/skia/+log/86e31a1..d2737ad
>
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> TBR=mtklein@google.com
>
> Committed: https://crrev.com/83109ac5eab7187ec595c487bdd5bab74c1847c1
> Cr-Commit-Position: refs/heads/master@{#319715}

TBR=mtklein@google.com,skia-deps-roller@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/992073002

Cr-Commit-Position: refs/heads/master@{#319740}

Also extensions::Dispatcher::WillReleaseScriptContext.

R=nasko@chromium.org

Review URL: https://codereview.chromium.org/985643004

Cr-Commit-Position: refs/heads/master@{#319739}

This CL removes the calculate_top_controls_position flag and instead
always creates the top controls manager. The methods of the manager
become no-ops if the top controls height is 0 so that it becomes
effectively enabled when a top controls height gets set.

This fixes the attached bug because some Android Chrome UI pages don't
have top controls but the manager was still created. These pages set
the height to 0 to hide the top controls but the methods of the
manager were still getting called. This caused a crash in Blink since
ScrollBy would try to calculate the shown ratio with a 0 height, causing
a NaN to propagate into Blink.

BUG=460007

Committed: https://crrev.com/7610e74eacde3468853c9765bd3f726c14df04c1
Cr-Commit-Position: refs/heads/master@{#319257}

Review URL: https://codereview.chromium.org/961023002

Cr-Commit-Position: refs/heads/master@{#319738}

Moves a subclass Tab method up to superclass to eliminate the dependency
on the downstream Tab implementation. Removes the no longer necessary
method from TabDelegate.

BUG=464934

Review URL: https://codereview.chromium.org/988323005

Cr-Commit-Position: refs/heads/master@{#319737}

Add AwContentsClient#hasWebViewClient so chromium layer knows when the
WebViewClient is null, and can fallback to default implementations.

Then move the default implementations to chrome layer.

Changes in implementation:

Use ContextWrapper instead of view.getContext(). This means the
"context instanceof Activity" check will never return true.
Use ContentViewCore.activityFromContext to check instead.

Call ContentViewClient.shouldOverrideKeyEvent directly instead of
keeping another copy of the implementation.

BUG=464491

Review URL: https://codereview.chromium.org/985833004

Cr-Commit-Position: refs/heads/master@{#319736}

Reason for revert:
Broke "compile" on "iOS_Device".

http://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/26659/steps/compile/logs/stdio

Undefined symbols for architecture armv7:
  "net::SpdyPriorityIR::SpdyPriorityIR(unsigned int, unsigned int, unsigned char, bool)", referenced from:
      net::SpdyFramerTest_CreatePriority_Test::TestBody() in spdy_framer_test.o
      net::SpdyFramerTest_ReadPriority_Test::TestBody() in spdy_framer_test.o
ld: symbol(s) not found for architecture armv7
clang:error: linker command failed with exit code 1 (use -v to see invocation)

Original issue's description:
> Test dead code.
>
> Test a log method that could be helpful for debugging.  Also inline SpdyPriorityIR constructors for code convergence.
>
> This CL lands server change 87053738 by birenroy.
>
> BUG=
>
> Committed: https://crrev.com/e44eb0a35c11f8ff743873f5f382b5d5c5353325
> Cr-Commit-Position: refs/heads/master@{#319724}

TBR=rch@chromium.org,bnc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/992613005

Cr-Commit-Position: refs/heads/master@{#319735}

Add methods in AwContents that mirrors WebView exactly. And have
WebViewChromium call through to AwContents directly.

Unfortunately the code to post to UI thread now needs to be duplicated
in WebViewChromium for each method.

BUG=464491

Review URL: https://codereview.chromium.org/986953002

Cr-Commit-Position: refs/heads/master@{#319734}

In this change:
- Move towards following class hierarchy: http://www.plantuml.com:80/plantuml/png/ZPBTJiCm38NlynIvv4TzWsaI525nCI5jkw-on1EZQHmvwQG9U7TC4-ZeKiITvNm-EiSExbv1Hxc6VOszYs24mDHQeG6xFNcGRqBAknYLVkd0nKr40l7nmqrU1deDeRUHYrfPkrEw3LmJx848YCkWqODfkECZBIOAZuHin9abWxUo9b0Hdjt38RGJyEhwZ4YZI9kJq_mmRp0pAPKnd7pGgG8t6usTHyVe7_FPtY3mbOth9ghGDjGxTnwlaEq-ySjv-KmCwZflxvVyE5bSIa4Mw7ZGyDHvAyHurPkgkhZgz9PuoNp75tDhAUZcJ68cwkATHyfXnFWn4_PFDsKuNLuKLrFodGS-0G00
- Remove AttachmenService::GetStore. Now attachment store is owned by
  model type, there is no need to get it from AttachmentService
- Introduce AttachmentReferrer. There is no functionality behind it yet
  and interface is not complete for it. These will come in the next change.

BUG=457735
R=maniscalco@chromium.org
TEST=Not exposed in chrome. Only unit tests available (sync_unit_tests)

Review URL: https://codereview.chromium.org/986743004

Cr-Commit-Position: refs/heads/master@{#319733}

BUG=459719

Review URL: https://codereview.chromium.org/994593002

Cr-Commit-Position: refs/heads/master@{#319732}

This is required to make the histogram results show in UMA.

BUG=433554

Review URL: https://codereview.chromium.org/981203006

Cr-Commit-Position: refs/heads/master@{#319731}

base::PowerObserver provides a platform-agnostic way to be notified
about system suspend and resume events.  Use it to check for missed
heartbeats instead of polling.  Unfortunately we still need to poll on
linux because there is no common system-wide notification about suspend
and resume events.

BUG=421725

Review URL: https://codereview.chromium.org/989803002

Cr-Commit-Position: refs/heads/master@{#319730}

Avoid the race by:
1. Calling InitApplicationContext() from CronetLibraryLoader.ensureInitialized()
2. Remove other calls to InitApplicationContext()
3. Make ChromiumUrlRequestContext() call CronetLibraryLoader.ensureInitialized()
Also:
4. Remove duplicate NetworkChangeNotifier initialization from ChromiumUrlRequestContext()
5. Remove now duplicate CronetLibraryLoader.ensureInitialized() call from ChromiumUrlRequestFactory()

BUG=465392

Review URL: https://codereview.chromium.org/991923002

Cr-Commit-Position: refs/heads/master@{#319729}

Revert of base: Fix/add header #ifndef guards. (patchset #2 id:20001 of https://codereview.chromium.org/985003004/)

Reason for revert:
This seems to be causing tree closing compile failure https://build.chromium.org/p/chromium/builders/Android/builds/36135/steps/compile/logs/stdio.

Original issue's description:
> base: Fix/add header #ifndef guards.
>
> Header guards should be defined based on the path and file name of the
> header file. Some headers have it wrong, some are missing the guards,
> and some just have the matching comment wrong.
>
> R=Nico
> BUG=464816
>
> Committed: https://crrev.com/301b392761fd8f66f3a701ab1dd011c6e7a55e19
> Cr-Commit-Position: refs/heads/master@{#319722}

TBR=thakis@chromium.org,danakj@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464816

Review URL: https://codereview.chromium.org/989343002

Cr-Commit-Position: refs/heads/master@{#319728}

This patch enables javascript code injection like <webview>.executeScript({code: ...}), but does not include file injection like <webview>.executeScript({file: ...}). File injection will be in another patch.

BUG=434081

Review URL: https://codereview.chromium.org/942533003

Cr-Commit-Position: refs/heads/master@{#319727}

Simple move of small chucnk of code out of glue layer.

BUG=464491

Review URL: https://codereview.chromium.org/984273002

Cr-Commit-Position: refs/heads/master@{#319726}

This reverts commit eabf1f5b.

Removing the toggle in about:flags breaks a workaround for users who
have nonstandard nsswitch configurations for hosts.

Revert the removal until we properly check nsswitch.conf before
assuming a standard configuration.

BUG=117655

Review URL: https://codereview.chromium.org/987133003

Cr-Commit-Position: refs/heads/master@{#319725}

Test a log method that could be helpful for debugging.  Also inline SpdyPriorityIR constructors for code convergence.

This CL lands server change 87053738 by birenroy.

BUG=

Review URL: https://codereview.chromium.org/988733003

Cr-Commit-Position: refs/heads/master@{#319724}

BUG=455057

Review URL: https://codereview.chromium.org/980353002

Cr-Commit-Position: refs/heads/master@{#319723}

Header guards should be defined based on the path and file name of the
header file. Some headers have it wrong, some are missing the guards,
and some just have the matching comment wrong.

R=Nico
BUG=464816

Review URL: https://codereview.chromium.org/985003004

Cr-Commit-Position: refs/heads/master@{#319722}

Have BluetoothAdapterProfileChromeOS objects managed through
BluetoothAdapterChromeOS, avoiding problems where references were being
left behind in BluetoothSocketChromeOS after deletion.

Adds some unit tests to confirm lifecycle works correctly even when
multiple profiles are requested simultaneously.

This is a resubmit of https://codereview.chromium.org/935383003/ after a revert
for LSan test failures https://codereview.chromium.org/975323002/, a patch with
just changes from the old CL can be found there.

BUG=457978
R=armansito, isherman@chromium.org, keybuk

Review URL: https://codereview.chromium.org/982593002

Cr-Commit-Position: refs/heads/master@{#319721}

Per the explanation in the bug, ui/ios should not have been created in
the first place; this code belongs in the ui/gfx subcomponent.

BUG=446643

Review URL: https://codereview.chromium.org/983413004

Cr-Commit-Position: refs/heads/master@{#319720}

Code in AnalysisCanvas::willSaveLayer was treating the case of layers
composited with kSrc_Mode as if they did not affect the destination,
when in fact it is kDst_Mode that does not affect the destination.
As a result of this error, the compositor was culling layers that
contained opaque canvas elements, which are composited with
'src' for performance.

BUG=464694
TEST=skia_unittest AnalysisCanvasTest.SaveLayerWithXfermode

Review URL: https://codereview.chromium.org/990983003

Cr-Commit-Position: refs/heads/master@{#319719}

Review URL: https://codereview.chromium.org/991953002

Cr-Commit-Position: refs/heads/master@{#319718}

Causing failures on perf waterfall.

NOTRY=true
BUG=465446

Review URL: https://codereview.chromium.org/989323002

Cr-Commit-Position: refs/heads/master@{#319717}

Make all the LOGs that follow DRM calls PLOGs since we're interested in
the error message.

Also add a few more LOGs during device probing just in case we end up in
odd states where the DRM device is controlled by another process and
we're trying to take ownership.

BUG=none

Review URL: https://codereview.chromium.org/991963002

Cr-Commit-Position: refs/heads/master@{#319716}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/86e31a1..d2737ad

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/995473002

Cr-Commit-Position: refs/heads/master@{#319715}

BUG=442033
TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/990253003

Cr-Commit-Position: refs/heads/master@{#319714}

Revert of [Android] Fix a flicker in stopping Chrome (patchset #11 id:200001 of https://codereview.chromium.org/843883002/)

Reason for revert:
Caused regression with lockscreen battery consumption.

Original issue's description:
> [Android] Fix a flicker in stopping Chrome
>
> Currently, we draw a blank frame as we release resources in onStop().
> This can be prevented if we hide the tab when the window gets hidden instead of
> on activity stop.
>
> BUG=434401
>
> Committed: https://crrev.com/e4b1990c9d49fd9734940fa863513ad43b82c6e7
> Cr-Commit-Position: refs/heads/master@{#311809}

TBR=tedchoc@chromium.org,dtrainor@chromium.org,yusufo@chromium.org,aelias@chromium.org,sievers@chromium.org,changwan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=434401

Review URL: https://codereview.chromium.org/990183004

Cr-Commit-Position: refs/heads/master@{#319713}

Now XMPP is implemented directly in remoting/signaling instead of
relying on WebRTC. The new code is mostly just a translation of
the XMPP implementation we use in the webapp from JavaScript to
C++ and uses the same layout and class names, except that the main
class is called XmppSignalStrategy instead of XmppConnection.

BUG=459756, 443806, 417336

Review URL: https://codereview.chromium.org/958703003

Cr-Commit-Position: refs/heads/master@{#319712}