- 15 Sep, 2020 40 commits
-
-
Josh Nohle authored
The ListPublicCertificates HTTP GET request has the option of including the IDs of certificates that the user already has. These certificates will not be returned by the server. The certificate ID is a byte field in the proto, and One Platform requires that byte fields be base64 encoded before being added to the URL's query parameters (https://developers.google.com/protocol-buffers/docs/proto3#json). Otherwise we get "Bad Request" errors in the HTTP response body like "Invalid value at 'secret_ids' (TYPE_BYTES), Base64 decoding failed for...". Fixed: 1128021 Change-Id: Icef3d04456de40a7207aba0ed64eda8f1438c675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410578 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#806919}
-
Josh Nohle authored
Correct the values used in the FieldMask |update_mask| field in the UpdateDeviceRequest proto. With these changes, we manually verified that the contacts and public certificates fields in the UpdateDevice response now show the expected changes in the Nearby Share server database. The values in this CL agree with those in GmsCore [1]. [1]http://google3/java/com/google/android/gmscore/integ/modules/nearby/src/com/google/android/gms/nearby/sharing/rpc/NearbySharingServiceGrpcClient.java?l=59-61&rcl=330996445 Bug: b/157685298 Change-Id: I5c7d669825cc0ff667cdaf17eb09b26f9f999327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411449 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
-
Maggie Cai authored
Currently the drive share action returns an empty icon, however this will no pass a size DCHECK. The reason we return an empty icon is because there is some refactoring needed for the GetActionIcon method and we should not create the icon at this stage (crbug.com/1127750). However because we don't want to cause a DCHECK failure, and also there is already another implementation that does the same thing, so I will add this temp solution and this will be fixted together. BUG=1097623 Change-Id: Iff4fcaac6aa0d2308d9b9539f861303164346f9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409850Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#806917}
-
Adam Rice authored
Remove redundant virtual/omt-worker-fetch expectations from TestExpectations. Bug: 1128252 Change-Id: I65f951923ccfeafa1e212a5ab815b8b0bafbd542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409478Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#806916}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ac8edb313ce2..53a7d9430dbb 2020-09-15 soxia@microsoft.com Fix issue where full screen capture captures part of screen. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id184c4a82aa7015af4ea2ea7ff133459c7fa5e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411234Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806915}
-
Harald Alvestrand authored
The bug it's checking for manifests as random timeouts on WPT tests that use RTCPeerConnection-helper's functions to set up connection. The bug was fixed in another CL, but these tests exercise interesting functionality, so worth adding. The purpose of the helper-test is to ensure that if we introduce more instabilities by changes to the helper, this test should fail first. Bug: chromium:1122106 Change-Id: Ic59f76fd36f645cee0e08d6dcd69db0c62cbc903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379193Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#806914}
-
Shakti Sahu authored
This CL adds: 1 - VideoIPHCreator that takes a ViewStub and inflates into an IPH 2 - A manager class on NTP to manage showing various video tutorial IPHs 3 - Added IPH features for search and download 4 - Moved VideoTutorialServiceFactory package to upper level TODO: - The IPH layout isn't upto spec. Needs one more pass. - The IPH configs aren't fully correct. Needs one more pass. I added them here for the sake of review clarity and completeness. Bug: 1117147 Change-Id: Iefdd02da06f8667fbd85a44a821d940277571559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367438 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#806913}
-
Solomon Kinard authored
Bug: 1108940 Change-Id: I0ad39f0249612c002dc288983c447b86d3e19ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404278 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#806912}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0547fb291708..f57e64e375ef 2020-09-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I43700bcd0d79c86f0018a0f06e9b3dfc8d298862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411235Reviewed-by:
-
Nela Kaczmarek authored
This change provides an interface and implementation of AffiliationFetcherFactory. It modifies the ScopedFakeAffiliationFetcherFactory to extend this interface and changes the creation of Affiliation Fetcher in Affiliation Service. Bug: 1117447 Change-Id: I900c34e09461e870ea144f20e209cec973976568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409899Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Cr-Commit-Position: refs/heads/master@{#806910}
-
Solomon Kinard authored
Though this is a breaking change, it's safe because the API was only available on dev channel in M86. Bug: 1108940 Change-Id: I4ee1718c8cdeda2e3fe28fcd810b894e656cc8f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398888 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#806909}
-
Anastasia Helfinstein authored
Previously, having a row with only 1 element threw an error. However, in the emoji keyboard there are places where that is the most logical grouping. Remove that check. AX-Relnotes: n/a. Fixed: 1127070 Change-Id: I61aa71ae20fbf3aa0015b12fceb50cf66ba271fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406658 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#806908}
-
Aaron Colwell authored
Removing DoesSiteRequireDedicatedProcess() and migrating all existing calls to use DoesSiteInfoRequireDedicatedProcess() to encourage code to use existing SiteInfo objects when trying to determine this information. Bug: 1085275 Change-Id: I3cda5cb7772e27c4b38bd49a4d0ed0731d43875c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406518 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#806907}
-
Takashi Toyoshima authored
This reverts commit efd0a0a1. Reason for revert: The failed internal test was fixed in the internal repos by https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3263707 Original change's description: > Revert "OOR-CORS: Remove BlinkCORS supporting code outside Blink" > > This reverts commit 1047b889. > > Reason for revert: Build failure on mac-builder-perf: https://ci.chromium.org/p/chrome/builders/ci/mac-builder-perf/220028 > > Original change's description: > > OOR-CORS: Remove BlinkCORS supporting code outside Blink > > > > As OOR-CORS was fully launched, this patch removes BlinkCORS > > supporting code that exists outside Blink. > > > > We still have some dead code in Blink, and subsequent cleanup > > changes will remove them all. > > > > Bug: 1053866 > > Change-Id: Ibe9f913d3cc9f183d6e681516996f1bc6cc58b96 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397458 > > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > > Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#805644} > > TBR=falken@chromium.org,sky@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,jam@chromium.org,karandeepb@chromium.org > > Change-Id: I51b1a274038b33b8db3036fc1a3912c6580c9446 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1053866 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401467 > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805662} TBR=falken@chromium.org,sky@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,jam@chromium.org,skyostil@chromium.org,karandeepb@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1053866, 1126827 Change-Id: I9251c658414ff98e3fc35e8a110366edb30b2d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405728 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#806906}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 86-4183.39-1595842708-benchmark-86.0.4208.0-r1 to 86-4240.11-1599471529-benchmark-86.0.4240.36-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I3b8d024e35ee277379193620a33536ad2ba46408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411770Reviewed-by:
-
Matthew Duggan authored
This requires intents to ensure the ArcAccessibilityHelperService is enabled in Android, and the editability of the control to be passed through to the MagnificationManager. To work with no other accessibility features are enabled, this also requires the Android side change: http://ag/12532278 This change will still be safe to merge without that change, as the intents will just be ignored. BUG=b:167133958 TEST=Manual (tab around apps and observe magnifier, enable and disable magnifier and other accessibility features) R=hirokisato@chromium.org, sarakato@chromium.org AX-Relnotes: Magnifier now follows focus in Android apps. Change-Id: I2fd1a7145be3475a9c288715c4d442f6bc035c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389802 Commit-Queue: Matthew Duggan <mduggan@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#806904}
-
Yuke Liao authored
This CL makes test runner supports lacros_chrome_browsertests by: 1. Appending necessary args to establish mojo connections. 2. Always use '--test-launcher-jobs=1' to run tests serially because multiple clients crosapis are still not supported yet. Bug: 1120582 Change-Id: I865ace26aa4a86c83912c6660bc433d79e43ef76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410350 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#806903}
-
Yue Li authored
Replace the current language detect API with the FindLanguage API from text classifier. This is the first change of the Translation backend for the Quick Answers. Bug: b/150034512 Test: Manual Test Change-Id: Ie0a53e473b8a378c2692952f350f37b3b2534894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377582 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#806902}
-
Peter Kasting authored
While such views are still sized based on their preferred size, this allows marking them as "can flex" or "should be visible" in more cases. In turn this allows FlexLayout to realize that e.g. zero min/unlimited max width Views should have their heights included in parent preferred size calculations. Bug: 1012136 Change-Id: Icd13e1d672701c962e88d9ce55a26a34547fa02a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021463 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#806901}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2296e7afd748..06b4fb92c569 2020-09-15 cclao@google.com Vulkan: Fool proof packed attachment index to vulkan and from OpenGL 2020-09-15 jmadill@chromium.org Test Runner: Re-use displays when using "bot mode". 2020-09-14 cclao@google.com Vulkan: Defer glFlush issued in middle of renderpass to endRenderpass 2020-09-14 jmadill@chromium.org Test Runner: Print total test execution time. 2020-09-14 jmadill@chromium.org GN: Componentize "Null" back-end. 2020-09-14 jmadill@chromium.org Add luci-go and mb to DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: I59f4b4e46c04db4f4d56dce616509dec76189271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411356Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d1b7c5ca690c..ac8edb313ce2 2020-09-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iea61601349aca2078aec981da9fe72e818ab9d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411365Reviewed-by:
-
Peter Kasting authored
This makes functioning of FlexLayout a bit more uniform by removing a conditional of whether the main axis is bounded. With the addition of SizeBounds and its various methods, very little syntactic change is needed. This will also help when fixing bug 1012136. Bug: 1012136 Change-Id: I0d768bed020c5039ddc326de86aa5b490780c11b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036638 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Peter Kasting authored
Using a dedicated class for this has the benefits of a type alias along with allowing overloaded math and comparison operators, as well as ToString(). All these together make code using this concept more streamlined and obvious. This will become even more useful when actually fixing bug 1012136. Bug: 1012136 Change-Id: I962edf36e16f5e2ca4e631b64cdd9c4aab2e3395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021295 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Johann authored
If mojo interfaces are bound to a RenderProcessHost then the interface cannot be frozen for a specific Frame. This is problematic for prerendering. Bind them to a RenderFrameHost (via PopulateFrameBinders) instead. BUG=chromium:1126758 Change-Id: I8c6683b45737a8276cb28391532b0e6a036386d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400554 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Yuheng Huang authored
Currently Tab.fav_icon_url conveys a base64 stream of favicon image, which is slow, heavy and not reusable. This CL removes it and the js side can get the favicon from chrome://favicon2. Removing fav_icon_url makes GetProfileTabs() and TabUpdated() API ~6x faster. Related CL: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3265887 Bug: 1099917 Change-Id: I4d1361b96a3f5a5b8ee43f77fb50e04b6f958607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406932Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#806895}
-
Vladimir Levin authored
Original change's description: > viz: Remove two fields from CompositorRenderPass. > > This patch moves two fields from RenderPassInternal into > AggregatedRenderPass, effectively removing them from CompositorRenderPass > since they are not used there. The fix to the test is to use the aggregated render pass for size comparison, since that's what the test is constructing / testing. R=weiliangc@chromium.org Fixed: 1124768 Change-Id: I414e802629395f739cb9d9f72b706935cf5d0096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392704 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#806894}
-
Hiroshige Hayashizaki authored
Classic script and SharedWorker versions of https://chromium-review.googlesource.com/c/chromium/src/+/2346251 https://github.com/web-platform-tests/wpt/pull/24948 Bug: 1114028, 1128214 Change-Id: I44353438ec9356a6a55a4ed3bb22cf80b9ab554a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369075 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#806893}
-
Prashant Nevase authored
Before organizing the dark mode test, we had same tests with different names different in folders like filter-all, filter-none and grayscale. This patch removes duplicate web tests for gradient and image. Bug: 1116914 Change-Id: If36468417c84ed122e0ce612569f7b2f8e8c30e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409879Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#806892}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/41974f57973e..0f14b7ab7a55 2020-09-14 amaiorano@google.com CMake: normalize FOLDER property for third_party targets 2020-09-14 bclayton@google.com SpirvShaderDebugger: Add PRINT_EACH_DEFINED_DBG_INSTRUCTION 2020-09-14 bclayton@google.com SpirvShaderDebugger: Implement DebugValue 2020-09-14 bclayton@google.com SpirvShaderDebugger: Reduce lock contention 2020-09-11 capn@google.com Drop the float literal suffix If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I9f8edc59b88cb30c70fa71e7f444d2827125dc33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410883Reviewed-by:
-
Mark Mentovai authored
content_nocompile_tests only works in non-cross builds. See build/nocompile.gni enable_nocompile_tests. For now, all mac-arm64 builds are cross builds where the build host is x86_64 targeting arm64. Removing this test should fix “analyze” step errors such as https://ci.chromium.org/p/chromium/builders/try/mac-arm64-rel/413. Native Client is not a thing on mac-arm64, and will never be a thing. Removing nacl_loader_unittests should fix generate_build_files errors such as https://ci.chromium.org/p/chromium/builders/try/mac-arm64-rel/414. These changes should bring mac-arm64-rel [closer] to a good state. This change was made by editing test_suites.pyl and waterfalls.pyl. chromium.*.json were generated by running testing/buildbot/generate_buildbot_json.py. Change-Id: I8be7c02793262d4e8dcd5f780f6f70fe21c14463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410764 Commit-Queue: Mark Mentovai <mark@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#806890}
-
Hiroshige Hayashizaki authored
Change-Id: I4044fbf55b82e998433c118fe0b6130ae3842966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409253Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#806889}
-
Alan Cutter authored
This is a follow up CL to https://chromium-review.googlesource.com/c/chromium/src/+/2392168. Background: The above CL fixes a bug that caused bookmark app -> BMO migration to set the user_display_mode to kBrowser for non locally installed apps. The bug fix unfortunately doesn't fix the effects of that bug for users that ran the migration code bug. Change: This CL specifically looks for users affected by the bug (where their bookmark app is set to open in a window while the BMO app is set to open in a tab) and re-migrates their bookmark app user_display_mode. Known issues: - If the user sets their user_display_mode to open in browser tab after migration and before the clean up runs it will be reverted back to window (this is indistinguishable from the migration bug but should be rare). - This won't run for users with sync disabled (though they are unlikely to have this bug as sync is required to have non-locally installed bookmark apps). Bug: 1127128 Change-Id: I4268fbf450760b0ef1403be209d1983fd83a8b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391704 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#806888}
-
Felipe Erias authored
Implementation of "force" for the scrollbar-gutter CSS property. This keyword forces a gutter on a non-scrollable element, so it can be accurately aligned with nearby scrollable areas (e.g. when implementing a header). css_properties.json5: scrollbar-gutter becomes non-inheritable, as otherwise the children inside a "force" element would also get gutters of their own, messing up the layout. This matches the current editor's draft: https://drafts.csswg.org/css-overflow-4/#scrollbar-gutter-property paint_layer: Assign a scrollable area to "force" elements, in order to calculate the size of scrollbar gutters. layout_box: Assign a layer to "force" elements. Take "force" into account when checking for scrollbar gutters. ScrollWidth and ScrollHeight defer to the scrollable area for "force" elements. Updated and expanded the scrollbar-gutter tests. Bug: 710214 Change-Id: Iea25ded4b7b635edeb513a93e30645326eb051e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404233Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Felipe Erias Morandeira <felipeerias@gmail.com> Cr-Commit-Position: refs/heads/master@{#806887}
-
Gavin Williams authored
Add the printer status icon to the destination dialog to show the status of local CrOS printers. Bug: 1123754 Change-Id: Ie4012183b9815a5eac906b5379e30e17a78fc071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406381 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#806886}
-
Ian Clelland authored
The use of commas as separators in the iframe allow attribute is not allowed, according to the specification, but it was previously parsed, as it can appear in HTTP headers. This CL adds a deprecation message, and is the first step towards removing this. Blink intent thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/43EhaSQWm6M/iqvQ3hY0AwAJ Bug: 1062400 Change-Id: I2efff7c9610ca7b85145a7600d1c0074ad2e30be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313298Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#806885}
-
Xiaohui Chen authored
* Moved `GlanceableInfoView` to `AmbientBackgroundImageView` together with the photo attribution so they can be moved together. * Move glanceable info views in small steps on each refresh with in a fixed bounds. * Fixed the spaceing to account for shadows. * Fixed typo in metadata setup. * Fixed dismiss event handling to include touch events. Bug: b:162596816 Test: run existing unit tests and manual test. Change-Id: If96d83b1541cc301c881e07ce987ef7eb78794ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410532Reviewed-by:
Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#806884}
-
manukh authored
Search suggestions are grouped above URL suggestions regardless of relevance scores. There are a some exceptions e.g. default match. After grouping, this CL, bubbles URLs back above search suggestions if 2 conditions are met: 1) There must be a sufficient score gap between the adjacent searches. E.g. for (S1, U1, S2), the difference in scores of S1 and S2 must be larger than some threshold. 2) There must be a sufficient buffer between the URL and search scores. This only applies to the first URL suggestion in a series. E.g. for (S1, U1, U2, S2, U3, S3), U1 & U3 must score higher than S2 + threshold & S3 + threshold respectively, but U2 need only score higher than S2. The intention is to allow good URLs to rank above relatively bad searches while maintaining some propensity to group URLs and searches into clusters. These changes are behind a 'OmniboxBubbleUrlSuggestions' feature with 4 params: - OmniboxBubbleUrlSuggestionsAbsoluteGap - OmniboxBubbleUrlSuggestionsRelativeGap - OmniboxBubbleUrlSuggestionsAbsoluteBuffer - OmniboxBubbleUrlSuggestionsRelativeBuffer And chrome://flags flag 'omnibox-bubble-url-suggestions'. Bug: 1127125 Change-Id: I43662284537e9a89ab19b7bab040f8a6ad996e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404753Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#806883}
-
rbpotter authored
- Hide and disable the sidenav in annotation mode. - Fix a timing issue, where the annotations bar would briefly appear when the annotation mode was toggled before disappearing and then re-appearing when the ink controller finished loading. - Fix a positioning issue in which the document scrolled slightly when changing between annotation mode and the plugin. - With the third fix above, positioning is much closer to expectations in the annotations feature enabled test. Verified that scrolling/zoom seems correct now, and updated the mismatched expectation for the case of the update being enabled as recommended by the test's original author. Bug: 1124183 Change-Id: I8f9357d883088e31fc8882f3359e662685978de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405539 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#806882}
-
Kyle Horimoto authored
Bug: 1045266 Change-Id: I2826792dc171aeeb8cfb338b384ccf1c8e0d8785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411469 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#806881}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/295570eb332d..7703f23b60c4 2020-09-14 sprang@webrtc.org Adds ability to delay pacer start until media is added. 2020-09-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e645bb4c..b0398ace (806687:806731) 2020-09-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ff96bd07..e645bb4c (806570:806687) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6428a490939359802e029f051dc38915650441c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411352Reviewed-by:
-
