- 19 Jun, 2018 40 commits
-
-
Stuart Langley authored
Steps I followed: autoninja -C out/Default chrome tools/clang/scripts/generate_compdb.py -p out/Default > compile_commands.json cd out/Default /usr/local/google/code/llvm/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \ -p ../.. \ -clang-tidy-binary /usr/local/google/code/build/bin/clang-tidy \ -clang-apply-replacements-binary /usr/local/google/code/build/bin/clang-apply-replacements \ -checks=-*,modernize-use-equals-default \ -header-filter=chrome/browser/chromeos/extensions/file_manager/* \ -fix chrome/browser/chromeos/extensions/file_manager git cl format Bug: 841659 Change-Id: I1df81598c3d7b7dc18dc3326de410cc91f5de4b9 Reviewed-on: https://chromium-review.googlesource.com/1106577Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#568549}
-
Eugene But authored
Notable changes: - DidFinishNavigation and DidStopLoading order expectations are swapped in tests. This is OK, because WebStateObserver API contract does not guarantee specific order. - NavigationContextImpl::GetDescription was updated to print is_loading_error_page_ flag. - Commit Pending Item if WebErrorPages is enabled and SlimNavigationManager is disabled. Failed navigations must always be committed. - Ignore decidePolicyForNavigationAction: callback if NavigationContext::IsLoadingErrorPage() returns true. This will suppress extra PolicyDecider callbacks. Bug: 725241 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9bb8fc76ecd51054cd85fb43fd86353035b631de Reviewed-on: https://chromium-review.googlesource.com/1105186Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#568548}
-
Stuart Langley authored
Steps I followed: autoninja -C out/Default chrome tools/clang/scripts/generate_compdb.py -p out/Default > compile_commands.json cd out/Default /usr/local/google/code/llvm/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \ -p ../.. \ -clang-tidy-binary /usr/local/google/code/build/bin/clang-tidy \ -clang-apply-replacements-binary /usr/local/google/code/build/bin/clang-apply-replacements \ -checks=-*,modernize-use-nullptr \ -header-filter=chrome/browser/chromeos/extensions/file_manager/* \ -fix chrome/browser/chromeos/extensions/file_manager git cl format Bug: 841659 Change-Id: I61747c05ca97127ad190de3e11337b0045128fea Reviewed-on: https://chromium-review.googlesource.com/1106578Reviewed-by:
-
Andrew Grieve authored
Also - Remove a File.exists() call from the normal start-up flow. Hoping this helps determine root cause of bug. Bug: 849550 Change-Id: Iaadeedbfedeb8e6fd76bc93f3d6729c579c89b44 Reviewed-on: https://chromium-review.googlesource.com/1102905Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#568546}
-
Shakti Sahu authored
Fixed several issues with animation : 1 - Color of the completed download check mark was grey. Changed it to light blue and smoothened the transition. 2 - For API < 25, when onAnimationEnd() is called, isRunning() still returns true, hence restartAnimation bails out early. This is a known android bug, workaround is to post the restart method. 3 - The fill animation was not being reset to correct deep blue color at the beginning of every loop. Fixed it. Bug: 853860 Change-Id: Iff2414f2e94ed85711be19a13776db31e74292ee Reviewed-on: https://chromium-review.googlesource.com/1105500Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#568545}
-
Daniel Rubery authored
Add a PhishGuard event log to chrome://safe-browsing. Currently only logs when triggered by on focus or password reuse events. Will add further logged events in future CLs. Screenshot: http://screen/YPyPv8CbirO Bug: 849351 Change-Id: I7341b79685af1839584a165a7c1e3ee200947329 Reviewed-on: https://chromium-review.googlesource.com/1102665Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#568544}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ba61029c5b49..96aa535b782f git log ba61029c5b49..96aa535b782f --date=short --no-merges --format='%ad %ae %s' 2018-06-19 benjaminwagner@google.com Remove .bat and .exe from commands where possible. Created with: gclient setdep -r src/third_party/skia@96aa535b782f The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:852581 TBR=kjlubick@chromium.org Change-Id: I59207c703be4e7429eee0a39a69724e23d9e331b Reviewed-on: https://chromium-review.googlesource.com/1106497Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568543}
-
Emily Hanley authored
Also turning on sharding on main waterfall for linux and mac configs. Bug:713357 Change-Id: I3aa3c67d5d23b2549455d363bbef374fb70fba4d NOTRY=true # CQ flakes, related tests passed Change-Id: I3aa3c67d5d23b2549455d363bbef374fb70fba4d Reviewed-on: https://chromium-review.googlesource.com/1106428 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#568542}
-
Pete Williamson authored
For some apps (Inbox), we discovered the mime type in content uri and contentProvider.getType() doesn't match the mime type in the intent. To prevent that from making chrome think the file is really a download, we now set headers whenever we see a mime type in the intent that is used by MHTML. Bug: 852629 Change-Id: I874e2c976a9817d3a35b8587044f7589c2d498e8 Reviewed-on: https://chromium-review.googlesource.com/1103592Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
-
Marijn Kruisselbrink authored
Failed() might have caused |this| to be destroyed, and we certainly don't want to call OnFinishLoading after an error, so add a missing return statement. Bug: 788890 Change-Id: Ida617ded94891878d0d3d167ffdcfea2fbb53c03 Reviewed-on: https://chromium-review.googlesource.com/1106296Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#568540}
-
GauthamBanasandra authored
Presently, the isNodeJS() method uses '===' operator which evaluates to true only for JS Capability. This check fails for inspector_main target as multiple capabilities are set for it. As a result, source maps doesn't get applied for inspector_main because the isNodeJS() check fails and prevents prefixing of "file://" to sourceMapURL as a consequence, leading to the source maps resource not being served. In this patch, we set only the JS Capability for inspector_main if the 'v8only' parameter in the URL is set to true. Bug: 846642 Change-Id: I96a01f3b984bf552c89c873d10f3bf0b5ecd67c8 Reviewed-on: https://chromium-review.googlesource.com/1095064 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#568539}
-
Ryan Landay authored
We don't allow taking screenshots in the current overlapping Android tab switcher when incognito tabs are open, even if the normal mode stack is active, because we show the edge of the incognito tabs visible on-screen. For the new horizontal tab switcher, we don't do this, so we can allow taking screenshots in this case. Bug: 853805 Change-Id: Ic7054524735b888c39b9a3373684971c962a6030 Reviewed-on: https://chromium-review.googlesource.com/1105392 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#568538}
-
sebsg authored
Change-Id: If7c15bc7f27bb9a311d28555d1efea4b5c1d0cf2 Reviewed-on: https://chromium-review.googlesource.com/1106287 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#568537}
-
Danyao Wang authored
This removes the brief omnibox shadow when animating NTP. With slim-nav, NTP navigation item is still pending at time of |animateNewTab:inForegroundWithCompletion|, so using last committed item URL will not correctly animate. Bug: 819606 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie6b5ecad62f67f1b380e29e2a97bae0cbc19b45a Reviewed-on: https://chromium-review.googlesource.com/1106420Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#568536}
-
danakj authored
The impl-side SetTrilinearFiltering() is unused, since it is only used for property tree building, and on the impl-side it comes from the test properties. So it's removed. R=weiliangc@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib9a726dbaa45665a0cd6c585a69e2f7800db78fa Reviewed-on: https://chromium-review.googlesource.com/1105348 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#568535}
-
erikchen authored
The method, on certain conditions, would simulate receiving a OnBeforeUnloadACK() IPC. This would immediately call back into the unload handler, which had just called RenderFrameHostImpl::DispatchBeforeUnload. The problematic series of events is as follows: 1) TabStripModel::CloseWebContentses tries to close many tabs. 2) This calls RunUnloadListenerBeforeClosing() on each tab. 3) UnloadListener will call RenderFrameHostImpl::DispatchBeforeUnload, which on certain conditions will synchronously call OnBeforeUnloadACK(). 4) This calls back into TabStripModel, mutating internal state. 5) The implementation of TabStripModel::CloseWebContentses relies on the assumption that there is no re-entrancy. This manifests itself as a buffer overrun when (1) calls SendDetachWebContentsNotifications, which then passes inconsistent data to the observers. Bug: 851400 Change-Id: I2080875f5d8d118c93addbe66503cb02b8b2966f Reviewed-on: https://chromium-review.googlesource.com/1101846 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#568534}
-
Aldo Culquicondor authored
The testapp build was broken due to a change in an Ozone API. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6b4c5898221afe565c3150e75a4e91e1242f650b Reviewed-on: https://chromium-review.googlesource.com/1106546Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#568533}
-
Nick Peterson authored
Bug: 854001 Change-Id: I7d463aae233fd9704b4e1af58e9a8e7596aa76f7 Reviewed-on: https://chromium-review.googlesource.com/1105504Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Nick Peterson <nrpeter@chromium.org> Cr-Commit-Position: refs/heads/master@{#568532}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2dabb4a367c3..7df52383cfdf git log 2dabb4a367c3..7df52383cfdf --date=short --no-merges --format='%ad %ae %s' 2018-06-19 lucferron@chromium.org Angle: Fix angle::Format's pixelBytes Created with: gclient setdep -r src/third_party/angle@7df52383cfdf The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I9d42fd4bbc361c64da325b183178f2cf902d6154 Reviewed-on: https://chromium-review.googlesource.com/1106097Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568531}
-
Kyle Horimoto authored
PendingConnectionManagerImpl originally landed in: https://chromium-review.googlesource.com/c/chromium/src/+/1103669 It was reverted by: https://chromium-review.googlesource.com/c/chromium/src/+/1105897 The original CL was reverted due to failures in the ASAN build. This CL uploads the original CL as patchset 1 and fixes the failing ASAN tests in the following patchset. Original CL description below: > This class creates one ConnectionAttempt per ConnectionAttemptDetails > requested; if more than one request shares the same > ConnectionAttemptDetails, a single ConnectionAttempt attempts a > connection for all associated requests. > > If a ConnectionAttempt successfully creates a channel, this class > extracts client data from all requests to the same remote device and > alerts its delegate, deleting all associated ConnectionAttempts when > it is finished. Bug: 824568, 752273 Change-Id: Ia7fc61bb017d7d083fa43c6b3f949c3eed98f62f Reviewed-on: https://chromium-review.googlesource.com/1106427Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#568530}
-
Fady Samuel authored
RenderWidgetHostViewAura had a SyncSurfaceProperties and SynchronizeVisualProperties. The only difference is SynchronizeVisualProperties took an optional LocalSurfaceId and updated the ParentLocalSurfaceIdAllocator using that Id if specified. If unspecified, it allocated a new ID. This CL merges SyncSurfaceProperties into SynchronizeVisualProperties thereby making the code a tiny bit easier to understand. Bug: 672962 Change-Id: I902f6d86b37a2a4d33bef00b4e30014d2c15f20c Reviewed-on: https://chromium-review.googlesource.com/1106237Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#568529}
-
John Abd-El-Malek authored
Since the relevant unit tests make real network requests, create network::TestSharedURLLoaderFactory helper class which is a network-service compatible version of net::TestURLRequestContextGetter. Use it instead of the one-offs in existing safe-browsing unit tests. Bug: 844939 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I905f29fda62f9e27905e3705b3d85c64ba13ae94 Reviewed-on: https://chromium-review.googlesource.com/1104795 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#568528}
-
Sergey Ulanov authored
Also dropped prefix from enum values names as they are not necesary with enum class. Change-Id: Iff808da768321a91a8b841db3aa133935ccab477 Reviewed-on: https://chromium-review.googlesource.com/1104789 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#568527}
-
Wez authored
This fixes the Fuchsia Debug build, which is failing due to the Ozone component missing the keycode-converter dependency. TBR: sergeyu, sky Change-Id: I23755129a2b44ad2e51bc35027ff12352be3eb7c Reviewed-on: https://chromium-review.googlesource.com/1106538Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#568526}
-
Xi Han authored
The test failure is due to NSApplication isn't set in extensions::TestShellMainDelegate. This CL also did a clean up of CL: https://crrev.com/c/1072387. Bug: 853172 Change-Id: Id42649427b659a2b97cd0236e0d1d4d815ba4158 Reviewed-on: https://chromium-review.googlesource.com/1105194Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#568525}
-
Boris Sazonov authored
This CL adds explicit @SuppressLint("MissingPermission") annotation to SystemAccountManagerDelegate calls that require permissions. Bug: 851932 Change-Id: I203cdb292daffdf44351268c9cd869615fbedaa7 Reviewed-on: https://chromium-review.googlesource.com/1097085Reviewed-by:Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#568524}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a1ea4276f87f..c765d2ac8676 git log a1ea4276f87f..c765d2ac8676 --date=short --no-merges --format='%ad %ae %s' 2018-06-19 vmiklos@collabora.co.uk Add FPDFText_GetMatrix() API 2018-06-19 art-snake@yandex-team.ru Use const pointers within GetDirectInteger function. Created with: gclient setdep -r src/third_party/pdfium@c765d2ac8676 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibd4c206a4321d4097081a7697f3db32238e16f0e Reviewed-on: https://chromium-review.googlesource.com/1106357Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568523}
-
Mike Klein authored
It does nothing. Change-Id: I9f170d43a18fe5e07032fd1f4a8e093a65992ee4 Reviewed-on: https://chromium-review.googlesource.com/1106003Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#568522}
-
Emily Hanley authored
Bug:713357 Change-Id: I559932e082f59f4dd918caca971d5e6eae688490 NOTRY=true # CQ flaky Change-Id: I559932e082f59f4dd918caca971d5e6eae688490 Reviewed-on: https://chromium-review.googlesource.com/1106041 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
-
Orin Jaworski authored
The new tab button ink drop needed a larger size than the default and overriding to pass bounds size corrected a rendering artifact on the highlight. Bug: 853700 Change-Id: Iff98f43049df3fa0c7142c3213707f423b6b1c14 Reviewed-on: https://chromium-review.googlesource.com/1105487 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#568520}
-
Sebastien Marchand authored
Bug: 773382 Change-Id: Ie7cbbf2c74bfbf1f1522b2a1f775a392545ad0a9 Reviewed-on: https://chromium-review.googlesource.com/1088196 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#568519}
-
Jordy Greenblatt authored
The "multidevice" settings-section is only suppose to appear when the Chrombook has a potential host. This information comes from a mojo call on that takes place further down the DOM tree than the basic-page element so the connected devices infrastructure must itself be able to detach any significant elements based on the results of the mojo call. By wrapping the entire multidevice settings-section element in a separate container element, we can make the container keep the entire section from the DOM without tinkering further up the tree. Change-Id: I766164a2d04ea42f77bb0c101a17c2e1eadad016 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1105185Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#568518}
-
Theresa authored
Update the incognito NTP background color to match the modern incognito toolbar color. Also update some text colors and remove the toolbar shadow when the incognito NTP is showing. A future CL will show the shadow on scroll. BUG=814881 Change-Id: I1995ec644781268ea1054a457dde0593d16fb0f9 Reviewed-on: https://chromium-review.googlesource.com/1105379Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#568517}
-
Kim Paulhamus authored
Bug: 678885 Change-Id: I52f8062a480c2657827dffda231382f48b2b6ef6 Reviewed-on: https://chromium-review.googlesource.com/1096536 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#568516}
-
Mitsuru Oshima authored
This can be nullptr and this is always checked against nullptr except this place. BUG=NONE TEST=covered by unit test Change-Id: Ie96065820a16dd14552a03d62ae7b06b4e2facb6 Reviewed-on: https://chromium-review.googlesource.com/1105698Reviewed-by:
-
Saman Sami authored
Also clean up the code and re-enable RenderWidgetHostViewGuestSurfaceTest.TestGuestSurface. Bug: 730193, 844469 Change-Id: I20f17fda6094b1ffb6bbb1482ccd14f6c20175ea Reviewed-on: https://chromium-review.googlesource.com/1104798 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#568514}
-
Ryan Hansberry authored
[Cros Multidevice] tether::HostScanScheduler: Remove restrictions on host scans if SecureChannel API is present. This conditionally (behind the chromeos::features::kMultiDeviceApi flag) removes the following restrictions introduced by the following CLs: 1) "Stop scans when device is locked": https://chromium-review.googlesource.com/c/chromium/src/+/940609 2) "Do not perform host scans while the device is locked": https://chromium-review.googlesource.com/c/chromium/src/+/1045254 3) "Delay host scans slightly after unlock": https://chromium-review.googlesource.com/c/chromium/src/+/941583 These restricitons were necessary because Tether and Smart Lock used different BLE comminication stacks. Now that the SecureChannel API is integrated into Tether (the BLE communication scheme that Tether and Smart Lock share), these restrictions are no longer necessary. Bug: 824568, 752273, 817554 Change-Id: Id63ba851c702502420ae42b99efcd5f18102aa34 Reviewed-on: https://chromium-review.googlesource.com/1105618Reviewed-by:
-
Mike Dougherty authored
The system touches need to be cancelled whenever the context menu is shown in order to prevent webview interaction after the context menu is displayed. Wait until the context menu element is available before determining if the element supports a displyed context menu. Bug: 853298 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I15bd7d4148f83646763504dd8370dce49e37dff3 Reviewed-on: https://chromium-review.googlesource.com/1104989 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#568512}
-
Clark DuVall authored
Bug: 789632 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Idbea61afbedd446993f01f5701a8f4ef484c5926 Reviewed-on: https://chromium-review.googlesource.com/1103188 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
Ella Ge authored
When zoom-for-dsf enabled, element_bound_in_document is in physical pixel; however, minReadableCaretHeight is hard-coded css pixel value. So we need to applied page zoom factor to the min caret height before calculate the new page scale. Bug: 848434 Change-Id: I3fe529032fbc380f4dc90a42a0fef532b79ba38b Reviewed-on: https://chromium-review.googlesource.com/1085559 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#568510}
-
