- 07 Aug, 2020 40 commits
-
-
Xida Chen authored
We are seeing half of FrameSequenceLength.Video reports length 0. What's the problem? It turns out that those half are from the main thread. A video frame is on impl thread only, so main thread gets 0 frames for a video tracker. This CL fixes it. Bug: 1112893 Change-Id: I0f6b41625ac2d781dc9c0599e0e8ad28c06a033d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342247Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#795949}
-
Mitsuru Oshima authored
* Add view metadata to HeaderView * WideFrameView's widget should always be opaque because it doesn't have a rounded corners. * fix typo in test name. Bug: None Change-Id: I80d5752cfba74a2cdcdd3a0e8cc197ee8a9f4bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336494Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#795948}
-
Maxime Charland authored
The font was previously changed in all illustrated empty states. The font change was also needed in Recent Tabs > Recently Closed. Because the TableViewDetailTextItem is used in multiple places in Bling, the font had to be changed only in Recent Tabs. Bug: 1098328 Change-Id: I047f7f53ed1d118a1efd7e3bda9671a8e482630b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342313Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Maxime Charland <mcharland@google.com> Cr-Commit-Position: refs/heads/master@{#795947}
-
Andrew Grieve authored
And fix a broken link. Change-Id: I96a2e13069e53da5545f3bd042a96057f7ba67e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331274 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#795946}
-
Scott Little authored
This CL removes usage of the |new| operator with std::unique_ptr in components/translate, either changing the call site to use std::make_unique, or refactoring the call site to not require a std::unique_ptr at all. Bug: 881807 Change-Id: I7d66f206bc9807e5188f22b58647901d720d3505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341177Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Auto-Submit: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#795945}
-
Friedrich Horschig authored
Even in RTL layouts, origins should remain in LTR layout. Bug: None. Change-Id: I5f928e1b2d0e82e3918c46c02d57361030e56ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339753Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#795944}
-
David Bokan authored
DocumentPolicy has been enabled in M86 so we want to ship the ForceLoadAtTop policy soon. This CL adds a web platform test to ensure its correct operation. Bug: 1047900 Change-Id: I127331aece02d5b23b77941f5cc2958c81a63315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342344Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#795943}
-
Xianzhu Wang authored
The only purpose of it was to group the overflow control layers. With it removed, we can make all GraphicsLayers collectable as GraphicsLayerDisplayItems. Change-Id: Ic37fa3a3902fa3bb493c2b78b15c1df5bd1f6b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341038Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#795942}
-
Andrew Grieve authored
Change-Id: I7376cc126cd0a9cee9953cc48a54df696c02a14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343145 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#795941}
-
Rune Lillesveen authored
See: https://github.com/chrishtr/battery-savings/blob/master/explainer.md Bug: 1114184 Change-Id: I6772febbb0a511f523aab1bc34b2368695d7cad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343105Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#795940}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/045adb564e19..3b08f35fd150 2020-08-07 mtklein@google.com deserialize SkFilterQuality safely If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I28dae663e286239da21c2f53284f516aa795fd4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343055Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795939}
-
Jaeyong Bae authored
The security indicator icon in the payment handler UI should match exactly the icon in the regular URL bar, for any given URL. Only if SSL certificate state is secure, the security indicator icon would be appear. Change-Id: Ic15b0f848ecdf326e5ad63704a28cf8d19416fd2 Bug: 1052493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302970 Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#795938}
-
Ulan Degenbaev authored
The move of V8PerFrameMemoryReporterImpl from content to blink introduced a bug where the PerFrameV8MemoryUsageData::associated_memory mojo map started to use WTF::HashMap as the backing, which makes key=0 invalid because the hash traits for int64_t reserve that value for the deleted sentinel. This CL also fixes another bug of dereferencing a non-existent entry in the |frames| HashMap. Additionally this CL adds a test for V8PerFrameMemoryReporterImpl to make sure that the fixes work. Bug: 1085129 Change-Id: I04b0b7230fde191571f407b4931d6dba543bd2d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339317 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#795937}
-
clamy authored
This CL adds a WPT test that checks the interaction of COOP same-origin-allow-popups with redirects. Bug: 1108292 Change-Id: I647025e635a7096d5f52d30c42b1dc4e0902535f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312796 Commit-Queue: Camille Lamy <clamy@chromium.org> Auto-Submit: Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#795936}
-
Trent Begin authored
When the Chrome OS browser starts up, pass a bound remote to the platform service cros_healthd. This allows the platform daemon to access the network telemetry information. Bug: chromium:1057739 Change-Id: I6084107e8a5364ed0698f521c5e47dbd26265b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323921 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795935}
-
Jose Dapena Paz authored
GCC fails to compile the Color getter in TextDecorationInfo, as it gets confused by different declarations in different namespaces: ../../third_party/blink/renderer/core/paint/text_decoration_info.h: At global scope: ../../third_party/blink/renderer/core/paint/text_decoration_info.h:76:9: error: declaration of ‘blink::Color blink::TextDecorationInfo::Color() const’ changes meaning of ‘Color’ [-fpermissive] 76 | Color Color() const; | ^~~~~ To avoid that, we rename the getter to be LineColor. Bug: 819294 Change-Id: I5b1a0d8a9c4580029ba8148281f9a3a514a88b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339487 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#795934}
-
Abigail Klein authored
When a user clicks on a character in the braille caption panel, it sends a routing event to the braille command listener and moves the cursor to the designated position. Chromevox. Click on a character in the panel to move the cursor to the desired position. AX-Relnotes: Added cursor routing to the braille caption panel in Change-Id: I28e10e17f81c9b0336842a2756263c9f5acb8df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333752Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#795933}
-
Tanmoy Mollik authored
This cl adds description strings for the sync error cards that will be used in ManageSyncSettings page. Bug: 1107420 Change-Id: I16c68378e6bc2fb4f8f35e4d1bdcaceb38c2f2eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332446Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#795932}
-
Nohemi Fernandez authored
Currently we add the CHROME_CONNECTED cookie only in the case where the user navigates to a Google domain or subdomain, however if cookies are removed outside of our control (as will be the case for ITP in iOS 14) we should instead make sure this works for all Google-owned domains that support Mirror. Bug: 1102794 Change-Id: I1394f73213b81d0921e75426cd9726c95ce993a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340045 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#795931}
-
rbpotter authored
This selector no longer works and Shadow DOM V0 is no longer supported. Since this has not been working for some time, removing these references should not change any behavior. Bug: 842602 Change-Id: I3f2cb9521a3e7c84238bf50ced9455d5b8606386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342116Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#795930}
-
Ewann authored
Disabled buttons are greyed out. This CL sets the button's property |userInteractionEnabled| to NO instead of disabling it. Bug: 1106673 Change-Id: I56d877a88cbb44313225ee5bfa76f73590883d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343073 Auto-Submit: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#795929}
-
Vladimir Levin authored
This patch ensures that if we blocked a graphics layer rebuild because of a display lock that we continue such a rebuild when the context is unlocked (or rather we ensure that we rebuild the graphics layer tree again). R=wangxianzhu@chromium.org, chrishtr@chromium.org Fixed: 1113838 Change-Id: I3b904f7c89c74c4d1a370b63382241c6729e1f3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342464 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#795928}
-
Sebastien Marchand authored
This adds a second voter to the Win system memory pressure evaluator that will base its vote on the OS Memory Pressure signals. This voter works in parallel to the default voter (based on heuristics) and so the pressure level will always be based on worst of these 2 signals. This code is behind a feature flag, some feature param will later be added to test some variations of this solution (e.g. only use the OS-signals based voter for the critical pressure notifications). Change-Id: I52fa235df42efcdf9f14d592de8e0dc1d91395e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321524Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#795927}
-
Eleonora Rocchi authored
This CL adds the subtitle to the header of Check Passwords. It also adds the tests to verify the correct subtitle is shown. Screenshots in the linked bug. Bug: 1109691, 1092444 Change-Id: I5b29cbed5f94b84610e96b5fe64815b18e8b0eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342850 Commit-Queue: Eleonora Rocchi <erocchi@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#795926}
-
Friedrich Horschig authored
With this CL, the deletion button triggers a confirmation dialog. Bug: 1108358, 1092444 Change-Id: I473cd9d7fe0f2037220ba5ae4b4fe4b28774ce3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339751Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#795925}
-
Robert Sesek authored
Users of ServiceWatcher and ServiceResolver can delete the objects while operations are still in-flight. The classes used to use base::Unretained, which then led to uses-after-free. Now, the reference-counted ObjC objects are used to appropriately manage the lifetimes. This also fixes an incorrect DCHECK, which assumed that -netServiceBrowser:didRemoveService:moreComing: would pass a NSNetService with pointer equality rather than -isEqual: equality. Local observations indicate that the system does not do that. Bug: 1098376 Change-Id: I337a14238f3bd5afbb9ed106e8d09d399b21c613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341359Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#795924}
-
Andrew Grieve authored
* Remove anchors for <application> since every manfiest change will cause it to change. * Use android:name to compute anchors when available since that will lead to stable anchors when attributes / children are changed. * Prevent self-closing tags for <service>, <activity>, etc. * Added test. Bug: 1064151 Change-Id: Ia0c242c713b58c6cb54556e6d0b82a559ad9858a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340644 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#795923}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b643d8d6. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I38e44441be0292306e5e920d34edec55a1bf1e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339940Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795922}
-
Vasilii Sukhanov authored
Tbr: sergeyu@chromium.org Bug: 810690 Change-Id: I657ab563616524df4280855cce7553c692d55a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343265Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#795921}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/27c7933767aa..69a10924bc97 2020-08-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I87fd6580834e066e1e1c8bd17165425a66971b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795920}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e69d5b2de943..56f14dabfe99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic6a6cd1c3e23502bf9935d0e32f086e44005a1fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342135Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795919}
-
Kevin Ellis authored
There are no restrictions on how quickly the client agent needs to respond to a pending play-state change. For non-composited animations the ready promise is resolved on commit of the animation frame; however, for a composited animation, the process is delayed until receiving a start-time notification from the compositor. The event dispatch test previously waited up to 2 animations frames, which is adequate for non-composited tests since the events trigger on the next frame. For composited tests, we need to first wait for the animation to be ready if in a pending state. Once the ready promise is resolved, a two frame time limit is sufficient for the remainder of the steps. Tested with 300 repetitions of the flaking tests in the virtual/threaded environment. Bug: 1064065 Change-Id: Ic4975d5885d3513c5c1b53d755757c0adcc027c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341803Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#795918}
-
Tina Wang authored
- Changed the UI to managed when the pref is managed by policy. - Added access to management page to the popup info bubble. Bug: 1093170 Change-Id: Id736435653af686a06948decf6537d2cb03010c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259554Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#795917}
-
Alice Wang authored
This CL changes the |Add account| to |Add account to device| on the account management screen for the project MICe. Bug: 1106656 Change-Id: I3a05a1bb5d3cfdf317eb93c0d6da7a7a79ccfd9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340974Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#795916}
-
housseindjirdeh authored
First pass in adding JavaScript framework detections to UKM. This patch creates a UKM and adds a loading behavior flag for when Next.js is detected on a page. UKM collection review doc: https://docs.google.com/document/d/1eatNgsHthqcSaocbevAslky0kb7WqGP4_DT9HorGAQc/edit?usp=sharing Bug: 1006274 Change-Id: I8e645b80d0a2cb5f569c3c413f76345ca75c7995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294392Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Houssein Djirdeh <houssein@chromium.org> Cr-Commit-Position: refs/heads/master@{#795915}
-
Eleonora Rocchi authored
passwords. This CL adds the illustration to the header of Check Passwords. It also adds the tests to verify the correct illustration is shown. Screenshots in the linked bug. Bug: 1109691, 1092444 Change-Id: Ib55745974464d195a32da1394c95c755aa67ec31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340920 Commit-Queue: Eleonora Rocchi <erocchi@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#795914}
-
Maciek Slusarczyk authored
A new type of token API is introduced to sync password between multiple ChromeOS devices. On a password change event createToken operation will invalidate the old token, create and fetch a new one. CrOS devices will monitor the state of a global token by sending verifyToken requests and, when local token copy will be identfied as invalid, initiate online re-auth flow to sync the credentials. This cl implements notifications to InSessionPasswordSyncManager object when online login has to be triggered. Bug: 1090341 Change-Id: I14407e37ad05cc7aaf697634fcd76f005a7613b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316106 Commit-Queue: Maciek Slusarczyk <mslus@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#795913}
-
Javier Ernesto Flores Robles authored
Adds IOS.NSString.stringByReplacingCharactersInRange.NilArgument histogram, to be used internally. See https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/3202590/ Bug: 942445 Change-Id: I8697b9b90367620dc21297cffdf523a72a44ecc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340921 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#795912}
-
sauski authored
To support delivery of HaTS Next surveys, a new web dialog is created which connects to the Hats Next Chrome specific website. The dialog responds to events provided by the survey for managing dialog lifetime. For example the survey dialog is only shown when the HaTS webpage has confirmed that the user is eligible for a survey. Bug: 1110888 Change-Id: I323c662e41331cab47f05424de53906169b42f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246695Reviewed-by:
Theodore Olsauskas-Warren <sauski@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#795911}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3c7f144a738e..fb03de538548 2020-08-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 5fd92a7e0c84 to 7b2dd11dda7a (4 revisions) 2020-08-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from c967a2ddf18b to 9ba1bc28d878 (20 revisions) 2020-08-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from be7c55a2a8ce to 59b4828f293e (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Ibce8777df6b8fe280f0b8d6aa977e00a0896d211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343045Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795910}
-