GitLab

Test times out on Windows debug bot.

Bug: 890372
Change-Id: Ib337d19167c8864612bf697b2adb420507c27e76
Tbr: cthomp@chromium.org, estark@chromium.org
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585536Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654574}

Currently, a MojoRenderer is directly used to pass through messages to
and from the FlingingRenderer (FR).

This CL adds the FlingingRendererClient (FRC), which serves almost
exactly the same purpose as a pass-through MojoRenderer. The difference
is that, the FRC implements the mojom::FlingingRendererClientExtension,
which allows the FR to send remote Play/Pause change events directly to
the FRC. This removes the need for the general mojom::RendererClient to
have a specialized OnRemotePlayStateChange().

A follow up CL will remove media::RendererClient::OnRemotePlayState().

Bug: 956677
Change-Id: Ia7484b54849991cfad8a78040d0e47ab156bc3e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526637
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654573}

https://skia.googlesource.com/skia.git/+log/a30cf84b47a8..ee90eb42fe4f


git log a30cf84b47a8..ee90eb42fe4f --date=short --no-merges --format='%ad %ae %s'
2019-04-26 jvanverth@google.com Clean out stale shadow vertices from the SkResourceCache
2019-04-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-04-26 jvanverth@google.com Merge MTLRenderPassDescriptors when possible.


Created with:
  gclient setdep -r src/third_party/skia@ee90eb42fe4f

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/130757982
TBR=mtklein@chromium.org

Change-Id: I44690326661a88916950d37e77e175ea740380a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584352Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#654572}

This CL shows how all of the Get*View methods in OobeUI can be
eliminated, which simplifies adding a step to OOBE.

TBR=rsorokin@chromium.org
TBR=xiyuan@chromium.org

Bug: 928555
Change-Id: Ia798d223ca07841a6ecfbc884bd8944465a0b844
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577947
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654571}

CompositorFrameReportingController is using DCHECK_NE to compare
several unique_ptr. This is valid in libc++, but on libstdc++ unique_ptr
does not have an ostream operator.

Change-Id: I9f23ef17f02b9e107694ba493f6f8f3caf5cac4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584292Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#654570}

Bug: 955226
Change-Id: I7b8aff177370702b5a9baaf1e0823a2fde7e15e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585060
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654569}

Movements greater than the movement threshold should cancel
autoclick with stabilization "off".

Bug: 957113
Change-Id: Ibce4a7f168241a16a169c5811692807556eb51bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584784Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654568}

Removed some now-unneeded Mac- and Linux-related test suite
exceptions. There are no changes to the generated waterfalls.

Bug: 833020
Change-Id: Ia76178134f60fd0c018ef84658d9f0f3ea4390ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585987
Auto-Submit: Kenneth Russell <kbr@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654567}

Enables JavaScript console logs being copied to the system log in all
XR instrumentation and browser tests. This used to be the default, but
was recently changed to be disabled by default for privacy reasons.

Bug: 956784
Change-Id: I2f417bea9149bddf168e342d4674524624628c19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585072
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654566}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bdbb453061f8..5557cd43e22e


Created with:
  gclient setdep -r src-internal@5557cd43e22e

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=andruud@chromium.org,alexmos@chromium.org,horo@chromium.org,adithyas@chromium.org

Change-Id: If9aea184ce794b98442a08ea6be875cc18805751
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584355Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#654565}

This change removes a double slide animation when the user flings to
dismiss a notification.

TEST=manually verified, new unit test
BUG=933640

Change-Id: I7f9f4e558dfa53e8acf0abdbd86cf4449c1ea891
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583344
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654564}

Bug: b/131183141
Change-Id: I4db5d99a42220319e98871903ec94c28e25cd628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582623Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654563}

Both WebContentsDelegate and WCO have DidChangeVisibleSecurityState
methods. The WCO method was previously only being called if there was
a delegate. This broke some unit testing scenarios in which we want to
exercise a WCO method but there is no delegate, and there's no reason
for the two to be tied together.

Change-Id: Icff39b26317ff9cf7c373cfba02ed1e66a231e0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579102
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654562}

Adds a string "attribution" to OfflineItem and a gfx::Image "custom_favicon" to
OfflineItemVisuals. Also adds a parameter "GetVisualsOptions" to
GetVisualsForItem to allow callers to specify which visuals they want if one or
more isn't needed.

Bug: 852872
Change-Id: I26ed0e6313ca91f40bd2bf80f8043b065c5262ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576006
Commit-Queue: Ian Wells <iwells@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654561}

TBR=meacer@chromium.org

Change-Id: Ifdd304ebc3258a9e8ae1a6061f035bab00517f49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585291
Commit-Queue: Krishna Govind <govind@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654560}

A quick README describing some of the quirks and gotchas of this
particular fuzzer, and providing a very high-level overview of how it
functions. Isn't meant to provide an introduction to fuzzing in general,
but links to further documentation available.

R=kylechar@chromium.org, riajiang@chromium.org

Bug: 923088
Change-Id: I1ca073906292216f9a92c1ecaf62e5da5d850815
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586236Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Auto-Submit: Céline O'Neil <celineo@google.com>
Cr-Commit-Position: refs/heads/master@{#654559}

Bug: 928390
Change-Id: If3ad1ee79805b328415c8fc5bd65a0f8516dad8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585143Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654558}

This CL adds Reporting "clients", i.e. endpoints and endpoint groups, to
the SQLitePersistentReportingAndNELStore. Endpoints and endpoint groups
are stored in their respective tables in the database. When loading
Reporting clients, both endpoints and endpoint groups are retrieved
and passed to the caller.

Bug: 895821
Change-Id: Ia609ea422f0fe5a5f7ddd6576aa70e56d81b0cc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560456
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654557}

This flag will change the bahvior of CloudReportingEnabled policy to not
use the extension anymore.

Bug: 956237
Change-Id: I52634abd5310d994615c852bb7b7dffe8dea7bde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584819
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654556}

The ErrorCallback in MediaStreamRendererFactory is not used outside of
one unit test, so remove it entirely.

R=avi@chromium.org, guidou@chromium.org
TBR=guidou@chromium.org

Bug: 953861
Change-Id: Ie6adade2cb73a4d57299a30589949f2eae984c8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585960
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654555}

- Set the PpdManufacturer of printer when PpdProvider fails to find
  the PpdReference for a USB printer.
- The manufacturer will now auto populate in the make/model dialog
  if we fail to configure a USB printer.
- Add unit tests to CupsPrintersManagersTest and PpdProviderTest
  to reflect this change.

Bug:932202
Test: manual end to end, CupsPrintersManagerTest, PpdProviderTest

Change-Id: I882decd0daa3180d3eaa99c4c5eb61ead5e01050
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566903
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654554}

We record two count histograms, one for tablet mode and one for clamshell mode.

TEST=verified in chrome://histograms
BUG=950407, 954431

Change-Id: If722880394f5a7a105ea8c6fcee8c1acae262b8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585243
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654553}

Bug: 955783
Change-Id: I4a09ea2a5797d3438b3ba79b6010c3f0fe680624
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580595Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#654552}

Also marks all GPU.FYI Mac bots as gpu-slow-bot,
for consistency with other platforms and ease of maintenance.

Bug: 908949
Change-Id: I90360c05f9917636ab5f403cc6c01a11f8758b1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584702
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654551}

We are observing in the field some cases where DWrite can't
initialize properly. They are related to these versions:

  6.1.7601 ?????
  6.1.7600 ?????

The GetSystemFontCollection method in the IDWriteFactory
interface fails with E_INVALIDARG.

This CL is adding a retry loop to see whether it's due to
a latency to connect to the windows fonts service.

Bug: 956064, 944227, 955031
Change-Id: I87c49fab384dbf849cb6faef6feee7b92c216507
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584429
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654550}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c6fbb279..457ad5c9

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I97eb2e5fefeebdc0b324b3f47754f07aa43b3868
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585815Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#654549}

AppMenuButton does not show the correct color in Focus Mode Window.
To fix this, we add TabStripModelObserver to WebAppBrowserController
class so that whenever we add/remove a tab, the WebContentsObserver
is able to watch the content change, and the browser frame theme
color could be consistent with the web contents' theme color.

We also update the frame color when web_content is added to browser
so that the AppMenuButton gets the right color.

Change-Id: If0161a789e622b0cd3c655ca457b9d8be98611c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579463
Commit-Queue: Yining Wang <yiningwang@google.com>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654548}

This is part of EG1 to EG2 migration, which involves moving EarlGrey code from
app-side helpers into test code. For GREYAsserts, the policy is to take assert-
containing-helpers, modify them to return NSError* with localizedDescription
containing the assert failure (in the event of a failure), and then assert
on the result of the helper on the test side.

I used a Python script to automatically find ChromeEarlGrey callsites in test
code.

Bug: 922813
Change-Id: I1fdf362e9a8691c1833d19990fe551e41056e858
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578018
Commit-Queue: ericale <ericale@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654547}

It is a regression issue. So it is necessary to have a test for this
scenario.

Test: ash_unittests
Bug: 941428
Change-Id: I62e3b5e943f94fa143bc2629bca4c4cb15e3b3a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585097Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654546}

Autofill assistant is crashing after being moved to DFM. The reason seems
to be resources cannot be loaded without initialization before accessing
the module.

This CL try to initialize the activity properly. There is also another
initialization after installation, without which a clean install of chrome
would crash. This is like an issue from Play Core, and this CL tries to
provide a walkaround.

Bug: b/131149231
Change-Id: I4f3fba3d958105467bf0240bd06d0330f19ec921
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582225
Commit-Queue: Hui Wu <wuandy@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654545}

ShelfContextMenuModel holds a raw pointer to ShelfItemDelegate.
If a delegate is deleted while a menu is being shown, selecting
a menu item will cause use-after-free.

A delegate might be deleted from 3 places:
- when a shelf item is removed (this is already handled correctly)
- when ShelfModel is destroyed on shutdown (does not seem to cause
  problems)
- when a delegate is replaced on an existing shelf item (handled
  in this CL).

Bug: 937507
Test: ShelfViewTest.ReplacingDelegateCancelsContextMenu
Change-Id: Iac551bbab7b97a863941c89ea5a056ddf330a910
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585016
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654544}

Currently the download::Client API asks the client after the download
has started and headers received about whether or not to continue the
download. This feature is not widely used and is complicating migrating
the API to become fully async.

# trivial changes to the download clients
TBR=peter@chromium.org,carlosk@chromium.org,aoldemeier@chromium.org

Bug: 956246
Change-Id: I470422030e00053d91ea460283aaaf156eec7870
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583101Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654543}

This CL moves constructing the WebLoadParams for search by image out
into their own separate class. This will be used in an upcoming CL to
immediately load the search-by-image search on startup from the search
widget.

Bug: 952939
Change-Id: I755dbd8190fe9d9cd08bbc9a4572afc9f2225a17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574058
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654542}

This implementation is only based on the amount of free memory and the
disk idle time for now, more signals will be added later as needed.

The signal isn't used yet, this only implement the logic to build it
and a follow-up CL will put this behind a feature and add some
histograms that will help evaluate the performance of this signal.

Bug: 771478

Change-Id: Ic850c878482eb8637ec614490666f72e6146701c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529267
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654541}

HeapListHashSet is deprecated in favor of HeapLinkedHashSet.

HeapLinkedHashSet's invalidate iterators when the container is
modified. It happens here that CoreProbeSink::Remove{{class_name}}
(which calls HeapLinkedHashSet<{{class_name}}>::erase) can be called
while iterating over probe_sink->{{class_name}}s(). Hence, a helper
function was added in order to perform the copy.

Note that having a helper function rather than the copy code inlined
helps with binary size matters.

R=jbroman@chromium.org
CC=​​blink-reviews-vendor@chromium.org

BUG=614112

Change-Id: I25692b867e0c32dc634b7d7f3a84877218082268
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584109Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#654540}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c62691b671a9..199182fd64c7


git log c62691b671a9..199182fd64c7 --date=short --no-merges --format='%ad %ae %s'
2019-04-26 tandrii@chromium.org git_cache: on upload, run "git gc" only if necessary.


Created with:
  gclient setdep -r src/third_party/depot_tools@199182fd64c7

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:943696
TBR=agable@chromium.org

Change-Id: Idc08c5befaacb9188fb25be77508bdcec55454f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586096Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#654539}

UserTiming is transistioning from L2 to L3. We want both the L2 and L3 features
and code paths covered by web tests during the transition. So we setup virtual
tests for L2 while enabling L3 as default in web tests.

Bug: 957097
Change-Id: Ia0fdb898441ee61f11e1c4c7fc4f4d474c82b588
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584423Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654538}

Bug: 956581
Change-Id: I16332fa1dd9c9f9282fb894308c199652fcfb540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584887Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654537}

This a new method to AppHooks for starting the system settings
observer. Related downstream CL is included in the bug.

Bug: 951850
Change-Id: If5f4f825a72a894dbe84c720403eba283c03e144
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584906
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654536}

UnlockManager used a confusing "waking up" notion throughout
the class, which conflated device suspension and whether or not
scanning was visibly in progress. This name has been improved to
"initial scan" for readability.

UnlockManager also incorrectly began this "initial scan" in its
constructor. This makes no sense without its public method which
begins a scan (SetRemoteDeviceLifeCycle) being called, and was
unnecessary, so it has been removed.

Finally, logs (mostly VERBOSE) have been added to help developers
better understand device state when debugging feedback reports .

Bug: 943761
Change-Id: Ia4d884e665aa5e49f6d421c45e65f699dacef786
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565780
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Auto-Submit: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654535}