- 14 Feb, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c663845357d0..149341bb048d Created with: gclient setdep -r src-internal@149341bb048d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I553a721a869ff1e15abb57577d9369a55632685e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057725Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741637}
-
Xianzhu Wang authored
Previously when we copy subsequences, we did everything to construct the paint chunks freshly. Now avoid most of the operations by copying data from the cached paint chunks. This also avoids callbacks into the DisplayItemClient in the cached paint chunks, to avoid security issue on under-invalidation of subsequences. Bug: 1050090 Change-Id: Ie6b7c0b1f24c63100d73b988f303faf09b75ae6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055596Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#741636}
-
Stephen Chenney authored
Image orientation was not correctly applied in base_rendering_context_2d, resulting in always oriented images sometimes drawn with the wrong source rect. This change fixes that. The image-orientation setting we respect always comes from the canvas into which the image is being drawn. This keeps the rules for which orientation to apply simple. As part of this change, orientation is added to StaticBitmapImage and used in the necessary cases to track the orientation of the source image. As part of this change, the code to correct an image source rect is moved to Image and callers updated. Bug: 1043790 Change-Id: I13d74b66cff912382f8f5efe0050eae6a0f283c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044050Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#741635}
-
Rainhard Findling authored
* Tests that the safety check is present in basic settings and in the settings menu if the privacy settings redesign flag is on, and absent if the flag is off. * This test has been moved from https://chromium-review.googlesource.com/c/chromium/src/+/1959036 to this CL to not prevent the first from landing. Bug: 1015841 Change-Id: Idea2368bdeeff5722eb0e0c9f82b5c09a9ad062c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044077 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#741634}
-
Dave Tapuska authored
The RenderFrameHostImpl implements this interface and will process calls when it is in fact the main frame. WebViewImpl attaches to this interface when the local main frame is attached. BUG=1046424 Change-Id: I41db5ba44cb50832dc1523e55ec7aed90d606cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044764 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#741633}
-
Jason Chase authored
In [1], we implemented a workaround to re-enable WebComponents V0 in headless, regardless if any valid origin trial tokens are present. That workaround has been merged to M80. In [2], we implemented a fix so that origin trials are properly supported in headless (that is intended for merge to M81). This CL removes the workaround, as it is no longer needed. It also implements a basic test to verify that trials are working in headless, and specifically the WebComponents V0 trial. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2039601 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2042382 Bug: 1049126 Change-Id: Ie118f2d53a535ff8cb8f9f1644b866298e57f036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042689Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#741632}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f9f999f5a2eb..348f07b40c2b git log f9f999f5a2eb..348f07b40c2b --date=short --first-parent --format='%ad %ae %s' 2020-02-14 amaiorano@google.com Fix unit test when ENABLE_RR_EMIT_PRINT_LOCATION is defined Created with: gclient setdep -r src/third_party/swiftshader@348f07b40c2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ifde9770700d6746b7435ae6fbe736c6af96d5d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057162Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741631}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I65c266c6c16e5d6123609a476f54252c8c9c2e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056525 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#741630}
-
Anastasia Helfinstein authored
Currently, calls to NavigationManager need to check if it has been initialized. Instead, avoid initializing any of Switch Access until the desktop node has been returned. TBR=dtseng@chromium.org Bug: None Change-Id: I579c2e6622bef831e55d38792c1e79c320a362dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049827Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#741629}
-
Tricia Crichton authored
Reland: After a test times out during a ChromeDriver command, trigger a Chrome crash and a minidump collection for troubleshooting. This is not available on tests connecting to a remote browser, or when running on Android. Added exception handing for the Page.crash request and a fix to detect when session_id has not yet been set. Bug: 1045241 Change-Id: I34c088d669d272bb3517d47826ef97d8c10a1ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055549Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#741628}
-
Robbie Gibson authored
This reverts commit fabf13a1. Reason for revert: Talked to ender@, and this is the wrong flag to use on iOS. We should use omnibox-on-focus-suggestions instead. Original change's description: > [iOS] Add flag for zero-suggest on NTP > > This extends the definition of kZeroSuggestionsOnNTP from > Desktop/Android to iOS. > > Bug: 1048193 > Change-Id: I593c8dfd287a20b7afb9b4041ce6c33abbb99c22 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036030 > Commit-Queue: Robbie Gibson <rkgibson@google.com> > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738183} TBR=stkhapugin@chromium.org,rkgibson@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1048193 Change-Id: I42b97ef1c5279a923a12d0fcff3c3bb81524ba17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057635Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#741627}
-
Meilin Wang authored
This is a reland of 75161d96 Original change's description: > assistant: Fix mic button doesn't work with fake gaia account. > > |Service| stores the current account info and later registered as a > session activation observer for this account, so that it can enable > listening when the session becomes active. Previously when the login > account was a fake gaia account, e.g. in Tast tests, we did not update > the stored account info with the latest primary account when requesting > access token. In this way, |Service| couldn't receive any session active > signals because it was not observing a valid account. > > Bug: b/147442943 > Test: run the service in signed-out mode and manually verified. > > Change-Id: Iaaef86303686291b419754505ead9b14cca0adbc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033642 > Commit-Queue: Meilin Wang <meilinw@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740818} Bug: b/147442943 Change-Id: Iad700a8dc8a2747619dd2fbe81a32e5cea6d5d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053284Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#741626}
-
Anastasia Helfinstein authored
This change is a pure refactor. TBR=akihiroota@chromium.org Bug: None Change-Id: Ibaea6dd273eadb4c49cd590be8744b1003502370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057156Reviewed-by:
-
Sangwoo Ko authored
This allows consumers to choose which alert state to use. Bug: 1004983 Change-Id: Icac5c3f658710acfcf1589e845451075f381f91c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056005 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#741624}
-
Aaron Leventhal authored
Bug: None Change-Id: Icaaa7fdc44ad65d0569e2cb412b3671ef70756ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047405Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#741623}
-
Tricia Crichton authored
For nontypeable input elements - where primary input is by means other than direct text input - ChromeDriver will set the value attribute directly rather than simulating keyboard events. Initially this applies to color input types, but others can be added easily. Bug: chromedriver:3352 Change-Id: I873e00d3616e1dfb3892595f15926453ced96ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986912Reviewed-by:
-
Moe Ahmadi authored
The GWS experiment stats are expected in the following format in suggest response: "google:experimentstats":[ { "2":"0:67", "4":10001 }, { "2":"46:67", "4":10001 }, ] and are to be encoded into the AQS match URL param in the following format expected by the Searchbox logging flow: aqs=[CLIENT_NAME].[ASSISTED_QUERY_INFO].[AVAILABLE_SUGGESTIONS].[EXPERIMENT_STATS].[EXPERIMENT_STATS_V2] For instance: aqs=chrome.3.35i39l6j69i59l2.198455216j1j15.10001:0,67j10001:46,67 Bug: 1044255 Change-Id: Ief567ffe1c1f513d30442d91f6c9c24748a89b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036556Reviewed-by:Marc Treib <treib@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#741621}
-
Chris Blume authored
Some platforms would prefer to raster in sRGB unless there is reason not to, such as content using a wide color gamut.t cl for This CL adds a setting to indicate the preference of using sRGB and short-circuits GetRasterColorSpace() to return sRGB instead. Bug: 955158 Change-Id: I5762851ffc7cf93a50e6d46eefebf8a652ee3e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045053 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#741620}
-
Maks Orlovich authored
This further centralizes the first-partiness check, and increases type safety by having the notion of 1st party be more consistently kept inside net::SiteForCookies (this helped find 2 bugs!) Bug: 577565 Change-Id: Ie11f8a0fc5a762318c3a0c0b818b488c4775374b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992264 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#741619}
-
Connor Clark authored
Bug: 10521119 Change-Id: Ib103c7a9e639a1f9f7eae00924b1d20872e06b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055398 Commit-Queue: Connor Clark <cjamcl@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#741618}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0bf716dac129..591a14bda6ae git log 0bf716dac129..591a14bda6ae --date=short --first-parent --format='%ad %ae %s' 2020-02-14 John.Emau@microsoft.com SoftDropdown: Remove workaround for DCHECK failure Created with: gclient setdep -r src/third_party/devtools-frontend/src@591a14bda6ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I436b846ae6df8dd2f1be6a5791dfa9c4f0e53b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057161Reviewed-by:
-
Eugene But authored
Breakscrumbs (feature which attaches steps to reproduce to crashlogs) relies on not_user_triggered="true" to filter out non-interesting events. Notable changes: - Add MobileNTPShowMostVisited metric to actions.xml (this is not a new metric, it's already logged on iOS, but was not part of xml) - Add not_user_triggered="true" to MobileNewTabOpened, MobileTabGridEntered, MobileTabGridExited, MobileTabSwitched, NewTabPage_ContentSuggestions_ArticlesUsage as all these metrics are triggered from the code without user involvement. Bug: 1046231 Change-Id: I12d97758f304426da7af1784f1f0126014baa600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057159 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#741616}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/15ef4a463092..3b3069e9b4a3 git log 15ef4a463092..3b3069e9b4a3 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 dproy@chromium.org [trace viewer] Fix a number of broken features under polyfill 2020-02-14 dproy@chromium.org [trace viewer] Fix keyboard navigation under polyfill 2020-02-14 dproy@chromium.org [trace viewer] Enable Webcomponents V0 Polyfill Created with: gclient setdep -r src/third_party/catapult@3b3069e9b4a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1036492 Tbr: skyostil@google.com Change-Id: I388fef6401ca9b4d9fb5750f69ebd91743626d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057628Reviewed-by:
-
nancy authored
BUG=1016159 Change-Id: I066b6e1273ffab397b917043363db19a66ac6802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049994Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#741614}
-
John Rummell authored
Due to problems on some bots failing to start PulseAudio and causing Chrome startup to hang, disabling audio output for media browser tests on Linux to avoid the hang. Bug: 986021,1023029,1026849,1035472,1049467 Test: modified browser_tests pass locally Change-Id: I29a996ee627bc4a5b93e5b8d6227dd7801998d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056760Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#741613}
-
Piotr Bialecki authored
Continuation of work started in https://crrev.com/c/2055587 ARCore session needs to be able to update its plane information in a way that is independent of whether plane detection is configured. This is needed to enable creating anchors out of hit test results, while still avoiding more costly step of extracting complete plane data from ARCore if it is not needed. Notable changes: - Only ArCorePlaneManager::Update() is non-const - all other public methods can be made const. - The Update() needs to be called in each frame if the ARCore session supports plane detection (note: this is distinct from WebXR's notion of plane detection, see code comments). - Minor change - ForEachArCorePlane now accepts the list over which it's supposed to iterate instead of relying on member variable. Step 2/3(?) - preparing for creating anchors from hit test results. Change-Id: I87a187947a5ff7638b805d99ed5e44de03263b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057092Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#741612}
-
Tricia Crichton authored
r1924789 added a retry loop while waiting for DevTools messages. This spammed users' logs with uninformative timeout reports. This CL suppresses those log messages and correctly reports the command timeout value when appropriate. Bug: chromedriver:3332 Change-Id: I4b123ccdb58fcdaa1364327a687cd624508d0f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052193Reviewed-by:
-
Scott Violet authored
This makes it so the runner passes --run-web-tests when running weblayer tests. The renderer then turns on test only features if this flag is present. content_shell also uses --run-web-tests, which is why I'm using the same here. BUG=1049426 TEST=none Change-Id: If7882840a6f805677189c13dd99ac099cad952b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055562Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#741610}
-
Charlie Hu authored
This CL separates DocumentPolicyFeature enum from FeaturePolicyFeature enum, which makes DocumentPolicy and FeaturePolicy independent to each other. Previous test on document policy and feature policy coexist is removed. Follow-up CL will replace all usage of migrated features, i.e. font display and unoptimized-lossless-images so that current wpt tests on document policy still pass. Bug: 993790 Change-Id: I730b95efd013c25d97c2d24dd777e12b7b38bbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028666 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
-
David Tseng authored
The panel runs in a separate page context than the background page, so some js objects like UserAnnotationHandler or ChromeVoxState, which are initialized by the Background class, are never initialized. This leads to indirect bugs from directly required classes such as Output which directly depend on ChromeVoxState or UserAnnotationHandler. For a fix, this change initializes these singletons. Note the divergent styles in which they do so due to the way they were initially written. For reference, not doing this initialization causes errors like: TypeError: Cannot read property 'enabled' of undefined at Function.getAnnotationForNode (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxPanelScript.js:1113:101) at Output.<anonymous> (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxPanelScript.js:1190:489) at Array.forEach (<anonymous>) at Output.format_ (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxPanelScript.js:1182:8) at Output.node_ (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxPanelScript.js:1263:30) at Output.<anonymous> (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxPanelScript.js:1243:6) at Output.range_ (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxPanelScript.js:1247:228) at Output.render_ (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxPanelScript.js:1179:83) at Output.withSpeech (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxPanelScript.js:1140:104) at PanelNodeMenu.findMoreNodes_ (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVoxPanelScript.js:1436:118) Change-Id: Id867f585dededc77a56f0332aba8ea1bd4ebb06a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055415 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#741608}
-
Etienne Bergeron authored
Accept the src_func and src_file for the ScopedAllow events. Follow-up on this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2031440 R=gab@chromium.org, oysteine@chromium.org Bug: 1047794 Change-Id: I0d00ad7121dbc9e7d464fe3b2c915951b77f0699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057287Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#741607}
-
Etienne Bergeron authored
On Windows, ShapeRuns(...) is shaping the text by trying: PrimaryFont GetFontFallback(...) : using DWrite GetFontFallbacks(...) : using registry keys (Font Linking) The GetFontFallbacks function is deprecated and should be remove. There is still a long tail of cases that succeed only with the use of that mechanism. This CL is making these cases to be reported as a crash to be analyzed before removing the code. The goal is to avoid breaking the text rendering even for a small population. R=robliao@chromium.org Bug: 995789 Change-Id: I381753ed3985779cd34dae58a34f523c2f215c9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049126Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#741606}
-
Vasiliy Telezhnikov authored
This CL limits the use of shortcut for recreating SkSurfaceCharacterization to resize case. If anything else was changed we will request new characterization from gpu thread. For mergability this change keeps the old code on Linux. This CL also adds ForceReshapeOnNextDraw() to viz::Display so platforms can force reshape in cases if something changed outside of size and formats. WebView uses it to force reshape and get new characterization in case of fbo id changed between zero and non-zero. Bug: 1052115, 1051527 Change-Id: I2ec4a7d2ca5c6dc6cdf896a679ada26f5be2a9e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055348Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#741605}
-
Sigurdur Asgeirsson authored
This will surface these values in a structured way on the crash backend, obviating the need for a debugger. Bug: 1003391 Change-Id: Ib8c1868babd4b3c01600bcb05d861a1f15875478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055543 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#741604}
-
Matt Wolenetz authored
These 3 metrics' data will hopefully help us reduce the frequency of fuzzing timeouts. Earlier data showed good promise. Reactivating these (which had just expired a few days ago) to resume data collection to assist eventual improvement (via https://crbug.com/907268). BUG=1037604,907268 Change-Id: I0e97abb39b0106c57898a12f1ba71724265e4fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051166Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#741603}
-
Nick Diego Yamane authored
After crrev.com/c/2022280, logic for coalescing XEvents has been moved to ui::X11Window [1], there are cases where translating coalesced XEvent results in ET_UNKNOWN events. Before migrating away from PlatformEvent based ui::*Event ctors to XEvent translation helper functions, handling such cases was a matter of checking its ::type() value, now translation functions return nullptr instead, so update this checking accordingly. [1] https://crrev.com/c/2022280/18/ui/base/x/x11_window.cc#b1196 R=thomasanderson@chromium.org Bug: 1052293, 1052301 Test: Run with ozone/x11 backend, scroll, browser should not crashed Change-Id: Icf415ce72e679f39598f9d72ad098d56217e21da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057072 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#741602}
-
Nic Champagne Williamson authored
Currently, the HOVERED and PRESSED states of toolbar buttons will return the same as the default normal state. However, when a theme is applied that sets a different COLOR_TOOLBAR_BUTTON_ICON value, these default HOVERED and PRESSED states are wrong. This change makes the HOVERED and PRESSED states return the current normal state, rather than the default. Bug: 1050960 Change-Id: Id46cd5e711625070737344d3d34f9540fba7d9e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050827 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#741601}
-
Victor Costan authored
This CL removes the feature flag gating IndexedDB large value wrapping. The feature will be rolled out using Chrome's standard waterfall release model. Bug: 844782 Change-Id: Ie33675293a1c592c8731ab380ae9c55674ee6ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056863 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#741600}
-
Nick Harper authored
ProofVerifierChromium will reject certificates that don't chain to a known root unless the hostname matches one specified in --origin_to_force_quic_on. That flag also allows a wildcard "*" to force QUIC on for all origins, but that wasn't handled in ProofVerifierChromium. Now it is. Change-Id: I9576bcfbb14aac8956a81731d35190062e469b23 Bug: b/144497826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048034Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#741599}
-
Elly Fong-Jones authored
* In PlatformVerificationDialog, a lambda now wraps all three callbacks to pass the needed response codes, and the overrides are removed * In ToastDialogView, the dismiss callback is used directly as the DialogDelegate close callback, and the ::Close override is removed * In EchoDialogView, the listener is used directly as a receiver for the success callbacks. The contract of the listener is "it receives zero or more calls to OnMoreInfoLinkClicked, then exactly one call to either OnCancel or OnAccept", which fits neatly into the DialogDelegate model, since the cancel/accept callbacks can only be run when the dialog is already closing (and therefore no more button presses can be delivered). * In RequestPinView, a dead override of ::Cancel is removed; the default ::Cancel just returns true already. Bug: 1011446 Change-Id: I5b7489799327d497f9e6f948620a0e0918680d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044133Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#741598}
-
