GitLab

Targets that depend on //net:test_support should be able to use
//net/data with no additional configuration.

BUG=

Review-Url: https://codereview.chromium.org/2065313002
Cr-Commit-Position: refs/heads/master@{#400684}

The method took a const reference for a PasswordForm, but never used it.
Instead it hard-coded using pending_credentials_, which was passed as the
argument all the times anyway. This CL changes the function to use its
argument, changes the argument from a const ref to a non-const pointer to allow
modification, and moves the function to the anonymous namespace, because it
does not need any state of PasswordFormManager.

R=kolos@chromium.org

BUG=621355

Review-Url: https://codereview.chromium.org/2086483002
Cr-Commit-Position: refs/heads/master@{#400683}

BUG=618311

Review-Url: https://codereview.chromium.org/2049543003
Cr-Commit-Position: refs/heads/master@{#400682}

Possible outputs are:
- "none"
- "1 app (<example>)"
- "2 apps (<example 1>, <example 2>)"
- "X apps (<example 1>, <example 2>, and X-2 more)"

Since this is rather complex, also add a unittest.

BUG=510028

Review-Url: https://codereview.chromium.org/2080283002
Cr-Commit-Position: refs/heads/master@{#400681}

metadata are updated and not just on OnComplete(). Keeping the OnComplete()
logging intact for a few more relaeses and will phase them out eventually.
BUG=611813

Review-Url: https://codereview.chromium.org/2034223002
Cr-Commit-Position: refs/heads/master@{#400680}

Revert of Make the notification builder more XPC friendly (patchset #6 id:100001 of https://codereview.chromium.org/2053613002/ )

Reason for revert:
Broke compilation on Mac https://build.chromium.org/p/chromium/builders/Mac/builds/16903/steps/compile/logs/stdio

../../chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm:11:10: fatal error: 'chrome/grit/generated_resources.h' file not found
#include "chrome/grit/generated_resources.h"

Original issue's description:
> Make the notification builder more XPC friendly
>
> Move it to ui/cocoa/notifications where the xpc service will eventually live.
> Make it a static library so it can be linked by both the app and the XPC.
> Make sure the build operation only uses information from the underlying
> dictionary.
>
> BUG=571056
>
> Committed: https://crrev.com/aafb03bf0df164a2fb86db117ae6053e9578c437
> Cr-Commit-Position: refs/heads/master@{#400672}

TBR=jochen@chromium.org,peter@chromium.org,rsesek@chromium.org,miguelg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=571056

Review-Url: https://codereview.chromium.org/2080733002
Cr-Commit-Position: refs/heads/master@{#400679}

BUG=619103
TBR=wangxianzhu@chromium.org,chrishtr@chromium.org

Review URL: https://codereview.chromium.org/2085503002 .

Cr-Commit-Position: refs/heads/master@{#400678}

Previously, the fill-on-account-select experiment in the password
manager had used a custom flag and Finch to manage the experiment. This
updates the experiment to use the Features API which handles all of that
automagically.

Note: This is an updated copy of jww's
https://codereview.chromium.org/2066703004/. Patch set 1 is equal to the
approved patch set 3 of that CL, and patch set 2 here addresses jochen@'s
comment from that CL.

BUG=568713
TBR=jww@chromium.org, jochen@chromium.org

Review-Url: https://codereview.chromium.org/2080263002
Cr-Commit-Position: refs/heads/master@{#400677}

Old warning suppressions are kept in proguard.flags file without anyone
caring about them. It seems like removing them has absolutely no effect.

BUG=619937

Review-Url: https://codereview.chromium.org/2069213002
Cr-Commit-Position: refs/heads/master@{#400676}

Convert clients to the sk_sp-based SkTypeface API

R=reed@google.com,bungeman@chromium.org
BUG=skia:5077
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2066323002
Cr-Commit-Position: refs/heads/master@{#400675}

As discussed in https://codereview.chromium.org/2053693002#msg22: HSTS is
an HTTP feature, not generally applicable to URLRequests. It makes sense
to move processing out of URLRequest, and into URLRequestHttpJob (where
the work was actually being done anyway).

This patch refactors the implementation a bit, and moves it over to the
latter class.

R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2079783002
Cr-Commit-Position: refs/heads/master@{#400674}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d604cd94..62740faa

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2081693002
Cr-Commit-Position: refs/heads/master@{#400673}

Move it to ui/cocoa/notifications where the xpc service will eventually live.
Make it a static library so it can be linked by both the app and the XPC.
Make sure the build operation only uses information from the underlying
dictionary.

BUG=571056

Review-Url: https://codereview.chromium.org/2053613002
Cr-Commit-Position: refs/heads/master@{#400672}

BUG=566121

Review-Url: https://codereview.chromium.org/2064903003
Cr-Commit-Position: refs/heads/master@{#400671}

Revert of Update Zlib to version 1.2.8 (patchset #10 id:220001 of https://codereview.chromium.org/1955383002/ )

Reason for revert:
Broke the Windows Debug GPU FYI builder:

https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Win%20Builder%20%28dbg%29/builds/41421

fx_zlib.gzlib.obj : error LNK2005: _gzopen_w already defined in zlib.gzlib.obj

initial\chrome.dll : fatal error LNK1169: one or more multiply defined symbols found

Possibly because they use shared components with a GYP build.

Original issue's description:
> Update Zlib to version 1.2.8
>
> merge the latest open source zlib into chromium external projects
>
>  Version 1.2.8 fixes a very rare bug in decompression. All users are encouraged to upgrade immediately. Version 1.2.8 also has these improvements:
>     - Add new inflateGetDictionary() function
>     - Fix bug where gzopen() immediately followed by gzclose() would write an empty file instead of an empty gzip stream.
>     - Fix bug in gzclose() when gzwrite() runs out of memory
>     Version 1.2.7 has many portability improvements over 1.2.6, and has these enhancements:
>     - Fix bug in gzclose_w() when gzwrite() fails to allocate memory
>     - Add "x" (O_EXCL) and "e" (O_CLOEXEC) modes support to gzopen()
>     - Add gzopen_w() in Windows for wide character path names
>     - Fix type mismatch between get_crc_table() and crc_table
>     Version 1.2.6 has many changes over 1.2.5, including these improvements:
>     - gzread() can now read a file that is being written concurrently
>     - gzgetc() is now a macro for increased speed
>     - Added a 'T' option to gzopen() for transparent writing (no compression)
>     - Added deflatePending() to return the amount of pending output
>     - Allow deflateSetDictionary() and inflateSetDictionary() at any time in raw mode
>     - deflatePrime() can now insert bits in the middle of the stream
>     - ./configure now creates a configure.log file with all of the results
>     - Added a ./configure --solo option to compile zlib with no dependency on any libraries
>     - Fixed a problem with large file support macros
>     - Fixed a bug in contrib/puff
>     - Many portability improvements
>
> BUG=610615
> R=agl@chromium.org
> R=gavinp@chromium.org
>
> Committed: https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883
> Cr-Commit-Position: refs/heads/master@{#400647}

TBR=agl@chromium.org,gavinp@chromium.org,khasim.mohammed@linaro.org,jiadong.zhu@linaro.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=610615

Review-Url: https://codereview.chromium.org/2079313002
Cr-Commit-Position: refs/heads/master@{#400670}

Converts ios_web_shell target to use Automatic Reference Counting.

BUG=None

Review-Url: https://codereview.chromium.org/2073753003
Cr-Commit-Position: refs/heads/master@{#400669}

This prevents a publisher name in a RTL/LTR language from messing up the formatting on a device set to a LTR/RTL language.

BUG=608680

Review-Url: https://codereview.chromium.org/2064753006
Cr-Commit-Position: refs/heads/master@{#400668}

At the start of the story set, open the browsers associated with all
stories. This makes sure that, when taking memory dumps, we always get
a dump for all browsers all the time.

BUG=616043

Review-Url: https://codereview.chromium.org/2073713003
Cr-Commit-Position: refs/heads/master@{#400667}

BUG=597273

TEST=InkDropHostViewTest.*
TEST=FloodFillInkDropRipple.MaxDistanceToCorners

Review-Url: https://codereview.chromium.org/2042073002
Cr-Commit-Position: refs/heads/master@{#400666}

- Do not re-save to disk if new metadata is the same as the old.

- Add stats to determine where saveState is spending most of its
  time.

- Move to using uptimeMillis to avoid stats being influenced by time
  spent in sleep.

BUG=612574

Review-Url: https://codereview.chromium.org/2057733002
Cr-Commit-Position: refs/heads/master@{#400665}

- Move responsibility of application context initialization in
  AwBrowserProcess to caller to prevent double initialization.

- Switch to using ContextUtils.getApplicationContext for methods that
  only need the application context. Ensures the wrapped context is
  always used.

- Move away from using mWebViewDelegate.getApplication as that
  returns the raw unwrapped application object.

BUG=620790

Review-Url: https://codereview.chromium.org/2076623002
Cr-Commit-Position: refs/heads/master@{#400664}

Fix for: https://codereview.chromium.org/1950033002/

Adding initial remote characteristic implementation on OS X, with only the basic methods (e.g. GetUUID) implemented.
Characteristic discovery also implemented in BluetoothRemoteGattServiceMac.

BUG=609064

Review-Url: https://codereview.chromium.org/2071323002
Cr-Commit-Position: refs/heads/master@{#400663}

BUG=621460, 621466, 621488
TBR=reillyg
NOTRY=true

Review-Url: https://codereview.chromium.org/2084533002
Cr-Commit-Position: refs/heads/master@{#400662}

We no longer need this hidden value.  peria@ once removed this hidden
value at https://crrev.com/1836193002 .  This is the same.

BUG=

Review-Url: https://codereview.chromium.org/2079243002
Cr-Commit-Position: refs/heads/master@{#400661}

Use HttpServerProperties* instead of WeakPtr<HttpServerProperties> everywhere
outside HttpServerProperties and its derived classes.

In production, IOThread (or IOSChromeIOThread) outlives everything that would
reference HttpServerProperties, so there are no lifetime issues.

As for tests, this CL ensures that in test base classes that own both an
HttpServerPropertiesImpl and an HttpNetworkSession instance, the former outlives
the latter.

BUG=508548

Review-Url: https://codereview.chromium.org/2041863002
Cr-Commit-Position: refs/heads/master@{#400660}

Reland of [Android] Ensure perf test runner does not create shards for blacklisted devices. (patchset #1 id:1 of https://codereview.chromium.org/2059253002/ )

Reason for revert:
CL wasn't responsible for the v8 breakage

Original issue's description:
> Revert of [Android] Ensure perf test runner does not create shards for blacklisted devices. (patchset #4 id:60001 of https://codereview.chromium.org/2039363002/ )
>
> Reason for revert:
> Possibly breaking v8 perf bots.
>
> Original issue's description:
> > [Android] Ensure perf test runner does not create shards for blacklisted devices.
> >
> > BUG=617559
> >
> > Committed: https://crrev.com/15c70d1120b419bc68a484d8ecce5773433466f0
> > Cr-Commit-Position: refs/heads/master@{#398197}
>
> TBR=jbudorick@chromium.org,perezju@chromium.org,mikecase@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=617559
>
> Committed: https://crrev.com/c89b1748ad3fee34318dd63b32e881a7361743ce
> Cr-Commit-Position: refs/heads/master@{#399460}

TBR=jbudorick@chromium.org,mikecase@chromium.org,rnephew@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=617559

Review-Url: https://codereview.chromium.org/2084493003
Cr-Commit-Position: refs/heads/master@{#400659}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/502f2a65..d604cd94

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2083513002
Cr-Commit-Position: refs/heads/master@{#400658}

Cleaning up video-dom* tests in media/track
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Review-Url: https://codereview.chromium.org/2079203002
Cr-Commit-Position: refs/heads/master@{#400657}

Doing it as it did with string substitution is brittle, since it forced
assumptions about the JSON being generated out of the BuildRequest()
function and into its callers and GetHostRestricts().

When we're generating different types of requests, it will be easier to
understand what e.g. "obfuscated_gaia_id" is if it's always the ID, and
never a partial string of JSON.

Expose the BuildRequest() function to tests and test it.

BUG=621090

Review-Url: https://codereview.chromium.org/2077973002
Cr-Commit-Position: refs/heads/master@{#400656}

BUG=613678

Review-Url: https://codereview.chromium.org/2078353002
Cr-Commit-Position: refs/heads/master@{#400655}

Revert of MD Settings: ... and we fixed all CHECK()-based URL crashes once and for all. (patchset #3 id:40001 of https://codereview.chromium.org/2076083003/ )

Reason for revert:
New test is failing on DrMemory :(

First failing build:
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Browser%20%28DrMemory%20full%29%20%281%29/builds/3504

Sample test output:
MdSettingsBrowserTest.BackForwardDoesntCrash:
Did not complete.

Original issue's description:
> MD Settings: ... and we fixed all CHECK()-based URL crashes once and for all.
>
> But...
>
> ONCE AND FOR ALL!
>
> BUG=620370
> R=groby@chromium.org
>
> Committed: https://crrev.com/b8e015295703f0f5689688a99c5d232b89db9325
> Cr-Commit-Position: refs/heads/master@{#400528}

TBR=groby@chromium.org,michaelpg@chromium.org,dbeam@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=620370

Review-Url: https://codereview.chromium.org/2082563002
Cr-Commit-Position: refs/heads/master@{#400654}

Add detection of trace() calls over smart pointer types that either do not
wrap up references to heap objects, or are otherwise not meant to be traced
over. In particular, CrossThread(Weak)Persistent<T> fields are now detected
as being illegal to trace over. Also consider OwnPtr<T>, RefPtr<T> and
std::unique_ptr<T> as illegal to trace over & emit a more concise error
messages for these.

R=
BUG=619149

Committed: https://crrev.com/3ba6089cd6a901b62ff5a0d8f08a2bd818edcbe8
Review-Url: https://codereview.chromium.org/2060553002
Cr-Original-Commit-Position: refs/heads/master@{#399861}
Cr-Commit-Position: refs/heads/master@{#400653}

This test should be deleted at https://codereview.chromium.org/2076933002

BUG=531990

Review-Url: https://codereview.chromium.org/2071133004
Cr-Commit-Position: refs/heads/master@{#400652}

Also clean up the existing tests a bit

BUG=605870

Review-Url: https://codereview.chromium.org/2079833002
Cr-Commit-Position: refs/heads/master@{#400651}

BUG=614935

Review-Url: https://codereview.chromium.org/2072173003
Cr-Commit-Position: refs/heads/master@{#400650}

BUG=webrtc:5682

Review-Url: https://codereview.chromium.org/2068703002
Cr-Commit-Position: refs/heads/master@{#400649}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/cfa49712..502f2a65

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2080193002
Cr-Commit-Position: refs/heads/master@{#400648}

merge the latest open source zlib into chromium external projects

 Version 1.2.8 fixes a very rare bug in decompression. All users are encouraged to upgrade immediately. Version 1.2.8 also has these improvements:
    - Add new inflateGetDictionary() function
    - Fix bug where gzopen() immediately followed by gzclose() would write an empty file instead of an empty gzip stream.
    - Fix bug in gzclose() when gzwrite() runs out of memory
    Version 1.2.7 has many portability improvements over 1.2.6, and has these enhancements:
    - Fix bug in gzclose_w() when gzwrite() fails to allocate memory
    - Add "x" (O_EXCL) and "e" (O_CLOEXEC) modes support to gzopen()
    - Add gzopen_w() in Windows for wide character path names
    - Fix type mismatch between get_crc_table() and crc_table
    Version 1.2.6 has many changes over 1.2.5, including these improvements:
    - gzread() can now read a file that is being written concurrently
    - gzgetc() is now a macro for increased speed
    - Added a 'T' option to gzopen() for transparent writing (no compression)
    - Added deflatePending() to return the amount of pending output
    - Allow deflateSetDictionary() and inflateSetDictionary() at any time in raw mode
    - deflatePrime() can now insert bits in the middle of the stream
    - ./configure now creates a configure.log file with all of the results
    - Added a ./configure --solo option to compile zlib with no dependency on any libraries
    - Fixed a problem with large file support macros
    - Fixed a bug in contrib/puff
    - Many portability improvements

BUG=610615
R=agl@chromium.org
R=gavinp@chromium.org

Review-Url: https://codereview.chromium.org/1955383002
Cr-Commit-Position: refs/heads/master@{#400647}

This reverts commit 6a85b3b9.

Cr-Commit-Position: refs/heads/master@{#400646}

Reland of Check DisplayItemCient aliveness in cached subsequences (patchset #1 id:1 of https://codereview.chromium.org/2078393003/ )

Reason for revert:
It was not acceptable to revert the OwnPtr removal
patch just for this revert.

Relanding this to land OwnPtr commit again.

Original issue's description:
> Revert of Check DisplayItemCient aliveness in cached subsequences (patchset #6 id:100001 of https://codereview.chromium.org/2066603005/ )
>
> Reason for revert:
> Based on r400605 that is to be reverted.
>
> Original issue's description:
> > Check DisplayItemCient aliveness in cached subsequences
> >
> > BUG=609218
> >
> > Committed: https://crrev.com/127e5fadca5f431a5de1bef939f7f43aec1d136f
> > Cr-Commit-Position: refs/heads/master@{#400607}
>
> TBR=chrishtr@chromium.org,wangxianzhu@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=609218
>
> Committed: https://chromium.googlesource.com/chromium/src/+/6ece4aaeb5e2c53eca2617d42de64ff917cee884

TBR=chrishtr@chromium.org,wangxianzhu@chromium.org,vasilii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=609218

Review-Url: https://codereview.chromium.org/2082553002
Cr-Commit-Position: refs/heads/master@{#400645}