- 15 Feb, 2019 40 commits
-
-
Orin Jaworski authored
This CL adds a feature flag to experiment with unbolding suggestion text in the omnibox. Bug: 931332 Change-Id: I7ef5ced1a1e86f46e37e1695c7b3d20558e58b3c Reviewed-on: https://chromium-review.googlesource.com/c/1475746Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#632742}
-
Alex Clarke authored
This allows us to construct a SequenceManager and vend task queues before launching a thread. This should be useful in blink for launching workers (which currently have a worker scheduler on top of a MessageLoop), if we need an IO Thread scheduler (it looks like we might the IO thread is congested during startup) and for the BrowserThreadTest with a BrowserUIThreadScheduler. The message_pump_factory_ was added to base::Thread to support these two use cases: https://cs.chromium.org/search/?q=message_pump_factory&type=cs Bug: 863341, 872372 Change-Id: Ic30052e8af4a9351467792e70b7d7b65027d8a9a Reviewed-on: https://chromium-review.googlesource.com/c/1462801 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Auto-Submit: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#632741}
-
John Abd-El-Malek authored
Bug: 930941 Change-Id: I53a45cd823e2c2efaa8cc246dff92be12b2293c3 Reviewed-on: https://chromium-review.googlesource.com/c/1471241 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#632740}
-
kylechar authored
TaskRunner::PostTask() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=sandersd@chromium.org Bug: 714018 Change-Id: Ie4957f7669b72f804505f85e1bb8a71a63918441 Reviewed-on: https://chromium-review.googlesource.com/c/1475641 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#632739}
-
Stuart Langley authored
Most drive metrics will be obsolete once DriveFS ships, so set their expiry to M75 and take ownership. Set offline to the end of the year so we can re-evaluate then. WebstoreWidgetApp emitting code has already been removed so just mark them as obsolete. Bug: 931519 Change-Id: I6a545c2335e0a5f3f9ad3b480fce01f091d206a0 Reviewed-on: https://chromium-review.googlesource.com/c/1475133Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#632738}
-
Tommy C. Li authored
Sets the unfocused omnibox background to the same color as the results popup, which is conventionally white. Also enables the location bar border stroke in this mode, which already exists for high contrast mode. Bug: 931836 Change-Id: I97e0a5c768c739f4f037d9e3abdb99115b14999d Reviewed-on: https://chromium-review.googlesource.com/c/1474281Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Auto-Submit: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#632737}
-
iOS Autoroller authored
TBR=smut Change-Id: Ie63a87a644a29d45c4ef5c4b06e6383908db756a Reviewed-on: https://chromium-review.googlesource.com/c/1474466Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#632736}
-
kylechar authored
TaskRunner::PostTask() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=yuweih@chromium.org Bug: 714018 Change-Id: I5d3dabe31b239acb3e4ba6db7527fda5a3cd5f4a Reviewed-on: https://chromium-review.googlesource.com/c/1475635 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#632735}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/28bafb01c90c..1b85323f10e7 git log 28bafb01c90c..1b85323f10e7 --date=short --no-merges --format='%ad %ae %s' 2019-02-15 halcanary@google.com ICU: enable on wasm 2019-02-15 robertphillips@google.com Remove GrContextPriv.h from GrRenderTargetContext.h 2019-02-15 herb@google.com Reland "Use bulk interface for paths" 2019-02-15 halcanary@google.com SkPDF: simplify subsetting code 2019-02-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src b698b62f..5862f084 (425 commits) 2019-02-15 herb@google.com Revert "Use bulk interface for paths" 2019-02-15 brianosman@google.com Add curve visualization back, guard eval 2019-02-15 herb@google.com Revert "Calculate strike in path case" Created with: gclient setdep -r src/third_party/skia@1b85323f10e7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I2b3ce4c382b09bf1f3b266acf2a5338845d1d54c Reviewed-on: https://chromium-review.googlesource.com/c/1475700Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632734}
-
Elly Fong-Jones authored
This change assigns: enable-navigation-tracing trace-upload-url to tracing@ and marks them to expire in M80. Bug: None Change-Id: Ie28496728d26409ca979a08d2a33db9999c143c9 Reviewed-on: https://chromium-review.googlesource.com/c/1475808 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#632733}
-
kylechar authored
TaskRunner::PostTask() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=jamescook@chromium.org Bug: 714018 Change-Id: I58e7176c3d3a4544593f14ba4f170379f291aedd Reviewed-on: https://chromium-review.googlesource.com/c/1475732 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#632732}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/798bb03c8950..5212cf739dd8 git log 798bb03c8950..5212cf739dd8 --date=short --no-merges --format='%ad %ae %s' 2019-02-15 simonhatch@chromium.org Dashboard - Blacklist last_alerted_revision on TestMetadata migration Created with: gclient setdep -r src/third_party/catapult@5212cf739dd8 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:932564 TBR=sullivan@chromium.org Change-Id: I86439098e08b20743531f63f7c706ce253107093 Reviewed-on: https://chromium-review.googlesource.com/c/1475695Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632731}
-
Patrick Monette authored
Even though they almost never changes, Chrome checks the certificate of all known modules on a background sequence on every startup. This CL introduces a cache that avoids redoing this expansive operation if the certificate of a DLL didn't change. Bug: 932267 Change-Id: Id523bd7794c43c5282a213a888c3291d1a35e78c Reviewed-on: https://chromium-review.googlesource.com/c/1450812 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#632730}
-
Justin Cohen authored
Don't layer the sad tab overlay over the NTP, since it doesn't matter of the web process bails for about://newtab. Interestingly enough, this is a possible outcome. Bug: 932618 Change-Id: I9cc2afdb0e5ca6ac9de9a9e8ad91146574392e99 Reviewed-on: https://chromium-review.googlesource.com/c/1475793 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#632729}
-
Alexei Filippov authored
The flakiness seems to be fixed by https://chromium.googlesource.com/chromium/src/+/3d8e0ad7f87d2c3b91cfe528ab9948ce4299a3dd BUG=843467 Change-Id: I55903000c2d035b98b42eb91c65745a3a61e8f80 Reviewed-on: https://chromium-review.googlesource.com/c/1474848Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#632728}
-
Erik Chen authored
The exact same test was being added twice. Change-Id: Id0708a361cc2f5eb1fba49c3da02672e58d3acc5 Bug: 927900 Reviewed-on: https://chromium-review.googlesource.com/c/1474809Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#632727}
-
Eric Orth authored
Includes fix for an affected test with brittle logic for determining request IDs in MockHostResolver. The new API has different effects on the logic for generating such IDs. Also fixed HangingHostResolver to always return ERR_DNS_CACHE_MISS when source is LOCAL_ONLY to match HangingHostResolver::ResolveFromCache() behavior. Bug: 922699 Change-Id: I388dfc2a42feb49ca055160eb1bbcee05bb05de9 Reviewed-on: https://chromium-review.googlesource.com/c/1457215 Auto-Submit: Eric Orth <ericorth@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#632726}
-
John Abd-El-Malek authored
Bug: 932305 Change-Id: I3176382e360aa70944437d92bbbee7b9aa7cd0e3 Reviewed-on: https://chromium-review.googlesource.com/c/1474838 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#632725}
-
about://flagsYusuf Ozuysal authored
This starts listening for model switches to reset the model on the TabGrid accordingly. Also makes the flag visible in about://flags. BUG=931025 Change-Id: Ie53e362e831039f4fe101a051e36349f8988a9b4 Reviewed-on: https://chromium-review.googlesource.com/c/1471292 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#632724}
-
Xing Liu authored
All the notification scheduler code lives in chrome/browser/notifications/scheduler. Bug: 930968 Change-Id: Idfe8fd3ba7b3e8f3e9b295b2f4e8d7b14ce5df9a Reviewed-on: https://chromium-review.googlesource.com/c/1464456 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#632723}
-
Torne (Richard Coles) authored
Remove the MonochromeApplication class from TrichromeChrome's manifest so that the regular ChromeApplication will be used instead, to avoid trying to set up Monochrome-specific things. Update the comment in MonochromeApplication to make it clear that it's not used by Trichrome and that it must only be used for things that are specific to Monochrome being a WebView implementation. This fixes the startup crash caused by Trichrome attempting to use BIND_EXTERNAL_SERVICE for its child processes when the Trichrome manifest does not declare the services as external. Bug: 917417 Test: install and launch trichrome_chrome_apk Change-Id: If857dfb73b75e15c73398779a159ce7bb1ad56cb Reviewed-on: https://chromium-review.googlesource.com/c/1474997 Commit-Queue: Richard Coles <torne@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#632722}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b23ca2a5..dd091589 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib1ca861aeddb76a7ad8f474edf7ce5f2fc27d83f Reviewed-on: https://chromium-review.googlesource.com/c/1475744Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632721}
-
Mugdha Lakhani authored
A recent CL added some logic based on a feature being enabled in ChromeBackgroundService: https://chromium-review.googlesource.com/c/chromium/src/+/1432840 However, since the native JNI library might not be loaded at this point, the feature check can't be done -- it causes a crash. This CL takes out logic to ChromeBackgroundService, to be re-introduced when BackgroundTaskSchedulerForBackgroundSync feature is enabled everywhere. Bug: 924490, 932468 Change-Id: Ia1930c76a36e88a2a2bc53be96582123118ddc97 Reviewed-on: https://chromium-review.googlesource.com/c/1474655 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#632720}
-
Will Harris authored
Change-Id: I48dd4cbc29a53739bd8d272d96f513f1e23c6c92 Reviewed-on: https://chromium-review.googlesource.com/c/1455197 Auto-Submit: Will Harris <wfh@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#632719}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/333ac4ae60ac..7dc6b1b652fc git log 333ac4ae60ac..7dc6b1b652fc --date=short --no-merges --format='%ad %ae %s' 2019-02-15 tsepez@chromium.org CJX_Xfa::thisValue() can be null when called from C++. 2019-02-15 tsepez@chromium.org Document implications of NULL p_JSPlatform in public header. Created with: gclient setdep -r src/third_party/pdfium@7dc6b1b652fc The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ife55f85778a342abc037164d76a3120f35f7ce9f Reviewed-on: https://chromium-review.googlesource.com/c/1475699Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632718}
-
James Cook authored
Only display roots are considered root windows. We were doing the right thing for remote widgets, but not for remote embeds. This fixes Tast test ui.VirtualKeyboardOmnibox, which was failing because the virtual keyboard uses embedding but the widget is owned by ash. Bug: 931574 Test: added to ash_unittests Change-Id: I7d3bf1c5fccca596cf075969b2dfafc46426ad68 Reviewed-on: https://chromium-review.googlesource.com/c/1474261Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#632717}
-
kylechar authored
TaskRunner::PostTask() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=sadrul@chromium.org Bug: 714018 Change-Id: I1692b93a62ad26e81d6849075f8a3a49a2e93909 Reviewed-on: https://chromium-review.googlesource.com/c/1475731 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#632716}
-
chrome://process-internalschrome://chrome-urlsNasko Oskov authored
Bug: 904116 Change-Id: Ibc4a571d0598707ed76c245858ee58a5fd7a88b5 Reviewed-on: https://chromium-review.googlesource.com/c/1475076Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#632715}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0613361e6c4f..abcac71093c8 Created with: gclient setdep -r src-internal@abcac71093c8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9cb694128e318e82d7c31001ac270c3716b28a89 Reviewed-on: https://chromium-review.googlesource.com/c/1474978Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632714}
-
Nick Burris authored
The resize corner was only getting properly scaled when a scrollbar was present, since Scrollbar::ScrollbarThickness() uses ChromeClient::WindowToViewportScalar() to scale its thickness[1], whereas ScrollbarTheme::ScrollbarThickness() does not[2]. This patch properly scales the resize corner in the case where there is no scrollbar present. [1] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/scroll/scrollbar.h?l=111&rcl=acee82f7b5654353a98f7b739c25d428642e8f82 [2] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/scroll/scrollbar_theme.h?l=61&rcl=b722ee8240e66004b021a1421d548bf10367b311 Bug: 884575 Change-Id: I3a7e0b4134928ea40be625fa1f64c05ed9490620 Reviewed-on: https://chromium-review.googlesource.com/c/1474293 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#632713}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5e577f20fc7c..4bb6437ff800 git log 5e577f20fc7c..4bb6437ff800 --date=short --no-merges --format='%ad %ae %s' 2019-02-15 lalitm@google.com Merge "Revert "Protect SharedRingbuffer against concurrent manipulation."" 2019-02-15 hjd@google.com Merge "trace_to_text: Uses names from sched_switch" Created with: gclient setdep -r src/third_party/perfetto@4bb6437ff800 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I673f19aa36abcf56cff9b445cfa60737ee490dae Reviewed-on: https://chromium-review.googlesource.com/c/1475696Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632712}
-
Changwan Ryu authored
I have not made any significant contribution to web apps in the last 3 years, and I do not plan to. Change-Id: Icb89277ef72c0b43be98bac953f216282017ef93 Reviewed-on: https://chromium-review.googlesource.com/c/1474599Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#632711}
-
Noel Gordon authored
Android aarch64 has different PMULL and CRC32 feature values compared to Android aarch32. Rename init_arm_features to _arm_check_features to be consistent with the _MSC_VER code. Add Android aarch64 feature value support. Use the correct return type for the platform feature detectors (getauxval and android_getCpuFeatures). Add comments and a TODO for OS_ZIRCON. Bug: 810125 Change-Id: Ie1526b1d6d3ebeba76d49a83911b335ffce1b288 Reviewed-on: https://chromium-review.googlesource.com/c/1472810Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#632710}
-
Sylvain Defresne authored
The preferences are already correctly registered as part of the creation of the TestingProfile so there is no need to call this method (it is deprecated). Bug: 932534 Change-Id: I1898d7a55e21f2a6524df3d84d849fa428f9c944 Reviewed-on: https://chromium-review.googlesource.com/c/1474760 Commit-Queue: Drew Wilson <atwilson@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#632709}
-
kylechar authored
TaskRunner::PostTask() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=eroman@chromium.org Bug: 714018 Change-Id: I752c22efc5f81b5a7fb6dba1769ca61ecd0f6bd9 Reviewed-on: https://chromium-review.googlesource.com/c/1475647 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#632708}
-
Rohit Rao authored
This will allow us to use the autoroller to update the pinned revision. It will also allow developers to use a "custom_vars" entry in their .gclient file to set this to refs/heads/master if they need to develop against ToT locally. BUG=None Change-Id: I5e506cb12de5e8ceb9b5883750169163ba09adf5 Reviewed-on: https://chromium-review.googlesource.com/c/1474818Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#632707}
-
Mehran Mahmoudi authored
This CL creates a new style selector (or rather refactors the old one) for interest rings in spat nav. It also removes the SpatialNavigationForcesOutline flag and always shows the interest ring when using spat nav. See crrev.com/c/1344252 A future CL will remove the FocuslessSpatialNavigation flag. Bug: 906640 Change-Id: I8bb0e367a0dfd08a7bd48a3f940e58ac60875b36 Reviewed-on: https://chromium-review.googlesource.com/c/1468590 Auto-Submit: Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#632706}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/33bba657449d..685ea8d6f03c git log 33bba657449d..685ea8d6f03c --date=short --no-merges --format='%ad %ae %s' 2019-02-15 pprabhu@chromium.org config: Migrate {auron_yuna,caroline,cave}-paladin to Skylab Created with: gclient setdep -r src/third_party/chromite@685ea8d6f03c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I168745190b8321bf95225433c2e1807748d88f6d Reviewed-on: https://chromium-review.googlesource.com/c/1475694Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632705}
-
Aleks Totic authored
This reverts commit c3f69282. Reason for revert: broke wpt Original change's description: > New wpt tests for absolute position > > Tests buggy code paths in NG and Legacy. > > Bug: 907911 > Change-Id: I38f22f3673576a776fbe7e89f1cc8452b99d3ded > Reviewed-on: https://chromium-review.googlesource.com/c/1471384 > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Commit-Queue: Aleks Totic <atotic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632391} TBR=ikilpatrick@chromium.org,atotic@chromium.org,mstensho@chromium.org Change-Id: I39bd7b49cfd197eb9e194507d4e35b38f3987a97 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 907911 Reviewed-on: https://chromium-review.googlesource.com/c/1474994Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#632704}
-
Dana Fried authored
App menu now sets its label text context to toolbar button, like other toolbar buttons. Also prevent toolbar and app menu buttons from unnecessarily destroying and recreating empty borders if the inset size has not changed. Bug: 931575 Change-Id: Id2b7e146a97b1da56f08caa9b79b4c7072c9de04 Reviewed-on: https://chromium-review.googlesource.com/c/1474687Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#632703}
-