- 17 Apr, 2018 40 commits
-
-
Ramin Halavati authored
Tests are added to compare outputs of traffic_annotation_auditor using different parameters. Bug: 690323 Change-Id: I69bc0234310020e2e92ecdd25c90f543f9b99459 Reviewed-on: https://chromium-review.googlesource.com/960143 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#551298}
-
Harald Alvestrand authored
This is needed to return error codes to the Blink layer. Bug: 589455 Change-Id: I698325ae7960121174af1b345f438e716fd0d099 Reviewed-on: https://chromium-review.googlesource.com/1013521Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#551297}
-
Shuo Weng authored
Bug: 833214 Change-Id: I5552bdca37a2e3e20a039b9a0ca316f4480b1217 Reviewed-on: https://chromium-review.googlesource.com/1010055 Commit-Queue: Shuo Weng <shuow@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#551296}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3b0840b3. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15693 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: If9b8527313ca74fadb7945751dcdecc335208264 Reviewed-on: https://chromium-review.googlesource.com/1014731 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#551295}
-
Maksim Ivanov authored
The new policy gates the decision whether the client certificate based user data protection should be used for users signing in via SAML. For example, this allows to configure the smart card sign in, with the smart card being the first factor of the user authentication. * By default, the implementation-defined behavior will be used, which currently is a synonym to password-based authentication and cached data protection. * When the "client certificate" type is configured via this policy, the client certificates chosen by a login app and the corresponding keys are used for authenticating users and protecting the cached data. Bug: 826417 Test: unit_tests --gtest_filter=DeviceSettingsProviderTest.SamlLoginAuthenticationType Change-Id: I634d39f6b7f14457d292d9ce88eeb458a7e28014 Reviewed-on: https://chromium-review.googlesource.com/983960Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#551294}
-
Mark Cogan authored
This CL removes the obsolete-after-iOS8 LayoutOptionForRTLSupport() utility method. Since that was the major use case for many of the "option" variants of AddConstraint methods, they were converted to the fewer-parameter version, and other obsolete variants were also cleaned up. Bug: 637247 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I961204c1620d354b2c3c3461baa65a8d903e8c5b Reviewed-on: https://chromium-review.googlesource.com/1013569 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#551293}
-
chrome://reset-passwordRune Lillesveen authored
This reverts commit 21f70497. Reason for revert: Linux CFI detected a bad type cast in ChromePasswordProtectionServiceBrowserTest See: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_CFI%2F7224%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FChromePasswordProtectionServiceBrowserTest.VerifyIsPasswordReuseProtectionConfigured%2F0 Original change's description: > Add a static chrome://reset-password page > > Chrome will open a tab with chrome://reset-password if the user reuses > their protected enterprise password on other sites that are not allowed > by enterprise policy. > chrome://reset-password will only show if password protection related > enterprise policy settings are properly set. Otherwise, user will see > ERR_INVALID_URL. > > The new icon in ui/webui/resources/cr_elements/icons.html is copied from > /chrome/browser/resources/settings/icons.html > > Bug: 824501 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I8d648f0484e0c569ddbed048114a90471e4eea25 > Reviewed-on: https://chromium-review.googlesource.com/996565 > Commit-Queue: Jialiu Lin <jialiul@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Nathan Parker <nparker@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551195} TBR=stevenjb@chromium.org,calamity@chromium.org,nparker@chromium.org,vakh@chromium.org,jialiul@chromium.org Change-Id: I36544eabdd6e8822c15e37e68166e06452dfe57f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824501 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1014091Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#551292}
-
Pavol Marko authored
Sync to the newest server-side version. Bug: none Change-Id: I5c93a8d5569e9079c1738014a632a63538136249 Reviewed-on: https://chromium-review.googlesource.com/1014110Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#551291}
-
Ioana Pandele authored
Currently, the password manager doesn't autofill forms with prefilled values in the username field in order to preserve existing information. This CL changes the behavior to autofill in cases where the prefilled username value is part of a list of known placeholders. Bug:832622 Change-Id: I9178eac0e609655c61e5e1caf35d083414e14b8b Reviewed-on: https://chromium-review.googlesource.com/1007723Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#551290}
-
Rune Lillesveen authored
This reverts commit 042ae97b. Reason for revert: roll caused multiple chromium bots to start failing Original change's description: > Roll src/third_party/angle/ aa8b3982a..08b9e046c (2 commits) > > https://chromium.googlesource.com/angle/angle.git/+log/aa8b3982aeeb..08b9e046c1b6 > > $ git log aa8b3982a..08b9e046c --date=short --no-merges --format='%ad %ae %s' > 2018-04-16 jmadill Vulkan: Disable warning in Mock ICD. > 2018-04-16 tobine Roll (2/2) to latest LVL as of 4/16/18 > > Created with: > roll-dep src/third_party/angle > > > The AutoRoll server is located here: https://angle-chromium-roll.skia.org > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > TBR=jmadill@chromium.org > > No-Try: True > Change-Id: I34309b2c8fc6f4d49ba465929378687aaaa181a1 > Reviewed-on: https://chromium-review.googlesource.com/1014671 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#551232} TBR=jmadill@chromium.org,angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Change-Id: Ic6b5936a64210a40c6a2288fcbbed2a0e4bb1bf4 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1013940Reviewed-by:
-
Marc Treib authored
This was fun because these tests used account_id, gaia_id, and email more or less interchangably, which doesn't work well with IdentityManager (or with sanity). This CL cleans this up and clearly differentiates the three. Bug: 825190 Change-Id: Ibdebb6d295f84ef15dd2864819c98fb1274ab63c Reviewed-on: https://chromium-review.googlesource.com/1010423Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#551288}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b08b074b..73d9591f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Id49af88a70994dfa7122db0185d2dd494dad8549 Reviewed-on: https://chromium-review.googlesource.com/1014728Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#551287}
-
Gauthier Ambard authored
This CL changes the layout of the toolbar buttons. The tab switcher is now always on the trailing side, and the bookmarks button is only visible on iPad. Bug: 831151 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I903e4b702439c23a01e2cf4ef8e2edecae11fdf4 Reviewed-on: https://chromium-review.googlesource.com/1013558 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551286}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/745ac35bed03..778a1cdf05f1 $ git log 745ac35be..778a1cdf0 --date=short --no-merges --format='%ad %ae %s' 2018-04-13 khmel arc: Add packing SDK tools to uprev Android container. Created with: roll-dep src/third_party/chromite The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I65d06f12292b58732e710ca3c8d7b8da6bbc5c3a Reviewed-on: https://chromium-review.googlesource.com/1014742Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551285}
-
Rune Lillesveen authored
This reverts commit 499570b6. Reason for revert: Caused failures in browser_tests debug builds for two tests: CrExtensionsItemsTest.ClickableItems CrExtensionsItemsTest.FailedReloadFiresLoadError Original change's description: > MD Extensions - A11y: Announce when an extension has been updated. > > Bug: 27175 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I2fed4c16cf0406ea5361413840fe5ab2f5968f69 > Reviewed-on: https://chromium-review.googlesource.com/1003056 > Commit-Queue: Hector Carmona <hcarmona@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551142} TBR=rdevlin.cronin@chromium.org,hcarmona@chromium.org Change-Id: I8f6e654c798127a3a77d0cb2a107443aa8465686 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 27175 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1012850Reviewed-by:
-
Luciano Pacheco authored
This button is <paper-button> in contrast to other buttons that are just <button> so the style wasn't applying to it. Add "menu-button" CSS class to all buttons within div.dialog-header so they can share similar style. Bug: 687077 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1426891c17f734e8d4ce81cdec48c23cdefcbbdd Reviewed-on: https://chromium-review.googlesource.com/1013844Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#551283}
-
Mitsuru Oshima authored
BUG=833456 TEST=none Change-Id: I9d01f94670a406ea7b30b4c232775dc76ad4a48c Reviewed-on: https://chromium-review.googlesource.com/1013272 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551282}
-
Jonas Olsson authored
Bug: chromium:672469 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I33a9e06feddf52699c47a8d64e17eca8ed797bf6 Reviewed-on: https://chromium-review.googlesource.com/1013460 Commit-Queue: Jonas Olsson <jonasolsson@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#551281}
-
Marc Treib authored
This CL migrates LocalDiscoveryUITest from the old SigninManager + OAuth2TokenService to the new IdentityManager. TBR=vitalybuka@chromium.org (reviewed by @google.com account) Bug: 825190, 798408 Change-Id: If301de8524ee22c52dc4a4a0a0918c941d449226 Reviewed-on: https://chromium-review.googlesource.com/1012105 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@google.com> Cr-Commit-Position: refs/heads/master@{#551280}
-
Noel Gordon authored
Postpone the creation of the FilesApp component extensions AudioPlayer FileManager, Gallery, and VideoPlayer in browser testing. Not doing so leads to systemic browser test failures (flakiness) per the bugs. Fix: prepare test resources first, load the component extensions, then start testing. Failure was the component extensions were active before the file resources needed by the tests were ready, causing flake-fails when the component extensions tried to access those resources. Bug: 831074, 804413, 829310 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie794bac638f48c3855e0c1f1609e59aa615c31dd Reviewed-on: https://chromium-review.googlesource.com/1013823 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#551279}
-
Gauthier Ambard authored
This CL changes the omnibox button's background to match the browsing mode (incognito or normal). Bug: 829769 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I052e1228332121e7e75b1b781dabd7c4e6c3083b Reviewed-on: https://chromium-review.googlesource.com/1012840Reviewed-by:
-
Brian Osman authored
skcms will replace SkICC and some other pieces of Skia's colorspace API. Change-Id: I25615bce2963689eae26b41bc66532aa1a6e1daf Reviewed-on: https://chromium-review.googlesource.com/1014368Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#551277}
-
Kenichi Ishibashi authored
This test is failing regardless S13nServiceWorker is enabled or not. We already have an entry in TestExpectation for this test so we can remove the entry from FlagExpectations. I ran the test 100 times (--iteration=10 and --repeat-each=10) and confirmed that the test isn't flaky. Bug: 715640 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I3ef85639001e2f01bc469ac771e479d816c3ea77 Reviewed-on: https://chromium-review.googlesource.com/1013675Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#551276}
-
Jeremy Roman authored
This is now allowed across the Blink API, and also removes the need to write manual "delete this;" code. Change-Id: If5224aac68d6c96b7c6f7014580955e4922ea0bd Reviewed-on: https://chromium-review.googlesource.com/1013062 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551275}
-
Gauthier Ambard authored
This CL adds a new activity to the activity menu (share menu) to have allow bookmarking the current page. Bug: 829324 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If03dedc18b3f514bf54b75a8508dad3bd4c3bf84 Reviewed-on: https://chromium-review.googlesource.com/1012067Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#551274}
-
Ramin Halavati authored
Network traffic annotations summary has a minory format typo which is corrected. Change-Id: I5830be957859e056ec9aa6dac6f0c1f8f2507b44 TBR: dullweber@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1013490 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#551273}
-
Gauthier Ambard authored
This CL changes the way the toolbar button associated with a popup menu is spotlighted. It reduces the alpha of the buttons. This is used to reduce the alpha of the background of the omnibox button to prevent confusion between the spotlighted button and the omnibox button. It also changes the color of the spotlight in incognito, making it white instead of dark. Bug: 817752, 832076 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iee6797945df2e9ec65464ca0393789eb3b581e71 Reviewed-on: https://chromium-review.googlesource.com/1014124Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#551272}
-
Gauthier Ambard authored
This CL changes the CRWWebViewScrollViewProxy such as it is now persisting the value of the properties even after setting a new ScrollView. Bug: 831519 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I776c7983df536d5bed9c03a826998413b8a6d246 Reviewed-on: https://chromium-review.googlesource.com/1013520Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#551271}
-
Takashi Toyoshima authored
Remove WebCORS::ListOfCORSEnabledURLSchemes() and WebCORS::ContainsOnlyCORSSafelistedOrForbiddenHeaders() since these methods won't be used by CORSURLLoader in favor of OOR-CORS efforts. Also move IsForbiddenHeaderName(), ContainsOnlyCORSSafelistedHeaders(), and ContainsOnlyCORSSafelistedOrForbiddenHeaders() from FetchUtils to CORS since they are CORS related thin wrapper methods to call network::cors functions. FetchUtils::IsOkStatus is also moved to CORS, and implementation is placed at network::cors to reuse the same implementation in the Network Service. All changes are mechanical, and should not introduce any behavior change. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ibffd079162ce2b79742deeeba66bd7449defce5d Tbr: haraken@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1005134 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#551270}
-
Andreas Haas authored
The WebAssembly spec [1] requires that a TypeError is thrown if the status of the Response input of streaming compilation is not ok. I added layout tests for this, and cleaned up the surrounding tests a bit. [1] https://github.com/WebAssembly/design/blob/master/Web.md#webassemblycompilestreaming R=mlippautz@chromium.org, mathias@chromium.org also-by: mathias@chromium.org Bug: chromium:832552 Change-Id: Icd50e537ab659662708274a96959eb94d7fbc554 Reviewed-on: https://chromium-review.googlesource.com/1012035Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#551269}
-
Max Morin authored
The legacy IPC audio messages have been replaced by mojo interfaces. This CL also removes related experiment configs. Comments are also updated (diff against PS1), except for comments in audio_mirroring_manager.h, since that one is soon to be removed. A more comprehensive md file should be written when the audio service situation has settled a bit. Bug: 653871,721732 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia67ffe766802adec971b41dfc0593be61909175a Reviewed-on: https://chromium-review.googlesource.com/1010424Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551268}
-
Karan Bhatia authored
This CL adds test coverage regarding an extension frame's ability to embed a file frame. This ensures than an extension can only embed a file frame if it has explicit file access and host permissions to the file scheme. BUG=816685 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I8d167d9a8629ffece29d44bee4bd6db2ef988b02 Reviewed-on: https://chromium-review.googlesource.com/1003762 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551267}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I7e2a0accac4ad76d4a2a00b197bd3d66024b19af Reviewed-on: https://chromium-review.googlesource.com/1014566 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551266}
-
Koji Ishii authored
The disable_flip added in CL:960403 mistakenly disables inclusion of LocalClipPathBoundingBox. This patch fixes the logic only to disable block flipping. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6617ddf1d852cd9d98dcaa86d6926d01a5e7af8c Reviewed-on: https://chromium-review.googlesource.com/1013805Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#551265}
-
Daniel Cheng authored
Extract some more common code into WebFrameWidgetBase. The end goal is to completely merge WebFrameWidgetImpl and WebViewFrameWidget into WebFrameWidgetBase. This is an intermediate step to make it easier to create the frame widget before creating the local frame root: by sharing storage in the base class, the followup patch to invert creation order will only have to update pointers in one place. Bug: 820787 Change-Id: I5f096c8a8d74abb6b6773ff36c75288b998d3880 Reviewed-on: https://chromium-review.googlesource.com/1014017Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#551264}
-
Jungshik Shin authored
U+04CF (ӏ) has the confusability skeleton of 'i' (lowercase I), but it can be confused for 'l' (lowercase L) or '1' (digit) if rendered in some fonts. If a host name contains it, calculate the confusability skeleton twice, once with the default mapping to 'i' (lowercase I) and the 2nd time with an alternative mapping to 'l'. Mapping them to 'l' (lowercase L) also gets it treated as similar to digit 1 because the confusability skeleton of digit 1 is 'l'. Bug: 817247 Test: components_unittests --gtest_filter=*IDN* Change-Id: I7442b950c9457eea285e17f01d1f43c9acc5d79c Reviewed-on: https://chromium-review.googlesource.com/974165 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#551263}
-
Luciano Pacheco authored
This fixes a memory leak and renderer crash as described below. Change Cache Storage "open" method callback to have a WeakPersistent reference to CacheStorage to avoid a circular reference between them. Remove Persistent<CacheStorage> from callback for "delete" since it wasn't used. WebServiceWorkerCacheStorageImpl keeps the callback while waiting for mojo response from browser process which keeps CacheStorage alive, CacheStorage also has a reference to WebServiceWQorkerCacheStorage, which is implemented by WebServiceCacheStorageImpl, creating the circular reference, this situation leads to memory leak because those can't be garbage collected properly on some termination conditions, this leak in turn would cause renderer to crash when starting a new worker and trying to reuse pointer to address cleaned by Oilpan heap. When a worker is terminated with pending WithCacheCallback objects, the termination GC callback will access the Persistent handle. However, it will point to an object in a dead Oilpan heap and cause a segfault. Using a WeakPersistent is a workaround to prevent this crash, since the termination GC callback won't try to access it. In the future, Oilpan might be updated to handle this more gracefully see https://crbug.com/831117. The added test catches two conditions where renderer process was crashing: 1. When initializing Cache Storage after "close()". 2. Initializing Cache Storage before "close()" and issuing new calls, that trigger mojo after "close()". Bug: 831054 Change-Id: I6620d8107c00aed1c386c869dc1a793bc51d97fa Reviewed-on: https://chromium-review.googlesource.com/1011467 Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Andrey Lushnikov authored
Browser doesn't commit navigation if server responds HTTP 204 / HTTP 205 for the main resource or if navigation triggers a download. In these cases, navigation is considered aborted. This patch teaches page.navigate to return "ERR:ABORTED" when either of the usecases happens. R=dgozman, pfeldman Change-Id: I0017e458c2f905429c7234bc8f9be20a4201bbfd Reviewed-on: https://chromium-review.googlesource.com/1009487Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#551261}
-
Matt Menke authored
Bug: 824715 Change-Id: I71d7f38a2dbe9de6515b8e9d284ab622c2311276 Reviewed-on: https://chromium-review.googlesource.com/1014367 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#551260}
-
Christopher Lam authored
See go/closure-compile-gn for details. This CL converts the Closure Compilation from GYP to GN for the following: - cryptotoken - download_internals - md_downloads - md_extensions - md_history - md_user_manager - offline_pages - signin - webapks - welcome A local closure compile can be run by setting closure_compile = true in args.gn, and then running ninja -C out/Default webui_closure_compile. Individual projects can be compiled via, for example, ninja -C out/Default chrome/browser/resources/md_extensions:closure_compile Relanding with a fix for android builds. TBR=calamity@chromium.org,dpapad@chromium.org,ntfschr@chromium.org Bug: 632206, 833550 Change-Id: I197201fe9cd06153cce18a8e6243d6fd189f1087 Reviewed-on: https://chromium-review.googlesource.com/1013801 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#551259}
-
