GitLab

This includes:
mojo_public_system_unittests
mojo_public_bindings_unittests
gl_tests
events_unittests
boringssl_crypto_tests
ui_touch_selection_unittests
ui_base_unittests
gpu_ipc_service_unittests
device_unittests
libjingle_xmpp_unittests
ui_android_unittests

R=jbudorick@chromium.org

Bug: 725672, 670879
Change-Id: I3d46bb883e6508fea63bc722a15809306e0662ba
Reviewed-on: https://chromium-review.googlesource.com/518293Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475744}

This can happen in testAndroidTestCaseSetupProperly(), see
https://d.android.com/reference/android/test/AndroidTestCase.html#testAndroidTestCaseSetupProperly()
which is an empty test case.  Chromium avoids this but other test systems don't.
Also, remove a redundant loadLibrary call.

R=xunjieli@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2909223004
Cr-Commit-Position: refs/heads/master@{#475743}

BUG=726598

Review-Url: https://codereview.chromium.org/2914723002
Cr-Commit-Position: refs/heads/master@{#475742}

BUG=698403

Review-Url: https://codereview.chromium.org/2910463003
Cr-Commit-Position: refs/heads/master@{#475741}

MediaCodecVideoDecoder needs to decode using a MediaCodec on the MCVD
thread while dequeued buffers are released back to the codec on the GPU
thread. CodecWrapper supports this use case by vending CodecOutputBuffers
which keep a reference to their backing wrapper, and a unique id so that
CodecWrapper can keep track of which buffers are valid.

Bug: 660942
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I798df44a7639071f9eb3f2803d018ced4b121137
Reviewed-on: https://chromium-review.googlesource.com/517351Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475740}

BUG=723871

Review-Url: https://codereview.chromium.org/2902673003
Cr-Commit-Position: refs/heads/master@{#475739}

screenshot: https://drive.google.com/file/d/0B1O0Z7eoZMuGOXYzTG5YN1ZDdW8/view

BUG=725784

Review-Url: https://codereview.chromium.org/2901913003
Cr-Commit-Position: refs/heads/master@{#475738}

The extension action redesign has launched. Remove associated logic from
the ToolbarActionsBar, ToolbarActionsModel, and associated tests
(including ExtensionMesageBubbleBrowserTests).

BUG=590321

Review-Url: https://codereview.chromium.org/2906723003
Cr-Commit-Position: refs/heads/master@{#475737}

Currently TextIterator's constructor takes two Positions (start and end). It
came up during review of https://codereview.chromium.org/2901213008 that it
would be helpful to have another version of the constructor that instead takes
an EphemeralRange.

BUG=

Review-Url: https://codereview.chromium.org/2913003003
Cr-Commit-Position: refs/heads/master@{#475736}

This does not yet react to such messages but hooks up the plumbing so that we are ready for them

Because the app handlers need to be registered before any GCM messages are received, this app handler is added upon construction of the GCMProfileService.

BUG=701939

Review-Url: https://codereview.chromium.org/2864293003
Cr-Commit-Position: refs/heads/master@{#475735}

The unit test for SystemTimeProvider uses
base::Time::FromLocalExploded() to create a hard coded time. However,
this has the unfortunate side effect of creating a different number
based on the local timezone.

This CL changes the test to instead use base::Time::FromUTCExploded()
which forces the timezone to be UTC, which fixes test errors.

BUG=727916

Change-Id: I027ef0c5e100cb04ddad7472e8a8eaa7a3521a7f
Reviewed-on: https://chromium-review.googlesource.com/517870Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475734}

We are moving cast_channel related files from //extensions to //components and need to remove extensions dependencies.

- Added internal enum class ::cast_channel::ReadyState, ::cast_channel::ChannelError, ::cast_channel::ChannelAuthType and type conversion util functions
- Use internal enum class instead of enums in cast_channel.idl

BUG=723944

Review-Url: https://codereview.chromium.org/2891923004
Cr-Commit-Position: refs/heads/master@{#475733}

Revert of [DMC #17] Make TextMatchMarkers constructible in single step (patchset #4 id:60001 of https://codereview.chromium.org/2905753002/ )

Reason for revert:
This broke the build.

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/201575

Original issue's description:
> Make TextMatchMarkers constructible in single step
>
> Currently, we only construct instances of TextMatchMarker (previously
> RenderedDocumentMarker) inside TextMatchMarkerListImpl, by calling
> TextMatchMarker::Create() on an instance of DocumentMarker. This CL changes this
> so callers directly construct instances of TextMatchMarker. This sets us up to
> eventually move the storage and accessor methods for whether or not the marker
> is active out of DocumentMarker and into TextMatchMarker.
>
> BUG=707867
>
> Review-Url: https://codereview.chromium.org/2905753002
> Cr-Commit-Position: refs/heads/master@{#475724}
> Committed: https://chromium.googlesource.com/chromium/src/+/6b0a494122ebe2fc48099a9549b0acbf0b28571d

TBR=yosin@chromium.org,xiaochengh@chromium.org,rlanday@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=707867

Review-Url: https://codereview.chromium.org/2912133003
Cr-Commit-Position: refs/heads/master@{#475732}

Consolidates and simplifies user message serialization within the EDK.
Namely:

  * The ports layer no longer operates under the assumption that all
  events exist exclusively in serialized form. This eliminates the
  complexity of layered message allocation at the cost of a small amount
  of extra copying in some cases.

  * ports::Message is now more aptly named ports::Event, and different
  event types are subclasses.

  * Introduces a ports::UserMessage base class for ports embedder
  message types. These can be attached to ports::UserMessageEvent
  objects.

  * The MessageForTransit and PortsMessage types have been flattened
  into a single UserMessageImpl type, a subclass of ports::UserMessage.

  * Nearly all user message serialization and deserialization logic has
  been consolidated into UserMessageImpl. A few small pieces remain
  isolated in node_controller.cc and will eventually move elsewhere
  after additional refactoring.

All of this work is a precursor to supporting lazy serialization.

BUG=725321

Change-Id: Ib9e66cd0d5b88ac0e6dc898f248c958039078023
Reviewed-on: https://chromium-review.googlesource.com/516402
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475731}

Checkstyle gets run on Java changes on chromium_presubmit, which uses
a linux checkout.

Bug: 727875
Change-Id: I640418439735e91fbf5b18b3d5f5a72e5c00648e
Reviewed-on: https://chromium-review.googlesource.com/517978Reviewed-by: Bo Liu <boliu@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475730}

This patch supports minor follow up Blink Rename, and adds two LayoutNG
commonly used classes.

Tested on VS2015/2017 with natvis diagnostic messages turned on.

Review-Url: https://codereview.chromium.org/2913743002
Cr-Commit-Position: refs/heads/master@{#475729}

This patch changes text-align to use the logical left of the line box to
apply the CSS text-align property. This is set to the offset of
NGPhysicalLineBoxFragment, which is then copiped to
RootInlineBox::LogicalLeft.

This way is more efficient to move, the same as what the legacy does,
and better for painting since the line box does not have unused spaces.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2906233002
Cr-Commit-Position: refs/heads/master@{#475728}

BUG=436634

Review-Url: https://codereview.chromium.org/2916443002
Cr-Commit-Position: refs/heads/master@{#475727}

crrev.com/2cbd4fca moved
CastAudioOutputStream along with CastAudioOutputStream::Backend to
AudioThread, which is wrong. The backend need to run on CMA thread.

In addition to fixing the threading model, this patch:
- Lets AudioManager use MediaPipelineBackendFactory instead of BackendManager
- Updates tests to use the threading model used in production
- Adds another basic CastAudioManager test that creates AudioOutputStreamProxy, which is used in production.

Review-Url: https://codereview.chromium.org/2879703003
Cr-Commit-Position: refs/heads/master@{#475726}

This CL moves a task runner setting logic from PingLoader to FrameFetchContext.
In order to do that, this CL also introduces "keepalive" member to
ResourceRequest and WebURLRequest.

Bug: 695939
Change-Id: Id02e025d1d7e4bdfc4372e52b6c0fd4c72937520
Reviewed-on: https://chromium-review.googlesource.com/517450
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475725}

Currently, we only construct instances of TextMatchMarker (previously
RenderedDocumentMarker) inside TextMatchMarkerListImpl, by calling
TextMatchMarker::Create() on an instance of DocumentMarker. This CL changes this
so callers directly construct instances of TextMatchMarker. This sets us up to
eventually move the storage and accessor methods for whether or not the marker
is active out of DocumentMarker and into TextMatchMarker.

BUG=707867

Review-Url: https://codereview.chromium.org/2905753002
Cr-Commit-Position: refs/heads/master@{#475724}

BUG=726773

Review-Url: https://codereview.chromium.org/2905423002
Cr-Commit-Position: refs/heads/master@{#475723}

Now we use a proto message as parameter for the dbus interface
to start ARC instances.

BUG=b:37989086
TEST=locally build and flash, start ARC

Review-Url: https://codereview.chromium.org/2869163002
Cr-Commit-Position: refs/heads/master@{#475722}

Bug: 712963
Change-Id: Ib2a85a23d3403f85c2f7c3abcc37a3d0bd84017c
Reviewed-on: https://chromium-review.googlesource.com/517807
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475721}

https://pdfium.googlesource.com/pdfium.git/+log/9a505796f3fe..2c200030b55f

$ git log 9a505796f..2c200030b --date=short --no-merges --format='%ad %ae %s'
2017-05-30 tsepez Fix small ordering issue in CFX_ProgressiveDecoder cleanup.
2017-05-30 tsepez Release unowned m_pTiffContext before deleting through it

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ib7f4543d0ada994b04b7dbe986de4ea6dc8b8838
Reviewed-on: https://chromium-review.googlesource.com/517681
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475720}

This is incorrectly throwing exceptions on some samsung devices, causing
crashes.

BUG=727806

Change-Id: If9d16dedcdddb8c6b7db446e79e04f59f3d19bf0
Reviewed-on: https://chromium-review.googlesource.com/518403
Commit-Queue: Bo Liu <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475719}

This patch expands |TextCheckingParagraph::OffsetTo()| into
|SelectionController::MarkAndReplaceFor()| with optimizations, see below,
because it is called once for improving code health.

Since |TextCheckingParagraph| object |paragraph| holds single range
|checking_range|, we can hold
|TextCheckingParagraph::OffsetAsRange().StartPosition()| to
|checking_range.StartPosition()|.

When |caret_position < paragraph_start|, we don't need to consider it, because of
caret is placed before checked range.

This patch is a preparation of patch[1].

[1] http://crrev.com/2912053002: Call TextIterator constructor with proper range

BUG=727537
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2909923005
Cr-Commit-Position: refs/heads/master@{#475718}

This patch changes |SelectionController::HandleSingleClick()| to call
|TextDistance()|, which constructs |TextIterator| via |RangeLength()|
with proper range, start <= end, as preparation of making |TextIterator|
constructor to take only proper range[1].

[1] http://crrev.com/2912053002: Call TextIterator constructor with proper range

BUG=727537
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2912923002
Cr-Commit-Position: refs/heads/master@{#475717}

This could cause hard-to-detect memory corruption if objects from
different devices are mixed.

BUG=727216
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2917493002
Cr-Commit-Position: refs/heads/master@{#475716}

Previously, many subclasses independently implemented mostly identical
focus painter code. Moving this up to CustomButton helps reduce a lot
of copy-pasted code throughout Chrome.

CustomButton::OnPaint becomes final because background and border need
to be painted before the button contents, which in turn comes before the
focus Painter. CustomButton subclasses override PaintButtonContents
instead.

Bug: none
Change-Id: Idcaba58450de00f321191f697b850857955a5e68
Reviewed-on: https://chromium-review.googlesource.com/516824
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475715}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2a69daf1..20ee3efa

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2915463006
Cr-Commit-Position: refs/heads/master@{#475714}

This CL fixes few minor issues in layout-test-tidy.js.

- Correctly parse '-i' or '--inplace' option.
- Allow multiple files or paths in command arguments with `-R` option.
- Force the document type to 'html5'.
- Edit README accordingly.

Bug: 726455
Change-Id: Iaa9a403d9d9d288c7d84524a391738ab70948d10
Reviewed-on: https://chromium-review.googlesource.com/517296Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475713}

Previously, gutter did not take into account high-DPIness and didn't
convert from DIP to pixels and back correctly. This CL corrects this.

BUG=672962

Review-Url: https://codereview.chromium.org/2873473002
Cr-Commit-Position: refs/heads/master@{#475712}

BUG=722551
TEST=Compiles; no behavior changes.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2915553004
Cr-Commit-Position: refs/heads/master@{#475711}

This CL adds existing rendering controls to show paint flashing, FPS meter,
layout borders, scroll performance bottlenecks, and CSS media type emulation
into the command menu.

BUG=695986

Review-Url: https://codereview.chromium.org/2839413002
Cr-Commit-Position: refs/heads/master@{#475710}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=michaeln@chromium.org

Review-Url: https://codereview.chromium.org/2911983004
Cr-Commit-Position: refs/heads/master@{#475709}

increase experiment percentage to 10% to get reliable correctness data sooner

Bug: 660481
Review-Url: https://codereview.chromium.org/2913083003
Cr-Commit-Position: refs/heads/master@{#475708}

BUG=internal b/27694837
TEST=cast_media_unittests

Review-Url: https://codereview.chromium.org/2908893002
Cr-Commit-Position: refs/heads/master@{#475707}

With this CL, in focus videos can be controlled using the up/down keys
(volume), left/right keys (scrubbing), and space/enter (play/pause). This
improves upon the existing functionality, where one must tab over to the
individual control to manipulate it. Instead, the video now only needs to be
in focus to be able to control it.

BUG=135661

Review-Url: https://codereview.chromium.org/2700663002
Cr-Commit-Position: refs/heads/master@{#475706}

Remove loop unrolling to reduce code size in UpdateYUVComponentSizes
by adding for loop.

BUG=None

Review-Url: https://codereview.chromium.org/2897953002
Cr-Commit-Position: refs/heads/master@{#475705}