- 04 Aug, 2020 40 commits
-
-
Devlin Cronin authored
Move //c/b/extensions/extension_action_manager.[h|cc] and associated unit tests to //extensions/sbrowser, since it has no //chrome dependencies. Bug: 1073590 Change-Id: Ic131289b24e71f473788731c20530ac701f769c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259476 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#794623}
-
Pranav Batra authored
Before printerAddress contained the full uri path. Now the hostname and path are properly stored in printerAddress, printerQueue respectively. Also relax printer uri validation to allow printerQueue to contain both the path and query portions of the uri. BUG=chromium:1111654 TEST=Add brother printer to DUT via usb TEST=chromeos_unittests --gtest_filter=PrinterTranslatorTest.* Change-Id: I669a21e02b0fc485a00f1ad33d2f806a4c58042a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331519Reviewed-by:
Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Pranav Batra <batrapranav@chromium.org> Cr-Commit-Position: refs/heads/master@{#794622}
-
Marc Treib authored
Bug: 1110878 Change-Id: I92b45b1a8b97e4e00814886a66e646fb727681dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333837 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#794621}
-
Julian Mentasti-Meza authored
ScreenshotDelegate is a delegate for UIKit's UIScreenshotService, which will be used to generate full-page screenshots and provide the user with the 'Full Page' screenshot tab when they take a screenshot. Bug: 1103777 Change-Id: I9a297834e19507e1c0fdd90162ed40a12b63dc40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305035 Commit-Queue: Julian Mentasti-Meza <jmentasti@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#794620}
-
Noah Rose Ledesma authored
This is a reland of f300ac05 The original change added a method to a mojom interface but neglected to implemnet this method for a class in ChromeOS. This reland adds the missing implementation that caused builds to fail. Original change's description: > GMC: Add IPC for switching the audio output device > > This change adds methods used by the global media controls ui for > switching the audio output device used by a page. > > MediaController::SetAudioSinkId was created allowing the > MediaNotificationService to route the audio output of a > MediaNotificationSession to a specified audio device. > > Mojo interfaces were expanded to allow for this IPC between the > controller and session. > > Bug: 1096243 > Change-Id: Icd0ad17d6ef88ec297444b8b2cbc7ddda6c2c4c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295799 > Commit-Queue: Noah Rose Ledesma <noahrose@google.com> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Sean Topping <seantopping@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Auto-Submit: Noah Rose Ledesma <noahrose@google.com> > Cr-Commit-Position: refs/heads/master@{#792935} Bug: 1096243 Change-Id: I0dad44fc7d1c8daac50519e8625a3cc2150fa34c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328034Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Cr-Commit-Position: refs/heads/master@{#794619}
-
Alex Gough authored
Adds a wrapper to contain building proc_thread_attribute_* and to provide storage for pointed-at items for call to CreateProcessAsUserW(). This does not change functionality, but moves code from target_services into a helper. Bug: 1050359 Change-Id: I3d25e028638b2ea6f2917de1154be7a99fdf5971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330736Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#794618}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 387 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2021-01-31. TBR=chromium-metrics-reviews@google.com Change-Id: Iaf3a51a15bbe639afd4072643b8f2b9ebe24dbb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337053Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#794617}
-
Mike Wittman authored
Updates the ELF image builder to support building relocatable ELF images with virtual address mapping subject to load bias. Parameterizes tests based on mapping state. Fixes ReadElfLibraryName() for the load bias case. Bug: 1105170 Change-Id: I74c37342e50636fb875c2e0a463a987d7312adc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305569Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#794616}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/986a340dd528..8b3601324fde 2020-08-04 wl@gnu.org Minor typos, formatting. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC drott@google.com,thestig@google.com,bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: drott@google.com,thestig@google.com,bungeman@google.com Change-Id: I2bc631fa4fcb18e49b0ce0f64c1d45ef7c4f2520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336655 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#794615}
-
Michael Crouse authored
This change adds a commandline switch for controlling the default donwlink bandwidth. This will be used for testing and local evaluation. Bug: 1112788 Change-Id: Ibe50133f1182506d363a010bbb0194f3fd010520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336295Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#794614}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bec988515e9c..d41280a787d1 2020-08-04 jonahr@google.com Suppress SurfacelessContext test on Android/NVIDIA 2020-08-04 cnorthrop@google.com Tests: Remove more optimizations from traces If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Test: Test: angle_perftests --gtest_filter="TracePerfTest.Run/*nba*" Change-Id: Ie1b5fe7e10566f317db0f85d778bbf9f80d7765c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336896Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1596520791-9a2885d858aeb98ad5bcc11e2200637e7a775fe0.profdata to chrome-win64-master-1596542250-4b9669504bdebb7cf76d0d2b9c7cc833bb153daa.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I691948ebb390448504aa7f37a6032d6b44a9aec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336894Reviewed-by:
-
Richard Knoll authored
Handle click and dismiss actions of onboarding notifications and keep track of the last dismiss timestamp to prevent spamming the user with these notifications. Bug: 1102348 Change-Id: I5aa79deea29f9e3068bcd1890b50d6c85c654ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332634Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#794611}
-
Brian Ho authored
When the hardware doesn't support CTM [1], Chrome OS needs to fallback to applying the "night light" color shift with the compositor [2] by setting the OutputSurface's display color matrix. GLRenderer uploads this matrix to the fs to apply the tint [3]. SkiaRenderer currently does not respect OutputSurface's color matrix, so this CL adds color matrix support via a SkColorFilter similar to how we tint non-overlay content for debugging. [1] https://01.org/linuxgraphics/gfx-docs/drm/drm-kms-properties.html [2] https://source.chromium.org/chromium/chromium/src/+/master:ash/system/night_light/night_light_controller_impl.cc;l=219;drc=a6765a0769369b0d469e3df88e046e18104f7547?originalUrl=https:%2F%2Fcs.chromium.org%2F [3] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display/gl_renderer.cc;drc=42c6a1c82a29862f869d1a3a5ca1b3be4e55291f;l=3375?originalUrl=https:%2F%2Fcs.chromium.org%2Fchromium%2Fsrc%2Fcomponents%2Fviz%2Fservice%2Fdisplay%2Fgl_renderer.cc Bug: 1098435 Change-Id: Ia4772f245c80a73bfc431981f8ab8dc341232eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327810Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#794610}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Iec348432a6388c6a0c41e50cd180703cbe7adc83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335493Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#794609}
-
Caroline Rising authored
Approval given in crbug/962604. Bug: 910739 Change-Id: I26db0a3f807228cbb6d708889129ceb403233734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334812Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#794608}
-
Mario Bianucci authored
Today, custom SVG cursors are blurry on high DPI displays because they rasterized and then scaled up as required for the display resolution. This results in the cursor being blurry. This CL fixes that by scaling the size of the cursor up before rasterizing and placing it into a cursor to be used in the browser process. Bug: 325565 Change-Id: I61e37f4ae4355a534d71022974a30d62fccc53cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321534Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#794607}
-
Toni Barzic authored
Remove the traced process ID from PerfettoService's list of active service PIDs if the process goes away while ConnectToTracingService is in progress. The PID is added to active services list before calling ConnectToTracingService, and if it doesn't get removed, BeginTracing requests will keep waiting for acks from a process that's gone. BUG=1110514 TEST=tast run ui.LauncherAnimationPerf* Change-Id: I1c491536e8740e0e8618dbf3109046440c418749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333873 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#794606}
-
Sean McAllister authored
This migrates is_linux (which is also set for chromeos) to explicitly include chromeos as is_linux || is_chromeos in preparation for separating those flags. Bug: 1110266 Change-Id: I019e775b7ecd01c6a1c401c13d9a29abd35ad170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326290Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#794605}
-
Thomas Tellier authored
Bug: 1101326 Change-Id: Ibcb9e16bf903d518a69a2631b289881f0303f6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333191Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#794604}
-
Egor Pasko authored
Still looking at the data on Dev/Canary. Bug: 1045052 Change-Id: Ibf8f3f54bc944883e4f9450ac85535fff5c7d87b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335287 Commit-Queue: Egor Pasko <pasko@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Egor Pasko <pasko@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#794603}
-
Thomas Tellier authored
5-second instead of 3-second timer for password/PIN going back to masked format. 5-second timer will reset upon character being entered to keep the password/PIN visible during revision. Bug: 1101326 Change-Id: I962139aef26bd9fb68e5110d5169d0f486a5bce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314176Reviewed-by:
-
Hiroshige Hayashizaki authored
In order to use ClassicScript in worklet unit tests, this CL changes Script::RunOnWorker() to Script::RunOnWorkerOrWorklet(). This CL removes a DCHECK() in WorkerOrWorkletScriptController to allow kSanitize in non-importScripts() cases. This is to allow ClassicScript::UnspecifiedScript()'s default kSanitize value to be used in worklet unit tests in https://chromium-review.googlesource.com/c/chromium/src/+/2331758 kSanitize doesn't occur here in non-test environment, but allowing kSanitize here and using ClassicScript::UnspecifiedScript()'s default kSanitize value in worklet unit tests makes it easier to track ClassicScript::UnspecifiedScript() with kDoNotSanitize cases as exceptional. Bug: 1111134 Change-Id: Id4c35427391b263b5bdc9568be95266bb8715a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332096 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#794601}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a1a497ffe792..2de6d657dde3 2020-08-04 john@johnkgo.com SPV: Standalone; sanity check the client GLSL input semantics option value. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I7d1b7edcabf30579bf30ed88c27367eefba743ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336762Reviewed-by:
-
Friedrich Horschig authored
Although every password settings fragment should be launched using PasswordManagerHelper#showPasswordSettings() which requires a referrer, some clients crashed because the bundle seems to be missing regardless. A possible reason is that the fragment wasn't started but just recreated without a bundle. To cover these cases, store the referrer in the savedInstanceState and reuse it on creation. Bug: 1112628 Change-Id: I93805c2d93bae35c5dd0b6647626db87cc7db275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335444Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#794599}
-
David Roger authored
This CL re-organizes the file to avoid duplicated sources and deps sections Change-Id: I6fa29387b6da8c3c2f37412558b2922c2fac5a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335438 Auto-Submit: David Roger <droger@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#794598}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a79b9fd7235f..c6116bf6ce82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC aaronhk@google.com,sinhak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: aaronhk@google.com,sinhak@google.com Change-Id: I04ec65c1b3fafa8f5d0afb166785823897531975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336770Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794597}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596527967-453034edae7748ca30b46c873b3303e5191c764d.profdata to chrome-win32-master-1596542250-9615b306cb5f76d5a757426ea1c30fa3bd674a0e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I611493cff888a73bb559656975643bced09a3cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336772Reviewed-by:
-
Boris Sazonov authored
Reason: flaky. Failed builds: https://ci.chromium.org/p/chromium/builders/ci/Nougat%20Phone%20Tester/14902 https://ci.chromium.org/p/chromium/builders/ci/android-10-arm64-rel/7768 TBR=bialpio@chromium.org Bug: 1112773 Change-Id: I51c3a9c3aa5141ae7442e1da79bc590e2d968fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336602Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#794595}
-
Kevin Babbitt authored
Check for cases where a system color keyword is used on an element whose color-scheme differs from its parent. Refactored color-scheme methods on ComputedStyle slightly so that we can observe the computed value for color-scheme without needing to enable the CSSColorSchemeUARendering flag. Verified using http://wpt.live/css/css-color/system-color-compute.html that the UseCounter is recording on live sites. Bug: 1081945 Change-Id: Ifde1fcddd8bb230a9e2a52cfb4a32818d44b567a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330438 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#794594}
-
mark a. foltz authored
Replace with more inclusive terms per Chromium Style Guide. Bug: 1106011 Change-Id: I6b88cb9bfa1e1b7fa004c6e40b2ea6712cd29083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335486Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#794593}
-
Piotr Bialecki authored
Bug: 1112333 Change-Id: I6be773adf04a41639865521a2eec02b66bd4989d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335895Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#794592}
-
mark a. foltz authored
Replace with more inclusive terms per Chromium style guide. Bug: 1106011 Change-Id: I42537596567d42959e737aeffba16bce34f0cda7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335387Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#794591}
-
Saurabh Nijhara authored
As per product requirement, restrictions such as force sign out, notifications and EOL (End of Life or Auto Update Expiration) Settings banner are not applicable to unmanaged users by default. However, the admin can enable these for unmanaged users by setting the unmanaged_user_restricted flag in the policy MinimumDeviceVersion. This CL is to show the banner on Chrome OS Settings page and management page (chrome://management) for users only if 1) Update is required as per policy 2) Device has reached EOL 3) User is managed or unmanaged_user_restricted is true in policy. This policy is only applicable to ChromeOS. Bug: 1112371 Change-Id: I8e099529b898f1c63ecf7675457f7e1dcf9e80c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335433 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/965b1ffc561e..504a6f1944fe 2020-08-04 jobay@google.com Let `$` return null when no element is found 2020-08-04 jacktfranklin@chromium.org Bridges: fix complex type finding across imports 2020-08-04 jobay@google.com Use custom query handlers to implement $ and $$ in test/shared/helper.ts 2020-08-04 patrick.brosset@microsoft.com Grid: Handle separate row/col color and dash and highlight on grid-template hover If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5bd9a51c25a1a9e2de84a10b3e953374bb028bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336771Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium bb3f2812. With Chromium commits locally applied on WPT: dfdc7fe9 "[WPT] Errors caught/reported for importScripts()" a1917485 "Add WPT for CSP frame-ancestors violation reporting with report-uri" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: Ib34e4b4485db87f845bc48b661139a6a1ddfc5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334585Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794588}
-
Sigurd Schneider authored
This helper function will be used in upcoming CLs in a few places. Bug: chromium:1069378 Change-Id: If5646fa116c1d15c38f7e5ff43d5374cebdeb151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332820Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#794587}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f3bd05074570..46b0d8780f66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib0b3dbe1c1a7c48ab122378fe90106f5e8860dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336507Reviewed-by:
-
Chris Hamilton authored
A variant container for hosting instances of util::TokenType. Allows strong typing when a token can be one of many types. BUG=1096617 Change-Id: Iec386f9760d4b093931ecdc6c477c202ae00bdc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327644 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
-
Alexander Cooper authored
Both the Plane and Anchor Manager currently maintain a map and a uint to generate Ids based on the address of their corresponding type. This logic will soon be similiarily expanded for HitTest and potentially AugmentedFaces. To avoid duplicating this logic, it is extracted into a helper class. Change-Id: I51f4475d37fe84ca687b82761d21a07b5b93d948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333674Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#794584}
-
