- 25 Mar, 2020 40 commits
-
-
Haiyang Pan authored
The following tests starts failing consistently since the build https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-fyi-rel/838 Bug: 1064367 Change-Id: Ibfae8da42da2cbdc44fb8e70ada0f50ee8cd3b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119386 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#753437}
-
Kenichi Ishibashi authored
This CL temporary adds some CHECK to make sure that a ServiceWorkerVersion doesn't have any controllees when it becomes redundant. These CHECKs will be removed once we identified the cause of some crashes. This CL also add DEBUG_ALIAS_FOR_CSTR in ServiceWorkerVersion::AddControllee() to put how a ServiceWorkerVersion became redundant on the stack so that we can retrieve the information from reports. Bug: 1021718 Change-Id: I5c62e475d85aa327852b72d577faf8c5ccafb53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114478Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753436}
-
Gayane Petrosyan authored
Add downloaded file to completed dowwnloads for pre-Q versions and add to MediaStore.Downloads for Q+ versions. Bug: 993920 Change-Id: I9c4f88c218276ca59a2e1ebf14603af2e080eca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106672 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#753435}
-
Livvie Lin authored
Bug: 1061576 Change-Id: Ie3c6fcf924e8e08282fd710ccb69f5551fe4c1e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120454 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#753434}
-
Karandeep Bhatia authored
extensions/browser/api/declarative_net_request:declarative_net_request depends on extensions/browser:browser_sources. However some sources in extensions/browser:browser_sources also depend on extensions/browser/api/declarative_net_request:declarative_net_request causing a cyclic dependency. This dependency is necessary since DNR needs to hook into the installation flow. This dependency is not declared which can cause problems (e.g. configs won't be propagated correctly). Fix this by creating a new leaf target on which both extensions/browser/api/declarative_net_request:declarative_net_request and extensions/browser:browser_sources can depend on. BUG=1064163 Change-Id: I536567bb1c3ca03117bd779fd205fb49b1af4849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117450 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753433}
-
Oriol Brufau authored
r708735 made the language list scroll to the very top when typing in it, to avoid the effect of getting momentarily stuck while scrolling up. However, this prevented users from scrolling with the PageDown or PageUp keys. So this patch excludes them. Fixed: 1064190 Change-Id: Iba3a134444ccae7afa31076666e6cbcc3d932c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121255Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#753432}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/54f9ec739967..d6f84edeb857 git log 54f9ec739967..d6f84edeb857 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 wuwang@chromium.org Fix a flag, and call InitDependencyManager before call FetchPath. Created with: gclient setdep -r src/third_party/catapult@d6f84edeb857 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1060399 Tbr: skyostil@google.com Change-Id: Iefd7062d717c54f65eec29aac3e7e954c690750a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121220Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753431}
-
danakj authored
R=avi@chromium.org Change-Id: I82773ba75a97887d57ccbbb21b54c45193da0729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121082Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#753430}
-
Thomas Anderson authored
This reverts commit 838eb034. Reason for revert: Build failure on android-archive-rel: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/10360 Original change's description: > VulkanImage: support create from GpuMemoryBufferHandle on Android > > VulkanImage::CreateFromGpuMemoryBufferHandle() is added to replace > VulkanImplementation::CreateVkImageAndImportAHB(), and will replace > VulkanImplementation::CreateImageFromGpuMemoryHandle() as well. > > Bug: None > Change-Id: I7c6e3cea685f1ec305790f4a6d7bb66164f26e55 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114587 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753394} TBR=penghuang@chromium.org,rjkroege@chromium.org,vasilyt@chromium.org Change-Id: I08dcc519da5e693fc08e0323036dc691b6eaff7d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121418Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#753429}
-
Peter Williamson authored
This reverts commit 781b45f9. Reason for revert: It seems that the experiment name needs to match the flag name, so we'll revert the experiment name change, and instead change the experiment name that we use on the Finch side. Original change's description: > Rename experiment to FeedSendFeedback. > > The experiment name needs to match finch instead of matching the > name of the flag we use in chromium. > > Bug: 1045246 > Change-Id: Ie64379eb275d3a0c51c9d3237d9e12602003cc8a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117914 > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Dan H <harringtond@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753222} TBR=petewil@chromium.org,asvitkine@chromium.org,harringtond@chromium.org Change-Id: I37cb062deda3f30f457300a9b7bf4437c75475af No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1045246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121496Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#753428}
-
Peter Kasting authored
A number of different tests want this, so provide it all the time. Bug: none Change-Id: I04b49b955621594b47ab74305c98abeb206532c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121335 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#753427}
-
Nicolas Arciniega authored
Doing this cleans up an undesirable ConfiguredProxyResolutionService usage pattern where code that primarily works with a ProxyResolutionService must currently cast to the specialized class before setting the right PAC quick check value. Bug: 1032820 Change-Id: I777eb1c6097a604bf522e7d87f8806f4df0324b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113802 Commit-Queue: Nicolas Arciniega <niarci@microsoft.com> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#753426}
-
Shimi Zhang authored
Pointing the related code to the newly added doc. Bug: 1063189 Test: No logic change. Change-Id: I5fa3bdebe521b49a8f32241e4406ac9c072ec302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107569Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#753425}
-
Devlin Cronin authored
Typically, extension parsing errors should not be localized (for a number of reasons), but icon validation errors were. Change them to be simple strings, and also link to the manifest key where the icons were specified. Bug: None Change-Id: I89cd43b4cc895559a55f346b27399029fe116f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081015 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#753424}
-
Trent Begin authored
The parameter name passed to the DoSomethingAndReply example function does not match the name of the callback given to PostTask. Bug: none Change-Id: I7899a22880adb0ea98f717e6415a3ce562853ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121349 Auto-Submit: Trent Begin <tbegin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#753423}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5c4c61eeb38f..bccb5f3b3896 git log 5c4c61eeb38f..bccb5f3b3896 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 csmartdalton@google.com Add a simple FPS meter to CanvasKit viewer 2020-03-25 brianosman@google.com SPIRV: Track function signatures by SpvId(s), rather than display name Created with: gclient setdep -r src/third_party/skia@bccb5f3b3896 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I55ac3e7f950e00fc3cedf71c6a2020c8efb1058e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121219Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753422}
-
Mitsuru Oshima authored
This is a follow-up CL for crrev.com/c/2104457. Bug: 1057024 Test: covered by unittest Change-Id: I0733a19c08deeec2ca43f5930c3c185451fe39ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113911Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#753421}
-
Becca Hughes authored
Factor out the media data table. BUG=1059352 Change-Id: I1ffc498d270491eeb3a433de1e7e6c3fc722e3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116783Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#753420}
-
Sam Fortiner authored
This histogram did not provide sufficient insight into how changing composition decisions affected the use of LCDText on a page. It was very difficult/error prone to reason about the data as changes in what was composited affected both the number of layers as well as the percentage of layers in a bucket (LessThan10, 10To30, MoreThan30) that were composited. We will be looking for another UMA to gather this information. Bug: 1063904 Change-Id: If670a7c2abff5d9ee33d822d005c9070b758a478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117530Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Sam Fortiner <samfort@microsoft.com> Cr-Commit-Position: refs/heads/master@{#753419}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e2ac022f0bdf..4c3eb703583e git log e2ac022f0bdf..4c3eb703583e --date=short --first-parent --format='%ad %ae %s' 2020-03-25 ehmaldonado@google.com git-cache: Decode subprocess.check_output Created with: gclient setdep -r src/third_party/depot_tools@4c3eb703583e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1064547 Tbr: agable@chromium.org Change-Id: Ie915e0da276be2586098062e9f1e93f214078061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121218Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753418}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/449349092a72..94584718d2c2 git log 449349092a72..94584718d2c2 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 kimanh@chromium.org Updates wasmparser to generate unified disassembly Created with: gclient setdep -r src/third_party/devtools-frontend/src@94584718d2c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1043031 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1dfcdb86f96ef55978bc9b3d063dcc1d3e6ff786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121217Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753417}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/754d46b1..5ba92999 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1db1d64e4eb1822148aa89b41cf6d0cad7d63766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120794Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753416}
-
Jia authored
As majority of out clients will be calling the service in-process, we are working to towards using C++ impl directly to avoid mojo overhead. We will add mojo to support out-of-process overhead. This cl is the first step towards that (see bug below). Specifically, this cl 1. Allow LocalSearchServiceProxy to return impl directly. 2. Add sync functions to IndexImpl. 3. Add C++ structs that are equivalent to the mojo structs (Data, Result etc). The mojo structs will be removed later. Following the cl, the existing user of the service (settings) will update their function to use impl directly and will make sync calls. In the following cl, we will remove the mojo interface and rename relevant functions. Settings will make changes accordingly but this two-step change should be simpler than changing everything in one cl. Bug: 1064424, 1018613 Change-Id: I1200779483146a0344f0b15191918c0471b04c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114470 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#753415}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c77cb596a2c3..a7510f0675df git log c77cb596a2c3..a7510f0675df --date=short --first-parent --format='%ad %ae %s' 2020-03-25 ynovikov@chromium.org Re-enable angle_end2end_tests on 32-bit Windows SwiftShader Created with: gclient setdep -r src/third_party/angle@a7510f0675df If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I99eb889639ba00fe3001f4d3833e862076e3e6f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120911Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753414}
-
Sven Zheng authored
Commenting on gerrit feature was temporarily disabled on Skia Gold side. Using the wrong format for tryjob could get unexpected CQ pixel outputs merged to CI pixel outputs. Bug: 1059469 Change-Id: I4c141193e706bc106d09db9ba410c4ae1daff9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119582Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#753413}
-
Chris Harrelson authored
Change-Id: I61b08b576bbdd5f2450444580a23f12526f0776f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121350Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#753412}
-
Nicolás Peña Moreno authored
FindIt keeps finding more flakes. This CL marks all these tests as flaky. Bug: 1062984 Change-Id: I3512ad15af800d8e4f37d2952dca1762578253a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119385 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Auto-Submit: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#753411}
-
Klaus Weidner authored
This should be more accurate than using wallclock time, but is a bit clunky since unfortunately ARCore uses an unspecified time base, so it's not directly compatible with base::TimeTicks. Bug: 1064629 Change-Id: If4a73f26b7b5aaa7e87a615a15ad4b9031f5aa32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119637 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#753410}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 25f2a15c. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 39f5c78d "Reland test for lost pointercapture in disconnected node in shadow dom" 86287853 "NativeIO: Plumbing and minimal functionality." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I15ffc3191b4cbf6c56fa8bdc575c565b31826b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119112Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753409}
-
Nathan Zabriskie authored
Remove another instance of ContextGL from the shared main thread context in preparation for OOPR Canvas. Also a semi-step toward supporting texture upload on RasterInterface. Since RasterImplementationGLES just wraps glTexSubImage2D I anticipate that the WritePixels interface will look different for the RasterImplementation version as it won't rely on texture_target. Bug: 1063725, 1018898 Change-Id: I5ae922b5496690e4b6135e98fa0bcb76c144d7f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119635Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#753408}
-
Mitsuru Oshima authored
This was accidentally left out when format was changed to support 3 (and more) displays. I had to change the emulation code to support new behavior. We carry over the mirror state so that unified desktop can switch hw<>sw mode w/o exiting unified. Bug: None Change-Id: Icc219dab34251b2fba1f19db3f545cbf6de5a314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114580 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#753407}
-
Nico Weber authored
Bug: 346399 Change-Id: I41c8cf8581bff1256a28a15c80bdd59a599b0cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119759 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#753406}
-
Vladimir Levin authored
This patch aligns with the spec by switching the viewport intersection state in the context only at the next-frame-post-raf-callback timing. This has already been inadvertently tested, and the tests are updated to reflect new expectations. R=chrishtr@chromium.org Change-Id: Ia8e21c33e3c399f82cfda7fd79b7e12bf4dd3fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121038 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#753405}
-
Chris Harrelson authored
Previously, if |layer| was a stacking context, we would only call SetNeedsGraphicsLayerUpdate on it, but if it loses its backing then we should call it on the ancestor stacking context graphics layer also. Bug: 996931 Change-Id: I88aede8446eded11432334a58ea1a13cd5174c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120050Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#753404}
-
My Nguyen authored
Implement based on design doc at http://go/e14s-suggestion-window Screenshot view: http://screen/MO1QeHfRwi4 Note: Unit tests to come later. Bug: 1060965 Change-Id: I8d46a07892ca0b5373169d4acf5e563c24b1f44c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116162Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#753403}
-
Caleb Rouleau authored
Change-Id: I9abf963d70f931c4d4b4b252df6535e2ad88dd04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119633 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#753402}
-
Xianzhu Wang authored
When we added the conditions we expected that crbug.com/900241 would be fixed soon for CompositeAfterPaint, which hasn't happened yet. Removing these conditions to reduce difference between CAP and pre-CAP. Another reason of removing the conditions is to let the effect/filter node know some of the compositing reasons of the transform/effect node, so that when an object is forced compositing with will-change:transform/opacity, we won't decomposite that effect to avoid raster invalidation on change of the effect. Bug: 765003 Change-Id: I4f2deda6b08c1efb93841a9a804c22e99dd42f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118390 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#753401}
-
John Rummell authored
It looks like SharedBufferHandle can fail to map into the current processes address space, so check that it succeeds before creating a MojoCdmBuffer. If it fails, return NULL. Bug: 1063823 Test: Encrypted videos play (using Shaka Player) Change-Id: I02a2f9f1daea7cd0188f77ee051ac9fe012d8119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118890 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#753400}
-
Thomas Lukaszewicz authored
Removed the need for TabGroupIconImageSource from the ExistingTabGroupSubMenuModel and instead switched to using vector icons for the group image. When the ThemedVectorIcon change gets merged in this change will enable the group icon to be rendered using colors obtained through the ThemeProvider supplied from the rendered menu's Widget. Bug: 1056916 Change-Id: Ibc8bb5df41cd2b8e9e5baea97822d97e28c2e246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116492Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#753399}
-
Thomas Lukaszewicz authored
Currently child windows do not track the themes of their anchoring widget. This can lead to theme mismatches in spawned bubbles (in particular icons relying on native theme colors in the profile menu for linux themes). This change follows on from a previous change that fixes the issue for ThemeProviders in Bubbles. Follow up CLs should address the issue for the more general case of widgets tracking the themes of the Widgets that spawned them (see https://crbug.com/948859). Bug: 1057962 Change-Id: Ie3a71208cb920e8bced6a8bb2f42968bad46f403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121075 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#753398}
-