- 24 Jun, 2020 40 commits
-
-
Sunny Sachanandani authored
This reverts commit fc04607a. Reason for revert: Likely caused several regressions Original change's description: > cc: Subtract estimated display draw time from begin frame deadline > > Display draw time was being subtraced from display scheduler's deadline, > but a similar adjustment was missing from cc scheduler's deadline. To > fix this inconsistency, this CL applies the deadline adjustment at a > single place, the begin frame source so that there's no mismatch. > > This makes cc scheduler have a later deadline and can cause it to wait > longer for the main thread. Recent experimentation has shown improved > latency in the absence of a scheduler deadline. It's hoped that some of > the improvement can be achieved by just fixing the deadline. > > Bug: 1042584 > Change-Id: Ia948b64c1dbba5239d1b97062224e73487e35fba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045210 > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781159} TBR=sadrul@chromium.org,sunnyps@chromium.org,khushalsagar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1042584, 1098444, 1098229 Change-Id: I3dcad61af5f1ef6d8a38a3290c6c2e04c503dbb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264629Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#782068}
-
Elly Fong-Jones authored
Bug: None Change-Id: Iade75c41046ef96acb32c9f074a0e632fbccd488 Tbr: chcunningham@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264863Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#782067}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/29d59a140248..75fd127640bd 2020-06-24 sprang@webrtc.org Allows FEC generation after pacer step. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia480a8d36ee44b65a2adaccf3d542f8f3729b6b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264916Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782066}
-
Dominic Farolino authored
R=fs@opera.com Bug: 993273 Change-Id: If692195679f4b10f32449c04d34196260c22c55c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256853 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#782065}
-
evliu authored
This CL updates the DefaultRendererFactory to use the "OnReady" speech recognition callback to determine if and when speech recognition is available rather than continuously making mojo calls to the render thread. Bug: 1098552 Change-Id: Iabf19155f350bb6bd5aac8a6b157decb457d110e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261740Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#782064}
-
Leonard Grey authored
Bug: 1062493 Change-Id: I9b157a9c7e1f03563c090e4b629babc1d682e83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250347Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#782063}
-
Robert Ogden authored
If the origin probe fails, then no subresources should be loaded from the isolated cache. Bug: 1082505 Change-Id: I8f3411ad9e0fcbc2376cf43317fe8a6cfb125b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261411Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#782062}
-
Victor Fei authored
CL:2242046 introduced ui::UiaRegistrarWin for registering custom UIA property and event. This change moves the custom UIA event used for signaling test end to ui::UiaRegistrarWin. There is no functionality change. AX-Relnotes:n/a Bug: 847971 Change-Id: Id1b8852d788d5533e14bc63588fd26669ae78eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261876Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#782061}
-
Meilin Wang authored
This is a follow-up CL of the original: https://chromium-review.googlesource.com/c/chromium/src/+/2253363/ Upon shown, wake lock will only be requested when the battery is charging, and also be release when the charger is disconnected later. Bug: b/159382866 Test: covered by unittests. Change-Id: I62d94d645a67c07c2310b6d1a7ee8220a24c77f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259773 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#782060}
-
Ian Kilpatrick authored
Previously if we hit an anonymous flex-item we wouldn't update the hit-test result with the flexbox itself. This updates the hit-test with the flexbox if no node is set yet. Bug: 1097654 Change-Id: I4b9d1754061aae14dd8fa6a9f33d8d065c838db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264017Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#782059}
-
Jason Chase authored
Minor refactor to have all AddToken* methods have |token(s)| as the first parameter. Split off from http://crrev.com/c/2173473. Bug: 1073920 Change-Id: Icbb2699849e74743e7584f981aa831e407134986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261634Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#782058}
-
Darwin Huang authored
Change-Id: Ie2125b4bc4cf46db8f0e0f73f80dd30224ae049a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254352Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782057}
-
Patrick Noland authored
This reverts commit ea45d4f3. Reason for revert: breaks compile (https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8876580958035597312/+/steps/compile/0/stdout) Original change's description: > Add supports to Lens Shopping experiments for google.com > - enable lens shopping experiments variants for google.com > - add unit tests to LensUtilsTest for shopping intent > > Bug: 158099013 > Change-Id: Ib605afcfe069320a0b2a52d4ea045759a39e3592 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261093 > Commit-Queue: Yu Su <yusuyoutube@google.com> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782024} TBR=twellington@chromium.org,benwgold@google.com,yusuyoutube@google.com Change-Id: I8c607c310d540b6b491ff07c20147f9ba1ecdb7a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 158099013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264505Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#782056}
-
Tommy C. Li authored
Before this CL, Entity suggestions from ZeroSuggest would have their text color messed when switching back and forth between dark mode. This CL fixes it, and adds a TODO explaining some technical debt we have. This CL also makes a similar fix to Answers, which doesn't seem to happen in practice, since Answers don't show up in ZeroSuggest, but this is the more correct thing to do. Bug: 1095205 Change-Id: I2364bb578bbfe47705c594bfe423da694df6aad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264853 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#782055}
-
Evan Stade authored
This adds the glue code for MediaSession to work in WebLayer. A new Service class is required in the client library to display the notification. This service proxies lifetime events to WebLayer implementation, which then glues together componentized code. Of note: 1. notifications displayed with Service#startForeground cannot have a tag, so the ID must be unique across all application notifications. There's a default ID for the MediaSession notification, but an API is also added to WebLayer to allow setting a different ID, in case this one conflicts. 2. favicons are not supported (normally they'd be used as fallbacks for iconography/images not provided by the system) 3. Extra handling is required for the action button icons to work, see WebLayerNotificationBuilder. On L, we fall back to system icons, which look bad because of their low resolution, but are at least functional. https://googlechrome.github.io/samples/media-session/ Test: automated tests TODO; manual testing on Bug: 1066263 Change-Id: I5e2ae13a07315e73aae474251cb5c0424804a427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220551Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#782054}
-
Ng Zhi An authored
Tested with: python build.py --without-android --without-fuchsia \ --run-tests --skip-checkout With python == python3.7 (inside a pipenv). - get maxint from sys.maxsize from Py3 (sys.maxint is removed) - use StringIO from io - use .values() instead of .itervalues() - tweak lambda used in sort (became syntax error in Py3) - check_output with universal newlines, will open stream as text Bug: chromium:941669 Change-Id: I80ca9ae6d2f6d712c6e3cac5343627512ce84b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261715Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782053}
-
Alison Maher authored
http://crrev.com/c/2118693 caused the invert bubble to start showing up on Mac in increased contrast mode when a new incognito window was opened. http://crrev.com/c/2247407 addressed this temporarily by disabling the bubble for incognito windows. This change is a follow-up to http://crrev.com/c/2247407 as a more permanent solution to the original problem. The invert bubble should show up in the High Contrast dark theme on Windows. However, GetHighContrastColorScheme() was calling into UsesHighContrastColors() to detect this. The problem with this is that on Mac, UsesHighContrastColors() has a different meaning than on Windows. To fix this, make GetHighContrastColorScheme() a virtual function and only return the High Contrast theme on Windows. Bug: 1095855 Change-Id: I24a7ed2dd5b9194a795d1560ba1e5f4be85afd98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250224Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#782052}
-
Francois Doray authored
This CL uses the unaligned wake ups setting added to WakeUpBudgetPool in https://crrev.com/c/2249377 to allow unaligned wake ups in frames that are same-origin with the main frame. This completes implementation of the policy presented in this message: https://groups.google.com/a/chromium.org/g/blink-dev/c/8En_5DqV_fU/m/z0Xth2xLAgAJ Bug: 1075553 Change-Id: I1ac00f1efc58f1a701120514fb7ca4dcca94ba9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252935 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782051}
-
Elad Alon authored
This is not really an error; it happens quite naturally if the user profile has not enabled remote logging. Bug: 1098331 Change-Id: Ia4393ff5ac42e8e3b6ddaaa3ab08a39e75e8ebb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260875 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#782050}
-
Ben Schwartz authored
This replicates the desktop UI, with platform-appropriate adjustments. Bug: 1040146 Change-Id: I33cea7dd37086d87580e149404ed3619a828ee45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240456Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Ben Schwartz <bemasc@chromium.org> Auto-Submit: Ben Schwartz <bemasc@chromium.org> Cr-Commit-Position: refs/heads/master@{#782049}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2f852116281b..4c9667c115b0 2020-06-24 jec@chromium.org Update What's New UI for Chrome 85 2020-06-24 patrick.brosset@microsoft.com Grid: Skip line labels to avoid overlap 2020-06-24 janscheffler@chromium.org [Experience] Add related node to CLS 2020-06-24 tvanderlippe@chromium.org Add @types/estree to dependencies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1098673,chromium:1098730,chromium:1098785 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I28c0afb47dd0ac77716909cfc1ffe4e060ace9b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264915Reviewed-by:
-
Jorge Lucangeli Obes authored
set_robust_list(2) is blocked in the baseline BPF policy because it's used for inter-process futexes, which are not used by Chrome processes. However, because it's being EPERM'd, it's generating quite a bit of logspam on Chrome OS. Moreover, the syscall never EPERM's according to its manpage. Allow set_robust_list(2) for NaCl specifically. This syscall also doesn't allow interacting with other processes (only modifying the calling process), so it shouldn't be too bad to allow it. Moreover, NaCl is going away so this problem will solve itself in a few months. BUG=1051197 TEST=Enable NaCl on the open web in chrome:flags, TEST=Open NaCl demo, TEST=$ grep nacl /var/log/audit/audit.log is empty. Change-Id: I25cec12067a60c3379e55d36806e07c0f2b10caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264573Reviewed-by:
Derek Schuff <dschuff@chromium.org> Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#782047}
-
Elly Fong-Jones authored
This test uses an uninitialized member variable to keep track of calls. Bug: None Change-Id: Ie99dc04857d5b0bf889dcd88a0478d8fef59426b Tbr: khorimoto@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264584Reviewed-by:
-
Tibor Goldschwendt authored
Fixed: 688960 Change-Id: I71631b7a6fa0ccda9596eae0517b349ef8fe9675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262058Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#782045}
-
Justin DeWitt authored
SurfaceDependencyProvider is badly named (since it is application level dependencies). However, a rename is not possible without breaking the internal tree for some period of time. So, we will do a 3 sided change. First step is to move all methods into a properly-named interface superclass. Change-Id: I7da10b5bfffb53c2e3b685bdc5b4145f1e83d7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261633 Auto-Submit: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#782044}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/c17985424391fcbaaa57f733b7197c5dd3e510aa..430a7423039682e4bbc7b522e3b57b2c8dca5e3b The following commits have update notes: 33f8d33af Convert X.509 accessor macros to proper functions. d206a11d4 Remove X509_CINF_get_issuer and X509_CINF_get_extensions. beaf594f8 Remove X509_get_signature_type. dd86e75b2 Check the X.509 version when parsing. fd86eaa86 Fix x509v3_cache_extensions error-handling. Bug: none Change-Id: Ic03b5430a3651594df2f8504abb6b154b0e38d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264495 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#782043}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Iac292ff2e010028eb5f66819b90feea69dc6ade4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264336Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#782042}
-
Behdad Bakhshinategh authored
This reverts commit d64b01c3. Reason for revert: crbug.com/1098916 vulkan_pixel_skia_gold_test and vulkan_content_browsertests failures on on Android device Pixel 2 Original change's description: > Utility function to create VkImage from ScopedHardwareBufferHandle. > > Add a utility function to create VkImage from > ScopedHardwareBufferHandle. This helps to unify > common code. > > Bug: 1091945 > Change-Id: I87448b6a577bba95420ed0dd4f8d6925501cdec5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263478 > Reviewed-by: Peng Huang <penghuang@chromium.org> > Commit-Queue: vikas soni <vikassoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781848} TBR=penghuang@chromium.org,vikassoni@chromium.org Change-Id: I8016e4e108e4baad6b9d1e533fe616cc0f009f45 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1091945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264587Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#782041}
-
Alan Screen authored
Serialization support of metafiles will soon be expanded to handle font typefaces. Clarify the naming of the existing support for pictures ahead of the addition of contextual support for typefaces. Bug: 1044996 Change-Id: I4e8f52026276a6a5e5b81f77818b1022d3f24033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264619Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#782040}
-
Anatoliy Potapchuk authored
Currently, before the first launch of web kiosk app, the icon is not loaded and remains default until user installs the app for the first time. This can be somewhat inconvenient. In this cl we will use url provided by policy to download the icon. Bug: 1066496 Change-Id: I2b7a105723b4ff62748e95e211f1c9e67a11c077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257896Reviewed-by:
Anqing Zhao <anqing@chromium.org> Reviewed-by:
-
Mike Dougherty authored
This test was originally failing on iOS 12 device, but disabled for all configurations. The test passes locally on available devices (iOS 13.5.1 and iOS 14). Bug: 1060758 Change-Id: I14cab0b8aaff25c9da4728459ba0819c0b5a4e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264852Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#782038}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f9898ac95a9b..ba416f33b636 2020-06-24 jbudorick@chromium.org devil: add --blacklist-file back to device_recovery temporarily. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1097306,chromium:1098775 Tbr: oysteine@google.com Change-Id: I159571126491456342e82e581731350ee2c92154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264848Reviewed-by:
-
Lily Chen authored
Warning messages for cookies with unspecified SameSite that are accessed in a cross-site context, and for cookies with SameSite=None but not Secure, are removed from the JS console in DevTools. Analogous warnings have been added to the DevTools Issues Panel, so these are no longer needed. Bug: 977040 Change-Id: I7089e11679d603db8e9bb6e1380dca949dd2aa89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264262Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#782036}
-
David Dorwin authored
This reverts commit c0913ca9 and most of commit b11af76b, including support for release channel suffix on packages, archive_name_override, and C++ build flags for channel name. context_provider_test_connector.* are kept in their new locations. The TODO for https://crbug.com/1046615 is removed as that is obsolete. Bug: 1029184,1046615,1049378 Change-Id: Ia0b7191d15a889bc497ce77a4250b9db168e58f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262594Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782035}
-
Lucía Cantú-Miller authored
Several console methods were intended for old Chrome versions that are not longer supported. Console.messageAdded event was eliminated and Chrome 54 TODOS where resolved. Unit test was updated to test newer Chrome versions. Bug: chromedriver:3518 Change-Id: Iebf08a32a3c90d3ffd200fb81686c54a636d49f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259132Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lucía Cantú-Miller <cantumiller@google.com> Cr-Commit-Position: refs/heads/master@{#782034}
-
Robert Ogden authored
m.foo.com can set cookies on foo.com, so when checking for cookies in the eligibility code path, any cookie applicable to the same or higher domain up until TLD should cause the prefetch to be non-eligible. Also adds some browsertesting in the same vein. Bug: 1096765 Change-Id: I23801d45bbdd789b52977613bf1086deda166460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264933Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#782033}
-
Yves Arrouye authored
By default the absence of the flag means that the feature is disabled. This is to protect code while in development. Bug: chromium:1098854 Test: Manual Change-Id: I20063bf28ea74d9aeaa1bb541809fc6ab7162c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264577 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Auto-Submit: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#782032}
-
Tim Judkins authored
Changes the expected schema format that indicates promise support to no longer specify a callback in the parameters, but instead supply a "returns_async" key. This key species the format of the return value to the promise, or to the callback if one is supplied. Also adjusts associated tests to check for such. Bug: 978538 Change-Id: Ifcb0b8e8152fd6b6c9049e2d856b10d577c955fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253205Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Tim Judkins <tjudkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#782031}
-
Daniel Rubery authored
These tests were disabled due to MSan failures, but have been fixed by https://chromium-review.googlesource.com/c/chromium/src/+/2253759 Fixed: 1096972 Change-Id: I49d5da2660c78a55b7b5590e7b6f775c4bf65a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264018Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#782030}
-
Charlie Hu authored
The CL which caused the flakiness was reverted in (https://chromium-review.googlesource.com/c/chromium/src/+/2218833). The cause was attaching request params to image requests causing multiple requests being sent(previously only one request with one url). Upon first layout, different number of requests complete causes flaky behaviour. Unmark the test as flaky. Bug: 1087208 Change-Id: I5124c9107b50500962e82e63c6f846f557d6f282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261255Reviewed-by:
-
