- 25 Jul, 2020 40 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0d158ac68107..d5a4775cfc77 2020-07-25 hao.x.li@intel.com Query API: QuerySet on D3D12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ib3a7c6cafe9b147e351644e6afdc44b53f9b009a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319122Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791516}
-
Liquan (Max) Gu authored
Change: * Move the following methods from PRImpl to PaymentUIsManager without logic changes. - getModifier - getLineItems - loadCurrencyFormattersForPaymentDetails - isMixedOrChangedCurrency - getOrCreateCurrencyFormatter * Because the methods being moved reference some PR parameters, we also add getModifiers and getRawTotals to PaymentRequestParams. * Because the methods reference mCurrencyFormatterMap, mUiShoppingCart, they are moved into PaymentUIsManager as well. Bug: 1102522 Change-Id: Iaf69afee236bc9369bea4e87ee4d2547800d5487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310900 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#791515}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0ca429b29e9d5e72bbbdd9950f486212b61f13ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314935Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791514}
-
Marijn Kruisselbrink authored
Introduces directories where access to the directory itself is blocked, and access to subdirectories is blocked as well, but individual files can still be opened. This enables opening of individual files stored on for example MTP devices on Windows, which is implemented on Windows by copying the file to a temporary directory and returning that path to chrome. This does not give access to folders on things like MTP devices. That will require a much larger rewrite/implementation of new file system backends, and is unlikely to happen anytime soon. But at least it won't result in the confusing "blocked because in a system folder" error if a user opens individual files on an MTP device (anything else is already filtered out/blocked by the file dialog itself, by the flags chrome passes to the file dialog). Also adds logging when we block access to a directory to make it easier to troubleshoot why certain paths are blocked, even if we can't reproduce it ourselves. Bug: 1094835 Change-Id: I170c3b9fa83c809d63d0a031aec5debd10bb3ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316888 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#791513}
-
Xida Chen authored
This is one of the key input metrics, so extend it for another year. Bug: 1105083 Change-Id: I312490b1149323ea2c5be229251361b7e7769a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300606Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#791512}
-
Ghazale Hosseinabadi authored
In this CL, we make code changes to revoke extension's permission when updating to incognito mode. We also add a unit test to verify the expected behavior. Bug: 633706 Change-Id: I617092c1ed954b7d10b71f8d61a08154657f9262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293077 Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791511}
-
Mikel Astiz authored
This patch migrates tests away from deprecated APIs and adopts TestingProfile::Builder for tests in /chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm. Rationale: creating or overriding keyed services after the profile has been created is problematic and known to cause hard-to-debug test flakiness, because it bypasses BrowserContextDependencyManager and often leading to use-after-free. This CL was uploaded by git cl split. R=mark@chromium.org Bug: 1106699 Change-Id: I4583985cfaa38bdd820ddd43ad0f3757b93f403c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316208 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#791510}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ieaffc63cff8d92af05db651a5bdb965178f47657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318428Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791509}
-
Evan Stade authored
Fixed: 1109261 Change-Id: I1533048a2d8e67f0b82a1d20769ad22bf35c6213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317765 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#791508}
-
Yusuf Sengul authored
This change adds abstraction for the Windows APIs that are used create and manage GCPW extension. Bug: 1101590 Change-Id: I5fb88a6f73cc4c85f42728b9dee487d1067b8bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278651 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#791507}
-
rbpotter authored
Bug: 1105701 Change-Id: I1f45d55f6eb744bc63885016e5e8a9b2b4571d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311521Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#791506}
-
Xing Liu authored
There is a new property in modal dialog to control whether the positive button is blue. For download later dialog and location dialog, the positive button should be blue. Bug: 1108865 Change-Id: I6ee6d6c1b3e190c9a7186dcfe31929f13b0c96cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315431Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#791505}
-
Lei Zhang authored
They are explicitly inline. Fix some lint errors along the way. Change-Id: I94b8ea7ed7ab2025163d92f06db220f889094cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315223Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#791504}
-
Mikel Astiz authored
This patch migrates tests away from deprecated APIs and adopts TestingProfile::Builder for tests in /chrome/browser/importer. Rationale: creating or overriding keyed services after the profile has been created is problematic and known to cause hard-to-debug test flakiness, because it bypasses BrowserContextDependencyManager and often leading to use-after-free. This CL was uploaded by git cl split. R=gab@chromium.org Bug: 1106699 Change-Id: I69553cfbfa8231eab0805402b64a2d7b03786ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316536 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#791503}
-
Nohemi Fernandez authored
BookmarkEarlGrey contains the required methods that are being re-implemented in the Signin codebase. To ensure consistency across the codebase remove sign-in versions and update tests. Bug: 1103274 Change-Id: I2a9348945def367512240279731e7e9b6839960f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290633Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#791502}
-
Mounir Lamouri authored
Bug: 1108415 Change-Id: I6fe8888a8c70ca4217a9738fecd82b46d188c485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314817 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#791501}
-
Avi Drissman authored
There will be different binaries offered for Intel and Arm Macs, so distinguish them. This achieves this via a slight refactor, funneling all the places that show this data through the same function. Bug: 1106067 Change-Id: Id5f44ab4d7ca3186d09669984abed5b0377224ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305749 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#791500}
-
Pavol Marko authored
This is a speculative fix for flakiness in SitePerProcessIgnoreCertErrorsBrowserTest.SubresourceWithCertificateErrors. Instead of assuming that the SSLStatus of a NavigationEntry is finalized when the navigation completed, wait for the WebContents to announce a visible security state change through a WebContentsObserver. Bug: 1105145 Test: content_browsertests Change-Id: I52333c49e82f22a9bbd8b5f82f0e9c69121eb58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316360 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#791499}
-
Lei Zhang authored
It is not obvious what's going wrong, so save some data into the crash dumps to help with the investigation. Bug: 1108574 Change-Id: I4a9bbc147e2d47ca901e7ff35b44f7edf05de975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315080Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#791498}
-
My Nguyen authored
We are merging languages settings in browser into OS settings in Chrome OS, so some metrics are added to track users responses and interactions. This is the second CL following adding metrics for OS settings. Bug: 1106033 Change-Id: I2861bfe702a7edc6fbc05dbf13db55543aa11e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299666 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#791497}
-
Stefan Zager authored
It broke with: https://chromium-review.googlesource.com/c/chromium/src/+/2301589 Also, add my self to OWNERS, because I care. Change-Id: Ibb344fc4f432b5d3815ea40ab8e121e9403fa513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316946Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#791496}
-
Aga Wronska authored
Bug: 1088894 Change-Id: I9b84e130df9b72ef00d37e50d993c8313bcf5d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315923Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#791495}
-
Gayane Petrosyan authored
Bug: 1102382 Change-Id: I7a4bcfdf6ed30a3ff458f8b4c8e022a7daa2aa6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311678 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#791494}
-
Philip Rogers authored
This patch adds a UseCounter for position: sticky by tracking when new StickyConstraints are added. This feat is achieved by removing non-const access to PaintLayerScrollableArea::GetStickyConstraintsMap and adding an explicit "AddStickyConstraints" function that increments the counter. Bug: 1109232 Change-Id: Ic0543c6e3501019ada58aeec2c3885c3854c7897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317607 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791493}
-
Roman Sorokin authored
Fixed: 1062246 Change-Id: I04a2c875497b14b5e9418bdd6a2abebabccbc384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316205 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791492}
-
Avi Drissman authored
The "IsOS/IsAtLeastOS/IsAtMostOS" functions are driven from the Darwin version number, which is always accurate. Adjust the SysInfo::OperatingSystemVersionNumbers() function to return accurate version numbers (or the best we can deduce) so that all version numbers returned by helper functions are accurate and consistent. Bug: 1101439 Bug: 1108832 Change-Id: I2ca92478d76bf572cc55875cba443f4978482d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315490Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#791491}
-
Sam Maier authored
Bug: 1103399 Change-Id: I99cacadf2c0ea3e65b6e9dc8a8d127536114f14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293174 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#791490}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/446b974be827..1d66d3f9d4ce 2020-07-25 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-07-24 johnstiles@google.com Report the effect type when TestCreate returns null. 2020-07-24 michaelludwig@google.com Undo drawRRect+clipRRect merging outside of Android framework 2020-07-24 egdaniel@google.com Remove resource from GrD3DBuffer. 2020-07-24 herb@google.com properly account for GrTextBlob arena size 2020-07-24 reed@google.com demo CubicResampler 2020-07-24 jvanverth@google.com Reland "Make GrRingBuffer more generic so it can be used over all backends" 2020-07-24 robertphillips@google.com Revert "Attach whitespaces to the neighbor unresolved blocks" 2020-07-24 brianosman@google.com SkSL: Salt inline identifiers in PipelineStage and FragmentProcessor passes 2020-07-24 egdaniel@google.com Using staging buffers for uploads of d3d static buffers. 2020-07-24 brianosman@google.com Add several more values to SkYUVColorSpace 2020-07-24 jlavrova@google.com Attach whitespaces to the neighbor unresolved blocks 2020-07-24 mtklein@google.com remove more blacklists 2020-07-24 mtklein@google.com rename tools/xsan.blacklist 2020-07-24 johnstiles@google.com Enforce trivially-copyable types on unaligned loads/stores/casts. 2020-07-24 robertphillips@google.com Update more tests to use the GrDirectContext/GrRecordingContext pair 2020-07-24 johnstiles@google.com Rename bit_cast to sk_bit_cast, and migrate to SkUtils.h. 2020-07-24 csmartdalton@google.com Don't std::move fTriangleBuffer in tessellation 2020-07-24 johnstiles@google.com Remove input-color modulation from GrGLLightingEffect. 2020-07-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 9061d5d154bc to 0d158ac68107 (3 revisions) 2020-07-24 herb@google.com make calls to SubRun and AtlasSubRun const 2020-07-24 bsalomon@google.com Remove GrYUVProvider. 2020-07-24 jvanverth@google.com Revert "Metal: Hold refs for input buffers from bindBuffer calls." 2020-07-24 robertphillips@google.com Revert "implement working CorrectnessActivity to generate lottie keyframe PNGs" 2020-07-24 johnstiles@google.com Simplify GrPipeline by removing unused functionality. 2020-07-24 jvanverth@google.com Revert "Make GrRingBuffer more generic so it can be used over all backends" 2020-07-24 johnstiles@google.com Remove unused RunInSeries processor. 2020-07-24 johnstiles@google.com Rename Xfermode fragment processor to Blend. 2020-07-24 kjlubick@google.com Inclusive language 2020-07-24 jvanverth@google.com Metal: Hold refs for input buffers from bindBuffer calls. 2020-07-24 jlavrova@google.com Reland #3 "ICU API: only in SkParagraph, simplified." 2020-07-24 bsalomon@google.com Remove GrTexturePriv 2020-07-24 herb@google.com reduce mutex use and switch to spinlock 2020-07-24 jvanverth@google.com Make GrRingBuffer more generic so it can be used over all backends 2020-07-24 jmbetancourt@google.com implement working CorrectnessActivity to generate lottie keyframe PNGs 2020-07-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from f359cb667cb9 to df5ed61ddbca (3 revisions) 2020-07-24 csmartdalton@google.com Rename GrStrokeGeometry -> GrStrokePatchBuilder 2020-07-24 csmartdalton@google.com Write GPU buffers directly from GrStrokeGeometry 2020-07-23 fmalita@chromium.org ResourceProviderProxyBase should not drop loadFont (yet) 2020-07-23 robertphillips@google.com Manually Roll ANGLE from 20eb9be55299 to f6659b3df028 (17 revisions) 2020-07-23 elliotevans@google.com Fix CanvasKit SkSurface.requestAnimationFrame for web workers 2020-07-23 johnstiles@google.com Add GrFragmentProcessor::Compose for composing two processors. 2020-07-23 robertphillips@google.com Convert more tests to GrDirectContext/GrRecordingContext pair If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101491,chromium:1101513,chromium:1108626,chromium:842296 Tbr: robertphillips@google.com Change-Id: If668af2a8bbfadba4e66791346ed8ae6c19843b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319118Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791489}
-
Andrew Paseltiner authored
Bug: 1099014 Change-Id: I98a2d0e548a48fd93618fbae1c1d458f1dbd58a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269740Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Cr-Commit-Position: refs/heads/master@{#791488}
-
gogerald authored
The counterpart CL in downstream is https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/3180818 Bug: 1085419 Change-Id: I3e20df0bb93d47009cdaa30896c52c8c648b05a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315432Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#791487}
-
Jarryd authored
Applies the fix suggested by dbertoni@ on the bug: Adds a TearDown method which calls StoragePartition::WaitForDeletionTasksForTesting() to wait for all deletion tasks to finish and make sure QuotaDatabase does not run into out of disk space errors. Bug: 930481 Change-Id: I1d2203d0b6d817ef84ccbda206ab216e54f4fd80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307644Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#791486}
-
Sergey Ulanov authored
Previously VideoCaptureDeviceFactory interface provided GetDeviceDescriptors() and GetSupportedFormats(). Both were synchronous. That hasn't worked well on some platforms, particularly on Fuchsia. Replaced both methods with asynchronous GetDevicesInfo(). The new method returns device descriptors as well as list formats supported by each device. Bug: 1072932 Change-Id: If76abbc66db9fee54140a5e352eb0f8fd39f3294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306918 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#791485}
-
Nate Chapin authored
Bug: 1106608 Change-Id: Ie71fcdea1186761fd6cc7f32ebf38ee0e497d843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316695 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#791484}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/ff8fe2df3529..34c9aac3f30d 2020-07-23 dneto@google.com Start shaderc v2020.3 development 2020-07-23 dneto@google.com Finalize shaderc v2020.2 2020-07-23 dneto@google.com Update CHANGES 2020-07-23 dneto@google.com Roll third_party/glslang/ 9eef54b25..3ee5f2f1d (11 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I4390ce79f9a9f989085929968a5502282eb37d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319114Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791483}
-
Keren Zhu authored
Replace GridLayout with BoxLayout and FlexLayout in cases where GridLayout is not used as a true grid, but only for alignment. This CL is part of the changes to apply documented best practice to examples. Bug: 897377 Change-Id: I789da2ebaa083f149079c36134dc8a1f48dd093a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316455 Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#791482}
-
arthursonzogni authored
The reporting service delays reports by 60s. This gives the opportunity to group several reports into a single request. However, when running web_tests, we can't afford spending 60s. So this is reduced to 100ms to avoid timeout. So far, so good. The problem is about a second timer that used to be proportional: |endpoint_backoff_policy.initial_delay_ms|. They are both set to 60s. However in --run-web-tests, only the first is reduced to 100ms. This patch reduced the second one to 100ms as well, to keep them always proportional. After this patch, the configuration becomes: [Normal mode] reporting_policy.delivery_interval = 60s; reporting_policy.endpoint_backoff_policy.initial_delay = 60s [web-tests mode] reporting_policy.delivery_interval = 100ms; reporting_policy.endpoint_backoff_policy.initial_delay = 100ms. Bug: 1109194 Change-Id: I068a772e9eb95ec4c61466e290c400867ffbb63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316215Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#791481}
-
Christopher Cameron authored
Meet gives an option to request video quality of 360. Not all cameras will natively return a height-360 size, so Chrome will go with the next-biggest capture size, and letterbox-and-scale the video frame. On the machine where I reproduced this, the media::VideoFrame had the following attributes. - visible_rect:0,60 640x360 - natural_size:640x360 - coded_size:640x480 This exposed the following bug in the combination of the functions VideoResourceUpdater::CreateForSoftwarePlanes and PaintCanvasVideoRenderer::Copy. * The function VideoResourceUpdater::CreateForSoftwarePlanes creates a resource of size |coded_size|, and expects that PaintCanvasVideoRenderer::Copy will populate the |visible_rect| sub-rectangle of that resource. * PaintCanvasVideoRenderer::Copy actually copies not to |visible_rect|, but rather to rectangle at (0,0) that has the size of |visible_rect|. The consequence is that we end up viewing the resource through a misaligned letterbox. The fix is is to inline PaintCanvasVideoRenderer::Copy (which is only a few lines long) in VideoResourceUpdater::CreateForSoftwarePlanes, and specify the correct destination rectangle. Also add some comments to clarify the function's behavior. Note that this behavior was switched in crrev.com/545920. Bug: 1090435 Change-Id: Icef81728defc0cf46b35180dada5d68f24e6b21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318313 Auto-Submit: ccameron <ccameron@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#791480}
-
Orin Jaworski authored
This CL changes the behavior of the dialog that pops up at chrome://settings/clearBrowserData by setting the ignore-enter-key attribute. The key is ignored because it results in destructive action and is very easy to trigger by mistake. Bug: 1108630 Change-Id: If557df2e741a981da1d983bea4fc87989e65bac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316439 Auto-Submit: Orin Jaworski <orinj@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#791479}
-
Peng Huang authored
Bug: 1109466 TBR: vasilyt@chromium.org Change-Id: Ie2ada7d94ed618caf3c96e20c543fc378fa0d975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318927Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#791478}
-
Anastasia Helfinstein authored
The Chrome menu (the three dots at the right of the omnibar) stopped being openable recently, because it shows up as a combo box. Modify the combo box behavior to allow for some elements detected as combo boxes to not be combo boxes. This is a temporary fix; the long-term fix is to properly populate the location for combo box pop-up windows. AX-Relnotes: n/a. Bug: 1106529 Change-Id: Ica0494ce85246abb73efb899d15abad38d700ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300982 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#791477}
-