GitLab

This CL moves some code from site_lists.js to site_settings_behavior.js
so that it can be used from site_details.js. As a result, we can
complete the initialization of the SiteException received in
site_details.js and show the URL in that UI.

BUG=635874
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2338133008
Cr-Commit-Position: refs/heads/master@{#419216}

In this CL:
 - Make test methods in update_w3c_test_expectations have more realistic examples.
 - Change some lines in write_to_test_expectations to make that method shorter.

This is a refactoring CL (no behavior changes).

BUG=647395

Review-Url: https://codereview.chromium.org/2349543002
Cr-Commit-Position: refs/heads/master@{#419215}

s.t. cc_perftests can find the device .isolate file we now generate.

BUG=647016

Review-Url: https://codereview.chromium.org/2342253002
Cr-Commit-Position: refs/heads/master@{#419214}

The first run flow div, whose height is not hard-coded, has a fractional height value, which is also used as the top margin size for the header below it. By keeping it fractional rather than rounding by using offsetHeight, we avoid rounding errors.

BUG=615373
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2345773002
Cr-Commit-Position: refs/heads/master@{#419213}

rollforward cr/2296923004 with fix: updated unittest to prevent issue with unreachable code (win_chromium)

BUG=635596

Review-Url: https://codereview.chromium.org/2345693004
Cr-Commit-Position: refs/heads/master@{#419212}

This is needed to allow the UiAccess enabled binary to work.  Otherwise the
binary will crash on launch which is an undesirable behavior.

BUG=617185

Review-Url: https://codereview.chromium.org/2349583002
Cr-Commit-Position: refs/heads/master@{#419211}

R=stevenjb@chromium.org, phajdan.jr@chromium.org
BUG=643238

Review-Url: https://codereview.chromium.org/2344093002
Cr-Commit-Position: refs/heads/master@{#419210}

Reverted in
https://codereview.chromium.org/2342243003/

Reason for reland:
Actually fixed gn gen failure.

This will allow monochrome to easily define its own set of the same
targets with a different resource whitelist

TBR=brettw@chromium.org,miu@chromium.org,yutak@chromium.org
BUG=641032

Review-Url: https://codereview.chromium.org/2342023004
Cr-Commit-Position: refs/heads/master@{#419209}

Previously the field trial testing was incorrect. The key was the
feature name instead of the Finch experiment name.

BUG=608886

Review-Url: https://codereview.chromium.org/2342893003
Cr-Commit-Position: refs/heads/master@{#419208}

https://chromium.googlesource.com/skia.git/+log/3d5541dc3d0f..43d665111137

$ git log 3d5541dc3..43d665111 --date=short --no-merges --format='%ad %ae %s'
2016-09-16 msarett Support Float32 output from SkColorSpaceXform
2016-09-16 jvanverth Remove old SkGaussianEdgeShader code

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=djsollen@google.com

Review-Url: https://codereview.chromium.org/2348603004
Cr-Commit-Position: refs/heads/master@{#419207}

https://chromium.googlesource.com/chromium/src/+/e34a6457a

BUG=601247
TBR=kdsilva@google.com

Review URL: https://codereview.chromium.org/2343203002 .

Cr-Commit-Position: refs/heads/master@{#419206}

We ended up not using it, and there are no plans to use it in
the future. It adds some unnecessary complexity to
SyncMessageFilter which I don't want to have to maintain as
I add some extra support for associated interfaces.

BUG=612500
R=jam@chromium.org

Review-Url: https://codereview.chromium.org/2343033002
Cr-Commit-Position: refs/heads/master@{#419205}

The source event type information will be used in a follow up patch to compute scroll latency metrics for touch and wheel, separately.

BUG=622827
TEST=RenderWidgetHostViewAuraTest.SourceEventTypeExistsInLatencyInfo, RenderWidgetHostViewMacTest.SourceEventTypeExistsInLatencyInfo, EventTest.PointerEventSourceEventTypeExistsInLatencyInfo

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2317253005
Cr-Commit-Position: refs/heads/master@{#419204}

Uses drawing commands rather than raster assets.

This CL tries to retain/reuse the same positioning logic that already exists, but I didn't attempt to correct any bugs in positioning that might be introduced. That's up next.

BUG=635170

Review-Url: https://codereview.chromium.org/2343913003
Cr-Commit-Position: refs/heads/master@{#419203}

This reduces the number of compilation units that depend on files like
LayoutBlock.h by more than 200 (from around 500 to around 280).

Review-Url: https://codereview.chromium.org/2348853003
Cr-Commit-Position: refs/heads/master@{#419202}

Updating instructions for the blimp shell

BUG=

Review-Url: https://codereview.chromium.org/2345673004
Cr-Commit-Position: refs/heads/master@{#419201}

This includes making it work when gtk2 is not installed.

BUG=none

Review-Url: https://codereview.chromium.org/2342163002
Cr-Commit-Position: refs/heads/master@{#419200}

Previously the partial magnifier border was difficult to see on white colored backgrounds. I add a textured layer instead of a solid color, so the border is outlined in black, so that it is visible on all backgrounds.

BUG=638996
TEST=none

https://screenshot.googleplex.com/htWDLX1Bxdp

Committed: https://crrev.com/da331ee46dfead28a5b2af2379f9fad320509957
Review-Url: https://codereview.chromium.org/2269383002
Cr-Original-Commit-Position: refs/heads/master@{#418785}
Cr-Commit-Position: refs/heads/master@{#419199}

BUG=598854

Review-Url: https://codereview.chromium.org/2345193002
Cr-Commit-Position: refs/heads/master@{#419198}

Previously, ScrollRectToVisible bubbles up through its dom parent. It works
fine when its layout container is its dom parent, but this is not the case for
absolute-positioned elements. Simply scrolling the dom parent of an
absolute-positioned element wouldn't put the desired rect into view. This patch
changes the behavior by bubbling up through its layout parent.

BUG=645841
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2336013002
Cr-Commit-Position: refs/heads/master@{#419197}

BUG=601247

Review-Url: https://codereview.chromium.org/2301823002
Cr-Commit-Position: refs/heads/master@{#419196}

In addition to the existing createFoo() to create an AudioNode, we add support for
new FooNode(context, options).  The options argument is a dictionary
specific to the node and is also defined here.

Tests added for the basic functionality for constructing the nodes
and for testing that the required arguments (if any) are processed correctly.

Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/QpOwpM15YRA/SQJbPmuuAAAJ
Feature: https://www.chromestatus.com/features/6409704485945344

BUG=626449
TEST=constructor/*.html

Review-Url: https://codereview.chromium.org/2102133002
Cr-Commit-Position: refs/heads/master@{#419195}

R=mahmadi@chromium.org
BUG=645417
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2339353002
Cr-Commit-Position: refs/heads/master@{#419194}

Also fix some Closure compiler warnings that triggered as a result of this
change.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2342093002
Cr-Commit-Position: refs/heads/master@{#419193}

There was a sligh difference in how status=test and status=experimental were
handled. Content turned on experimental features before initializing webkit and
the content shell enabled test features *after* webkit was started. This is a
problem when the feature alters webkit initialization.

This cl moves enabling test features to the place where experimental features
are enabled.

BUG=268240
LOG=no

Review-Url: https://codereview.chromium.org/2345233002
Cr-Commit-Position: refs/heads/master@{#419192}

Revert of Use a stamp file when symlinking in GN work around mtime issues (patchset #1 id:1 of https://codereview.chromium.org/2348793002/ )

Reason for revert:
Breaks BuildPackages due to GN error (https://bugs.chromium.org/p/chromium/issues/detail?id=647706).

BUG=647706

Original issue's description:
> Use a stamp file when symlinking in GN work around mtime issues
>
> Ninja follows a symlink when stat'ing, so you can't use a symlink as an
> output and have dirty checking work properly.
> https://github.com/ninja-build/ninja/issues/1186
>
> BUG=646165
>
> Committed: https://crrev.com/fef37c4393d059c9125353928de7e49d4ea04ab4
> Cr-Commit-Position: refs/heads/master@{#419156}

TBR=dpranke@chromium.org,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=646165

Review-Url: https://codereview.chromium.org/2348493005
Cr-Commit-Position: refs/heads/master@{#419191}

Revert of Make chrome/BUILD.gn use symlink.gni rather than symlink.py directly (patchset #1 id:1 of https://codereview.chromium.org/2349603002/ )

Reason for revert:
Breaks BuildPackages due to GN error (https://bugs.chromium.org/p/chromium/issues/detail?id=647706).

BUG=647706

Original issue's description:
> Make chrome/BUILD.gn use symlink.gni rather than symlink.py directly
>
> Committed: https://crrev.com/ca5b9cba81bf335ce205cc06e094587b25c79758
> Cr-Commit-Position: refs/heads/master@{#419168}

TBR=dpranke@chromium.org,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2344223002
Cr-Commit-Position: refs/heads/master@{#419190}

https://chromium.googlesource.com/skia.git/+log/1bd72ba2cb34..3d5541dc3d0f

$ git log 1bd72ba2c..3d5541dc3 --date=short --no-merges --format='%ad %ae %s'
2016-09-16 rmistry Fix Seal_of_Mississippi URL and update version of SVG asset.
2016-09-16 scroggo Make SkPngCodec decode progressively.
2016-09-16 halcanary SkPDF: fix unembeddable text drawn with positioning (broken in 6059dc3)

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=djsollen@google.com

Review-Url: https://codereview.chromium.org/2343153002
Cr-Commit-Position: refs/heads/master@{#419189}

Revert of Enforce capability spec renderer <--> browser (patchset #19 id:360001 of https://codereview.chromium.org/2259903002/ )

Reason for revert:
Speculative revert to fix breakage here:

https://build.chromium.org/p/chromium.memory.full/builders/Linux%20TSan%20Tests/builds/1670

Original issue's description:
> Enforce capability spec renderer <--> browser.
>
> This implements:
>
> - allows the content embedder to merge a manifest into the base ones provided by content, allowing it to add to the list of interfaces exposed to the renderer.
> - adds such an overlay to chrome/browser
>
> So.. from now on if you add an interface to either the browser/renderer, you'll need to list it in the manifest. I wonder how we should broadcast this. Also as a separate step we should require these manifests get security review.
>
> R=rockot@chromium.org,tsepez@chromium.org
>
> Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
> Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
> Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
> Committed: https://crrev.com/cdf40b4b434b43af6accf0c822ea964bc6bfd931
> Committed: https://crrev.com/8b277b0bd73aa544f0d5e38a8763658d3e807880
> Cr-Original-Original-Original-Original-Commit-Position: refs/heads/master@{#418282}
> Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#418398}
> Cr-Original-Original-Commit-Position: refs/heads/master@{#418582}
> Cr-Original-Commit-Position: refs/heads/master@{#418691}
> Cr-Commit-Position: refs/heads/master@{#418988}

TBR=rockot@chromium.org,tsepez@chromium.org,ben@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2346803004
Cr-Commit-Position: refs/heads/master@{#419188}

Drop inclusion of SVGParserUtilities.h in a number of places since it's
no longer used. Push FE*.h inclusion into the implementation where
possible, and don't include FilterEffect.h in those cases.
Also simplify a loop in SVGFEMergeElement::build.

Review-Url: https://codereview.chromium.org/2342353002
Cr-Commit-Position: refs/heads/master@{#419187}

This CL updates the test filter for content_browsertests for
browser-side navigation. It removes tests that are no longer failing or
do not exist anymore.

BUG=475027

Review-Url: https://codereview.chromium.org/2342363002
Cr-Commit-Position: refs/heads/master@{#419186}

This API is not yet connected to anything in the net stack. Most of
these new metrics will be plumbed through from net::LoadTimingInfo, and
a few from other places.

Includes a unit test for the big mess of longs/Dates in
RequestFinishedInfo.Metrics, but no other tests yet because nothing
works yet.

Leaves the old APIs in place for now, since those actually work.

BUG=629194

Review-Url: https://codereview.chromium.org/2220023002
Cr-Commit-Position: refs/heads/master@{#419185}

BUG=NONE

Review-Url: https://codereview.chromium.org/2343003002
Cr-Commit-Position: refs/heads/master@{#419184}

  - Moves from class to enum class for notification state and type.
  - Notification instances now have clear knowledge of their type.
  - Don't instantiate an AsyncMethodRunner for non-persistent ones.
  - Simplify the lifetime of Notification instances: non-persistent
    notifications now follow their state machine, whereas persistent
    notifications now follow regular GC rules.

This will make it somewhat easier to merge the close{Persistent,}()
methods on the WebNotificationManager.

BUG=

Review-Url: https://codereview.chromium.org/2338483004
Cr-Commit-Position: refs/heads/master@{#419183}

This CL makes ManifestUpgradeDetectorFetcher take the Murmur2 hash of the bitmap
at the icon URL prior to any transformations being applied to the bitmap (such
as encoding/decoding the bitmap). The icon hash is used to determine whether the
icon that the user sees matches the icon of a WebAPK that the server generated
for another user.

The icon could be dynamically generated and:
- use the same icon URL for all users
- be visually different for each user

If the hashes match the server can vend the WebAPK that it
previously generated to other users. Vending previously generated WebAPKs is
faster than creating a new WebAPK for each "create WebAPK" request.

BUG=624059
TEST=ManifestUpgradeDetectorFetcherTest.*

Review-Url: https://codereview.chromium.org/2331773002
Cr-Commit-Position: refs/heads/master@{#419182}

This CL is a follow up to https://codereview.chromium.org/2337013005

NOTRY=true
NOTREECHECKS=true

BUG=601247

Review-Url: https://codereview.chromium.org/2343133002
Cr-Commit-Position: refs/heads/master@{#419181}

Make EnterpriseInstallAttributes defer running its
consistency check (which calls cryptohome's TpmIsOwned
method over D-Bus) until the cryptohome service is
available.

Also fix an apparent bug where the check was retried five
times the intended number of times.

BUG=636554

Review-Url: https://codereview.chromium.org/2244443002
Cr-Commit-Position: refs/heads/master@{#419180}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/3d7a0942bcf4..be85e5fd4bf5

$ git log 3d7a0942b..be85e5fd4 --date=short --no-merges --format='%ad %ae %s'
2016-09-16 nednguyen Reenable testTBM2ForSmoke & fix clock sync error on ref build of Chrome on Mac

BUG=646925

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2343113003
Cr-Commit-Position: refs/heads/master@{#419179}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ad5be95d..7f777213

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2347063004
Cr-Commit-Position: refs/heads/master@{#419178}

It's either reset or we early-out. The only real change
is in LayerTreeImpl. The other changes are just call site
updates to skip passing the 2nd parameter.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2349713002
Cr-Commit-Position: refs/heads/master@{#419177}