- 26 Mar, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/17aaea21d40d..0dd5482c5254 git log 17aaea21d40d..0dd5482c5254 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 ehmaldonado@google.com depot_tools: Restore appending title before change description. 2020-03-26 sokcevic@google.com Fix git_number windows unit tests Created with: gclient setdep -r src/third_party/depot_tools@0dd5482c5254 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1064905 Tbr: agable@chromium.org Change-Id: I77ab91086375477fb5eab59299a3108dc33112f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122732Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753747}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/cafff78f665b..37457d5e1826 git log cafff78f665b..37457d5e1826 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 bclayton@google.com Regres: Add support for generating collated coverage info 2020-03-26 bclayton@google.com CMake: Emit coverage-toolchain.txt file next to ICD json 2020-03-26 bclayton@google.com CMake: Add SWIFTSHADER_EMIT_COVERAGE option Created with: gclient setdep -r src/third_party/swiftshader@37457d5e1826 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I0643d077fb6f3f205be1dd4b5517262e8cf7a23c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122519Reviewed-by:
-
Jon Mann authored
This is a reland of 3014d931 with fix for a use after free of the NetworkMetadataStore held by wifi sync classes. Original change's description: > Inject NetworkMetadataStore in wifi sync classes which depend on it. > > The instance of NetworkMetadataStore for a user profile is created > after the sync service is already initialized. This change does > the necessary plumbing to get the metadata store instance to > the wifi sync classes. > > Bug: 966270 > Change-Id: Icd235cd780df97a367f09f281f3e957893baa93b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110079 > Commit-Queue: Jon Mann <jonmann@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: James Vecore <vecore@google.com> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752273} TBR=stevenjb@chromium.org,treib@chromium.org Bug: 966270 Change-Id: Ib4327a1a953ebee8d49775890eec2e6c353c4e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114586 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#753745}
-
Peng Huang authored
Bug: None Change-Id: I34640da23483581c91c56fef4344afce106a0a78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122450 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#753744}
-
Aya ElAttar authored
Changed base::ListValue to base::Value according to the new design. Change-Id: Iadabd65d527eea187ed6f7ecfb767bb8011a0538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120574 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753743}
-
Daniel Rubery authored
This CL adds a fixture that can be used for integration tests when deep scanning downloads. Future CLs will use this fixture for testing the core user journeys in download deep scanning. Bug: 1060367 Change-Id: I1aea7d4821e9abe6230038419de7061bee88e5a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117294Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#753742}
-
Nico Weber authored
TBR=reillyg Bug: 346399 Change-Id: I7f52d34dd3be08485c1aace38f2f61d1d4f14176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122428 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#753741}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/3d915b280266..9472e3eec085 git log 3d915b280266..9472e3eec085 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 rharrison@google.com Convert compile options to require explicit environments (#1019) 2020-03-26 dgkoch@users.noreply.github.com Roll glslang dependency (#1018) Created with: gclient setdep -r src/third_party/shaderc/src@9472e3eec085 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: Iaee0904b8bc8e0da0a65151ebd6afe1b117798df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122520Reviewed-by:
-
Sahel Sharify authored
This cl introduces a new type of ukm source id called PAYMENT_APP_ID. This source id is generated using the scope of service worker based payment apps and used to record UKM payment app checkout events when a payment app is invoked to handle the payment request and when a modal payment handler window is shown. On Android UKM is only recorded for expandable PH UI code path. UKM Privacy Review Approval: https://docs.google.com/document/d/1xF0dFyMqbe70WTGvo3WWCWxKeXttV8Tbe2RdmPKLB4Q/edit?usp=sharing Bug: 1047816 Change-Id: Iafb02ee9dab5fda6367c9db9d3d2104f1897d06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033754Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#753739}
-
Andrew Grieve authored
It's a feature that we don't use, and causes scary stack to be printed when incremental_install=true Also made some comments from BuildConfigGenerator.groovy be written out to BUILD.gn (but didn't actually run fetch_all.py due to androidx transition). Bug: 1025357 Change-Id: Iac87d758b330c130a1bcd96ec91922020594ccce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122234 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#753738}
-
Abigail Klein authored
This flag has expired and is no longer necessary for development. Bug: 785493 Change-Id: Id23df3604f80c6ff33607513efdd1df0231c2b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122185Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#753737}
-
Tommy Nyquist authored
This reverts commit 893bb04d. Reason for revert: Test now fully disabled in https://chromium-review.googlesource.com/c/chromium/src/+/2122463 Original change's description: > android: disable one FeedNewTabPageTest in android-pie-x86-fyi-rel > > The test FeedNewTabPageTest#testFeedDisabledByPolicy keeps crashing since > https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-fyi-rel/860 > > Bug: 1064388 > Change-Id: I9885ed704254197cc024857f41e8bd8930656b81 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121357 > Auto-Submit: Haiyang Pan <hypan@google.com> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753446} TBR=jbudorick@chromium.org,hypan@google.com Change-Id: I12cc58d61768f9a57bb528a0aacd56c2ec9e2a66 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1064388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121766Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#753736}
-
Tommy Nyquist authored
It seems to be flaky not only on earlier mentioned bots like android-pie-x86-fyi-rel, but is also flaky on test-n-phone. Bug: 1064388 Change-Id: I95ef0332b57897255b23eca86ddfd2bc351636b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122463 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#753735}
-
Wei Li authored
In Background class, the default value for |color_| is not used in any of the subclasses: either a subclass will override the color with SetNativeControlColor(), or a subclass will not use |color_| at all. So change the initial value to a placeholder color. Also replace CreateStandardPanelBackground() with directly calling CreateThemedSolidBackground() to make shell window to use themed colors and to remove unnecessary wrapping function. BUG=1059867 Change-Id: I97c6cf8943046453516ba93dc3b779eb6740d658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102785 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#753734}
-
John Lee authored
Use class cr-section in cases where applicable, and just use normal CSS for cases where most of the properties of the mixin was being overridden anyway. Bug: 973674 Change-Id: I676998212fb0a78a3caa57d78e799054e3b565a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121436Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#753733}
-
Yi Gu authored
This is not due to recent regression. They were enabled recently via crrev.com/c/2120733. Bug: 1065059 Change-Id: Ib5b1bd5d0e0efde58ceaf07843782b24037a26f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122727Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#753732}
-
Dana Fried authored
Translate bubble was getting confused in some cases because of the way the translate button is placed in PWA mode, especially during immersive mode (see attached bug). This change causes the translate bubble to prefer to be on the screen rather than switching its mirroring from the button (which may not even be visible). Bug: 1063745 Change-Id: I8308d84f130b1ea59b2ba3db82179561bc035213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122387Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#753731}
-
Fredrik Söderqvist authored
Preferably these should also return a const ContainerType but we're not quite there yet. Bug: 1028063 Change-Id: Ibe0bc052e5c66661902c3416a2c94e77eb6af75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120309Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#753730}
-
Alexander Cooper authored
The isolated_xr_device process is a utility process spun up by the browser process to interact with XR devices. With VRService moving out of chrome and into content, the registration of this device also needs to move into content. After offline discussion with services-dev, this creates content/services and moves the service itself there. Bug: 1031622 Change-Id: Icc379d4c053f3c568c5ce62503dfb37275d318b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109824 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#753729}
-
Ali Juma authored
This is a reland of 6a3e1c15. Relanding since M83 is branching soon. This will be reverted again after the branch point. Original change's description: > [iOS] Disable Safe Browsing full-hash requests > > This temporarily disables making full-hash requests on iOS, allowing > the rest of the Safe Browsing code to be exercised. > > Since this change breaks unit tests, this CL also stops running > Safe Browsing database unit tests on iOS for now. > > Bug: 1028755 > Change-Id: Id772d4682bd9a3443b8d6b7042b0b5aecaaff80e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088349 > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Commit-Queue: Ali Juma <ajuma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748049} Bug: 1028755 Change-Id: Ib63d6020eaeb3d53b617f2f903f2130266993fe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122457Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#753728}
-
Hwanseung Lee authored
Use enum class instead of enum for TableView::AdvanceDirection. enum class is more type safety. Bug: 940736 Change-Id: Idb86122852d226475e678506f29b0716160b16fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120840 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Alexandre Frechette authored
Bug: 1044196 Change-Id: I1613ee4f5b3d8e46a4f9a9aa0ae706c7a0046891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067875Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#753726}
-
Caroline Rising authored
Bug: 943702 Change-Id: Ib7a8fc70ffeabcf62057d82ce0fe34a9c10f8985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118896Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#753725}
-
edchin authored
Change-Id: I7d44615cd725effa9834ba597191c749b9dc0848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122367Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753724}
-
Swapnil authored
the policy InstallationTracker shuts down if forced list is empty and some other extension installs or fails before the timer runs out. Thus we should wait till any of the forced extension fails or gets loaded or the timer runs out. A unit test is added to check the same. Bug: 1063406 Change-Id: I4e5842683e0442e39d381337ab82a2efb490f4da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112730Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#753723}
-
Anastasia Helfinstein authored
This change refactors the focus ring manager within Switch Access for readability and future eng velocity. It is a pure refactor, with no behavioral changes. Relnotes: N/A Bug: None Change-Id: If0ebe2682ac1c9350f33f17627b6c0275e22b7a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116574 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#753722}
-
Robert Sesek authored
Bug: 1064831 Change-Id: Ie938a496feae4ccb50add0cad6876b45a6b885c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122569 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Charlie Hu authored
This CL makes IsFeatureEnabled(DocumentPolicyFeature...) on Document & ExecutionContext const qualified so that the migration of LayoutAnimations from feature policy to document policy can start. Initially the method is not marked as const because it called ExecutionContext::AddConsoleMessage which is not marked as const. Bug: 993790 Change-Id: I98e1b4d210cf3f898c016e004d8d1856dbe41bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101707 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#753720}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d5db214564bd..0847cb463736 git log d5db214564bd..0847cb463736 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 enga@chromium.org Convert LayoutBindingInfo to an array of BindingInfos Created with: gclient setdep -r src/third_party/dawn@0847cb463736 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I2b58c761d5bf5d6a88375fcd7288dd7324c677a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122513Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ice350668b9e3ff1335db155a60dc9fdbcadcb844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122460Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#753718}
-
rbpotter authored
Bug: 1026426 Change-Id: I1c9ab419fd1c02d9a8faedde28ecc77fcd536def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117343Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#753717}
-
Wez authored
Pass-through the shard-index and total-shards command-line parameters, if specified. These are used by Chromium infrastructure to request that the TestLauncher only run a subset of the suite's tests in each Swarming shard. Bug: 1064103 Change-Id: I7cbf358177eae85a050fd071b205cd895a1793a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122056 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#753716}
-
Paulo Warren authored
This CL moves vaapi_wrapper into its own target so that it can be used in the SharedImage interface. This involves removing the dependency on platform_video_frame_utils.h so that //gpu/command_buffer/service:gles2_sources can eventually depend on VaapiWrapper without causing a circular dependency. I moved all call sites of VaapiWrapper::CreateVASurfaceForVideoFrame() to use VaapiWrapper::CreateVASurfaceForPixmap() instead to remove the dependency on platform_video_utils.h. This CL is a prequel to CL:2083662 BUG=1058103 TEST=on atlas: tast run video.DecodeAccel.* Change-Id: I10e0a28cf9cc38bef43839dad326b7e2babc6387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106485 Commit-Queue: Paulo Warren <pwarren@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#753715}
-
Nate Fischer authored
This swaps Dev UI's navigation menu for a bottom navigation bar. The bottom nav bar is a more intuitive and discoverable UI element, so this should improve user experience. This puts "home," "crashes," and "flags" in the bottom nav bar (the most prominent tools) and leaves changing WebView provider for the top menu (on N+). I built my own bottom navigation bar because the standard library (BottomNavigationView) depends on AppCompat, which was causing crashes on L-M and other problems (for standalone WebView) on N+. The custom navigation bar is built out of TextViews with compound drawables. This adds new icon resources from Google's material design library. No change to the actual Dev UI tools themselves. Bug: 1017532 Test: Manual - verify on L and N+ Test: Manual - verify dark mode on Q Change-Id: I235cd9ba0557631a12a6132acd0b1b705227965b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113799 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#753714}
-
Antonio Gomes authored
Original patch: https://bugs.webkit.org/show_bug.cgi?id=70772 BUG=1063749 R=dgrogan@chromium.org, robertma@chromium.org Change-Id: I5855f8986f1072cc6486f80139f2970271811f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122470 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#753713}
-
Becca Hughes authored
This is a reland of 0bbf0f94 Original change's description: > [Media Feeds] Add feed items to WebUI > > This adds the feed items to the WebUI. You > can select a feed to show the content. > > BUG=1058187 > > Change-Id: I5051f77b68cb3da6710a547d50109cb95a7b890f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118758 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753441} Bug: 1058187 Change-Id: I7ec8a25ba03d192341e6d02eccfba991b4156504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121450Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#753712}
-
Sven Zheng authored
When a cl intends to change UI, we want all previously approved gold images become invalid. To do so, the cl can change the baseline, which will change the name of the gold image. In this way, the image is considered as a new image and all previous gold images are invisible to the test and become invalid. This should also mitigate another issue, that when a breaking cl merges, developer see unrelated pixel output changes in tryjob. Bug: 1059469 Change-Id: I52f6543876c770a1e0488feece8b603562590a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121469 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#753711}
-
Piotr Bialecki authored
Changes: - Pass tracking state to the functions accepted by ForEachArCoreAnchor and ForEachArCorePlane in anchor manager and plane manager. - Add test page for experiments with local space stability & drift, the page will not be exposed via proposals/index.html There should be no functional change introduced by this CL. Change-Id: Ib325c090f165f306865701987e89c6ad45db5a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118990Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium efd03535. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Id2dba7fcb79ad42eb08ecb65a291f75fa98b8a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122247Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753709}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/de6c45646618..17aaea21d40d git log de6c45646618..17aaea21d40d --date=short --first-parent --format='%ad %ae %s' 2020-03-26 ehmaldonado@google.com Reland "depot_tools: Run using Python 3 by default." Created with: gclient setdep -r src/third_party/depot_tools@17aaea21d40d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ibcfcc7df0da483af3e00fdde5cd383f5de659416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122510Reviewed-by:
-
