GitLab

Second part of a 2-part changelist.
The first part is https://codereview.chromium.org/25883006/

BUG=304879

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259726

Review URL: https://codereview.chromium.org/25909005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260243 0039d316-1c4b-4281-b951-d872f2087c98

Add first_run/InstallHelper GetFirstRunSentinelFilePath helpers.
Use PathService to get the correct value of DIR_USER_DATA.
(may be overridden by a policy, env var, or commandline)
(InstallUtil::GetSentinelFilePath just uses the default dir)

Make the IsFirstRunSentinelPresent helper platform-specific.
(simplifies its predecessor's Win-specific legacy abstractions)
Some related refactoring, cleanup, and test updates.

TODO(msw): Fix InstallUtil::GetSentinelFilePath.
TODO(msw): Fix/Nix installer::GetChromeUserDataPaths.
TODO(msw): Further consolidate related/duplicated code.

BUG=354634,341049
TEST=Chrome install and first run work as intended; respect user-data-dir commandline, env var, and policy overrides.
R=grt@chromium.org
TBR=gab@chromium.org

Review URL: https://codereview.chromium.org/208393020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260242 0039d316-1c4b-4281-b951-d872f2087c98

 - Adding docstrings
 - Factoring out _CalculateBounds method
 - Bug fix???

BUG=

Review URL: https://codereview.chromium.org/209853009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260241 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/213513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260240 0039d316-1c4b-4281-b951-d872f2087c98

aura_unittests explicitly calls GLSurface::InitializeOneOffForTests in main().
The Ozone platform isn't initialized this early causing a CHECK failure when
trying to get SurfaceFactoryOzone.

At this point surface creation in unittests is handled by OSMesa, thus we don't
need SurfaceFactoryOzone initialized.

TBR=piman@chromium.org
NOTRY=true

TESTS=Ran aura_unittests manually using an Ozone build

Review URL: https://codereview.chromium.org/217003007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260239 0039d316-1c4b-4281-b951-d872f2087c98

In ChromeContentBrowserClient, check for membership in the trial group, and if the autoreload field trial is enabled, set the renderer command-line flag to enable it.

BUG=355569
TEST=unit,trybot

Review URL: https://codereview.chromium.org/212533004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260238 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349737

Review URL: https://codereview.chromium.org/211983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260237 0039d316-1c4b-4281-b951-d872f2087c98

BUG=352263
TESTS=PartnerBookmarksShimTest
NOTRY=True

Review URL: https://codereview.chromium.org/215693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260233 0039d316-1c4b-4281-b951-d872f2087c98

maintain their caches. r259958 altered the way the feature data was populated
and caused a big regression. This fixes it.

R=rockot@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/216703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260232 0039d316-1c4b-4281-b951-d872f2087c98

Without this change, all calls to get or set preferences simply show up
as "types.ChromeSetting.get" or "types.ChromeSetting.set" in the
extension activity log.  With this change, the argument list will
include the name of the preference being changed and (when the
preference is changed) the new value.

BUG=356314

Review URL: https://codereview.chromium.org/214843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260231 0039d316-1c4b-4281-b951-d872f2087c98

Original CL: http://crrev.com/156963003

Preserved ip_pattern* which is now being used by the DnsConfigService.

BUG=347382

Review URL: https://codereview.chromium.org/215623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260230 0039d316-1c4b-4281-b951-d872f2087c98

Also moves some logic into the platform-independent OmniboxEditController.  Future work may be able to move more code into this class for sharing across platforms.

BUG=338563

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259639

R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/200783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260228 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromedriver:416
NOTRY=true

Review URL: https://codereview.chromium.org/217233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260227 0039d316-1c4b-4281-b951-d872f2087c98

tpcontrol and mousecontrol have been merged into a new script for controlling
input devices. This CL updates input_device_settings to use this new script.

BUG=chromium:285663
TEST=Has to be tested with chromium-side CLs containing the new script.
Then make sure changing mouse and touchpad preferences is working well and
that your preferences are correctly applied on bootup.

Review URL: https://codereview.chromium.org/212873006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260226 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357505
TBR=jdduke@chromium.org

Review URL: https://codereview.chromium.org/216313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260225 0039d316-1c4b-4281-b951-d872f2087c98

This is to avoid users using the window for hiding sensitive contents that they don't want to share.
See https://code.google.com/p/webrtc/issues/detail?id=2789#c36

BUG=https://code.google.com/p/webrtc/issues/detail?id=2789

Review URL: https://codereview.chromium.org/215363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260224 0039d316-1c4b-4281-b951-d872f2087c98

It solves issues where we were sometimes getting stale data,
especially if reading information after a DisplayListener event.

BUG=354275

Review URL: https://codereview.chromium.org/212933012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260223 0039d316-1c4b-4281-b951-d872f2087c98

I have a plan to add more audio player tests. Before that, make audio player tests
separated for readability.

This is the 2nd (last) part of the work of crrev.com/214463002. First part is committed as crrev.com/260069.

BUG=none
TEST=browser_test passes
TBR=hirino@chromium.org

Review URL: https://codereview.chromium.org/212123008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260222 0039d316-1c4b-4281-b951-d872f2087c98

BUG=335208

Review URL: https://codereview.chromium.org/216523005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260221 0039d316-1c4b-4281-b951-d872f2087c98

For example, chrome://newtab#bookmarks becomes
chrome-native://bookmarks. This helps users transition smoothly to the
new NTP: any tabs open to the old NTP when the user updates will start
showing the new NTP. Also: opening a foreign session tab from other
platforms and pressing back until arriving at chrome://newtab will now
show the new NTP.

BUG=354063
NOTRY=true

Review URL: https://codereview.chromium.org/205983005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260218 0039d316-1c4b-4281-b951-d872f2087c98

Because EthernetEAP is never a visible service, we do not observe it.
When it is first created, no properties (including Profile) are set, so
it does not appear in the 'Favorite' list and as a result never gets
updated. This currently only affects debugging.

As a workaround, we always treat EthernetEAP networks as a Favorite,
eveb if Profile is empty.

Original CL: https://codereview.chromium.org/210433002/
This patch removes a failing test for some unused code (removed both).

BUG=355117
TBR=pneubeck@chromium.org

Review URL: https://codereview.chromium.org/213853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260217 0039d316-1c4b-4281-b951-d872f2087c98

This error shows up if the server indicates to the client that
enrollment got rejected due to the device belonging do a different
domain (as indicated by the client-provided state key).

BUG=chromium:357207
TEST=Manual, check that the error message shows up on domain mismatch.
R=asvitkine@chromium.org, dpolukhin@chromium.org, joaodasilva@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260102

Review URL: https://codereview.chromium.org/214963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260216 0039d316-1c4b-4281-b951-d872f2087c98

BUG=261628

Review URL: https://codereview.chromium.org/216263004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260215 0039d316-1c4b-4281-b951-d872f2087c98

As a first step, I'm introducing stub implementations such that the Ozone path
can be exercised. In future CLs I plan on removing ifdefs limiting the use of
OutputConfigurator to X11 and add actual functionality to the delegates.

BUG=333413

Review URL: https://codereview.chromium.org/214513006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260214 0039d316-1c4b-4281-b951-d872f2087c98

> Switched main WebRTC browser tests to use a more realistic video.

> After switching to fake device flags instead of software webcams, we
> noticed a ton of video-related metrics changed. This is because the
> spinning green ball is an unrealistic encode/decode example. This patch
> will use the new fake device file flag to play a more realistic video.

> BUG=352261, 343504
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259887

TBR=tommi@chromium.org
BUG=352261, 343504

Review URL: https://codereview.chromium.org/216773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260213 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=357566

Review URL: https://codereview.chromium.org/216773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260212 0039d316-1c4b-4281-b951-d872f2087c98

BUG=348616

Review URL: https://codereview.chromium.org/214983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260211 0039d316-1c4b-4281-b951-d872f2087c98

A follow up to https://codereview.chromium.org/214543009 where boliu@ noticed
that we are using getInstrumentation().getTargetContext() in AwSettingsTest
instead of simply getting the context of the container view.

This change required some overhaul of testing classes as they didn't have access
to the container view.

Review URL: https://codereview.chromium.org/216823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260210 0039d316-1c4b-4281-b951-d872f2087c98

The browser test is showing Mac ASAN failures.

> Handling LevelDB errors encountered after open.
>
> The previous IndexedDB implementation only checked for (and reported)
> corrupted LevelDB's during open. If they are determined to be corrupted
> during use then the database was simply closed. The page would be unaware of
> this, and would likely reopen the database at a later time (which would work)
> only to fail again during a read/write operation. There was no way for the
> page to get out of that corrupted state - the user would have to delete all
> origin data.
>
> This change will record the fact that the backing store was corrupted, and
> during open this would be read and, if present, result in the same dataLoss
> state being reported to the page in the upgradeneeded event.
>
> Also split IndexedDBBackingStore's REPORT_ERROR macro in two:
> REPORT_ERROR_UNTESTED (which calls NOTREACHED) and REPORT_ERROR. REPORT_ERROR
> is used for errors which are encountered during tests. This was done so that
> runtime errors could still be caught during a debug build run.
>
> BUG=322707
> R=isherman@chromium.org, jochen@chromium.org, jsbell@chromium.org
>
> Review URL: https://codereview.chromium.org/197333009
>
> Patch from Christopher Mumford <cmumford@chromium.org>.

TBR=jsbell@chromium.org

Review URL: https://codereview.chromium.org/216433007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260209 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357559
TEST=manual
R=dzhioev@chromium.org

Review URL: https://codereview.chromium.org/216473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260208 0039d316-1c4b-4281-b951-d872f2087c98

Make a new class, ExtensionGarbageCollector, which performs:
- ExtensionService::GarbageCollectExtensions(),
- extension_file_util::GarbageCollectExtensions() (the file-thread impl of
  ExtensionService::GarbageCollectExtensions()),
- ExtensionService::GarbageCollectIsolatedStorage()

BUG=351891
TBR=rkc@chromium.org (for c/b/chromeos/kiosk_mode - no functional changes, but the TODO has moved from ExtensionService to ExtensionGarbageCollector).

Review URL: https://codereview.chromium.org/204983020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260207 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260205 0039d316-1c4b-4281-b951-d872f2087c98

This is just intended to reduce some code duplication and allow increased velocity on altering the SkCanvas API

Review URL: https://codereview.chromium.org/199043004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260204 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=170229:170313&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/216433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260203 0039d316-1c4b-4281-b951-d872f2087c98

BUG=353127
R=jshin@chromium.org

Review URL: https://codereview.chromium.org/214413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260202 0039d316-1c4b-4281-b951-d872f2087c98

On machines with slow I/O, the localserver might not shut down immediately,
wait for it if necessary.

BUG=

Review URL: https://codereview.chromium.org/145873004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260201 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260200 0039d316-1c4b-4281-b951-d872f2087c98

R=mallinath@chromium.org

Review URL: https://codereview.chromium.org/215133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260199 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357621
TEST=manually tested

R=hirono@chromium.org
TBR=arv@chromium.org
# TBRing for adding a resource.

Review URL: https://codereview.chromium.org/209853011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260198 0039d316-1c4b-4281-b951-d872f2087c98

This is a pre-requirement to remove webkitCreateShadowRoot in blink.
The patch on the blink side is here: https://codereview.chromium.org/208503004/.

BUG=336121

Review URL: https://codereview.chromium.org/214093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260197 0039d316-1c4b-4281-b951-d872f2087c98