GitLab

BUG=401028
TEST=browser_tests

Review URL: https://codereview.chromium.org/489333002

Cr-Commit-Position: refs/heads/master@{#291845}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/508513002

Cr-Commit-Position: refs/heads/master@{#291844}

Add OpenDevToolsWindow() and IsCurrentChannelOlderThanDev() to AppsClient.

BUG=387288

Review URL: https://codereview.chromium.org/494483006

Cr-Commit-Position: refs/heads/master@{#291843}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/502173004

Cr-Commit-Position: refs/heads/master@{#291842}

This class is simply unnecessary.

BUG=None
R=oshima@chromium.org
TEST=athena_unittests passes

Review URL: https://codereview.chromium.org/501183002

Cr-Commit-Position: refs/heads/master@{#291841}

This makes it harder to accidently use the wrong
macro.

Also, removes the D* variants of the macros and
associated DebugNow() function. These were rarely
used and removing them removes clutter from the
header file. Existing uses converted to be behind
NDEBUG ifdefs.

No functional changes except for a fix to the
code in content_based_thumbnailing_algorithm.cc
which was incorrectly using a ternary operator for
the histogram name (which doesn't work since the
macros cache the histogram object) and removal
of local histograms Spellcheck.SuggestTime and
Spellcheck.InitTime per groby@.

Since this is an API rename, TBR'ing downstream
owners.

BUG=311349
TBR=groby@chromium.org,zea@chromium.org,jeremy@chromium.org,reveman@chromium.org,agl@chromium.org,jam@chromium.org

Review URL: https://codereview.chromium.org/484603006

Cr-Commit-Position: refs/heads/master@{#291840}

This delegate isolates SearchProvider from chrome dependencies

Add AutocompleteProviderDelegate and its chrome implementation ChromeAutocompleteProviderDelegate.

BUG=388515
TBR=blundell@chromium.org for the new DEPS line

Review URL: https://codereview.chromium.org/500023002

Cr-Commit-Position: refs/heads/master@{#291839}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/503903004

Cr-Commit-Position: refs/heads/master@{#291838}

BUG=

Review URL: https://codereview.chromium.org/504003002

Cr-Commit-Position: refs/heads/master@{#291837}

BUG=407080

Review URL: https://codereview.chromium.org/473683005

Cr-Commit-Position: refs/heads/master@{#291836}

Crash reports indicate that the WindowAndroid's Compositor may be NULL
during |RenderWidgetHostViewAndroid::SetContentViewCore()|. While this
is a somewhat surprising result, it is in theory possible and should
probably not be fatal. Avoid creating the overscroll effect in this
case, instead creating it after the compositor is (re-)attached.

BUG=407208

Review URL: https://codereview.chromium.org/503813003

Cr-Commit-Position: refs/heads/master@{#291835}

Note that the Match() function copies the data into a memory blob.  This is of course only for demo purposes. This will soon be changed to use a streaming API. See bug 403493.

BUG=392621

Review URL: https://codereview.chromium.org/465463002

Cr-Commit-Position: refs/heads/master@{#291834}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/502203003

Cr-Commit-Position: refs/heads/master@{#291833}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/502123003

Cr-Commit-Position: refs/heads/master@{#291832}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/501263002

Cr-Commit-Position: refs/heads/master@{#291831}

of the previous CongestionFeedback Timestamp frame.
Adds QUIC_VERSION_23. Deprecate CongestionFeedbackFrame

1 bytes - num_received_packets
First packet:
1 byte - distance from the largest observed in sequence number space.
4 bytes - mod of microseconds since the connection's creation when the
  packet arrived.  (1.1hrs in us)
Every other packet:
1 byte - distance from the largest observed in sequence number space.
2 bytes - mod of microseconds since the previous timestamp

Merge internal change: 73740829

The following are chromium specific changes:
+ Changed ACK frame not to send CongestionFeedback frame
+ Added received_packet_times to ACK frame.
+ The timestamp that is sent is relative to creation time, thus passed
  MockClock's now() as argument to AckFrame and it is used to pass
  QuicFramer's creation time and received_packet_times.

R=cyr@google.com, ianswett@google.com, rch@chromium.org

Review URL: https://codereview.chromium.org/478153003

Cr-Commit-Position: refs/heads/master@{#291830}

The GPU command buffer client uses Rect/RectF from gfx.
RectBase and friends have an extern template declaration which means that
instead of inlining the x(), y(), width() and height() methods (e.g. where they
are used in the header and in gles2_implementation.cc), an external
reference is generated instead. Unlike in Chromium, the NaCl IRT build does
not build/link with the gfx/geometry implementation, which means that
these references never get defined.

So do not use the extern template declarations for NaCl.

R=bbudge@chromium.org (GPU untrusted build), danakj@chromium.org (graphics primitives OWNERS)

TEST= NaCl IRT build with no optimization
BUG= https://code.google.com/p/chromium/issues/detail?id=388035

Review URL: https://codereview.chromium.org/503953002

Cr-Commit-Position: refs/heads/master@{#291829}

1) Image parsing missed one nesting level of dictionaries, and so
   always failed.
2) Images are returned without a scheme prefix - prepend that.

R=mpearson@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/470403003

Cr-Commit-Position: refs/heads/master@{#291828}

Picks up:
r291620 vpx: Simplify intrinsic gypi files.
r291625 Attempt to let libvpx's SSE files build with clang-cl.

BUG=82385
TBR=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/502323002

Cr-Commit-Position: refs/heads/master@{#291827}

This CL allows the extension action context menu to use the new embedded
extension options feature. If the enable-embedded-extension-options flag
is enabled, instead of opening an extension's options page in it's own
tab, it will open chrome://extensions, scroll down to the correct
extension, and then open the embedded options page popup.

The context menu opens a link to chrome://extensions/ with the query
string ?options=|extensionId|. This query string is appended and
removed whenever the embedded extension options popup is opened or
closed.

BUG=386842

Review URL: https://codereview.chromium.org/484033003

Cr-Commit-Position: refs/heads/master@{#291826}

This check turns out to be fairly expensive on Windows (~150ms), and having
it at import time means we're taking the hit every time we launch
memory_cache_http_server. We only need to do this if the Python files have
changed, so move it to runhooks.

The reason this check exists in the first place is that we've had problems in
the past where e.g. someone renames foo.py to foo/__init__.py. foo.pyc remains
on the filesystem of every Chromium checkout and causes a name conflict in
Python imports - foo can refer to the compiled module or the package.

BUG=388256
TEST=git rm a file in src/tools that has a .pyc; git commit; gclient runhooks; ensure .pyc doesn't exist; undo commit

Review URL: https://codereview.chromium.org/489693002

Cr-Commit-Position: refs/heads/master@{#291825}

TBR=stgao@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/501153004

Cr-Commit-Position: refs/heads/master@{#291824}

This was causing a DCHECK as ToolbarView::Observe both didn't handle the
asked-for notification and DCHECKed on unhandled notification types.

BUG=407124
TEST=NONE

Review URL: https://codereview.chromium.org/503783002

Cr-Commit-Position: refs/heads/master@{#291823}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/503083003

Cr-Commit-Position: refs/heads/master@{#291822}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610
R=rogerta@chromium.org

Review URL: https://codereview.chromium.org/498123003

Cr-Commit-Position: refs/heads/master@{#291821}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610
R=raymes@chromium.org

Review URL: https://codereview.chromium.org/505013002

Cr-Commit-Position: refs/heads/master@{#291820}

R=enne@chromium.org, enne

Review URL: https://codereview.chromium.org/506733002

Cr-Commit-Position: refs/heads/master@{#291819}

Needed so that try bots can always depend upon a chrome_run target
existing. Without this it makes detection of whether chrome is going
to be built tricky (some times it'll be chrome, othertimes
chrome_run).

BUG=407419
TEST=none
R=jam@chromium.org

Review URL: https://codereview.chromium.org/507503003

Cr-Commit-Position: refs/heads/master@{#291818}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/500953005

Cr-Commit-Position: refs/heads/master@{#291817}

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/500253003

Cr-Commit-Position: refs/heads/master@{#291816}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/502163003

Cr-Commit-Position: refs/heads/master@{#291815}

The ETC1 spec says that any multiple of 4 is allowed for ETC1 size, but
certain old IMG devices (notably the Galaxy Nexus) crash unless the
textures are specifically power-of-two. To avoid wasting RAM on all
devices due to this device-specific problem, this patch plumbs a driver
workaround flag to the thumbnail store (the only user of ETC1 at
present).

We considered adding a workaround to the service side like all of the
others, but because texture size impacts memory budgeting and
coordinates, this one seems like it needs to be in the client code.

NOTRY=true
BUG=150500

Review URL: https://codereview.chromium.org/470233003

Cr-Commit-Position: refs/heads/master@{#291814}

Review URL: https://codereview.chromium.org/492423002

Cr-Commit-Position: refs/heads/master@{#291813}

instread of QuicClientSession's constructor to make it easier for server
side code to do the same.

Call QuicClientSessionBase::InitializeSession() after constructing
QuicCryptoClientStream.

This is done per discussion in interal change: 72671781

The following are the earlier related issues:
  https://codereview.chromium.org/393953009/
  https://codereview.chromium.org/407193002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/481103003

Cr-Commit-Position: refs/heads/master@{#291812}

We've recevied feedback that conflating maximized and full-screen is not what
users expect. This CL builds on https://codereview.chromium.org/498813003/ to
remove this functionality and instead add an explicit full-screen button to
the window frame.

Note that the icon is a placeholder until we can get UX resources to design a
better one.

BUG=404693

Review URL: https://codereview.chromium.org/491873004

Cr-Commit-Position: refs/heads/master@{#291811}

Review URL: https://codereview.chromium.org/494993005

Cr-Commit-Position: refs/heads/master@{#291810}

BUG=407396
NOTRY=true
TBR=ager@chromium.org
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/502233002

Cr-Commit-Position: refs/heads/master@{#291809}

Revert "Move core web_view code to extensions." (patchset #6 of https://codereview.chromium.org/496873006/)

This reverts commit 63bf863b.

This breaks the app_shell build for the reasons jamesr describes (src/extensions now depends on generated headers from src/chrome, but there cannot be a dependency from extensions -> chrome).

Hypothetical repro on Linux:
* rm -rf out/* && gclient runhooks && ninja -C out/Debug -j 1000 app_shell

chrome/browser/extensions/api/capture_web_contents_function.h:9:10: fatal error: 'chrome/common/extensions/api/types.h' file not found

Original issue's description:
> Move core web_view code to extensions.
>
>
> BUG=352290
>
> Committed: https://chromium.googlesource.com/chromium/src/+/1218a23163baab9f53d70e9a63030db13ef04d04

TBR=fsamuel@chromium.org,yoz@chromium.org,kalman@chromium.org,sky@chromium.org,dmazzoni@chromium.org,jamesr@chromium.org,hanxi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=352290

Review URL: https://codereview.chromium.org/502273002

Cr-Commit-Position: refs/heads/master@{#291808}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610
R=danakj@chromium.org

Review URL: https://codereview.chromium.org/500123003

Cr-Commit-Position: refs/heads/master@{#291807}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/467303005

Cr-Commit-Position: refs/heads/master@{#291806}