- 21 Dec, 2020 40 commits
-
-
Ella Ge authored
Bug: 1152282 Change-Id: Ieced102dbf0f15feadd688c5cc990438d0cdec08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595846Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#838746}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cb4a68ccf148..ec26b8d2b2f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC liberato@google.com,juanmihd@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1106990 Tbr: liberato@google.com,juanmihd@google.com Change-Id: I5bcc2fd092fb87ad70f9cf1c6a20e768d4cb01fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599675Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838745}
-
David Black authored
Note that this CL also updates the lifecycle of the holding space keyed service. Previously it was created with browser context but is now delayed until start of the user session. Also note modifications to DownloadManagerUtils to address tests broken by this CL which assumed DownloadManagerImpl would not be created until after tests bodies executed. Bug: 1155387 Change-Id: I7e0f226cb275465c72eb8d63f1348b44f5412685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572694 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#838744}
-
Camillo Bruni authored
Also clear out the cache handler and the script streamer, since we should no longer access the script's source after clearing it. Bug: 1154943 Change-Id: I89c142f3b33994599483581d3e9f0b3ecf80d073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595745Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#838743}
-
Fabrice de Gans-Riberi authored
Bug: 1073821 Change-Id: If4de5c5c4c1a2c272ec881b553ddc0e7a1bd5937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432133 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#838742}
-
Peter Kotwicz authored
This CL: - Rolls Chromium's guava version to 30.1 This is closer to the version of Guava used by the internal version of Chrome. - Updates the fetch_all.py script to force usage of the listenablefuture 1.0 library version. - Suppresses incorrect vulnerability warning for com_google_guava_failureaccess and com_google_guava_listenablefuture. The https://nvd.nist.gov/vuln/detail/CVE-2020-8908 vulnerability report is overlay broad. BUG=1159853 Change-Id: I4c5828aa3433214f28c6c0ee531f59a27a03973f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596140 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#838741}
-
Shubham Aggarwal authored
Migrate uses of the relevant set_* functions on the sql::Database object to use the new DatabaseOptions constructor instead. This change should have no intended behavioral effect. Bug: 1126968 Change-Id: Ib6bd7558e682dd00a1b40924b86e39275b2dfe64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596219Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com> Cr-Commit-Position: refs/heads/master@{#838740}
-
Thomas Lukaszewicz authored
Update browser command tests for Tab Search to explicitly set the kTabSearch flag when testing and remove the dependency on the default flag state. Bug: None Change-Id: I9fcad4093b50d57079667b373b7d98019a4d3f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598740Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#838739}
-
Zach Trudo authored
RecordHandlerImpl needs to be able to accept either since the server doesn't care which it sends. Bug: chromium:169883262 Change-Id: I72a2d9b52df36326f1f81e66be2b1ca4de4d5950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599809Reviewed-by:
Kyle Williams <kdgwill@chromium.org> Commit-Queue: Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#838738}
-
Nicholas Verne authored
When the disk image for a component is corrupt, it is rejected by dm_verity and fails to mount via the imagloader service. In this case, it is necessary to download a fresh version of the component and try again. Bug: 1068948 Change-Id: Id7607b625ee43b0a1ccc06cfebdb8d4059cdf63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598307Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#838737}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c65f224a7259..8986f3ce67ec 2020-12-21 primiano@google.com Merge "base: rename subprocess.cc -> subprocess_posix.cc" 2020-12-21 primiano@google.com Merge "Move ftrace format_parser into its own subdirectory" 2020-12-21 skyostil@google.com Merge "tracing: Add a way to observe track event sessions" 2020-12-21 primiano@google.com Merge "base::Pipe: Use HANDLE on Windows" 2020-12-21 delphick@google.com metrics: Remap all RAIL_MODE_LOAD to RAIL_MODE_ANIMATION 2020-12-21 delphick@google.com Merge "metrics: Use touch events in modified_rail_slices" 2020-12-21 treehugger-gerrit@google.com Merge "processor: Fix a stack overflow in memory snapshot parsing" 2020-12-19 primiano@google.com install-build-deps: Use different paths for clang on Win vs Linux 2020-12-19 primiano@google.com base::CircularQueue give up on const correctness for MSVC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:174454879,chromium:175871311,chromium:176078470 Tbr: perfetto-bugs@google.com Change-Id: I67ab37041b2397cbfd8e9e8a2228f3e80b2dd5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600063Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838736}
-
Michael Hansen authored
This updates NearbyShareAction to implement content::WebContentsDelegate so that we can handle keyboard events. This was preventing users from opening the feedback window. This change also removes the need to subclass views::WebView, so NearbyShareWebView is deleted. I confirmed via manual testing that links are still working. WebViewExample was used as a reference: https://source.chromium.org/chromium/chromium/src/+/master:ui/views/examples/webview_example.h;drc=d5caa87ad320cc8ceb307f9cc525b7d4f9604dd1 Fixed: 1133817 Change-Id: Id9122ac0a92229a1ebbff66232d31d78ef2ddfcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597900 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#838735}
-
Jeroen Dhollander authored
This is a reland of ef97c140, which was reverted in crrev.com/c/2597250. The original CL introduced a race condition, where LibassistantServiceHostImpl::SetInitializeCallback() assumed LibassistantServiceHostImpl::Launch() had completed, but both ran on different threads so this was not guaranteed. Code (and a lock) has been added to prevent this race condition. Original change's description: > Simplify Libassistant startup (and fix crashes) > > Currently starting Libassistant happens in 2 steps: > 1. (On background thread) ServiceController::Start() creates the > |AssistantManager|. > 2. (On main thread) ServiceControllerProxy::FinishAssistantStart() > sets some extra fields on |AssistantManager| and calls > AssistantManager::Start(). > > This causes a race condition if Libassistant is immediately stopped, > as that happens on the background thread and can collide with step 2 > above. > > To prevent this from happening, this CL collapses both starting steps in > a single step that runs on the background thread. We do this by > registering a callback which is called by the background thread in step > 1 above. > > This callback is temporary but necessary as some parts of the > initialization code still use objects that have not been migrated to the > Libassistant mojom service yet. > > Bug: 1157177, b/171748795, 1128032 > Test: chromeos_unittests "Assistant*:ServiceController*" > Change-Id: Ifab9705839ad5d3e5c9f2b7f7fba4c336b9f7c9d > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594090 > Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838277} Bug: 1157177 Bug: b/171748795 Bug: 1128032 Change-Id: I694f71a959ca7d6effd40c9f75422ec2a979d5e9 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599762 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#838734}
-
Yutaka Hirano authored
We kept such resources when they came from plain HTTP (as opposed to HTTPS). As we now prefer HTTPS to HTTP, we don't need optimizations that are effective only for plain HTTP. Bug: None Change-Id: Iab0aa7bc4550f01a6ed7340a99e5b8677b771cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598305 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Bruce Dawson authored
Exiting a process cleanly is difficult and expensive. Avoiding race conditions becomes almost impossible with complex software and a clean exit can be quite slow. Waiting on all threads, paging in code and data, and race conditions make it not worthwhile. We have been gradually moving towards using TerminateProcess for more process types. Although the majority of the shutdown processes tracked by this bug are in utility processes this change uses TerminateProcess for all process types. We should not need to let destructors run so it should be safe to never use exit() (or to make it opt-in). This change also adds TerminateProcess to windows_types.h to avoid having to add a Windows.h include to another source file. Bug: 896565 Change-Id: I720c692b3315544c09fe9ae438fb65f6f77fc657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598043Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#838732}
-
Bailey Berro authored
Uses the correct key to parse the discharge routine result Bug: 1128204 Change-Id: I5948494b513736f8b5bc0bc87cd9eece42d2c2e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573387 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#838731}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Iad8d59a51884e1f3083529dbbc5eb8189b244f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600022Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838730}
-
Sophie Chang authored
The bloom filter and optimization filter can get destructed on background thread when a new component comes in after initial load Bug: 1160660 Change-Id: Ia1dd5925d7513391148b677fb3e75b818a9fa190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600040Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#838729}
-
Fredrik Söderqvist authored
Text nodes does not have resources associated with them, so calling WriteResources() should never output anything. Bug: 1160415 Change-Id: I223c20eda8fc2a465cc1394850778e78094cfe9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599523 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#838728}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6aea07880248..cdff3fcba638 2020-12-21 johnstiles@google.com Add support for nulls in BasicBlock::Node::description. 2020-12-21 scroggo@google.com SkAnimatedImage: Always respect exif orientation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: I2da02f3ba58f14f287ac8b9fc88505da9c9bdcf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599466Reviewed-by:
-
Judy Wang authored
Add new full screen capture function in accelerator, hide behind capture mode flag for now. Test: Manual test Bug: 1149725 Change-Id: I0ca1beb067aaa98d4c0099f6803515142ec5c616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572686 Commit-Queue: Judy Wang <shidi@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#838726}
-
Aaron Leventhal authored
Code simplification. The ax_list class doesn't add unique logic, and causes role="directory" to be ignored. Bug: None Change-Id: Ie120fceb27b0ba231eb5f631bc7622f9e6fc7fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598618 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#838725}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5d4fd88a7403..ec56b90ceab0 2020-12-21 jiawei.shao@intel.com Skip all the dawn_end2end_tests using glTextureView() on GLES If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I9049d49899f69dd94fd9ad6a7ed99c0598736d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598332Reviewed-by:
-
James Cook authored
When the component updater detects that a new Lacros image is available for download, show a notification in the system tray. This is similar to what we used to do for Flash component updates. The only subtlety is that we have to start watching for updates after the initial install of the lacros component. Otherwise the user gets an "update available" notification for a binary they just chose to install by enabling the LacrosSupport flag. Bug: 1154427 Test: added to ash_unittests and unit_tests Change-Id: I0cabc8aad7963d07447a23a812ac5ec2f8ffec6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594320 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#838723}
-
Matt Reynolds authored
This CL adds a blocklist to block device functionality that should not be accessible from javascript. The blocklist may be extended by setting the WebHIDBlocklist.blocklist_additions Finch variation parameter. The blocklist may be bypassed by passing allow_protected_reports=true when connecting to the device. Bug: 1093544 Change-Id: I4d04161669f969c2e332c656808ad1bd7774409a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587797Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#838722}
-
Bailey Berro authored
This change adds support for routine cancellation to SystemRoutineController. Routines can be cancelled by closing the RoutineRunner associated with the execution. Test: Unittests, verified manually Bug: 1128204 Change-Id: I9e65d1e1bc14b537445b6520e2fca23f27b88ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559327 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#838721}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a89143c8..ab90f825 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I71207aa42dba54a31a21af9c68e00bbc932f3fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597232Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838720}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7f541a18c4f3..cb4a68ccf148 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC liberato@google.com,juanmihd@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: liberato@google.com,juanmihd@google.com Change-Id: Ia2c8d681df0a7d948bb88d8a370a8220dba6903a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600012Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: I0ef8b58e08b4872618cd93085462e30b15ff3df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600021Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838718}
-
rajendrant authored
This CL updates the date before which users who have enabled LiteMode will be treated as non-recent users. These users will show a one time infobar when the first page gets compressed. Bug: 1159971 Change-Id: I98b2fed0475a3b79c8e3f698853ad1122d1f355e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598464 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
-
Wenbin Zhang authored
Disabling stories which are consistently failing. Bug: chromium:1160628, chromium:1160630 Change-Id: Iab07e5809159743bd919d5791a09b1423da980c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599340 Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#838716}
-
Yuheng Huang authored
Remove tab_search_resources.grd since it's no longer needed with auto-generated grd Bug: 1099917 Change-Id: I8a71669432ec21ee0a89ae65c218913ac9620f9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599443Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#838715}
-
Nico Weber authored
Upstream now requires Py3, so let's see if the bot update to 10.15 happened to fix crbug.com/1037896... Bug: 1160953,1037896 Change-Id: Ib38ee655411c21552521b04e7852e16e5e2515b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595261 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#838714}
-
Hui Yingst authored
The Pepper plugin uses pp::Core::CallOnMainThread() to schedule tasks on the main Pepper thread, while the non-Pepper plugin plans to use base::SingleThreadTaskRunner() instead in the future. This CL adds method ScheduleTaskOnMainThread() to PDFEngine::Client and PaintManager::Client as a wrapper for pp::Core::CallOnMainThread() and base::SingleThreadTaskRunner() calls, so that direct calls of these two functions can be removed in the code shared by the Pepper and the non-Pepper plugin. Bug: 1108517 Change-Id: Ie1103adce2dbcf40ece40f318f7c3159f67e93ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594508 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#838713}
-
Jeroen Dhollander authored
This TAST test had become flaky because it uses the beta Libassistant server backend. Bug: 1158005 Test: Tast tests Change-Id: I54d102323cf14e9c5996995d63de4a444aa259a9 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595686 Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
-
Joey Arhar authored
For some reason the win7 bot started producing the same baseline as the regular win baseline, so the win7 specific baseline is no longer needed. Fixed: 1160594 Change-Id: Ic63d548dc59cda60bf589c2b13f5b990038b3af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599582Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#838711}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1e98f9539164..8649e49d10e6 2020-12-21 crodbro@webrtc.org Add a field trial to skip REMB modification of BWE internal state. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iac3ad384b699851d4fee598eb681b4b4809c7930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599829Reviewed-by:
-
Cattalyya Nuengsigkapian authored
- Add a tab slider and update windows shown in Alt-Tab so that "Current desk" mode only display windows in the active desk, while "All desks" display all windows. - Handle special cases: As before, entering Alt-Tab with less than two windows aren't allowed. However, if users switch from the all-desks mode to the current-desk mode resulting in zero or one window, it should show "no recent items" or show a window consecutively. - Hide behind Bento flag and make sure to overwrite kLimitAltTabToActiveDesk in case of conflict, so the old flag works. - Disable remapping Alt+LeftClick to a right click when using Alt-Tab. - Ash unittests for switching between modes and special cases. Bug: 1142726 Test: A manual test (a video in crbug) and unit tests `ash_unittests --gtest_filter=ModeSelectionWindowCycleControllerTest.*` Change-Id: Ia203358d0b658529a3090a292ae36850ea60a36a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581684Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Cr-Commit-Position: refs/heads/master@{#838709}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4ebcee3eb02f..4e2b6d6b0102 2020-12-21 syoussefi@chromium.org Fix PackedVarying's move constructor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1159444 Tbr: ynovikov@google.com Change-Id: I5e6538af5209645265299db47bef8500a80a70fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598333Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I687b9b39d97686d5336f376ce0a9762b928bd37a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600014Reviewed-by:
-
