- 18 Oct, 2018 40 commits
-
-
Renjie authored
Bug: 787942 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: Ia9d210d3d427de332dae4f7ad7fb988239819926 Reviewed-on: https://chromium-review.googlesource.com/c/1289158 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#600901}
-
Yao Xiao authored
For each download, it records the following dimensions: - FrameType: kMainFrame/kSameOriginAdSubframe/kSameOriginNonAdSubframe /kCrossOriginAdSubframe/kCrossOriginNonAdSubframe - GestureType: kWithoutGesture/kWithGesture The code where download behavior is identifiable and ad bit is accessible lives in two distinct places. They will be sharing blink/public/common/download/download_stats.h to log the metrics. Bug: 881345 Change-Id: Ic9f62b8b4eee3e55212df9e336f0ac10ce962c85 Reviewed-on: https://chromium-review.googlesource.com/c/1230441 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ojan Vafai <ojan@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600900}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d876a0dad49c..2ec8dc1f8ab8 Created with: gclient setdep -r src-internal@2ec8dc1f8ab8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1ccd301224b0e301ea8ec9f885ec144edb9cb44c Reviewed-on: https://chromium-review.googlesource.com/c/1288963Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600899}
-
Scott Chen authored
Make css selectors more specific so that it works both in polymer 1 and 2. Bug: 874151 Change-Id: Ie39ea7a9a919b5d627491ba8b8d301720aa2cc32 Reviewed-on: https://chromium-review.googlesource.com/c/1287266Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#600898}
-
Eric Aleshire authored
Internal .json config: https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/700088 api.py CL: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1287890 This removes the step downloading the test files from GCS, as well as some other minor test runner fixes encountered in manual testing. Deploying test files with CIPD should be more straightforward to configure. Bug: 892381 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ib083cedad09ec8df1b250c092ee41e9739e0f2b6 Reviewed-on: https://chromium-review.googlesource.com/c/1287630Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#600897}
-
Eugene But authored
SetDisplayingNativeError should not be used if kWebErrorPages is enabled. Bug: 725241 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I8a8be55dc0312fe60e9a4d403ed5e1ad78cbbf32 Reviewed-on: https://chromium-review.googlesource.com/c/1288975Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#600896}
-
Xianzhu Wang authored
Bug: 627683 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib5e777a993b64f2efaf1b4f0952e506f8e3010a0 TBR: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1289389Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#600895}
-
Christian Biesinger authored
This allows me to remove the otherwise-unnecessary constructors I added in https://chromium-review.googlesource.com/c/chromium/src/+/1286884 R=eae@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I720e6a128b6aa16db734bbc4bad94c0af827782d Reviewed-on: https://chromium-review.googlesource.com/c/1289304Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#600894}
-
Matthew Denton authored
Adds a check in the DnsQuery to ensure we don't parse extra bytes from the buffer. Also adds a check in DnsResponse that ensures we don't leak any uninitialized bytes if we allocated the buffer too large, after constructing the DnsResponse from a DnsQuery. Bug: 891521 Test: ./net_unittests Change-Id: Ia0fd4c677be71efec55e452e5219c34c8112a5e5 Reviewed-on: https://chromium-review.googlesource.com/c/1263280 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#600893}
-
Francois Doray authored
The histogram shows that 99.9% of the time, less than 1000 BLOCK_SHUTDOWN tasks are posted during shutdown. This CL replaces the histogram with a crash when the number is to high, which will be more actionnable. Note: Current histogram data shows that this crash will happen less than 0.1% of the time. Bug: 697731 Change-Id: I553caf93b0109a1bd44c5c841d0f557e6cad16cd Reviewed-on: https://chromium-review.googlesource.com/c/1280670Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#600892}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/488362624b6d..c1e6594df580 git log 488362624b6d..c1e6594df580 --date=short --no-merges --format='%ad %ae %s' 2018-10-18 iannucci@chromium.org [roll-dep] Use Bug: instead of BUG= 2018-10-18 scottmg@chromium.org Support target_arch for WindowsSDK Created with: gclient setdep -r src/third_party/depot_tools@c1e6594df580 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:892712 TBR=agable@chromium.org Change-Id: Iffc29d1699a639e3443d1bc4690878f283f95164 Reviewed-on: https://chromium-review.googlesource.com/c/1288961Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600891}
-
Joshua Pawlicki authored
We don't appear to be close to ready to experiment with Mac. Bug: 687231 Change-Id: I4969c762b691faa6c714359116f143afe20d22bf Reviewed-on: https://chromium-review.googlesource.com/c/1289429Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#600890}
-
Jun Mukai authored
I've got a report saying some SpokenFeedbackTest cases fail with some leaks when SingleProcessMash is enabled. It can be fixed by disabling AutomationManagerAura at shutdown since the leaked objects are allocated through some asynchronous events after shutting down (QuitBrowsers()). BUG=896728 TEST=interactive_ui_tests --enable-features=SingleProcessMash Change-Id: I215c3d5990cc78653c7fd44d378f7130a137a219 Reviewed-on: https://chromium-review.googlesource.com/c/1289295Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#600889}
-
Sergei Istomin authored
StreamMixer can be configured to use audio post processor. The test did not set any post processing pipeline for StreamMixer. When the test ran on a device test failed because a device additionaly processed audio and test got audio data changed. The test succeeded only when it is run on host (testx86). The test was fixed to use fake post processor. Bug: 117792326 Test: Unittests on device. Change-Id: Ife64df2690504bac249829f98ca659b19d763f23 Reviewed-on: https://chromium-review.googlesource.com/c/1285124 Commit-Queue: Sergei Istomin <sistomin@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#600888}
-
Maks Orlovich authored
Bug: 882585 Change-Id: Ic740f1ccd310ba5fc23f7bbb6f6bb40d6a3c59c2 Reviewed-on: https://chromium-review.googlesource.com/c/1287069Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#600887}
-
James Cook authored
Window close events are sent over mojo between browser and ash. The test needs to wait for in-flight messages to complete before making assertions about the state of ash. Also fix a problem where the window delete message wasn't being sent by WindowTreeClient. Bug: 877118 Test: DeviceLocalAccountTest.LastWindowClosedLogoutReminder Change-Id: I43145c8140462428a7db050489593038745c8f94 Reviewed-on: https://chromium-review.googlesource.com/c/1284059 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#600886}
-
Leonard Grey authored
Bug: 850098 Change-Id: Ia9559f323ba5d8d7b74578c91a4fee0618d3bd53 Reviewed-on: https://chromium-review.googlesource.com/c/1288854Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#600885}
-
Mikel Astiz authored
From the bridge's perspective, it's confusing to receive ApplyStopSyncChanges() with a non-null parameter, which reflects sync being disabled, without a prior MergeSyncData() call, which represents sync being enabled. Instead, make sure that a null parameter is passed to the bridge if the initial sync is not done. Prior to this patch, bridges would be overly conservative and clear sync metadata unnecessarily (because there couldn't be any). Other than that, no real user-facing issue exists. Credits for feuunk@ for surfacing and investigating the scenario. Bug: 890709 Change-Id: Ic39fb83596bd4e5e4c6f921b2df0812d0d94515c Reviewed-on: https://chromium-review.googlesource.com/c/1288578Reviewed-by:
Florian Uunk <feuunk@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#600884}
-
Daniel Rubery authored
Based on some example campaigns for which chrome sync history won't be useful, extend the maximum number of gestures in a referrer chain to 5 gestures. We can then evaluate how useful the extra data is, and possible extend the maximum gestures for all users. Bug: 864266 Change-Id: Idbcc2e07f7593a90f05ba07a2e1ef0c2a1be757b Reviewed-on: https://chromium-review.googlesource.com/c/1287041 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#600883}
-
Scott Violet authored
This increases msan multiplier from 6x to 7x and asan multipler from 2x to 3x. I'm doing this as a fair number of tests run very close to the limit, and often timeout. This leads to flake, which makes sheriffing tedious. BUG=896756 TEST=test only change Change-Id: Ib05875935fc2fdc5e042e7af0429794bf5f5b04f Reviewed-on: https://chromium-review.googlesource.com/c/1289083Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#600882}
-
Greg Kerr authored
The keychain was re-authorized to support Chrome's new signing certificate 18+ months ago. At this point, users who haven't re-launch Chrome in 18 months are unlikely to do so, or need the keychain. This removes the re-authorization code. Bug: 893729 CQ-Depend: CL:*698113 Change-Id: I9ba74e11861baafd36dd92b5cd2be2a2d46e6fa6 Reviewed-on: https://chromium-review.googlesource.com/c/1282028 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#600881}
-
Tarun Bansal authored
Enable the experiment that probes data saver proxies, and disables a proxy if the probe to it fails. Change-Id: I037d000f375d9a1eddf3515e4929948cafbd7d36 Bug: 760294 Reviewed-on: https://chromium-review.googlesource.com/c/1280142 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#600880}
-
Eric Karl authored
The passthrough command decoder counterpart to: https://chromium-review.googlesource.com/c/chromium/src/+/1279429 Adds support for DoCreateAndTexStorage2DSharedImageCHROMIUM to the passthrough command decoder. Causes the passthrough command decoder to store shared image representations for relevant client IDs. This isn't really used now, but will be used in a future begin/end access patch. Bug: 891059 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I14f9c0cdfeaf9e836361c2c811a06b69f36cdd66 Reviewed-on: https://chromium-review.googlesource.com/c/1287267 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#600879}
-
Theresa authored
Create a new omnibox/status/ component and move status icon (security and location icons) and verbose status text code from LocationBarLayout to a new StatusViewCoordinator. A future CL will refactor StatusViewCoordiantor. This CL specifically aims to move code with minimal changes. BUG=896096 Change-Id: I2464e1f32ceff17bfeb6c9c9b10c7f7e7fa22c9e Reviewed-on: https://chromium-review.googlesource.com/c/1287042Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#600878}
-
proberge authored
InlineInstallPrivate seems to have been an experimental API developed to allow apps to install other apps and extensions. It seems like it was never launched. Since regular inline installation is being removed, we should probably remove this API as well. Bug: 882045 Change-Id: Iefa97bd46cc38873d1a3d07292d45b2188c8f637 Reviewed-on: https://chromium-review.googlesource.com/c/1265558 Commit-Queue: proberge <proberge@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600877}
-
Nate Fischer authored
No change to the product, this only adds a python script for developers. This adds a script to remove the pre-installed system image WebView APKs. This is an adaptation of the guide at https://www.chromium.org/developers/how-tos/build-instructions-android-webview#TOC-Building R=jbudorick@chromium.org, torne@chromium.org Test: adb shell ls /system/app/webview /system/app/WebViewGoogle /system/app/WebViewStub Test: adb shell pm path com.android.webview Test: adb shell pm path com.google.android.webview Change-Id: Ib4a9c9706b15aa4c8ec826eb552a4b7552cff129 Reviewed-on: https://chromium-review.googlesource.com/c/1281964 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#600876}
-
Edward Lemur authored
The functionality was moved to cq.cfg in https://chromium-review.googlesource.com/c/chromium/src/+/1265735 Bug: 881860 Change-Id: I839784ec7babfa095272ab06c4c21c1e57475216 Reviewed-on: https://chromium-review.googlesource.com/c/1266055Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#600875}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3d878160972c..1922eb00bbd9 git log 3d878160972c..1922eb00bbd9 --date=short --no-merges --format='%ad %ae %s' 2018-10-18 vmpstr@chromium.org Update trace categories to reflect new trace names. 2018-10-18 eyaich@google.com Updating user timing argument regex to not parse on subsequent ':' chars. 2018-10-18 benjhayden@chromium.org Add chopsui to third_party via bower. 2018-10-18 cbruni@chromium.org [results.html] Speed up <histogram-json> parsing 2018-10-18 perezju@chromium.org [pinpoint_cli] Add try job configs for v8 and scheduler teams Created with: gclient setdep -r src/third_party/catapult@1922eb00bbd9 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:892184,chromium:879526 TBR=sullivan@chromium.org Change-Id: I41ed30ce8eb8a704b4105398214b09008cff9566 Reviewed-on: https://chromium-review.googlesource.com/c/1289132Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600874}
-
Theresa authored
Disable this test on Android only. TBR=sahel@chromium.org,dtapuska@chromium.org BUG=894857 Change-Id: I3018030565a733de22b5c16a495a62211d8e1838 Reviewed-on: https://chromium-review.googlesource.com/c/1289081 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#600873}
-
Mirko Bonadei authored
Before this CL, the following GN args were causing an error [1] when building WebRTC. is_debug = false target_cpu = "arm64" target_os = "android" rtc_use_h264=true [1] - ERROR at //third_party/openh264/BUILD.gn:38:5: Undefined identifier. defines += [ "ANDROID_NDK" ] ^------ See //modules/video_coding/BUILD.gn:325:7: which caused the file to be included. "//third_party/openh264:encoder", Bug: None Change-Id: Ia27d995500364306edc555132dba3dbfdf632daa Reviewed-on: https://chromium-review.googlesource.com/c/1286409Reviewed-by:Henrik Boström <hbos@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#600872}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/2d98d49cf712ca7dc6f4b23b9c5f5542385d8dbe..dd412c428ad7c2a60ae4709dfbad6301e499dcb8 The following commits have Chromium bugs associated: 6650898e0 Remove -fsanitize-cfi-icall-generalize-pointers. b68b83223 Fix undefined function pointer casts in LHASH. Bug: 785442 Change-Id: I8a7cdc34cf9c6d9991452eaed6156361ee8c0bab Reviewed-on: https://chromium-review.googlesource.com/c/1289159 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#600871}
-
Jonathan Backer authored
This fixes instrumentation relied on by rendering.desktop telemetry tests. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ibfdb788359a873f7eba83a678a903d0aab8f9b19 Reviewed-on: https://chromium-review.googlesource.com/c/1288715Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#600870}
-
Edward Lemur authored
The PRESUBMIT_test is broken (see https://crrev.com/c/1289164). PRESUBMIT only filters out LayoutTests changes, but PRESUBMIT_test passes more files and expecting all of them to be filtered out. Bug: None Change-Id: I3a7e03c22c0c486fc438490c4b3ea00db5cdae0f Reviewed-on: https://chromium-review.googlesource.com/c/1289300Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#600869}
-
dpapad authored
Need to wrap <style is="custom-style"> with <custom-style> such that styling works both in Polymer 1 and Polymer 2. Bug: 739532,896507 Change-Id: I40e4a1fa6ac071cc31268c5e86fa13a023a59490 Reviewed-on: https://chromium-review.googlesource.com/c/1287258Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#600868}
-
Andrey Kosyakov authored
This reverts commit 5f74e543. Reason for revert: this broke run_web_tests.py, I'm getting: No handlers could be found for logger "blinkpy.web_tests.port.base" Original change's description: > Automatically pick a target directory which exists for run_web_tests.py script > > This also updates how we compute the default for 'configuration'. First, we try to look for the > configuration definition (args.gn) & use that value. If that doesn't succeed, we guess the > value of configuration using the target value. > > Reviewers: the main change is in third_party/blink/tools/blinkpy/web_tests/port/base.py, the rest are followed by. > > > Bug: 893618 > Change-Id: I578c977bcaccd6294596f8cf7079748809698db6 > Reviewed-on: https://chromium-review.googlesource.com/c/1281043 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Robert Ma <robertma@chromium.org> > Commit-Queue: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#600760} TBR=dpranke@chromium.org,nednguyen@google.com,robertma@chromium.org Change-Id: I99ddad12601e0d207ee7d9c276b9d64333488f67 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 893618 Reviewed-on: https://chromium-review.googlesource.com/c/1289431Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#600867}
-
Nicolas Ouellet-payeur authored
It returns true when there are any policies at the machine level, whether that's from a platform provider, or from cloud policies. Bug: 893626, 893628 Change-Id: I6e90ff54ee400a82df04c2f671d408d04b3e3bc5 Reviewed-on: https://chromium-review.googlesource.com/c/1269764 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#600866}
-
Robert Ogden authored
It was agreed that we should use "provided" instead of "delivered". Bug: 896774 Change-Id: I542a0ffc217aa5601d114e5cf1541c12b5b9f990 Reviewed-on: https://chromium-review.googlesource.com/c/1289293Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#600865}
-
Theresa authored
TBR=msramek@chromium.org BUG=894572 Change-Id: I0f9cea8f6434598f9a2c03e5b68d6c95e21f3ece Reviewed-on: https://chromium-review.googlesource.com/c/1289079Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#600864}
-
Andreas Butler authored
Change-Id: I88a0fe75383bb9712478580a7bd60a145e2d89ba Bug: 1228492 Reviewed-on: https://chromium-review.googlesource.com/c/1228492 Commit-Queue: Andreas Butler <andreasbutler@google.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#600863}
-
jdoerrie authored
This change enables the WebAuthN M70 Features "WebAuthenticationUI", "WebAuthenticationTouchId" and "WebAuthenticationCableWin" by default. Relevant Launch Bugs: - TouchId: https://crbug.com/837392 - UI and CableWin: https://crbug.com/873195 TBR=jochen@chromium.org Bug: NONE Change-Id: I3693fbd28c0b11978a045c7fa9f68c9e4995c1a0 Reviewed-on: https://chromium-review.googlesource.com/c/1288795 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#600862}
-