- 01 Jun, 2020 40 commits
-
-
Xianzhu Wang authored
This reverts commit 64bcb13d. Reason for revert: Tentative for crbug.com/1086968. Original change's description: > Fix layer/phase violation of custom scrollbar painting > > TL;DR, with this CL: > - We no longer update custom scrollbar part position during paint; > - We avoid unnecessary ScheduleAnimation when painting custom > scrollbars; > - CustomScrollbar::*Rect() methods no longer have side effects; > - Some FIXMEs are fixed. > > Details: > > Previously LayoutCustomScrollbarPart::FrameRect() stored different > values at different document lifecycle stages: > > - Before paint, its location was always zero, and the size was not the > actual size for some parts, but the minimum size calculated from the > style, not based on layout, though updated in UpdateLayout(). > UpdateLayout() was called not during layout (as a scrollbar part is > not in the layout tree), but anytime we wanted the minimum size from > const methods of CustomScrollbar. > > - During paint, as the FrameRect() calculated during UpdateLayout was > not the real frame rect, we updated the frame rect to make sure they > would be painted correctly. This caused unnecessary > SetShouldCheckForPaintInvalidation when the FrameRect changed and > unnecessary ScheduleAnimation(). > > This CL contains the following changes: > - Removes LayoutCustomScrollbarPart::UpdateLayout(). > Adds ComputeThickness() and ComputeLength(), and lets Margin*() get > style directly, to replace the original UpdateLayout() (which called > SetSize()/SetMargin*()) + Size()/Margin*() in the const methods of > CustomScrollbar. This removes the dependency of the const methods > on the temporary incorrect FrameRect(). > > - Adds CustomScrollbar::PositionScrollbarParts() to set the correct > FrameRect() for scrollbar parts. It's called from several places that > position of scrollbar parts can change. This replaces the Set* called > from CustomScrollbarTheme::Paint*. > > Bug: 856802 > Change-Id: I5b120294a31a7f91831441cb361adfd27aefa44e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167602 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771890} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 856802, 1086968 Change-Id: If1703dcda1d4cb6a53a132557b34867090f397ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225222Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#773772}
-
Matt Menke authored
Fixed: 1088510, 1089026, 1089007, 1089005, 1088996 Bug: 1088998 Change-Id: I5d6f67d711cf2122616d77a2d35b49eaf3c452de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224646Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#773771}
-
Teresa Kang authored
According to the flake portal, these four OffscreenCanvas tests have been marked as flaky. Updated the test expectations accordingly. Bug: 1088007 Change-Id: Ide12f3ef53f05ed7d855ed8924a95a7089a32060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222893 Commit-Queue: Teresa Kang <teresakang@google.com> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#773770}
-
Erik Staab authored
android_cronet_tester is a duplicate of android-cronet-arm-dbg. It appears to have been accidentally duplicated in https://crrev.com/c/1576160. Change-Id: I1e324348a40d8d5cb4015de49c5c9a586f292271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220806Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#773769}
-
Adam Langley authored
The parser called on the changed line demands a Python |str| type, but |contents| here can be a |unicode|. The |str| converter in Python 2 assumes an ASCII encoding and thus throws an exception if any characters are > 127. This means that any changed .mojo files that contain non-ASCII characters cause a presubmit error. One can't remove those characters either because the presubmit parses the previous version of the file too. Thus all changes to .mojo file with non-ASCII characters are blocked without this. Change-Id: I887890590c8ad97a4fac60d19a8bebce439abacc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223973 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#773768}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/71a35d49b734..33dbd656112d 2020-06-01 adlai@google.com Pass file and line number when asserting single owner 2020-06-01 johnstiles@google.com Reland "Remove double support from SkSL." 2020-06-01 johnstiles@google.com Fix strict-constraint bleed in strict_constraint_[batch_]no_red_allowed. 2020-06-01 kjlubick@google.com [canvaskit] Use scratch arrays for colors and matrices 2020-06-01 senorblanco@chromium.org Dawn: fix Device leak in DawnTestContext. 2020-06-01 johnstiles@google.com Revert "Remove double support from SkSL." 2020-06-01 ethannicholas@google.com Revert "Omit dead SkSL functions" 2020-06-01 adlai@google.com Make abandonment state of context thread-safe 2020-06-01 brianosman@google.com Convert GrMatrixEffect to pure CPP/H 2020-06-01 ethannicholas@google.com Omit dead SkSL functions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: Ice02a1a7bcf8a2c093253d2e6a2e711ddf5f3093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225074Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773767}
-
Jeroen Dhollander authored
The old name, ChromeOsOnDeviceAssistant, is simply too long and the |ChromeOs| doesn't add anything extra. Change-Id: Ie7e742672a7440d22404366ccbe92b35f80da89c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225261Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#773766}
-
Kevin Babbitt authored
https://crrev.com/c/2117330 refactored accessibility hit testing to use physical pixel coordinates consistently but overlooked the fact that MacOS passes hit test points in device-independent coordinates. This CL scales the input by device scale factor to compensate. Test will come in a follow-up CL. Bug: 1086819 AX-Relnotes: Fixes an issue with accessibility hit testing on the Mac. Change-Id: I3fcc2cee34082e58d7fd38fdc219672680674095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225334Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#773765}
-
ckitagawa authored
This is a reland of 09cf456a Failures were due to flakiness in FileManagerTest.OldestFileForCleanup Timing of last modified time seems to be racy leading to inconsistent behavior. The fix for this is manually setting the modified time to something longer. Original change's description: > [Paint Preview] Create total size budget > > This CL introduces a mechanism to determine the oldest files and > enforce a total disk size budget for captures. By default this is set to > 25 MB for the tab service. This will ensure we don't use excessive disk > space. > > Bug: 1086963 > Change-Id: I71bd8efa5985214b322a4dc3048afbe4d0b717f2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218548 > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> > Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772809} Bug: 1086963, 1087592 Change-Id: Id95442afcdeb55e60cafc4a8bf6cebef84b3fc8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220483Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#773764}
-
Sergey Ulanov authored
This is a reland of 92842b6a Original change's description: > [Fuchsia] Add WebEngineIntegrationTests.PlayVideo test > > Previously there were tests that play audio and tests that play video, > but no tests were playing a file with both audio and video. Also video > was not played to the end. Added PlayVideo test that plays > bear-vp9-opus.webm to the end. Also updated SetBlockMediaLoading tests > to share play_video.html and reduce amount of duplicated code. > > Bug: b/153914562 > Change-Id: Iba492ec252f692f7aa3f93c319d858a91bb38278 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219404 > Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773338} TBR=kmarshall@chromium.org Bug: b/153914562 Change-Id: I7f0c0d7040861d03dfd505c594eca1ccd0827ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223260Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#773763}
-
Jeff Yoon authored
Bots are failing as they sometimes are allocated 10.13 bots when installing xcode 11.4, which requires OS 10.14. Restricting these to os.MAC_10_14. Bug: 1087161 Change-Id: If7b2937fc3bbd3a67f43f07f51e493b395426c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225232 Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#773762}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/34eef22ca072..a0aaf24a2757 2020-06-01 soxia@microsoft.com [Dual screen] Fix a hinge issue. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I92d8ac0a459926653a965f49420ae6ad88641dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225296Reviewed-by:
-
Dmitry Gozman authored
With PerNavigationMojoInterface launched, this boolean is not needed. Initial history navigation in the child frame will be canceled by destroying the NavigationClient. CommitNavigation IPC will be dropped on the floor because there is no receiver in the renderer, and browser will react to the NavigationClient disconnect and abandon the navigation. Bug: 1020175 Change-Id: Ifddd2d74ca2897283c39e47ec0f57d3a7470f72c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215380Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#773760}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/b4a735cc1ada..9a0423c5f727 2020-06-01 rharrison@google.com Roll third_party/spirv-cross/ 61cddd630..d385bf096 (4 commits) (#1077) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: Iec4a89dbf4c80e51cc29ea40f585fdf856cfe8d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225075Reviewed-by:
-
Mustafa Emre Acer authored
When the SafeBrowsing Delayed Warning experiment delays a warning on a page, we don't want the page to be able to request any permissions. This CL handles the desktop capture request, immediately shows the delayed warning and records a histogram entry. This CL ignores captures initiated by extensions so it doesn't modify desktop_capture_access_handler.cc or and tab_capture_access_handler.cc. Bug: 1081312 Change-Id: I95d04ad0505ae175fabe84815b4ba484055939aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213930 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#773758}
-
Tim Volodine authored
Failing on Marshmallow Tablet Tester: testPromoImpressionCountIncrementAfterDisplayingSigninPromo testPromoNotShownAfterBeingDismissed BUG=1088730 TBR=twellington@chromium.org Change-Id: Ib9a8d928ccfe3aa7ed6a6c4cac378858e1cd75ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224223 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#773757}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 84-4142.0-1590399482-benchmark-84.0.4147.32-r1 to 85-4136.1-1589799307-benchmark-85.0.4150.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ia3d5a2ad32c0a8733ec610a9e2d5bc520997e459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225303Reviewed-by:
-
Francois Doray authored
Before this CL, a WakeUpBudgetPool was owned by MainThreadScheduler and shared among pages hosted in the renderer. This CL moves the WakeUpBudgetPool to PageScheduler. This will allow wake up rate to be set independently for each page, which is needed for the intensive wake up throttling experiment. In the intensive wake up throttling, the wake up rate will start at 1 per second and will transition to 1 per minute after 5 minutes in background. This CL also cleans up the outdated RendererSchedulerWakeUpThrottling entry in fieldtrial_testing_config.json (entry was not needed since feature has been enabled by default for a long time). Bug: 1075553 Change-Id: I74699e4d9dc883712ec6455cd8f788864dd45b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220261 Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#773755}
-
Li Lin authored
Bug: b/157779488 Test: unit test Change-Id: Ib7626b9c78c197f2ec2b7e7b7eac489994262893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223374 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#773754}
-
Nina Satragno authored
Disable */SpokenFeedbackTest.TypeInOmnibox/*. It's flaky. TBR=dmazzoni@chromium.org Bug: 1065235 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Id7d610d2cff752965fb60baedfac78204065d84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225130 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#773753}
-
Jidong Qin authored
The SurfaceOrigin isn't being plumbed from gpu::Capabilities to the output surface. DirectOutputsurface always specifies gfx::SurfaceOrigin::kTopLeft but it needs to pass along the value from gpu::Capabilities instead. Bug: 1077572 Change-Id: I04f96781d90d87a6dc8a9f5a192f76a417249874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217528 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#773752}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I50d74f06fb8c285c81ce9ac1890c1c712e7fe570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224645Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773751}
-
Wenbin Zhang authored
This CL puts testers win-10-perf and win-10_laptop_low_end-perf in lightweight mode with '--skip-perf'. In this case the tests will no longer upload the perf data. Bug: chromium:1045256 Change-Id: I3cc891ec6bebaf4c1becb4d690e70dd3735d734e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219563Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#773750}
-
Christopher Cameron authored
The gl::GLSurface::SwapCompletionCallback function takes two arguments: a gfx::SwapResult and gfx::GpuFence. Consolidate these into a single SwapCompletionResult structure. This mirrors the behavior of gl::GLSurface::PresentationCallback, which takes a gfx::PresentationFeedback. In a follow-on patch, we will add a gfx::CALayerParams argument to this structure, which will be used to communicate information about the CALayer tree on macOS. Bug: 894929 Change-Id: I03eeec04a1b11f1bc8b99d6e426ed04897941061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223376Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#773749}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iaab1593034059554a24e44d8bd060a148df133bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225220Reviewed-by:
-
Jeroen Dhollander authored
Without this the On-Device-Assistant will not start correctly. Bug: b/154866551 Change-Id: I04e9202fb21746304f240a2cb4cb7cd1258ec03b Tests: Launched Assistant and ensured ODA started Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225219Reviewed-by:
-
ckitagawa authored
This re-enables the flaky test PlayerCompositorDelegate.OnClick. The test was failing due to a bug where a tmpdir's deletion time raced with another operation. This CL fixes this by delaying the tmpdir's deletion until after the work requiring it is done. Bug: 1087768 Change-Id: I20061a77a22e2b340b7ce2c702a6c911956056f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222544Reviewed-by:
-
Scott Violet authored
SwipableOverlayView makes use of GestureListenerManager, which is currently rather broke. This is because GestureListenerManager needs to see cc::RenderFrameMetadata on every frame, which it currently isn't. Making GestureListenerManager get render-frame-metadata on every frame is quite costly. I'm in the process of making GestureListenerManager get every frame only when listeners are attached. This patch changes SwipableOverlayView to only attach a listener when it actually needs the information. Patch that makes GestureListenerManager get cc::RenderFrameMetadata is here: https://chromium-review.googlesource.com/c/chromium/src/+/2222623 (it's a work in progress that I'll be doing right after this). BUG=1087480 TEST=none Change-Id: Ib22f1d1ac1caefece5fb1c6059cdd37da72b4618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225139Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#773745}
-
Nate Chapin authored
The WindowAgentFactory is only stored on Document for bindings security checks. Have the bindings go to the LocalFrame instead. Move WindowAgentFactory selection entirely out of DocumentInit and into SecurityContextInit Change-Id: Ib83272185edbec212d30a9afedd4def16c2bc044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188902 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#773744}
-
Nektarios Paisios authored
In https://crrev.com/c/2205400/ a fix was made to the selection offsets that might be necessary whenever there are nodes in the internal accessibility tree that are ignored, i.e., they are not exposed to the platform tree. This patch adds a test for Linux ATK which checks whether either setting or retrieving the selection works properly in such a tree. A helper method is added to the test fixture that searches the ATK tree for a node with a specific role. Also took the opportunity to clean up the test fixture by adding comments, moving methods to be in declaration order, adding const, and renaming erroneously named variables. Example: <p> <div></div> <!-- ignored --> <span>Selected</span> </p> The anchor offset points to the second child of the paragraph and the focus offset to the third. However, the first child, the div, is not exposed to the platform tree because it is empty. The offsets should be adjusted accordingly, i.e., in ATK text, the anchor offset should be equal to 0 and the focus offset should equal the text's length. AX-Relnotes: n/a. R=dmazzoni@chromium.org Change-Id: I22fabbbdc3eea1648c088f35ee898ff307a97d24 Bug: 1082814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218042Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by:
-
Kevin McNee authored
A std::list was being used here due to issues with using a set with previous kinds of smart pointers (described here: https://codereview.chromium.org/1608743004/diff/1/content/browser/frame_host/render_frame_host_manager.h#newcode758 ). Bug: None Change-Id: Ie50bfe12a35ab2ea373c81d2447b44d62cd612d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219158 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#773742}
-
behdad authored
The output path to test_results should be separate for rerun and non-rerun case. Bug: chromium:1088104 Change-Id: I54b6ba26254b37af3c9df0f44ec9d43ea140e52f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224819Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
Brandon Wylie authored
Bug: 1082612 Change-Id: Iaf0a6c5e9aad9a7e12bfbc72e4c392cfdcd4b645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212454Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#773740}
-
Ahmed Fakhry authored
Get rid of an unused variable, and properly use OnWindowAdded() instead of OnWindowHierarchyChanged() which can be triggered for many events we're not interested in. BUG=997102 Change-Id: If9f7677bdb6c7f73ddcfa455139149e4d7922ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223367Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#773739}
-
Frank Liberato authored
Add a check for nullptr, to verify that it's actually the cause of a nullptr deref. Should be removed after figuring that out. Bug: 1077645 Change-Id: Iad2434eb07c3f88574e3c2aff81f348d67a0070a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225257 Commit-Queue: Frank Liberato <liberato@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Auto-Submit: Frank Liberato <liberato@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#773738}
-
Nina Satragno authored
Disable SitePerProcessInteractiveBrowserTest.FullscreenElementInMultipleSubframes, it's flaky on all platforms. TBR=alexmos@chromium.org Bug: 756338 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I6887ea1ef98138f877ec1174208f616f7f670e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225356Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f1c5b95e516e..00b172a6fa55 2020-06-01 danilchap@webrtc.org Add av1 test with temporal scalability. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iae93f3cd4130b09c8bec200500b3635d61ea2237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225072Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 84-4142.0-1590399482-benchmark-84.0.4147.27-r1 to 84-4142.0-1590399482-benchmark-84.0.4147.32-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Idc57069523a51454d3f6a722c7ae0eef613bc004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225298Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1591012454-8f48edc56ad7737be6be6679c88eb62db7b87448.profdata to chrome-mac-master-1591026828-08649a6f2f91ff46c0ee4a8534af4c349ceca721.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I5f8f563dd3bc8f70d203a0a4a9e55d73b0ab885c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225071Reviewed-by:
-
Yi Gu authored
This patch adds a timeline option to Element.animate() function based on the recent spec change: https://github.com/w3c/csswg-drafts/issues/5013. Change-Id: Ibf7e6f824f9e013f62da015cebdbc893255142dd Bug: 1080720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220352 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#773733}
-
