- 06 Nov, 2018 20 commits
-
-
Ned Nguyen authored
Add generator_script and modify BUILD to generate a wrapper script that runs layout tests with build target prefilled Bug: 897803 Change-Id: I21c00b8924e38304903cf10840fdf5bea1ebb864 Reviewed-on: https://chromium-review.googlesource.com/c/1296990 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#605539}
-
Tatiana Buldina authored
Bug: chromedriver:1995 Change-Id: I471db88d118c8954421c2d360a277e4f15c0e8b2 Reviewed-on: https://chromium-review.googlesource.com/c/1318810Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#605538}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4c7f72c9764e..c8ac03930c6d git log 4c7f72c9764e..c8ac03930c6d --date=short --no-merges --format='%ad %ae %s' 2018-11-05 primiano@google.com Merge "UI: Minor fix to prebaked query on cpufreq" Created with: gclient setdep -r src/third_party/perfetto@c8ac03930c6d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Idfe01bad42d30026cc23a8eadf1a67468e0d969d Reviewed-on: https://chromium-review.googlesource.com/c/1318157Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605537}
-
Changwan Ryu authored
The test fails when non-English locale is used, or even when there is a secondary language set in the language preferences. Nougat introduced local lists, so checking the default locale isn't enough to ensure that there isn't any secondary locale, and setting the default locale does not remove the secondary locale. This CL provides a separate code path for multiple locale check in N+. Bug: 901230 Change-Id: I181378e79888a36d47db7c1c3ca360573fdec235 Reviewed-on: https://chromium-review.googlesource.com/c/1318670Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605536}
-
Max Moroz authored
TBR=inferno@chromium.org,metzman@chromium.org Bug: 539572 Change-Id: Ia8904c035a4a5342bed95763be2fb3d64e168c0f Reviewed-on: https://chromium-review.googlesource.com/c/1318653 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#605535}
-
Andres Calderon Jaramillo authored
This CL re-enables virtual/threaded/fast/scroll-behavior/wheel-and-touch-scroll-use-count.html on Linux since it doesn't seem to be flaking anymore. Bug: 766357 Change-Id: I58be5caa2263282d167e12a6543520ee05ca9ebe Reviewed-on: https://chromium-review.googlesource.com/c/1313575 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#605534}
-
Anand K. Mistry authored
BUG=900749 Change-Id: Ia2429113cc5b2bef49e25643fa2176e883029e2b Reviewed-on: https://chromium-review.googlesource.com/c/1311854 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#605533}
-
Joey Arhar authored
Bug: 888755 Change-Id: I428409372cf99d527db0da7771198cdd14cacea7 Reviewed-on: https://chromium-review.googlesource.com/c/1318181Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#605532}
-
Jun Mukai authored
Some tab-dragging test cases never finishes on SingleProcessMash, and it turns out that WindowEventDispatcher thinks some TOUCH_RELEASED events can be invalid; it won't generate any gestures and does not do anything. In that case, OnEvent() won't be called and any other methods are not called, therefore InjectedEventHandler couldn't notify it's done. This CL adds a new method to WindowEventDispatcherObserver to catch such cases and allow handling it's done. BUG=890071 TEST=see the filter update Change-Id: I6dcda9af52e5cbd4013b8d228bda2e9b1f14bdd6 Reviewed-on: https://chromium-review.googlesource.com/c/1316767 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#605531}
-
https://crbug.com/817981Makoto Shimazu authored
Bug: 817981 Change-Id: I13fe128e6771600f135e0a8e9cde00c456305c81 Reviewed-on: https://chromium-review.googlesource.com/c/1317301Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#605530}
-
Andrew Grieve authored
Bug: 901488 Change-Id: I7c98a48ab86533ee206ef7302e085e39be76cd7c Reviewed-on: https://chromium-review.googlesource.com/c/1318669 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#605529}
-
Scott Graham authored
Bug: 883496 Change-Id: I402ef87f893488bcd15ec171e18add9918022a95 Reviewed-on: https://chromium-review.googlesource.com/c/1313570 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#605528}
-
Bo Liu authored
On Android, Navigation.LoadIfNecessaryType.kRequestedByClient counts number of tab restore loads after switches back to a tab with a dead renderer process. Bug: 841572 Change-Id: I753bedf1f0acfbe5bafe286b7cabfa2cf5c31fcf Reviewed-on: https://chromium-review.googlesource.com/c/1316361 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#605527}
-
Jonathan Metzman authored
Add docs on reproducing libFuzzer crashes on Windows. Make it clearer that reproduce tool is not for Windows. Fix a command to work on cmd.exe Bug: 901836 Change-Id: Iabc5f8a2973053659addbb27d326ccb07c7910e2 Reviewed-on: https://chromium-review.googlesource.com/c/1318629 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#605526}
-
Eugene But authored
Changes to SadTabView: - messageTextView and actionButton are now public for testing (http://go/unit-test-practices#public-apis) - _messageTextView and _actionButton ivars are not synthesized anymore, because properties belong to a category SadTabViewController will be owned by SadTabCoordinator which will be landed in a follow up CL. Using view controller for UI presentation will allow to avoid using Transient View for Sad Tab and will follow New Architecture patterns. Bug: 901563 Change-Id: If84d89e9bc3d991e743f3420406881292b345579 Reviewed-on: https://chromium-review.googlesource.com/c/1312684 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#605525}
-
Xiaohui Chen authored
When assistant controllers init and receives an assistant status of NOT_READY, it tries to hide non-exist Assistant, which will eventually cause a segfault. Bug: 901720 Test: locally build and test Change-Id: I4bf7247c175906167436849b4514c450c763c79f Reviewed-on: https://chromium-review.googlesource.com/c/1318680Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#605524}
-
Ria Jiang authored
Root cause https://bugs.chromium.org/p/chromium/issues/detail?id=898842 has been fixed for flaky tests gpu_tests.depth_capture_integration_test.DepthCaptureIntegrationTest.DepthCapture_depthStreamToRGBAFloatTexture and gpu_tests.depth_capture_integration_test.DepthCaptureIntegrationTest.DepthCapture_depthStreamToRGBAUint8Texture. Remove their flaky suppressions on Android and Win. TBR=kbr@chromium.org Bug: 899748 Change-Id: Ida2212bc191a1c5e060cb19b5d6d52d04b377bd2 Reviewed-on: https://chromium-review.googlesource.com/c/1318673Reviewed-by:
Ria Jiang <riajiang@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#605523}
-
Abhishek Arya authored
R=mmoroz@chromium.org TBR=erikchen@chromium.org Bug: 900812 Change-Id: I1e7cac38d9d705179aeff95d438a6932febe8cd4 Reviewed-on: https://chromium-review.googlesource.com/c/1317868Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#605522}
-
Joshua Bell authored
Code in chrome/browser/browsing_data queries storage back-ends for origins and the size on disk and last modified time of each origin's data. This is done for each storage backend by unique plumbing between a BrowsingDataXXXHelper and the corresponding XXXContext via the BrowsingContext's StoragePartition. The same data (list of origin/size/time tuples) is reported for each storage backend. Replace structs specific to each type (e.g. XXXUsageInfo) with a generic StorageUsageInfo struct. This removes several nearly identical classes from content/public/browser (for Indexed DB, Cache Storage API, Local Storage, Service Worker). Follow ons can remove similar classes (e.g. PendingXXXUsageInfo) and do other code deduplication. One functional change: The list of scopes registered for Service Workers is no longer displayed in the "cookies tree" (chrome://settings/siteData); this is not useful for end users and developers should use devtools instead. Change-Id: Ibd759c3e303188580aea8bfcaa450b44183bc100 Reviewed-on: https://chromium-review.googlesource.com/c/1308074 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#605521}
-
Findit authored
This reverts commit 93ee1837. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 605481 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzkzZWUxODM3MDA2NDAwYTRmZGU3ODk3ODdkNzBhN2YwOTkwNWNjZTgM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/8731 Sample Failed Step: compile Original change's description: > [Media Session] [1/4] Move MediaMetadata to service > > This CL moves the MediaMetadata and MediaImage mojo types > from Blink to the Media Session service along with their > mapped types in content. > > This is the first of four parts. > > BUG=875004 > > Change-Id: Ie862229bbeb474a60ccc4d2f82d8c4e1f8017b74 > Reviewed-on: https://chromium-review.googlesource.com/c/1227401 > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605481} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=875004 Change-Id: Ica72191d2b5700c793fbdcf61ce680faa938f0d5 Reviewed-on: https://chromium-review.googlesource.com/c/1318747 Cr-Commit-Position: refs/heads/master@{#605520}
-
- 05 Nov, 2018 20 commits
-
-
Eric Orth authored
On built-in resolver failures, we sometimes fallback and try again with the system resolver. This is not desirable when the source is explicitly set to DNS as we should then only resolve using the built-in resolver. Also changed the "disabling" of DnsClient after errors that succeed on fallback. Should only opportunistically affect requests that can fallback. When we cannot fallback (e.g. due to being a DNS request), DnsClient will still be used. Also changed the behavior of requesting DNS with the DnsClient disabled. Subsequent requests match that behavior and return an error instead of DCHECKing. Bug: 846423 Change-Id: If9e20e32e3e95aad7bd9e09b66bcb00808b95b43 Reviewed-on: https://chromium-review.googlesource.com/c/1313448 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#605519}
-
John Abd-El-Malek authored
This broke for the non-network-service path in r579953 because the new URL from the GoogleURLLoaderThrottle wasn't being sent to ResourceDispatcherHost. While I had added tests to ensure that the correct network request is made, there was a bug in how NavigationURLLoaderImpl called the URLLoaderInterceptor in the non-network service path. It was giving interceptors the ResourceRequest structure that wasn't used, instead of recreating it again from the NavigationRequestInfo that would be used to make the network request. Bug: 899268 Change-Id: I248c8b0614aab803a2a916a1e55d91acbed2e28e Reviewed-on: https://chromium-review.googlesource.com/c/1317865Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#605518}
-
Wenzhao (Colin) Zang authored
This reverts commit f8dfbe74. Reason for revert: crbug.com/900373 Original change's description: > viz: add unittests for CL:1291590 > > BUG=896945 > TEST=SingleOverlayOnTopTest.AllowVideoNormalTransformWithOutputSurfaceOverlay > > Change-Id: Iaa46909657f3e11f1d982f94aaff102676a74b4a > Reviewed-on: https://chromium-review.googlesource.com/c/1292822 > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com> > Cr-Commit-Position: refs/heads/master@{#602548} TBR=dongseong.hwang@intel.com,dcastagna@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 896945, 900373 Change-Id: I57a2c9770df54447e207e7a1d1079006087829ae Reviewed-on: https://chromium-review.googlesource.com/c/1318359Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#605517}
-
Luciano Pacheco authored
Change-Id: Ibd687d1fd8bdce9719c8efb38fc78a341ae4764d Reviewed-on: https://chromium-review.googlesource.com/c/1318770Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#605516}
-
Dmitry Titov authored
This reverts commit f7123bcb. Reason for revert: Made accessibility tests fail, according to Find-It: https://bugs.chromium.org/p/chromium/issues/detail?id=902050 Failure example: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930659681487728800/+/steps/content_browsertests/0/logs/AccessibilityWinBrowserTest.TestNotificationChildrenChanged/0 Original change's description: > AttachLayoutTree on a new Document not necessary. > > We called AttachLayoutTree on a new Document which just got its > LayoutView created. It will not do anything useful as the document does > not yet have any child nodes. > > Change-Id: I1af44b96b86dcb0a597c662b4c47fe9ab3d972aa > Reviewed-on: https://chromium-review.googlesource.com/c/1317889 > Reviewed-by: Anders Ruud <andruud@chromium.org> > Commit-Queue: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605372} TBR=futhark@chromium.org,andruud@chromium.org Change-Id: I64837f90bc4b3f3b43f43115e74555ac20c1ca8d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1318742Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#605515}
-
Sergey Ulanov authored
Change-Id: I1c6d0c24e4c4efec52e64078e3d52b521ae9bb24 Reviewed-on: https://chromium-review.googlesource.com/c/1318588 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#605514}
-
Changwan Ryu authored
We made a change that requires CTS change: https://chromium-review.googlesource.com/c/1297172 Android's CTS has already been fixed in April, but Chromium's CTS version is older and thus failing. We can re-enable them once our build version goes beyond 4738804 (on master, so we may need a few more build numbers until it gets propagated to other branches). Bug: 900915 Change-Id: I17f2d52acf323dc60b772d3f1a6a50290f38448e Reviewed-on: https://chromium-review.googlesource.com/c/1318689Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605513}
-
Zhenyao Mo authored
BUG=867155 TEST=manual R=sunnyps@chromium.org, kbr@chromium.org Change-Id: I1abd150568f1693c6470dfb40ea3c7121c168c4f Reviewed-on: https://chromium-review.googlesource.com/c/1318543Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#605512}
-
rajendrant authored
Move data reduction proxy PLM observer to use OnResourceDataUpdate and use compression ratio to compute the original content length. This CL also plumbs URL to RenderFrameObserver::DidStartResponse to distinguish if its a secure (https) scheme. Bug: 898326 Change-Id: I82ba4fecc7d40b078d49c1b2c722a8ae87917e26 Reviewed-on: https://chromium-review.googlesource.com/c/1313410 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#605511}
-
Dmitry Titov authored
This reverts commit 0475617f. Reason for revert: Broke compile: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/4072 Original change's description: > [Media Session] [2/4] Move Metadata to service > > This CL moves any existing uses in Android of MediaMetadata > to the new version in the media_session service. > > BUG=875004 > > Binary-Size: Adding duplicate classes that will be removed > in https://crrev.com/c/1241554 > > Change-Id: I8ed9afd45a37e515ae89d5d82a542a6f4c139136 > Reviewed-on: https://chromium-review.googlesource.com/c/1241466 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605498} TBR=mlamouri@chromium.org,tedchoc@chromium.org,beccahughes@chromium.org Change-Id: I0a9477b6cbc90bc7379e4ce5c30283c42d82ecc8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 875004 Reviewed-on: https://chromium-review.googlesource.com/c/1318738Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#605510}
-
Shu Chen authored
Bug: 859432 Change-Id: I2fb4b30fffac5db5c2d5a31e7bf96b74e2bcbc89 Reviewed-on: https://chromium-review.googlesource.com/c/1317074Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#605509}
-
Nate Fischer authored
This creates a mostly default NetworkContext. This duplicates the work provided by the content-layer implementation, but will later be extended to provide more functionality. The main addition beyond content layer is this configures WebView's HTTP cache. R=changwan@chromium.org, mmenke@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Bug: 887538 Test: No major issues with NetworkService feature enabled. Change-Id: I9cc1823f144d9ffc96fca917b0763b74e36a53d7 Reviewed-on: https://chromium-review.googlesource.com/c/1314133 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#605508}
-
Jared Saul authored
The tests in this CL have been landed and reverted a couple of times; they work, but end up being a little flaky on Win7. We've had a hard time getting a reproducible setup, and the Chrome testing team have verified our feature works as intended, so for the time being we're marking the tests as flaky on Windows and will follow up. (Sheriffs: If somehow the landing of this CL causes additional flakes, feel free to revert. Flake analysis hasn't shown anything outside of Win7.) Bug: 884817 Change-Id: Iec545cb861bfc1aa3d50746c3a413257c9a9ec82 Reviewed-on: https://chromium-review.googlesource.com/c/1316666 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#605507}
-
Aaron Leventhal authored
Also: - Fixes a bug where updating tabindex on a node did not update its focusable state. - Removes hack for hiding objects from NVDA virtual buffer by providing a null accName. It turns out that using a hidden:true object attribute works and is preferred by NVDA, which for historical reasons ignores the INVISIBLE state. Bug: 900982 Change-Id: I7611d3c3e2da3d6b3f22e40e69189579d15b580e Reviewed-on: https://chromium-review.googlesource.com/c/1312675 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#605506}
-
Luciano Pacheco authored
NOTE: This CL can introduce FLAKINESS, because the number of metadata call depends on multiple async calls. I'll watch the bots and update these tests accordingly. |equal1PercentageMargin| wasn't checking properly the 1% margin, because it was comparing to |desiredValue| instead of |value|, this was causing it to always return true. :-( Change this function to have ceil/floor so it accounts to at least 1 full unit for min and for max values. Changed it to log the values when it returns false which is helpful for debugging failing tests. Change |metadataLargeDrive| test to be more lenient for |fromCache| metadata calls, because calls to cached metadata are cheap we don't have to be too strict and running locally it flaked ranging from ~40 to < 70. Fix small typo. Bug: 899664 Change-Id: I6c6654684a5b341a3ac7378774cb6fe9b7affe4c Reviewed-on: https://chromium-review.googlesource.com/c/1317223Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#605505}
-
David Tseng authored
- ensure we exit Learn Mode for any conceivable user input we capture - improve intro and outtro announcements Bug: 884541 Change-Id: Id2c81cb4e11c5c0a100a065de5f13ba6857eead1 Reviewed-on: https://chromium-review.googlesource.com/c/1313055Reviewed-by:
Zach Helfinstein <zhelfins@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#605504}
-
yileili authored
This is a reland of 08f4508d Original change's description: > Add cast http apis for assistant services. > > Bug: b:118193766 > Test: Manual > Change-Id: I6da9d8458a59701ae7c9ed642d16094e2f36782b > Reviewed-on: https://chromium-review.googlesource.com/c/1304489 > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Commit-Queue: Yilei Li <yileili@google.com> > Cr-Commit-Position: refs/heads/master@{#605395} Bug: b:118193766 Change-Id: I56fe71e0c29cb78500d0f6f9164be126e55ff8f9 Reviewed-on: https://chromium-review.googlesource.com/c/1318186Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yilei Li <yileili@google.com> Cr-Commit-Position: refs/heads/master@{#605503}
-
Hector Carmona authored
Missed this in previous CL. TBR=scottchen@chromium.org Bug: NONE Change-Id: I484d67c17d35daf6e643739eb28f157aa3cf9ec2 Reviewed-on: https://chromium-review.googlesource.com/c/1316114 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#605502}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff3c10197ad5..f742ea814813 Created with: gclient setdep -r src-internal@f742ea814813 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:448088 TBR=mmoss@chromium.org Change-Id: I753819a1857e958854ad9d46f01c0b53dc273317 Reviewed-on: https://chromium-review.googlesource.com/c/1318156Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605501}
-
chrome://flagsMatt Reynolds authored
The default polling rate has been changed to 250 Hz, and the chrome://flags option is no longer necessary. BUG=857522 Change-Id: I4852a67ecd8b8426de0386cdedcadafacd81f1e8 Reviewed-on: https://chromium-review.googlesource.com/c/1317864Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#605500}
-