- 23 Mar, 2020 40 commits
-
-
Adrienne Walker authored
This is a followup to: https://crrev.com/c/2099463 There are no existing origin trial tokens at the moment, so this is hooking up code that will eventually work, with some test overrides. Bug: 1015227 Change-Id: Iac23203c59d0246f38b9d02b55a5c9c21fe17ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107834 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#752527}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/befc2993d549..01ed358917aa git log befc2993d549..01ed358917aa --date=short --first-parent --format='%ad %ae %s' 2020-03-23 ehmaldonado@google.com depot_tools: Run using Python 3 by default. Created with: gclient setdep -r src/third_party/depot_tools@01ed358917aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I7037275e02094760c0fe33f843d4a86e66754afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116230Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752526}
-
Samuel Huang authored
This CL migrats SuperSize (and Python scripts that use it) to Python 3. Details: * Use futurize to perform standard migration changes: * {raw_input(), xrange()} -> {input(), range()}. * {Queue, SimpleHTTPServer} -> {queue, http.server}. * __builtins__ -> builtins. * .iter{items(), keys(), values()} -> {.items(), .keys(), .values()}. * Explicit iter() added at some places. * itertools.{ifilter(), imap(), izip()} -> {filter(), map(), zip()}. * Explicit list() added at some places. * exec(): Use function syntax. * Make classes inherit from objects. * Generators: .next -> .__next__. * Remove __future__ usage (including those added by futurize). * Remove auto-launch using PyPy. * Benchmarking shows PyPy 3 confers no advantage over CPython3! * json.dumps(): Remove File parameter. * Main challenge: String changes: {str, unicode} -> {bytes, str}. * basestr -> str. * subprocess.Popen(): Add encoding='utf-8' param. * Need to disable pylint warning. * subprocess.check_output(): Explicitly decode('ascii'). * Replace cStringIO.cString() with io.BytesIO or io.StringIO. * io.stringIO(): .truncate(0) does not bring write head to origin; need to call .seek(0) explicitly. * gzip.open(): Use text mode instead of binary mode. * String literal replacement for file parsing. * Replace 'literal' with b'literal' for these usages. * b'bytes'[idx] is an int! Adapt wherever used. * archive.py: _NameStringLiterals(): Redo '\n\t' removal and printable character detection. * file_format.py: * Use io.TextIOWrapper() to iterate lines from |file_obj|. * Caveat: Needs to specify newline='\n' so '\r' does not wrap! * Replace shutil.copyfileobj() with simple dst.write(src.read()). * Tests: * assert{Not}Equals() -> assert{Not}Equal(). * PRESUBMIT.py: Limit tests to use Python 3 only. Notes on scripts that use SuperSize: * Change shebang & invokes: {python, vpython} -> {python3, vpython3}. * sizes.py: * Kept in Python 2, owing to dependence on tracing.value. * trybot_commit_size_checker.py: * _SizeDelta: Replace __cmp__() with __lt__(). Bug: 1054018 Change-Id: Ib374331dec67c027db9f95ab3d5e3dfb780b62a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107794Reviewed-by:Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#752525}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aa550dd6d8b8..e9340f3aaa1e Created with: gclient setdep -r src-internal@e9340f3aaa1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1045987,chromium:1057652 Tbr: jbudorick@google.com Change-Id: Ic9d97481ccfad1e262a5aa34a322f7a41ffc9809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115914Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752524}
-
Wei-Yin Chen (陳威尹) authored
Bug: 1023833, 1063642 Change-Id: I98de404b5544e8de4297746cc063e7d6a2127aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114399Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752523}
-
Dave Tapuska authored
Previously sending a shared array buffer across a frame boundary serialized as null and the message handler would be called. messageerror should be called in these scenarios. This change brings us compliant with Firefox and the standards. BUG=1028736 Change-Id: I2e87b0d6685440b81ed24ff1b41cd4e8f7b874c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109021Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#752522}
-
David Bokan authored
This reverts commit 4a7404ec. Reason for revert: Captured enough stacks to get useful information Original change's description: > Add DumpWithoutCrash to Mac KeyPress builder > > Add a DumpWithoutCrash to KeyPress events where the timestamp of the OS > differs from the current time by more than 5 seconds. We see in UMA that > we often see events in the 95% percentile reaching many seconds of > difference. Hopefully the crash stacks will reveal something about > what's causing this. > > We additionally store some information about the key press event to see > if there's any pattern there. > > Bug: 1039833 > Change-Id: I0be1a4fab8dbbaab2830ad1d8206486c2a5ab971 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111782 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752159} TBR=ellyjones@chromium.org,sadrul@chromium.org,bokan@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1039833 Change-Id: I4d6a64b37947c9e2ed5bc7a4adb5fc6ed4ca540b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115946Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#752521}
-
Lijin Shen authored
1. rename modern_primary_color to default_bg_color 2. rename modern_secondary_color to default_bg_color_secondary 3. update doc 4. remove unnecessary tools:ignore Bug: 775198 Change-Id: Iad6e7f59279e274db966a849cd226ba02734f12b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112818Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#752520}
-
Aaron Gable authored
Trying to use the NaCl SDK (32-bit only) on Mac 10.15 (64-bit only) doesn't work. It prints this error message: The NaCL SDK is 32-bit only. macOS 10.15+ removed support for 32-bit executables. To fix, set enable_nacl=false in args.gn, or downgrade to macOS 10.14. For more information, see https://crbug.com/1049832. This CL sets `enable_nacl=false` in the GN args used by the new Mac 10.15 builders. Bug: 1057776 Change-Id: I5f883346eba96143a47620c8c9758c9bfafa05dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116130Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#752519}
-
Sebastien Marchand authored
These trace events will help understand if the system is under memory pressure when looking at a Chrome trace. Change-Id: I8f761d6aeea974977972ee74ba73a5e5684a767e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111908Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#752518}
-
Ilya Sherman authored
This is the alias that's used for our gwsq, to load-balance reviews among the team. R=asvitkine@chromium.org Bug: none Change-Id: Id0b960b08be6f3030f869d2de74b99c8e3d867cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116313 Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#752517}
-
Alexander Cooper authored
Vr/service is being moved to content; however, until that is finalized this ensures that no extra usages of the directory are added. Also moves a class out that should not have been in vr/service to start with. Change-Id: I3cdc64f8db27e2d09296de8ecabe2b1bb98b8fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111670 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#752516}
-
Michael Thiessen authored
Uses gn refs to find the test target containing the file, then builds and runs the suite. For java test files the filter can be automatically generated, but for c++ it isn't as straightforward so I've made the filter mandatory. ./tools/autotest.py -C out/Desktop image_decoder_browsertest.cc --gtest_filter="ImageDecoder" ./tools/autotest.py -C out/Android UrlUtilitiesUnitTest --fast-local-dev -v Examples: Change-Id: I1840ef3634e4a011f871acd973d5f8bb5038c3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101542Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
-
Sebastien Marchand authored
Local tests confirmed that the version of pefile in third_party produces the same results as the one in tools/symsrc on official binaries (32 and 64 bits). Bug: 762072 Change-Id: If2ebbe4f2e948b07e3a38228e325685fbb87c446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115770 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
-
danakj authored
This file does not access content internals and is not tied to the files in test_runner/ that do. But it is also used by content/shell/*/web_test also, so we move it out to content/shell/ for them both to use it there. R=nasko@chromium.org Bug: 866140 Change-Id: I16722f3b06e0c6487afd546395c1277d20133d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113430 Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#752513}
-
Colin Blundell authored
As part of sharing Chrome's external intent launching logic, WebLayer will need a mechanism for determining whether it is in the foreground. Chrome uses ApplicationStatus for this functionality, but this is not appropriate for WebLayer. Instead, this CL has BrowserFragmentImpl.java add listening of onResume()/onPause() to its existing listening of onStart()/onStop() to be able to add an API to BrowserImpl.java that returns whether it is currently resumed (i.e., is in the foreground with focus). Bug: 1031465 Change-Id: I271ea7a0677065ec8acf690841a2e45b9360c72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115518Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#752512}
-
Chris Harrelson authored
Verified that it still fails with [1] applied and [2] reverted. This may help with deflaking WPT [3] [1] https://chromium-review.googlesource.com/c/chromium/src/+/2111906 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2092698 [3] https://github.com/web-platform-tests/wpt/pull/22364 TBR:szager@chromium.org Change-Id: Ie668c43c4d03ea442c37075c0e80be5ba1481fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115932 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#752511}
-
Emircan Uysaler authored
This CL fixes the regression introduced by looping to find the supported MediaAccessHandler and adds tests. Bug: 1063215,346399 Change-Id: I2427d720768b68955ebcc341ea3493872aaa9c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111931 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Min Qin authored
The finch experiment already launches. Default the flag values to enabled. BUG=971366 Change-Id: I8ab291b6c020e521094c3cc12e76e6a5d9918f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096794Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#752509}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cad8fba253af..99ede42ffe50 git log cad8fba253af..99ede42ffe50 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 jlavrova@google.com Some bengali text does not have cluster index in ascending order 2020-03-23 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2020-03-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cb7e7387e61f..31e36a631345 (2 commits) Created with: gclient setdep -r src/third_party/skia@99ede42ffe50 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Iab157ac4f8610aeac70869adfda4028b7da01382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115913Reviewed-by:
-
Jeff Yoon authored
Creating src-side changes for Chromium to run ios-webkit-tot. Deleting the original JSON as it would no longer be consumed. - xcode_build_version 11c505wk added to ci.star. lib/ changes added to support overriding default cache (11c29) - gn_args migrated to mb_config.pyl - test suites migrated to test_suites.pyl. waterfall.pyl definition introduced to map builder to test suites. mixins.pyl has a change for the custom webkit argument. Bug: 1055164,912681 Change-Id: I6552f5a48db0f02837378c3b08e65d6553325b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106236Reviewed-by:Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#752507}
-
Andrew Xu authored
When adding an icon to shelf, two animations occur in sequence: first, icons which are already pinned are moved to leave the space for the new icon; second, the new icon fades in. Now bounds animator is used for both animations through ShelfView::AnimateToIdealBounds. However, ShelfView::AnimateToIdealBounds actually updates the bounds of all icons. As a result, first animation may be interrupted by the second animation. Note that in the second animation, only the opacity of the new icon changes. This CL replaces the bounds animator with layer animation for the second animation. In addition, thanks to the recent change in bounds animator (https://crrev.com/c/2079607), calling SchedulePaint during fade out animation should be unnecessary. Hence this CL also removes that. Bug: 1061984 Change-Id: Ide80042db99ba9ec40e824eb38ed37eb754715f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114579 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#752506}
-
Hui Wang authored
Remove this since NetworkService had been enabled. No logic changed. Signed-off-by:
Hui Wang <wanghui210@huawei.com> Change-Id: I0760a844bbc07abb8d951f8214e7ad57d5f71665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113598Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#752505}
-
Tomasz Śniatowski authored
Introduced by http://crrev.com/c/1532984, likely because the presubmit check fails to fire in cases where the "tag" argument to a log call contains a space (see bug). Bug: 1063573 Change-Id: I1e9b53a80faa45c422b9536fd8d7ac06a7f99b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113491 Auto-Submit: Tomasz Śniatowski <tsniatowski@vewd.com> Commit-Queue: John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#752504}
-
Ben Pastene authored
The libassistant build calls gn_helpers to read the out dir's args.gn file (while it's being invoked by ninja, mind you!) and passes its contents through gn_helpers, applies a filtering, then creates a sub build dir (within the original build dir) using its modified set of GN args. This is problematic since crbug.com/937821 is trying to transition CrOS bots to using import() lines in their args file, which breaks libassistant's build. This fixes that by adding import support to gn_helpers. Bug: 937821 Change-Id: I790bc27368611f31b63a0135c0e5919f35b21e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107709Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#752503}
-
Robert Ogden authored
Uses a separate Network Context (only 1 on SRP page loads) with the proxy configured to fetch all predicted resources. Testing for this is a bit limited at the moment. Currently, there is not a CONNECT proxy for testing, so only the tunnel request can be verified. Working on a testing proxy in a separate cl/bug. Bug: 1042829 Change-Id: I9e7a325405ac9660db9afe37ef34efff5c56bed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108534Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#752502}
-
Mark Cogan authored
Updates the device sharing manager to be a keyed service. The device sharing manager implementation was such that it would be more cleanly implemented as a keyed service; prior to this CL the service needed to be updated manually when browser states were created or destroyed. By making this change, explicit handling of device sharing manager creation, clearing, and destruction is removed, simplifiying the browser wrangler and startup/shutdown APIs. This change re-implements the Objective-C device sharing manager as a C++ keyed service class with an accompanying factory class. The basic behavior of the class remains unchanged, with the following exceptions: - There is no longer an "update for browser state" or "clear device sharing manager" method. As a keyed service, the manager is bound to a specific browser state for its lifetime. - Instead of expecting calling code to set an empty URL to indicate that no URL is being shared, an explicit ClearActiveUrl() method is added. The device sharing manager implementation (as before) creates and owns an instance of HandoffManager, which in turn creates user activities that expose the active URL. For testing purposes, the handoff manager and its activity's URL are exposed; the prior implementation mocked this instead. For EGTests, the utility that grabbed the device sharing manager from MainController is removed, and instead the app interface uses the keyed service to access it (also using the test-exposed interface for the activity URL). This CL overall is the first step in a two-part process to update device sharing for multi-window; the second CL will factor the sharing logic out of BrowserViewWrangler into a BrowserAgent. Bug: 1049535 Change-Id: If067547fcaf7caabb334adf25c7681fa286c53f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115610Reviewed-by:Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#752501}
-
Alison Maher authored
If the legend had been laid out in previous fragments, the fieldset content block size didn't take into account the block size previously taken up by the legend. This change addresses this and updates the affected unit tests. virtual/layout_ng_block_frag/external/wpt/css/css-break/fieldset-001.html now crashes due to the fact that when the block_start_padding_edge_ is adjusted by the legend, the calculated adjusted_padding_box_size can become inconsistent between fragments, causing a crash when laying out the fieldset content. This crash will be addressed in a follow up change. Bug: 875235 Change-Id: Id7f678afdc67acb41fc55c7fe2255b9d1041c7b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109530 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#752500}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4c7460aceb93..31e36a631345 git log 4c7460aceb93..31e36a631345 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 lexa.knyazev@gmail.com Reland "Refactor BitCount" Created with: gclient setdep -r src/third_party/angle@31e36a631345 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: Iec7d7421b75d73d4e05420aad6cd1fcf1cb379c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115506Reviewed-by:
-
Anders Hartvoll Ruud authored
Whenever we are animating a property that affects the font, we must avoid the base computed style optimization. This is because the base style may contain em, ex (etc) units which needs to resolve against the font. Hence, set a flag when a font-affecting animation is applied. Bug: 437689 Change-Id: I8bd950a1df9c8e100c4ca2b7318b0389a2acfad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109694 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#752498}
-
Vasiliy Telezhnikov authored
This CL converts resource_dirs to sources for android_resources in BUILD.gn files in components and ui. Details: https://crbug.com/1026378 https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/KAFsfaoq7y4/OC4v5sb9BQAJ Bug: 1062263 Change-Id: I50542a81d1fa7f08e4664334a87353bfc389982e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115551Reviewed-by:
-
Sahel Sharify authored
This cl enables PaymentHandlerEnableDelegationsTest tests after removing "PaymentRequestTestRule.ENABLE_EXPERIMENTAL_WEB_PLATFORM_FEATURES" I tried reproducing the flakes locally by copying trybot's gn args and running tests 100 times on a Nexus 5, and Pixel 3, I couldn't reproduce any flakes. Looking at the stack trace of some of the crashes(see the link below) I suspected that the crash might be related to one of the experimental service worker features enabled by the experimental web platform features. https://bugs.chromium.org/p/chromium/issues/detail?id=1054103#c7 Change-Id: I7b74752034f6540aff25df4a1f0e3cdb9366086b Bug: 1054103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115875Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#752496}
-
Nohemi Fernandez authored
As a part of the sign-in architecture migration we are moving logic for presenting the sign-in promo out of a custom view controller and into a utility class. Logging from this custom view controller will be added subsequently to a specialized UpgradeSigninLogger class. Bug: 971989 Change-Id: I83aeb58ccaaff75d833015597e3ec2cb8992721d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107552 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#752495}
-
Clark DuVall authored
These tests were previously using the fake permission manager which always grants permissions. Now we can use the real permission manager, and the fake permission manager can be removed. Fixes a strict mode violation in permission dialogs (similar to fixes from https://crrev.com/c/2108603). Bug: 1025625, 1025609 Change-Id: I8b756c61ee213151e53d68a375ffa4d3f8fd7643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111061 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#752494}
-
Nico Weber authored
While here, also replace an LOG(INFO) with a DLOG(INFO) on Windows for a LOG(INFO) that had a TODO to switch to DLOG once crbug.com/730068 is fixed (which it now is). Other than that, no behavior change. Bug: 730068,346399 Change-Id: Ifa5cef7e27f3fc2f45ac30fe2769eeb6c44b5d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113738 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#752493}
-
Joshua Pawlicki authored
Bug: 926234 Change-Id: I453092f47dd059a48ed1579bcb63d700739909eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042217 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#752492}
-
Dana Fried authored
Change-Id: I1b1f1cf0daf1a7f3eb468a9c2ab5f6c6652b5ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116132 Commit-Queue: Dana Fried <dfried@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#752491}
-
Mugdha Lakhani authored
Currently, PageInfo embeds function pointers in a ChooserUIInfo struct that map from a Profile to the appropriate ChooserContextBase instance that is associated with the Profile. However, this organization blocks componentization of PageInfo. This CL instead has PageInfo obtain the ChooserContextBase instance to use for a given ChooserUiInfo via the delegate; the Chrome delegate impl has access to the Profile and can key off the ContentSettingsType param in the ChooserUiInfo object to determine the appropriate ChooserContextBase instance to fetch. External clients of the prior ChooserUIInfo functionality all have access to a PageInfo instance, hence, they are ported to this model as well via PageInfo exposing the necessary API publicly. Bug: 1052375 Change-Id: Ic6750e5504fb7b2ea23dc6b3cff64542d44b6084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111171 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#752490}
-
Elly Fong-Jones authored
This framework is now unused. Bug: 496955 Change-Id: I025cb6281f4251d1ea92e99bcb33b59ef50dcc5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115691Reviewed-by:
-
Garrett Beaty authored
Milestone M82 is being abandoned, so the beta bucket is entirely removed. Change-Id: I4e99bfc8c925c492fb1fa818c6e08e37eb0d3b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108906 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#752488}
-
