- 23 Nov, 2018 40 commits
-
-
Tibor Goldschwendt authored
Update Play Core to fix a bug where SplitInstallManager.getInstalledModules would return an empty set if no module was installed as a true split. This CL is a precursor for adding the installed feature modules to crash reports. Bug: 873719 Change-Id: Ibd1715e01e504860f2124a9b9abaca027306a563 Reviewed-on: https://chromium-review.googlesource.com/c/1349009Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#610630}
-
Javier Ernesto Flores Robles authored
Running git log will reveal that Olivier has committed more than 40 CLs this folders and given that he has been a committer for more than 6 months. He meets all the criteria. Change-Id: I090289fa27abee24fcf9e46c916cb4287e15048a Reviewed-on: https://chromium-review.googlesource.com/c/1348091Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#610629}
-
Jeremy Roman authored
Bug: 736037 Change-Id: I86fec7e292751bcd7dd4a0091704a8cc79dcacc8 Reviewed-on: https://chromium-review.googlesource.com/c/1348832Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#610628}
-
Ross McIlroy authored
Also replace deprecated uses of arraysize with base::size(array). BUG=v8:7290,v8:8238 Change-Id: I1ea89bcc0162e8ac1f530be979511171d53c5467 Reviewed-on: https://chromium-review.googlesource.com/c/1349321 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#610627}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/246e02474676..1a5db00d4018 git log 246e02474676..1a5db00d4018 --date=short --no-merges --format='%ad %ae %s' 2018-11-23 fmayer@google.com Merge "profiling: Dump all on receipt of USR1 signal." Created with: gclient setdep -r src/third_party/perfetto@1a5db00d4018 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I085ebe91be19612acbea50f5f121acb8173f9ff6 Reviewed-on: https://chromium-review.googlesource.com/c/1349436Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610626}
-
Andrew Grieve authored
Bug: 906803 Change-Id: I5a9c315008a6908e2bb3aef7ac9726e20b6c1cfc Reviewed-on: https://chromium-review.googlesource.com/c/1349672Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610625}
-
Mathias Carlen authored
Propagate the cookie experiment bool to the initial request parameters by setting it explicitly in the parameters map. This will allow the backend to make informed decisions for previously seen sites where we may not have a clean slate. Note: This parameter only gets set when the cookie experiment is enabled. Note 2: This patch introduces a different pattern to set parameters not actually provided by callers. Bug: 806868 Change-Id: Ibe7b19ad8bda2636e531884b89928d3a9cebb0f1 Reviewed-on: https://chromium-review.googlesource.com/c/1349226Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#610624}
-
Mathias Carlen authored
Bug: 806868 Change-Id: I17f1e150ed5cf5d14124086717364c7ac7c5d21a Reviewed-on: https://chromium-review.googlesource.com/c/1349319Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#610623}
-
Michael Lippautz authored
Change-Id: Id380da541c8ed38ca1c07df6c53f7fddd2fc9b82 Reviewed-on: https://chromium-review.googlesource.com/c/1349312Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#610622}
-
sebsg authored
This will be used to record whether a user has opted in to seeing their Google Account cards in the Autofill dropdown. The dictionary should not contain info about accounts that are not opted in. Bug: 907929 Change-Id: Icc663b228792c58b00c02b204249fba9f557481b Reviewed-on: https://chromium-review.googlesource.com/c/1348792Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#610621}
-
Jeremy Roman authored
Bug: 736037 Change-Id: I4c0bf2d3d374fbd659c7c70383e68c8102ef80f3 Reviewed-on: https://chromium-review.googlesource.com/c/1349494Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#610620}
-
Dan Elphick authored
Also rebaselines the tests to match. Bug: v8:7279, v8:8238 Change-Id: I4ba0aa32c5048a4a7e7a86ebf7481f048c13c95c Reviewed-on: https://chromium-review.googlesource.com/c/1349225Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#610619}
-
Sami Kyostila authored
The following perf tests are often timing out on Android: - JSONPerfTest.StressTest - ObserverListPerfTest/1.NotifyPerformance - ScheduleWorkTest.* This patch disables them on Android until they are be investigated. TBR=gab@chromium.org Bug: 906686 Change-Id: Iad78d71e1b3293a75834b06a2b7b4b13b7ac5e75 Reviewed-on: https://chromium-review.googlesource.com/c/1349711Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#610618}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c7c809224d90..f8d95114b66d Created with: gclient setdep -r src-internal@f8d95114b66d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I61b503b4d48b2841007cb07fefeadd8960c31802 Reviewed-on: https://chromium-review.googlesource.com/c/1349435Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610617}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b5906a4d. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org: external/wpt/mediacapture-streams NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: If546c1f899ae3bef760513114c7811080594ab98 Reviewed-on: https://chromium-review.googlesource.com/c/1349493 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610616}
-
Dave Tapuska authored
While not possible the compiler still generates errors without casts. BUG=879657 Change-Id: I1975197135c8ab2bd0723360180d851b8be17e93 Reviewed-on: https://chromium-review.googlesource.com/c/1348954Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#610615}
-
Nicolás Peña Moreno authored
This reverts commit 9703d737. Reason for revert: compile failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Builder/42183 Original change's description: > Disable failing zipFileOpenDownloadsEncryptedCancelPassphrase. > > linux-chromeos-rel currently fails this test. > > TBR=amistry@chromium.org > > Bug: 908071 > Change-Id: Iff70ff9c3cc4eb455b48f4effaa3befc441d52b4 > Reviewed-on: https://chromium-review.googlesource.com/c/1349345 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Commit-Queue: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610609} TBR=amistry@chromium.org,futhark@chromium.org Change-Id: Id22fd9c845a0656c16b939930a6ea37474eaec8a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908071 Reviewed-on: https://chromium-review.googlesource.com/c/1349497Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#610614}
-
Nicolás Peña Moreno authored
This reverts commit 0850df10. Reason for revert: the culprit CL was reverted, no longer needed. Original change's description: > EventTiming: mark event-timing-onloadthenobserve.html as flaky on Mac > > Bug: 907948 > TBR=tdresser@chromium.org > > Change-Id: I53d328b935ab235e441f555e625aa97fac1b9ea4 > Reviewed-on: https://chromium-review.googlesource.com/c/1349033 > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610519} TBR=tdresser@chromium.org,npm@chromium.org Change-Id: Ib20b5fd4bf0cf147518967ede801d9092e7a7112 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 907948 Reviewed-on: https://chromium-review.googlesource.com/c/1349496Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#610613}
-
Gauthier Ambard authored
This CL adds EG test for testing the Switch to Open Tab feature. The covered test cases are: - Check that it is possible to switch to an open tab, - Check that if you switch tab, your previous tab isn't closed, - Check that the incognito tabs aren't taken into account in non-incognito and vice-versa, - Check that the current page doesn't have the switch button. Bug: 908010 Change-Id: I9434ef8cf2b41b55ab59f70aec48aea282d2401e Reviewed-on: https://chromium-review.googlesource.com/c/1349331Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#610612}
-
Javier Ernesto Flores Robles authored
In order to add the animations some refactoring was required. This also updates the suggestions view and form accessory view instead of recreating them every time new suggestions arrive. Continues the UI layering of these views, by removing the navigator related logic from them. Relies on setting content insets instead of removing suggestions to lock on the manual fill icons. Refactors names of delegates and properties to more appropriate ones Fixes an issue when disabled suggestions was ignored when jumping between fields. Bug: 905651, 907084, 845472, 905660 Change-Id: I4ceebcabadbb26e6d948c26f9691d5684a143b79 Reviewed-on: https://chromium-review.googlesource.com/c/1346833 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610611}
-
Ross McIlroy authored
BUG=v8:7290,v8:8238 Change-Id: Icb327a0da2bb9abd4b3fa058ce922f96ed7782a0 Reviewed-on: https://chromium-review.googlesource.com/c/1349267Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#610610}
-
Rune Lillesveen authored
linux-chromeos-rel currently fails this test. TBR=amistry@chromium.org Bug: 908071 Change-Id: Iff70ff9c3cc4eb455b48f4effaa3befc441d52b4 Reviewed-on: https://chromium-review.googlesource.com/c/1349345Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#610609}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/38ec294c9aeb..c7c809224d90 Created with: gclient setdep -r src-internal@c7c809224d90 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If21f887196f59b011e76955a84feae53c98cb857 Reviewed-on: https://chromium-review.googlesource.com/c/1349530Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610608}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2ecd5f54..01b0845a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6025e28e8c94a6e54abb1edccf768496a997fd14 Reviewed-on: https://chromium-review.googlesource.com/c/1349490Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610607}
-
Kush Sinha authored
Also add a note about AccountManager::UpsertToken being idempotent. Bug: 904128 Bug: 820046 Change-Id: Ie9cc135edf2afad2d9da3c13df5fbc6fc822c4ad Reviewed-on: https://chromium-review.googlesource.com/c/1349224Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#610606}
-
Matthew Cary authored
Small fix to correct usage of --manual-libname. Change-Id: Idba891ed7e193a42bd355812972f9c649876f214 Reviewed-on: https://chromium-review.googlesource.com/c/1349263Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#610605}
-
Antonio Gomes authored
BUG=907483 Change-Id: Id6b76a8b0d89d4ecb18e1253e6919ab37666b009 Reviewed-on: https://chromium-review.googlesource.com/c/1349590Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#610604}
-
Jonas Olsson authored
Intent to Implement and Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/lxHPNYoaEU8/0JFwF0ipCQAJ Bug: chromium:823144 Change-Id: Ia849f44d1c8898da0fcb8341c8ff56de4de2d815 Reviewed-on: https://chromium-review.googlesource.com/c/1292560 Commit-Queue: Jonas Olsson <jonasolsson@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#610603}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4ed4737007d8..43e8ebcaf284 git log 4ed4737007d8..43e8ebcaf284 --date=short --no-merges --format='%ad %ae %s' 2018-11-23 perezju@chromium.org [soundwave] Use /timeseries2 to fetch data on -i option 2018-11-23 perezju@chromium.org [soundwave] On finalization terminate pool, don't close. Created with: gclient setdep -r src/third_party/catapult@43e8ebcaf284 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:900218,chromium:907885 TBR=sullivan@chromium.org Change-Id: Id2475cd9a73b69a2231b508deb72467107836bd6 Reviewed-on: https://chromium-review.googlesource.com/c/1349434Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610602}
-
Leszek Swirski authored
This is a reland of 7c10d9bb. We just need to add SlowTest entries for the failing tests (already done for default) Original change's description: > Revert virtual test-suite for streaming-preload. > > Causes too many timeout issues for WebKit Linux Trusty MSAN. > > This reverts the virtual suite part of [1]. > > [1] https://crrev.com/7c10d9bbc2c168bc6fd889c523ab8d7e6d48abaa > > TBR=leszeks@chromium.org > > Bug: 908060 > Change-Id: I50111b8a5dc93a29078a0e9f77feefc1a960bedd > Reviewed-on: https://chromium-review.googlesource.com/c/1349222 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Commit-Queue: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610589} TBR=leszeks@chromium.org,futhark@chromium.org Change-Id: Id7486a144dcf5a93c5c2521d36dec62bc91e34f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908060 Reviewed-on: https://chromium-review.googlesource.com/c/1349266Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#610601}
-
Greg Thompson authored
BUG=907979 Change-Id: I8922218a0488eee539a5f3814de3dee9c58e31e0 Reviewed-on: https://chromium-review.googlesource.com/c/1349339 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#610600}
-
Mathias Carlen authored
Before this patch, we used the chrome custom tab activity instead of the ChromeActivity base activity. This will prevent us to introduce Autofill Assistant other flavors than CCT. This patch reverts to ChromeActivity. The one caveat is that CCT's finish() does a little more cleanup compared to ChromeActivity, but the behavior for the cases we tested is the same. Bug: 806868 Change-Id: I77e99419738f41f0dbaaa5cbb3bb0f64f8c9a37c Reviewed-on: https://chromium-review.googlesource.com/c/1348114 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#610599}
-
Lukasz Suder authored
Comparing just title is fragile (e.g. different languages), therefore we allow specifing the mid inside parameters. Bug: 806868 Change-Id: Ie5790beb6cb06bc4c124ae7a969c2263a77fc2cf Reviewed-on: https://chromium-review.googlesource.com/c/1349335 Commit-Queue: Lukasz Suder <lsuder@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#610598}
-
Dave Tapuska authored
maxActions is defined in the IDL as a 32 bit integer, return it as such. BUG=879657 Change-Id: If389a010dc5b098095b95674ef017742e787da52 Reviewed-on: https://chromium-review.googlesource.com/c/1348867Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#610597}
-
Nikita Podguzov authored
Add support for External Data referenced by Device Policy. Use the new support to implement the DeviceNativePrinters policy. Add browser test verifying external data cache is cleaned up after policy was changed or removed. Bug: 807068 Change-Id: Ib98778a438e929a78214d1d9ab066a41a6bdcf09 Reviewed-on: https://chromium-review.googlesource.com/c/1335592 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#610596}
-
Ross McIlroy authored
BUG=v8:7290,v8:8238 Change-Id: I4e44d97dfde85b471ed4e6b38f4e32374462de95 Reviewed-on: https://chromium-review.googlesource.com/c/1349342Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#610595}
-
Daniel Bratell authored
In some (non default) jumbo configurations, strike.cc and legacy_strike_database.cc compile in the same translation unit and then some constants clash. Assuming LegacyStrikeDatabase will soon go away, just give its constants a bit longer names. Bug: 884817 Change-Id: I1dc6d8b6499d3c6195a56423236198a02c32f3f0 Reviewed-on: https://chromium-review.googlesource.com/c/1348471 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#610594}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5f2ffeec22d1..b357e54dd5b2 git log 5f2ffeec22d1..b357e54dd5b2 --date=short --no-merges --format='%ad %ae %s' 2018-11-23 crodbro@webrtc.org Add field trial config to disable pacer emergency stops. 2018-11-23 nisse@webrtc.org Delete unused method NetEq::PacketBufferStatistics Created with: gclient setdep -r src/third_party/webrtc@b357e54dd5b2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ieeed6f4e6266cbd13ef650aa146a743beabb6046 Reviewed-on: https://chromium-review.googlesource.com/c/1349433Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610593}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e92c674abcb9..246e02474676 git log e92c674abcb9..246e02474676 --date=short --no-merges --format='%ad %ae %s' 2018-11-23 treehugger-gerrit@google.com Merge "Fix GCC build" 2018-11-23 hjd@google.com traced_probes: Fixes to run_ftrace_proto_gen Created with: gclient setdep -r src/third_party/perfetto@246e02474676 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia46ab0bde1ef9122bedda8a9effda21411511877 Reviewed-on: https://chromium-review.googlesource.com/c/1349432Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610592}
-
Marc Treib authored
https://crrev.com/c/1343087 rewrote that function, and inadvertently removed a null check that turns out to actually be necessary. Bug: 908055 Change-Id: Ibaaa6fc27cebb4c1af0f03661ee143ef468f59ae Reviewed-on: https://chromium-review.googlesource.com/c/1349220 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#610591}
-