- 21 Oct, 2019 40 commits
-
-
Corentin Wallez authored
libdawn is deprecated and was split in libdawn_proc and dawncpp so each could be used separately. Make Chromium use the split targets so the temporary libdawn group used for backwards compatibility can be removed. BUG=dawn:22 Change-Id: I2db79b5b14c12b10111bd03bf66ca2692c07c200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869209Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#707937}
-
Philip Rogers authored
In crbug.com/1012775 we are unifying how trivial 3d transforms are handled across platforms by making them not a compositing hint. This caused performance regressions in tough_animation_cases, tough_canvas_cases, and tough_scrolling_cases which were using trivial 3d transforms as a compositing hint. This patch updates these tests to be more explicit about layer triggers by using "will-change: transform". Bug: 1012775, 1016320 Change-Id: Ia2978b867e439bbffa173da747cda7ecd5a9f2bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872743 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#707936}
-
Philip Rogers authored
The DoNotCompositeTrivial3D flag has changed many performance tests (e.g., twitter, see crbug.com/1016343). To reduce the chances of breaking real sites, I would like to switch to rolling this out via a (forward) finch experiment. This patch switches the flag to be disabled-by-default, and I will enable this via finch. TBR=chrishtr Bug: 1012775 Change-Id: Ifc9cf670fb95b48995a5072f95eea1e3c570c063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872659Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
-
Dave Tapuska authored
Remove FrameHostMsg_DidContainInsecureFormAction and FrameHostMsg_DidDisplayInsecureContent legacy IPC messages and replace them we new mojo APIs on the LocalFrameHost interface. BUG=1008432 Change-Id: I84258d4175466f89c0a288196a75889ffddd102d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872452Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#707934}
-
Eric Willigers authored
Bookmark apps are no longer created in views tests using extensions-specific code. Bug: 966290 Change-Id: I9596d498421d6d5d180861bad2969d369f159cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865741Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#707933}
-
Francois Doray authored
Failure log https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8904107524722548848/+/steps/browser_tests__with_patch_/0/logs/Flaky_failure:_TabManagerTest.TabManagerBasics__status_CRASH_SUCCESS_/0 shows error when navigating to WebUI pages. Since the test doesn't depend on navigating to a WebUI, this CL changes it to navigate to a simple test page. Bug: 997719 Change-Id: Ifcc53fb9d4df5f144e99c2e9c9eaf41614778c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869480Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#707932}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I3ad81b16a00a8226641458a793618302ae90e31e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872748Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707931}
-
Francois Doray authored
These histograms will be used to assess the impact of fully launching tab freezing in M81. Bug: 986508, 986510 Change-Id: Iaed38a46e755d231872355d0a866c0c09bdff499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872291 Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#707930}
-
Ella Ge authored
The test was flaky with RunLoopFor. Make the test_environment use MOCK_TIME and FastForward. Bug: 992784 Change-Id: Ie54cf62078fc994b68d921692ddbc672581dddf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869395Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Miriam Zimmerman authored
Previously, https://crrev.com/c/1863363 changed the describedby tag so that "File will be sent to google for debugging" is read along with the upload selector. However, with that change, the text is also read when a screen reader navigates to the next item. Mark the label as hidden, so screen readers skip it when navigating. (But not when reading the description of the "Choose File" button.) TEST=Load onto an eve, navigate with screen reader. BUG=chromium:1005528 Change-Id: If693cdc2f5cd434d5d4def7a1482399fd108d2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869560 Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Cr-Commit-Position: refs/heads/master@{#707928}
-
Elly Fong-Jones authored
The flag 'unsafely-treat-insecure-origin-as-secure' was being used in this test to test the behavior of ORIGIN_LIST_VALUE_TYPE flags; that made it impossible for that flag to expire or be removed without breaking the test. This change: 1) Introduces about_flags::testing::SetFeatureEntries() to override the flags list for testing purposes 2) Has AboutFlagsBrowserTest use it to set the flag set to a single test flag. As a side-effect, this hugely speeds up this test suite since the page now contains far less data. 3) Undoes a bit of confusion in the tests: they treated "switch" and "flag" as synonyms throughout, which is not correct. A followup change will fix https://crbug.com/1010678 and re-enable these tests on the bots. Bug: 1010678 Change-Id: I91f39fb8b3e000a824d8cf85fd3daa51d9a247af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872318 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#707927}
-
Ken Rockot authored
This removes util.cc/h from the leveldb service's client library. This is the last bit of remaining code from the service apart from LevelDBDatabaseImpl itself, which will be simplified and moved into the Storage Service as a wrapper around DomStorageDatabase. The utility functions here are used almost exclusively in tests, and are all trivial. In many cases their use can be eliminated by proving the surrounding APIs (e.g. taking spans instead of vectors, or introducing a more robust key/value type) or by inlining direct use of base and STL APIs which essentially solve the same problems. For now, their definitions have been duplicated in the few places they are used. Bug: 1000959 Change-Id: I568ac5d829b643d332783faddffa2bc63685e211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868847Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#707926}
-
Tommy Li authored
This CL makes the Remove Suggestion button only appear on hover. It also prohibits showing the Remove Suggestion button when the Tab Switch button is visible. I did this because it insert the X on the far-right on-hover, since it shifts the Tab Switch button. Additionally, it seems like if the user has the tab open, it's not important to offer to delete that suggestion. The user is still clearly interested in that content. Bug: 1014788, 929477, 1205 Change-Id: I49684914e94ce5d6e884597c3d3b0bb612c5ebfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869555Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#707925}
-
Brian Sheedy authored
Temporarily switches the GPU Win10 Intel experimental builder to trigger tests on the stable driver version so that the existing bots with the older experimental driver can be upgraded to the newer version without a loss of capacity. TBR=kbr@chromium.org Bug: 1016459 Change-Id: Ie50166147eadb89a7b4f970ddd21cbd9b5a4e7ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872742Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Ken MacKay authored
Change-Id: I3d09f627e3e3e808ecf5a288c39d048bf3a34852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872128Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#707923}
-
Elly Fong-Jones authored
This layer of delegation originally existed to allow for both Cocoa and Views versions of this dialog to share logic. Since the Cocoa versions are now gone, the remaining logic can be folded into the Views versions. This change: 1) Adds ExternalProtocolHandler::Delegate::OnSetBlockState, to allow tests to listen directly for block state changes; 2) Folds the body of ExternalProtocolDialogDelegate into ExternalProtocolDialog; 3) Removes ProtocolDialog (interface only) and ExternalProtocolDialog (interface & implementation) 4) Reworks the ExternalProtocolDialogDelegate browser tests to test "one layer up" - instead of using a test delegate for the dialog, they use the normal production behavior of the dialog, but hook into the ExternalProtocolHandler system at the ExternalProtocolHandler::Delegate layer. This provides better fidelity to the production behavior in the test and simplifies the tests considerably. Next steps here: As the ongoing DialogDelegate refactor proceeds (see https://crbug.com/1011446), ExternalProtocolDialog will shrink further until it contains only Accept and Cancel. Bug: None Change-Id: I90518f8086db4127d41776ad086210c6db9d7462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872411 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#707922}
-
Ella Ge authored
This CL marks InputEventPrediction.Accuracy metrics obsolete and also removes related code. The Accuracy.Scroll.* metrics is replaced by new prediction metrics introduced in crrev.com/c/1764409 Mouse* and Touch* are lack of use now so they are safe to remove. Similar new metrics will be add for Mouse/Touch too. Bug: 988625 Change-Id: Ic86de9e27c370f7ea5f6b01880b899ff11fd6867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849093 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
-
Adrienne Walker authored
In http://crbug.com/957175, wanderview@ added an optimization for BlobReader where it would add an extra hop when finishing a stream. Many blobs size mojo::DataPipe to exactly fit the blob size, and so this can be quite common. As SourceStreamToDataPipe is going to be used in this CL (https://chromium-review.googlesource.com/c/chromium/src/+/1830360), that optimization needs to be carried forward. Bug: 1012869,957175 Change-Id: I9f7fc006b633a248fe3b726ac78d1fe4773472a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862253Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#707920}
-
John Lee authored
Bug: 989131 Change-Id: I2245020cc33911dfba7e1bc1942168c3321b5e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869338 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#707919}
-
Maksim Orlovich authored
This reverts commit a88c5fe6. Reason for reland: The test was/is flaky on that bot in the first place, the name change just makes it look different. Original change's description: > Revert "Adjust tests for upcoming cross-site cookie requirements" > > This reverts commit 83b71438. > > Reason for revert: SitePerProcessSSLBrowserTest.UnloadHandlersArePowerful* > failing on Android. Please see bug. > > Bug: 1014956 > Original change's description: > > Adjust tests for upcoming cross-site cookie requirements > > > > They will need to be marked explicitly and secure, so adjust some tests to > > be over SSL and mark those cookies appropriately > > > > Bug: 1006816 > > Change-Id: I6da53ea64a7c03530335913fadb9099992e8ca33 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863389 > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Commit-Queue: Maksim Orlovich <morlovich@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#706108} > > TBR=avi@chromium.org,morlovich@chromium.org > > Change-Id: I982bc1590171f92883000c8315d3be77f7b35b9f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1006816 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865249 > Reviewed-by: Parastoo Geranmayeh <parastoog@google.com> > Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> > Cr-Commit-Position: refs/heads/master@{#706453} TBR=avi@chromium.org,parastoog@google.com,morlovich@chromium.org Change-Id: I51c863c89ade36edddc4b1b7a3f16d82c9f855f3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1014956, 1006816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866614Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#707918}
-
Sam Goto authored
Per instructions on the Unido design doc [1], this is the first step in the process of creating a new Unido feature: 1) Add a new SharingMessage to the proto and update metrics mapping 2) Add your new SharingFCMHandler in SharingService constructor 3) Add a new feature in DeviceInfoSpecifics.EnabledFeatures 4) Add your enabled feature to SharingDeviceRegistration 5) Use SharingService to list device candidates, and use the new SendMessageToDevice to send messages Steps (2-5) will follow in separate CLs, to ease reviewing and ease other features tracking how to integrate. [1] https://docs.google.com/document/d/1tvrKCEOaQuZv_j6j61ij_r9sjFlI25x8M8rIRL1DTsA/edit# Design Doc: https://docs.google.com/document/d/1da8CjO71DlFbBzDcSosFRXTvDsKII_XMCohpZLQ_QbM/edit?userstoinvite=himanshujaju%40google.com&ts=5da89bb1&actionButton=1 Bug: 1015645 Change-Id: If41831a2e71ec88b4771c739be18fd17c18ac6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867444 Auto-Submit: Sam Goto <goto@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#707917}
-
Harald Alvestrand authored
Spec: https://w3c.github.io/webrtc-svc/ Intent to implement: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/--ZpYlTo6LE/h0RzUIWkAAAJ Chrome dashboard: https://www.chromestatus.com/feature/5769626174619648 Bug: 986069 Change-Id: Ia8f2cb90ec26eb83528f0f45acbc5ccbdf2ad030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868989Reviewed-by:
Florent Castelli <orphis@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#707916}
-
Shawn Gallea authored
This allows custom implementations that can share base functionality. This is needed since instances must be created to control both web views and cast apps. Bug: b/136460199 Test: Compile cast_shell Change-Id: Id19507b3127f4bd2071e02f4b2cd4ec931c7ea71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872466Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#707915}
-
Ella Ge authored
This reverts commit 3692f7b0. Reason for revert: compile failure https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-dbg/1638 Original change's description: > [web_engine] Add "web_engine_shell" standalone executable. > > Implements a simple standalone executable which will launch a fullscreen > browsing session and navigate it to a given URL. Similar to > content_shell, but using Web Engine instead. > > The flow is kept deliberately simple and linear so it can serve as a > functioning code sample for aspiring embedders of Web Engine. > > The shell can be used to test arbitrary static data, which is sourced > from //fuchsia/engine/test/shell_data and hosted under the content URL > fuchsia-dir://shell-data/ . > > The shell can also optionally request that the DevTools server be > started at a port specified on the command line. > > Bug: 1016485 > Change-Id: I09ad56f20553acc83fbf38924fa3e8d8a98a1200 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869887 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: David Dorwin <ddorwin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707911} TBR=ddorwin@chromium.org,kmarshall@chromium.org Change-Id: Ib38a55b43411e01d49fffdf92f268fdf3c4db187 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1016485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872719Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#707914}
-
Philip Rogers authored
In crbug.com/1012775 we are unifying how trivial 3d transforms are handled across platforms by making them not a compositing hint. This caused performance regressions on tough_compositor_cases which were using trivial 3d transforms as a compositing hint. This patch updates tough_compositor_cases to be more explicit about layer triggers by using "will-change: transform". Bug: 1012775, 1016320 Change-Id: I1734e885ec287d1ca608f7a70674b8b0f74b6b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872177 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
-
Clark DuVall authored
This is a reland of 18c60acc This should not be flaky anymore after http://crrev.com/c/1869849 Original change's description: > [WebLayer] Implement executeScript() on BrowserController > > This adds a way to execute javascript in WebLayer. The script will be > executed in a weblayer isolate that will not be able to access any > scripts from the page. > > Change-Id: Ia17bd8476b5d9247d5761f0af24cd4d61edaccb2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867300 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707455} TBR=sky@chromium.org Change-Id: I6b1e1763b0a89345a5d0b96d2f42170978343695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872658Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#707912}
-
Kevin Marshall authored
Implements a simple standalone executable which will launch a fullscreen browsing session and navigate it to a given URL. Similar to content_shell, but using Web Engine instead. The flow is kept deliberately simple and linear so it can serve as a functioning code sample for aspiring embedders of Web Engine. The shell can be used to test arbitrary static data, which is sourced from //fuchsia/engine/test/shell_data and hosted under the content URL fuchsia-dir://shell-data/ . The shell can also optionally request that the DevTools server be started at a port specified on the command line. Bug: 1016485 Change-Id: I09ad56f20553acc83fbf38924fa3e8d8a98a1200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869887 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707911}
-
Nick Burris authored
The 99th percentile of TouchpadPinch latency exceeds the 100ms max. This patch updates to TouchpadPinch2 with a max of 1 second, or 1000ms. Change-Id: I58bcc7fd8ee441043bdb0482f15e58c70368f954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834679Reviewed-by:
-
Evan Stade authored
Use ProfileManagerObserver::OnProfileAdded instead. Also worth noting that this removes an obsolete superclass from UserCloudPolicyManagerChromeOS, i.e. KeyedService. Both KeyedService and ConfigurationPolicyProvider have a "virtual void Shutdown()" so this removes that collision (not that it was doing any harm). Bug: 268984,171406 Change-Id: Ia0b3dd4dd34a0f62e84dd057928d61c5677231d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854525 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#707909}
-
Aran Gilman authored
Bug: 952034 Change-Id: I6debbcb4e8474cacdcd8b5add471a9c04c0a4dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853862 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#707908}
-
Ryan Sturm authored
When a navigation to the wrong URL begins, the prerender in NavigationPredictor should be stopped, and no new prerenders should begin. Due to mojo magic, it is hard to stop the case of a navigation starting followed by load event finishing followed by commit. As such, that case will still begin a prerender, but it should be relatively rare. Bug: 1016212 Change-Id: I1e406c877dd7c8d73d8d29efdbcfc2bde35bbdc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872744Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#707907}
-
Jonathan Backer authored
Change-Id: Ie1d9dadc454b36fdd4bf1c3f07e336fd49536f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872739Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#707906}
-
Justin Cohen authored
crrev.com/c/1863950 introduced a visibility check, that causes multitasking tests to fail. Since the goal of 1863950 was to migrate to EG2 and keep the tests the same, removing visibility check here. Bug: 1016283 TBR: eugenebut@chromium.org Change-Id: I45e7fff55fce5fd987dc712931809bad442bf164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872565 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#707905}
-
Olga Gerchikov authored
The original CL caused flakiness of /virtual/threaded/animations/animationworklet* tests (crbug.com/1014966). The reason for the flakiness is change in timing of main thread effect local time update. Reverted CL: https://chromium-review.googlesource.com/c/chromium/src/+/1826872 The reverted CL is in Patchset 1. Patchset 2 fixes the tests by explicitly waiting for the effects to change. This CL changes how local time of composited worklet animations is updated on main thread: instead of polling local time on main thread, the local time is posted via animation events by the composited thread to the main thread. Design document: https://docs.google.com/document/d/1vUxaKBLDHQv9ACJUQJH4RXjuQTlWIsSiAFYkMrjccyc/edit?usp=sharing Changes made: - Expanded AnimationEvent to support worklet animation time update event type. - Reused existing mechanism of posting animation events to the main thread to support new event type. - Removed "peek" logic. - Enabled tests that previously failed. Bug: 943787 Change-Id: I9a2965f204cad15b405be82305c38788c0eafd62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864518Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/master@{#707904}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1d2ab0dfbb1b..d578b2973f62 git log 1d2ab0dfbb1b..d578b2973f62 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 chrome-bot@chromium.org Update config settings by config-updater. 2019-10-21 shaochuan@chromium.org Make betty-pi-arc-release non-experimental Created with: gclient setdep -r src/third_party/chromite@d578b2973f62 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I0d6bc00b0fd0565be50a6808d2d6cefc3b972f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872238Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/72cc71cd70d4..eef5e4ffc239 git log 72cc71cd70d4..eef5e4ffc239 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 mbonadei@webrtc.org Remove dep between test:test_support and rtc_base_approved. 2019-10-21 ssilkin@webrtc.org Reset end-of-frame flag in non-VCL packet. 2019-10-21 danilchap@webrtc.org Avoid DEPRECATED_SingleThreadedTaskQueueForTesting::CancelTask in VideoAnalyzer 2019-10-21 danilchap@webrtc.org Clarify NetworkControl interface: result of each function must be used 2019-10-21 danilchap@webrtc.org Update call Rampup tests not to rely on DEPRECATED_SingleThreadedTaskQueueForTesting 2019-10-21 jakobi@webrtc.org Change failing rtc::dchecked_cast to rtc::saturated_cast. Created with: gclient setdep -r src/third_party/webrtc@eef5e4ffc239 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:999807,chromium:None,chromium:1016147 Change-Id: I2ef7e4c518655482bcfca9b90757a353c3c8baa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872235Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/63aaa927a3c7..e5b6f3adef16 Created with: gclient setdep -r src-internal@e5b6f3adef16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I577532fb8f460aefc0ddaf948068c7f1fbdff2d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872122Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707901}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4a80ba25e67b..f228038ddeb4 git log 4a80ba25e67b..f228038ddeb4 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 courtneygo@google.com Treat Pixel 2 XL and Pixel 2 the same Created with: gclient setdep -r src/third_party/angle@f228038ddeb4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I2e7b544d2a6602264d9c22625ed57e5f4aeeb05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872123Reviewed-by:
-
Ben Mason authored
This reverts commit 55a4bb68. Reason for revert: Causing crashes - crbug.com/1016233 Original change's description: > Kill quiet permission requests if a new request is made > > Bug: 1014026 > Change-Id: I5fe93b9bc7b39873900d9e15dcba66dfddd7c4ef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860015 > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706445} TBR=engedy@chromium.org,andypaicu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1014026 Change-Id: I4e0f0120e3f7d2b9711d122bb186012c5d06464d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871632Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#707899}
-
Hwanseung Lee authored
Use enum class instead of enum for ShadowType enum class is more type safety. Bug: 940736 Change-Id: Ib816aa59a3b1ad67738050a1b9d5fd00b7140482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868535 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#707898}
-
