- 15 Sep, 2017 40 commits
-
-
tzik authored
PassRefPtr is now an alias of RefPtr. This CL inlines the alias to the users in platform/{a,b,e}* for PassRefPtr removal. Bug: 494719 Change-Id: I852aaf96ebef5ca5bf84f4aee0aafae01982e3c9 Reviewed-on: https://chromium-review.googlesource.com/668301Reviewed-by:Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#502193}
-
Kent Tamura authored
bindings: Support snake_case file names for #includes in callback interfaces and V8ContextSnapshotExternalReferences.cpp Bug: 760462 Change-Id: Ic51f698517d8445def957d002edbe9aa1fbe6f05 Reviewed-on: https://chromium-review.googlesource.com/668303Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#502192}
-
Tetsui Ohkubo authored
In new style notification, system notifications have different style from other notifications such as web notifications. * The context header shows the title "Chrome OS system". * The context header has accent color, depending on severity of the notification. * New material design icon is used. TEST=manual BUG=751024 Change-Id: I36d2c5d43bf85b0f91828b48918f3066cf0b6eb3 Reviewed-on: https://chromium-review.googlesource.com/658014 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#502191}
-
Xianzhu Wang authored
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I06e3f03ffff0b071bb7446aaf7d0e17dbb75edb0 Reviewed-on: https://chromium-review.googlesource.com/668021 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#502190}
-
Matt Falkenhagen authored
Revert the following due to crashes. Revert "Remove the unused wait-forever-in-install-worker.js" This reverts commit 10503e57. Revert "Pass the WPT: register-wait-forever-in-install-worker.https.html" This reverts commit ddf5acab. Bug: 761251, 723037 Change-Id: I72235453c9465df48f637f293f3e3a122a79b567 Reviewed-on: https://chromium-review.googlesource.com/668260Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#502189}
-
Mattias Nissler authored
The metric checkbox on the EULA page and the TPM firmware update checkbox on the Powerwash page didn't allow toggling the checkbox by clicking on the label as the label wasn't attached to the checkbox. Fix that by nesting the label in the checkbox element. While at it, switch a few element IDs to CamelCase for consistency. BUG=chromium:763470 TEST=Manual Change-Id: If0905aa132052e6c1cc99a65bfb86ed5a0a2c729 Reviewed-on: https://chromium-review.googlesource.com/666964Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#502188}
-
Daniel Cheng authored
Bug: 706466 Change-Id: I29a7fde7dcca0bf7dcfe6c9a9733e0b51dbfa7cc Reviewed-on: https://chromium-review.googlesource.com/668148Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#502187}
-
Yuki Yamada authored
This CL adds ServiceWorker.stopAllWorkers() to devtools protocol for stopping all service workers before running perf benchmark for PWA. Design doc of perf benchmark for PWA: https://docs.google.com/document/d/1Nf97CVp1X7aSqvAspyJ7yOCDyr1osUNrnfrGwZ_Yuuo/edit?usp=sharing Bug: 736697 Change-Id: I4286b6a79dbfd29c28437145ef870fca352cce1c Reviewed-on: https://chromium-review.googlesource.com/635105 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#502186}
-
tzik authored
PassRefPtr is now an alias of RefPtr. This CL inlines the alias to the users in modules/websockets for PassRefPtr removal. Bug: 494719 Change-Id: I1710f2fb7029d7645f2d6e0ec43f6ff5676e6a82 Reviewed-on: https://chromium-review.googlesource.com/666953 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Mike West authored
FTP accounts for something approaching ~0.0026% of navigations in the last month (across ~0.063% of users in the last ~week). Since the protocol is even less secure than HTTP (as it has no headers, and therefore no way of expressing any security stance whatsoever), it seems reasonable to treat it in the same way as we'd eventually like to treat HTTP. Given its low usage, it seems like we could be more aggressive about this mode of transport with regard to timelines. PSA: https://groups.google.com/a/chromium.org/d/msg/security-dev/HknIAQwMoWo/xYyezYV5AAAJ Bug: 744481 Change-Id: Icef02d00e9a0a5dba8bf3db8b6dc42d04b596d15 Reviewed-on: https://chromium-review.googlesource.com/574024Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#502184}
-
tzik authored
PassRefPtr is now an alias of RefPtr. This CL inlines the alias to the users in platform/graphics for PassRefPtr removal. Bug: 494719 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2b8560ccd6b8ff2d753cb4b692b0cce3e5b0f19f Reviewed-on: https://chromium-review.googlesource.com/668299Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#502183}
-
Kent Tamura authored
Partial interfaces had an implicit rule that an IDL file name was used to find a static-only C++ class name implementing the interface. It won't work if we rename IDL files to snake_case because C++ class names are still CamelCase. In general IDL filename should not affect generated code. However IDL content has no information about implementation C++ class in this case. So we need to specify ImplementedAs. Bug: 760462 Change-Id: I791b73bbaf6605e4b87732ba3ce8163d1fdab2b1 Reviewed-on: https://chromium-review.googlesource.com/666948 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/69fe7110e6af..12abfd04a42a $ git log 69fe7110e..12abfd04a --date=short --no-merges --format='%ad %ae %s' 2017-09-15 vmiklos Add public method FPDFPath_CountPoint to get # of points of a path object. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I3f5d44cc73794976b2b8a42dc238c72ba14fe3fb Reviewed-on: https://chromium-review.googlesource.com/668168 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502181}
-
Tetsui Ohkubo authored
This CL replaces expand / collapse arrow assets used for new style notification. Previous assets had extra margins in the .icon. Before: http://screen/oD8vsdcpJ8K (with ARC notification) After: http://screen/VP85Jcg953H TEST=manual BUG=764006 Change-Id: Icb0b6278a040a8fa8d3c2a0b55bb953be07dd7b8 Reviewed-on: https://chromium-review.googlesource.com/663112Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#502180}
-
tzik authored
PassRefPtr is now an alias of RefPtr. This CL inlines the alias to the users in core/ for PassRefPtr removal. Bug: 494719 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic0533642caef455ad6f683907262e0836ca5d3b4 Reviewed-on: https://chromium-review.googlesource.com/668264Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#502179}
-
Ramin Halavati authored
A function added to return a dummy network traffic annotation, for unreachable cases that the compilers or tests require an annotation. Bug: 656607 Change-Id: Ia460f0effec6c64543e411ba6a5e10fb72b380cb Reviewed-on: https://chromium-review.googlesource.com/666818Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
-
Michael McGreevy authored
This reverts commit 05b21c67. Reason for revert: This is causing crashes; see crbug/763891. The crash implies that AppBannerManagerAndroid::ShowBannerUi() is being called without a preceding call to AppBannerManager::RequestAppBanner() or after a call to AppBannerManager::Stop(). Perhaps Stop is being called due to the webcontents being destroyed, and ShowBannerUi is being called after that. I'm not sure whether this is plausible. Reverting until I understand this better. Original change's description: > Replace AppBannerManager::need_to_log_status_ with StatusReporter. > > AppBannerManager treats need_to_log_status_ differently (in both > RequestAppBanner and ReportStatus) depending on the return value of > IsDebugMode(). This makes it harder to reason about the valid states for > need_to_log_status_. This CL replaces need_to_log_status_ with a > StatusReporter, which has an implemenation that is decided by consulting > IsDebugMode() once in RequestAppBanner. > > Change-Id: I862fd76c9732cfcda0d5bf787a51161ef4fbfb66 > Reviewed-on: https://chromium-review.googlesource.com/630898 > Commit-Queue: Michael McGreevy <mcgreevy@chromium.org> > Reviewed-by: Ben Wells <benwells@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500199} TBR=benwells@chromium.org,mcgreevy@chromium.org Bug: 763891 Change-Id: Ia5a3dc666a2c27535aacc1abf2ea46f71c9eb94b Reviewed-on: https://chromium-review.googlesource.com/665639Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Michael McGreevy <mcgreevy@chromium.org> Cr-Commit-Position: refs/heads/master@{#502177}
-
Kouhei Ueno authored
This CL implements ReferrerScriptInfo, which holds a copy of "referencing script" info, referenced in the "HostImportModuleDynamically" algorithm: https://github.com/tc39/proposal-dynamic-import/blob/master/HTML%20Integration.md#hostimportmoduledynamicallyreferencingscriptormodule-specifier-promisecapability This info can be encoded into v8::Local<v8::PrimitiveArray> and will be attached to v8::ScriptOrigin in future CLs. Dynamic import resolver will extract this from the ScriptOrigin of the referencing script in its implementation of "HostImportModuleDynamically" algorithm. Bug: 711706 Change-Id: I0649b6f0334154cdde910a657eee449b39f5f9c7 Reviewed-on: https://chromium-review.googlesource.com/668257Reviewed-by:
-
Kent Tamura authored
We renamed RuntiemEnabledFeatures.json5 to runtime_enabled_featurs.json5. This CL updates references to it in comments and documents. Change-Id: I51bd48b6c48ed0e017c53aca9e77971707877269 Reviewed-on: https://chromium-review.googlesource.com/666938Reviewed-by:
-
Ramya Sharma authored
Before: https://screenshot.googleplex.com/08k1Gy6JD2x.png After: https://screenshot.googleplex.com/xT7jEZEz6xQ.png Bug: 695749 Change-Id: I982db141b96a754e529d4476b8a0bcba224d2097 Reviewed-on: https://chromium-review.googlesource.com/666947 Commit-Queue: Ramya Sharma <ramyasharma@chromium.org> Reviewed-by:
Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/heads/master@{#502174}
-
tzik authored
PassRefPtr is now an alias of RefPtr. This CL inlines the alias to the users in modules/webaudio/ for PassRefPtr removal. Bug: 494719 Change-Id: I7633a98ebef4522eaa8c9c670b40b3d088ff88f3 Reviewed-on: https://chromium-review.googlesource.com/666949Reviewed-by:
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/00375ce4c98d..832e31f0e448 $ git log 00375ce4c..832e31f0e --date=short --no-merges --format='%ad %ae %s' 2017-09-15 angle-deps-roller Roll skia/third_party/externals/angle2/ 32b7e2379..71c88b31d (1 commit) Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I333718675c6dd7867a874906e898aa80a4a3cfdd Reviewed-on: https://chromium-review.googlesource.com/668129Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502172}
-
Klemen Kozjek authored
As of now, when we mount a zip file we maintain mounted entries through retainEntry private method and use that information to restore them upon device restart or session login. Because retainEntry method does not work under incognito mode we return an error message if retainEntry is called. Incognito mode does not retain changes made in its session and therefore we skip calls that would otherwise call retainEntry method. As a result, Zip Archiver works in incognito/guest mode. Bug: 607078 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9220eea4ed9ea8b9e873698d44cd6e167194b071 Reviewed-on: https://chromium-review.googlesource.com/663002 Commit-Queue: Klemen Kozjek <klemenko@google.com> Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Cr-Commit-Position: refs/heads/master@{#502171}
-
tzik authored
PassRefPtr is now an alias of RefPtr. This CL inlines the alias to the users in modules/{serviceworkers,compositorworker} for PassRefPtr removal. Bug: 494719 Change-Id: I872d68f5816bcdbb8eaee0cfb495c56317c2c460 Reviewed-on: https://chromium-review.googlesource.com/666950Reviewed-by:Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#502170}
-
yoshiki iguchi authored
Bug: 754307 Change-Id: I008b6ceba99e0bf125d958f2435457f137da089d Reviewed-on: https://chromium-review.googlesource.com/616622 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Cr-Commit-Position: refs/heads/master@{#502169}
-
Shanmuga Pandi M authored
Move files which are used only testing to testing/ directory. Bug: 761254 Change-Id: I731cce4f237faf000076233d541afc08987b8f87 Reviewed-on: https://chromium-review.googlesource.com/666877 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
John Wu authored
Background: We want to add features like autofill to ChromeWebView. But autofill depends on sync, and we don't want to include sync by default because not all clients can sign in to sync. Bug: Change-Id: I3f27ce4d12ff90238f69712da5bab5ee53a89d3a Reviewed-on: https://chromium-review.googlesource.com/625503Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#502167}
-
Trent Apted authored
- Use GetDialogInsetsForContentType(CONTROL, CONTROL), since the dialog starts with a textfield and ends with a combobox. - Hardcode footnote view padding in BubbleDialogDelegate. - Tweak (simplify) the bookmark bubble dialog test so it can run on Mac. Bug: 726187 Change-Id: I87bf041bb9d45a679de6c54a7d5d787e0d525c2d Reviewed-on: https://chromium-review.googlesource.com/662883 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#502166}
-
Tetsui Ohkubo authored
This CL adds new material design icon to ARC notification. This CL also removes notification buttons on initial notification based on UX review (https://crbug.com/726241#c20). The icon and the accent color are effective only when chrome://flags/#enable-message-center-new-style-notification is Enabled (which is ToT default). TEST=manual BUG=726241 Change-Id: Id617ad8fa8ab42f5494cf53fd27100397a09ceee Reviewed-on: https://chromium-review.googlesource.com/662837Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#502165}
-
Tetsui Ohkubo authored
This CL adds new icon to supervised user notification. This CL also adds system notification accent color to the notification. The icon and the accent color are effective only when chrome://flags/#enable-message-center-new-style-notification is Enabled (which is ToT default). TEST=manual BUG=726241 Change-Id: Ia7b5adb96d6b9cd18ee7973003bc56f45e6381a0 Reviewed-on: https://chromium-review.googlesource.com/662998Reviewed-by:
-
tzik authored
PassRefPtr is now an alias of RefPtr. This CL inlines the alias to the user in modules/fetch for PassRefPtr removal. Bug: 494719 Change-Id: Ia3362dc3fb28648304bd628b83e4229924487138 Reviewed-on: https://chromium-review.googlesource.com/666943 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
-
Kent Tamura authored
This CL will help move_blink_source.py to qualify #includes. Bug: 578345 Change-Id: Ib19a07ea65cb1e39471760beac9e3d9a8f8289fd Reviewed-on: https://chromium-review.googlesource.com/666942 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#502162}
-
Steven Valdez authored
In the TLS 1.3 handshake, the client speaks last, so any middlebox problems around the final flight will not be captured by the per-connection Net.SSL_Connection_Error_TLS13Experiment. Add a per-request metric to capture those. Bug: Change-Id: Iab267af2aeed9d7da53ca05a089fb7ef4a288b6d Reviewed-on: https://chromium-review.googlesource.com/663578Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#502161}
-
tzik authored
This CL applies //tools/clang/base_bind_rewriters to //content/renderer. It rewrites base::Bind to base::BindOnce where the resulting base::Callback is immediately converted to base::OnceCallback, which is considered safe to use base::BindOnce. E.g.: base::PostTask(FROM_HERE, base::Bind([]{})); base::OnceClosure cb = base::Bind([]{}); are converted to: base::PostTask(FROM_HERE, base::BindOnce([]{})); base::OnceClosure cb = base::BindOnce([]{}); Change-Id: I4f9f90b68825d8da842ae538d61c14ead113a407 Reviewed-on: https://chromium-review.googlesource.com/666406Reviewed-by: -
Kurt Horimoto authored
This DialogCoordinator can be used to notify users that a feature is unimplemented rather than having no-op buttons. Bug: none Change-Id: I11cc8b7ec691cd4eccee5985800103e1b14062c1 Reviewed-on: https://chromium-review.googlesource.com/642618 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#502159}
-
tzik authored
PassRefPtr is now an alias of RefPtr. This CL inlines the alias to the user in bindings/ for PassRefPtr removal. Bug: 494719 Change-Id: Ibd5a97a47ea265bfb8c466a259a7604f27605f4c Reviewed-on: https://chromium-review.googlesource.com/667298 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/b1f9205bb1a0..69fe7110e6af $ git log b1f9205bb..69fe7110e --date=short --no-merges --format='%ad %ae %s' 2017-09-14 thestig Make static const char* arrays more const. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I3d953c5d7cf42758dd426e470db8b356b3353a05 Reviewed-on: https://chromium-review.googlesource.com/668161 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502157}
-
Chung-Sheng Wu authored
Shows information like CPU usage, Memory status, Zram status. This patch adds the implementation for the chrome://sys-internals page frontend. It gets the data from backend and then uses the LineChart library to show the data. Bug: 752002 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I41fd29135b2b40050713cf40050b95b6f7734fbf Reviewed-on: https://chromium-review.googlesource.com/659700 Commit-Queue: Zhong-sheng Wu <chungsheng@google.com> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#502156}
-
Tetsui Ohkubo authored
In new-style notification, system notification has different style from other notifications such as web notification. This CL applies the system style to screen capture notification. * The context header and action buttons have accent color. * New material design icon is added. * The title text is added. * The icon and the title are same as screen share notification. https://crrev.com/c/656782 TEST=manual BUG=751024 Change-Id: I86c55bcf5256ca9caf3663c5217bb28cc4d425ab Reviewed-on: https://chromium-review.googlesource.com/666102Reviewed-by: -
Nathan Bruer authored
This patch adds the ability to request a file as a blob and splits the other read functions to use the blob reader. R=lushnikov BUG=None Change-Id: I227b21fe5da19277ddbceedf2c69c33e1f4ef705 Reviewed-on: https://chromium-review.googlesource.com/667958 Commit-Queue: Blaise Bruer <allada@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#502154}
-
