GitLab

Skia has supported RGB8 for some time.

Bug: skia:7533
Change-Id: I69cf7f5050742ec7d074424648d220365184ef56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134664Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#756789}

For the password protection warning dialog for
saved paswords, up to three domains are shown.
The domains are retrieved from the signon_realms.
However, the signon_realms might not be eTLD+1
which means it will be empty string. To fix this,
the same url formatting should be done as the
password check to keep it consistent.

Bug: 1067401
Change-Id: I2bad2d38a936fb1aea821822087184e998128c6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133974
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756788}

https://chromium.googlesource.com/openscreen.git/+log/59b20e348f4d..9508a74c93b3

git log 59b20e348f4d..9508a74c93b3 --date=short --first-parent --format='%ad %ae %s'
2020-04-06 rwkeane@google.com Discovery: Multi Network Interface E2E Tests Cleanup

Created with:
  gclient setdep -r src/third_party/openscreen/src@9508a74c93b3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: I79a086d7b4aea88b6dd050dcce4f412309208946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137657Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756787}

Fix:
I missed one case where we look up an element with the wrong name when
the feature is enabled.

Original description:
SplitSettingsSync adds some text to the OOBE sync consent dialog.
Update test expectations to match, otherwise the test will fail when
we flip the flag.

Bug: 1067212
Test: browser_tests --enable-features=SplitSettingsSync
Change-Id: I5273f94c389f0cb4c2a6f0ac9149e9d65ec24106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136881
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756667}

TBR=xiyuan@chromium.org

Change-Id: I5273f94c389f0cb4c2a6f0ac9149e9d65ec24106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136871Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756786}

TBR=govind@chromium.org

Change-Id: I7489f975e049b53be8b7646d543336cf9fbd4dcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137655Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756785}

I cannot reproduce the error, even under ASAN. But crashing with an
illegal instruction is pretty telling and from inspection, the bug seems
pretty clear. Thanks C++.

(Patchset one is a clear revert. See diff from PS1 to PS2 for the fix.)

This reverts commit b4647037.

> Revert "webauthn: support non-standard default credProtect levels."
>
> This reverts commit 6361e1e8.
>
> Reason for revert:
> FidoGetAssertionTaskTest.TestSignSuccessWithFake in device_unittests has been failing on debug builds after this change.
> Here is the list of failing builds on the Linux Tests (dbg)(1) bot since this change:
> https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/87976
> https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/87977
> https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/87978
> https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/87979
> https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/87980
>
> Original change's description:
> > webauthn: support non-standard default credProtect levels.
> >
> > In the latest CTAP 2.1 draft, an authenticator can have a default
> > credProtect level other than one. Previously, Chromium couldn't
> > distinguish level one from not-specified thus, first, this change adds
> > that distinction.
> >
> > Then there are additional complexities because Chromium sets a default
> > credProtect level of two for discoverable credentials, but we don't want
> > to override an authenticator default of three. Therefore the credProtect
> > level for a request becomes a property that can only be resolved in the
> > context of the specific authenticator that will receive the request.
> >
> > We already have a property like this: the Android ClientDataJSON
> > extension. Thus pull these meta-level request properties into a
> > different structure so that MakeCredentialRequestHandler can craft
> > per-authenticator requests from that when needed.
> >
> > This isn't perfectly clean because the Windows API acts as an
> > authenticator, but is actually a front for many authenticators. So we
> > have to stuff |cred_protect_enforce| in the request object, despite it
> > being a meta-level property.
> >
> > BUG=1057126
> >
> > Change-Id: Id1c02d4689492d597f5f29674166b97a8e720d2f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130869
> > Reviewed-by: Martin Kreichgauer <martinkr@google.com>
> > Commit-Queue: Adam Langley <agl@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#756380}
>
> TBR=agl@chromium.org,martinkr@google.com
>
> Bug: 1057126
> Change-Id: Ibc43ae6f841115ade183aab5c4fbfd2c01e90986
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136280
> Reviewed-by: Joey Arhar <jarhar@chromium.org>
> Commit-Queue: Joey Arhar <jarhar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#756505}

Bug: 1057126
Change-Id: I2c2d275499be1c86d4456e5221d18a5848d5f05d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136482
Auto-Submit: Adam Langley <agl@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#756784}

SiteForCookies's member functions check the scheme length to
determine if the object is valid for that operation.

In an effort to centralize the logic use IsNull instead.

Change-Id: I131a946d5547d1cf944c365fabebe9a67391ae73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135899Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Steven Bingler <bingler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756783}

The new heading will allow us to provide a more direct link to the
explanation as we receive numerous reports of this misunderstanding.

Change-Id: I203b8881e05e38845f1e45c256a4c95745359660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137484Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756782}

Bug: dawn:375
Change-Id: I02ea08b1eee46001cfe8ab3b46d39b0dcf1c7d7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137751Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756781}

Indication of back gesture completion from application comes over an
asynchronous mojo callback and its return value is currently dropped
on the floor in order to avoid blocking the browser process to wait.

This cl changes the ConsumeGesture call to take a completion callback
and along with corresponding internal changes wires the return value
all the way.

Bug: internal b/149740759
Test: manual and unit tests
Change-Id: Ib2e519326e019148a64966e5e46ee9df00d40755
Merge-With: eureka-internal/382879
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132980Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Ryan Daum <rdaum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756780}

Do not define the live caption preferences and do not build the live
caption-specific files on Android. Android already has a Live Caption
feature so this feature will never be implemented on Android. Android
is sensitive to binary size so it is important not to ship this code
on Android since it will never be used there.

Bug: 1055150
Change-Id: Ibf4a7f23c96f341eabd9f9b7e607d0c04b4e7e78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135386Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Evan Liu <evliu@google.com>
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Cr-Commit-Position: refs/heads/master@{#756779}

Add IsAligned and IsPageAligned helpers to the aligned_memory file.
We need these helpers for another CL we're working on and this seems
like the best place for then.

- Add integral and pointer methods for IsAligned, which prefer
compiler builtins if available.
- Add an IsPageAligned which accepts integral or pointer types.
- Improve GetPageSize() on POSIX where it should use sysconf(_SC_PAGESIZE)
  if it's available and cache the value.


Bug:1067833

Change-Id: Ic7198873042c1ca8896b56449774dbf585d3a944
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136466
Commit-Queue: Brian Geffon <bgeffon@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756778}

Use it in WebLayer so that its download notifications match Chrome. Also remove DownloadUtils.getStatusString which was unused.

Bug: 1025603
Change-Id: I09d3ff636a750ad32188f8e0c4dddbb84448a7ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136891Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756777}

Animated doodles show a static preview image first and an animated image
(e.g. a gif) on click. Clicking the animation of an animated doodle or
the image of a simple doodle opens a doodle-associated URL in a new
tab/window.

To support displaying the animated image (which is external content) this
CL redefines the chrome-untrusted://new-tab-page/image?<url> helper that
now behaves like an img tag. The previous
chrome-untrusted://new-tab-page/image?<url> moved to
chrome-untrusted://new-tab-page/background_image?<url>.

Bug: 1039910
Change-Id: I57a6e0ca07271e5b9a055791a545d031d8694dc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134695Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756776}

This reverts commit 117ea7fd.

Reason for revert: crbug.com/1067845

Original change's description:
> [CompositeAfterPaint] Allow non-atomic effects in multicol
> 
> This is not fully correct, but we have to accept it in our current
> multicol painting based on FragmentClips.
> 
> Actually we have already allowed non-atomic effects in multicol within
> composited layers since SlimmingPaintV175. A fragmented element with
> effect applies the effect on each fragment separately. We have to do
> this because each fragment has its own fragment clip, and its own paint
> properties because they may depend on the fragment clip.
> 
> This CL enables non-atomic composited effects for CompositeAfterPaint.
> This is not an issue in pre-CompositeAfterPaint which doesn't allow
> fragmentation of composited layers (which is incorrect).
> 
> The root issue will be fully fixed by LayoutNG block fragmentation
> which doesn't need FragmentClips.
> 
> Bug: 1064341
> Change-Id: Id6ae4c263381f24d037f3c2bc493d73cd050598e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124340
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#754166}

TBR=wangxianzhu@chromium.org,pdr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1064341,1067845
Change-Id: I14da5cd66b644c39404446be61fc16a02dabe6f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135834Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756775}

This CL:
- Deletes WebApkActivity
- Removes references to WebApkActivity in code comments

BUG=1059580

Change-Id: Ibdc1042dc2058eb932d4c8c4c5d48a6ab8bd067a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128378
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756774}

This CL tentatively fixes the canvas-drawimage-live-video.html test
flakiness. It uses uses video.requestAnimationFrame to makes sure we
have new videos frames before drawing them, and making sure that the two
drawn images are different.

Bug: 816914
Change-Id: I430bedcd4089321eaafe76c10d808820c7726755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136204
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756773}

For some reason [dir=rtl] :-webkit-any(#realbox-icon, .match-icon) is
less specific than#realbox-icon in RTL preventing the former CSS rule
from applying to the #realbox-icon 

Bug: 1067503
Change-Id: I4b6c86429ca6714b37b40ce5cb745641e0c30830
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134649
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756772}

Change-Id: I27698aa13afe8a065acd8eaf5a89ac6dea762aa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136467Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756771}

This reverts commit 5d12d84a.

Reason for revert: crbug.com/1068275. This CL may cause EulaOfflineTest.LoadOffline failure on ChromeOS.
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/4659

Original change's description:
> Make chrome://terms on Chrome OS same as on desktops
> 
> To show "Google Chrome and Chrome OS Additional Terms of Service"
> 
> Bug: 1058348
> Change-Id: I1b37825fe6970bbc7cc59f0c1b26041e350c8fa4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132419
> Reviewed-by: Alexander Alekseev <alemate@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#756677}

TBR=alemate@chromium.org,rsorokin@chromium.org,tedchoc@chromium.org

Change-Id: I9a35ef08a8aa9d86121327eac74ac65a00a7c29a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1058348, 1068275
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136431Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756770}

https://chromium.googlesource.com/catapult.git/+log/1be7dc68558a..504782cdbabf

git log 1be7dc68558a..504782cdbabf --date=short --first-parent --format='%ad %ae %s'
2020-04-06 dproy@chromium.org [trace-viewer] Speed up rendering

Created with:
  gclient setdep -r src/third_party/catapult@504782cdbabf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC nuskos@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1036492
Tbr: nuskos@google.com
Change-Id: Ic48d29012a29e283a0fa5f50aeb00d66b4bf67db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137558Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756769}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I5c29c27e12e4a5df5c39c16b4e130f0261a532bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137658Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756768}

Bug: 1067999
Change-Id: Ie400d1b600295f3c36fcd422ab84eaf5e51caec0
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137732
Commit-Queue: Aaron Gable <agable@chromium.org>
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756767}

Changing no protection options strings to match style of cookie page not recommended string.

Bug: 1032584
Change-Id: I47854da34fb906e9fe2ddc39d8c725df7332f674
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137445Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756766}

Use `cp -c` to copy file into the bundle which uses clonefile instead
of hardlink. This is as efficient in speed and disk usage. This also
ensures that files in the bundle are distinct from any other files
(which is important when running EG2 tests via Xcode as it tries to
overwrite some files with `ditto` which fails if source and target
are hardlinked together).

Bug: 1042182
Change-Id: I53c08a0ee2200355b3c4249465f78189d6e294d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133930
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756765}

Bug: 1067999
Change-Id: I4cd7cd268e9e7d5cb799e106b92130ddf0fc9d89
No-Try: true
TBR: agable@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137517Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756764}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9d3fad03dfd0..fb7cf9786cf1


Created with:
  gclient setdep -r src-internal@fb7cf9786cf1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC zmin@google.com,jarhar@google.com,cfroussios@google.com,aboxhall@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: zmin@google.com,jarhar@google.com,cfroussios@google.com,aboxhall@google.com
Change-Id: I1b28aacaba8e26729ebc4ce8c7a4d1c3cd3c371e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137548Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756763}

Removes the WebGL and WebGL 2 expectations that were added due to
experimenting with Intel driver 26.20.100.7323. These issues should
hopefully be fixed on 26.20.100.7870.

Bug: 1026468, 1053803
Change-Id: Ifc6b1cbb61fdd586962117366b316311c4f5a728
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137585
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756762}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/be2d34de7a06..7767e4fa4792

git log be2d34de7a06..7767e4fa4792 --date=short --first-parent --format='%ad %ae %s'
2020-04-06 mathias@chromium.org Improve custom locations UI

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@7767e4fa4792

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I5fa911bd8adad8a241c8f938aed310f98230cf8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137651Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756761}

https://chromium.googlesource.com/webm/libvpx.git/+log/667138e1f058..104adb2aa3e6

$ git log 667138e1f..104adb2aa --date=short --no-merges --format='%ad %ae %s'
2020-04-02 wtc Return VPX_CODEC_INCAPABLE on capability failure
2020-04-02 johannkoenig x86inc.asm: update to 3e5aed95c
2020-04-02 johannkoenig x86inc.asm: namespace ARCH_* defines
2020-04-02 johannkoenig x86inc.asm: only set visibility for chromium builds
2020-04-02 johannkoenig x86inc.asm: do not align .text for aout
2020-04-02 johannkoenig x86inc.asm: use .text on march32
2020-04-02 johannkoenig x86inc.asm: copy PIC macros from x86_abi_support.asm
2020-04-02 johannkoenig x86inc.asm: set PREFIX from libvpx defines
2020-04-02 johannkoenig x86inc.asm: pull settings from libvpx
2020-04-02 johannkoenig x86inc.asm: update to 3e5aed95
2020-03-31 johannkoenig x86_abi_support: use correct hidden syntax

Created with:
  roll-dep src/third_party/libvpx/source/libvpx

Change-Id: I0e6fb3bc8e520b2a4a6c68e79c6eee85fc0fd8c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136986
Commit-Queue: James Zern <jzern@google.com>
Auto-Submit: Johann Koenig <johannkoenig@google.com>
Reviewed-by: James Zern <jzern@google.com>
Cr-Commit-Position: refs/heads/master@{#756760}

These tests are failing in downstream device builder running EG2 tests.
EG2 will run on devices in upstream main after EG1/EG2 swap. This will
prevent these builders being red after the swap.

Bug: 1046369
Change-Id: I198dce844e896e474c53a0e1e329af5768655119
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135416
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756759}

Handling Accept-CH on navigation redirects right requires understanding
Accept-CH in the browser, and WIP security work says that everything the
browser needs in HTTP headers parsed should be parsed by network
service... so the client hints type needs to live in services/network

Bug: 1050726
Change-Id: I24af1ec72fb0b2f002100ca205e235e15894dc08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119792
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756758}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/19d4809e1126..89624cdfd788

git log 19d4809e1126..89624cdfd788 --date=short --first-parent --format='%ad %ae %s'
2020-04-06 ehmaldonado@google.com Reland "git-cl: Execute clang-format-diff.py using vpython."

Created with:
  gclient setdep -r src/third_party/depot_tools@89624cdfd788

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1066187
Tbr: agable@chromium.org
Change-Id: Id4d47e51444d9319ddfe61c890ceefcd10927eeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137652Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756757}

Browser UI thread can be blocked on viz compositor or viz main. RunTaskAfterWindowReady blocks viz main on DRM thread when it is posted by PostSyncTask. These tasks need browser to call CreateWindow through mojo pipe to continue.
Deadlocks are caused by this. RunTaskAfterWindowReady needs to be relaxed to lower crash rates.

Bug: 1050676
Change-Id: Ie205300fa68300f129c1bb1e7d746c6399a65013
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135128
Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756756}

Before, it's initialized in PostEarlyInitialization,
which is a regression introduced in
https://chromium-review.googlesource.com/c/chromium/src/+/2078475.

Now it goes back to initialize in PreCreateThreads.

Also add a flag and a DCHECK to make sure in the future
we won't accidentally initialize it earlier.

TEST=bots
R=jam@chromium.org,kbr@chromium.org

Bug: 1055899,1060999
Change-Id: Id9e96a45035d1f5e6173c3f24ecedd0815005d74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134864Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756755}

VoiceSearchCoordinator needs a Browser to access a Browser-scoped
FullscreenController.

Bug: 790886
Change-Id: I24acae364cb64ecc011375045feab66e58dd432e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132852
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756754}

This adapts the implementation to some of the breaking spec changes
introduced in https://github.com/w3c/screen-wake-lock/pull/255.

Namely, WakeLockPermissionDescriptor has been removed in favor of using a
regular PermissionDescriptor object with |name| set to "screen-wake-lock".

That spec change also removed system wake locks (and consequently the
additions to the WorkerNavigator interface) altogether, but that will be
done in a separate CL, so for now we also support a PermissionDescriptor
object with |name| set to "system-wake-lock".

Bug: 257511, 1064685
Change-Id: I096f3fae24444da5ca6b1eeb3889a813a9e5f270
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134228Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#756753}

Make 4 histograms as LOCAL, and extend expiration date of others.


Change-Id: I30e9b63aafb9b1eeec29ccdab27295b8c4d47246
Bug: 1053087,1043725,1037175,1037174,
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136887
Auto-Submit: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756752}

This change introduces additional 56dp semi-compact suggestion variant
as well as unit tests for compact omnibox suggestions.

Bug: 1067799
Change-Id: I6ae57f5b8dd0b594eb69d4b2c55d59eb57f15ef0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134677Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#756751}

We have several different places to launch SettingsActivity. Adding this
SettingsActivityTestRule to provide a uniformed entry to launch
SettingsActivity.

This is the first CL in the series. This CL adds the
SettingsActivityTestRule, and change the call for SettingsActivityTest.
Other calls to launch SettingsActivity will be migrated in follow-up
CLs.

Bug: 1066660
Change-Id: I363034e543f9aabbb742d98f3e4b9aa0f0578acc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135021
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756750}