GitLab

HistoryQuick provider can provide what-you-typed scores (i.e., things
that are allowed to be the default match despite
prevent_inline_autocomplete being true) that is higher than
HistoryURL provider's what-you-typed score.

BUG=

Review URL: https://codereview.chromium.org/231023006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262854 0039d316-1c4b-4281-b951-d872f2087c98

There's a small race in the libevent code: it tests whether the monotonic clock
works and, if so, uses it and skips time-warp detection. However, the flag is a
static and thus causes a race.

We don't want to lose the ability to skip time-warp detection when the system
has a monotonic clock because we expect the vast majority of systems to have
it. But I'm not quite confident enough to remove support for systems without it
yet.

Thus this patch moves the race so that it only triggers on old systems that
don't have a monotonic clock. It's still there because we don't have easy
access to a "once" object this far down and we don't want to add a static init
function. But it will stop triggering the detectors and only arise on very old
systems.

BUG=360449
R=jln@chromium.org

Review URL: https://codereview.chromium.org/231493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262853 0039d316-1c4b-4281-b951-d872f2087c98

net::NetworkInterface.

This CL doesn't attempt to find network interface type, all are initialized
to UNKNOWN type. Subsequence CL's will have platform specific code
which will gather network interface type information.

BUG=
R=agl@chromium.org
TBR=gene@chromium.org, justinlin@chromium.org

Review URL: https://codereview.chromium.org/231973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262851 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/212813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262850 0039d316-1c4b-4281-b951-d872f2087c98

Turns out the application code (specifically openssh does
this) is allows to pass incomplete fd_set structs as long
as they can store at least nfds worth of information.
This means that we can't call FD_ZERO on the pointers
given to use since FD_ZERO assumes a full fd_set.

This fixed a long standing memory corruption issue with
openssh.

R=binji@chromium.org

Review URL: https://codereview.chromium.org/229863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262849 0039d316-1c4b-4281-b951-d872f2087c98

This is a revisit of https://codereview.chromium.org/218093002.  In that
change, I assumed that if was_same_page == true, then the fullscreen
exit should not be forced (e.g., a navigation that is just a hash tag
change in the URL).  However, this flag turns out to be unreliable:
There are cases (see bug) where going back/forward between two different
pages on the same site will commit a navigation with
was_same_page == true.

This change instead asks the NavigationController to compare the new URL
versus the last-committed entry's URL to decide.

BUG=356951

Review URL: https://codereview.chromium.org/230043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262848 0039d316-1c4b-4281-b951-d872f2087c98

+ set OEM apps folder name from default_app_order.json

BUG=357408
TEST=unit_tests
R= asargent@chromium.org, stevenjb@chromium.org

Review URL: https://codereview.chromium.org/216763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262847 0039d316-1c4b-4281-b951-d872f2087c98

Not reverting the string changes, because the new strings work with the old file, and we've passed string freeze.

> Switch to using the new Link Doctor API.
>
> The new API allows Link Doctor results to be integrated into Chrome's
> own error pages.

BUG=64832, 260709
TBR=mmenke@chromium.org

Originally Landed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255617

Review URL: https://codereview.chromium.org/228803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=359406

Review URL: https://codereview.chromium.org/230953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262845 0039d316-1c4b-4281-b951-d872f2087c98

crypto accelerator.

Adobe reports that this check is not working. We need to add a check
but for a canary or two we want to run it without it so end to end
test can happen.

Intial CL
https://codereview.chromium.org/191533002

BUG=349704
TBR=jam

Review URL: https://codereview.chromium.org/228783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262844 0039d316-1c4b-4281-b951-d872f2087c98

In the last data update, 005, Pica changed its boot-up sequence to no
longer depend on the old WebComponentsReady event, but the page set
was still using that to decide that the load was finished.

This patch switches the Pica page set to wait for 'polymer-ready' instead,
which should be fired just before the first paint.

It also includes a new WPR archive that cuts the payload size by 1/3.

BUG=361367
TBR=tonyg@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/232203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262842 0039d316-1c4b-4281-b951-d872f2087c98

The execinfo.h header is glibc-specific, as is the backtrace function.
Let's skip them for uclibc builds.

BUG=361130

Review URL: https://codereview.chromium.org/228753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262841 0039d316-1c4b-4281-b951-d872f2087c98

This patch introduces a requestUnmount() method, which is invoked by Files app's private api, and then emits an onUnmountRequested event. When the providing extension receives it, it should handle unmounting, and call the success or failure callback.

Unmounting is the first implemented request in the file system provider implementation. Other requests will be: listing directories, fetching files, etc. These requests are invoked by Files app and are routed to the providing extension, then the response goes back to Files app.

To make the code clean, a RequestManager class has been introduced. It acts as a glue between requests as responses.

TEST=unit_tests: *FileSystemProviderServiceTest.Unmount*, *FileSystemProviderRequestManagerTest*; browser_tests: *FileSystemProviderApiTest.Unmount*
BUG=248427

Review URL: https://codereview.chromium.org/194693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262840 0039d316-1c4b-4281-b951-d872f2087c98

The action that is taken when the user middle clicks on non client area
is configurable with gnome-tweak-tool. This allows users to disable any
action on middle click, lower windows, minimize windows, or toggle the
maximize state.

Also renames GConfTitlebarListener to GConfListener, since it's now
doing more than just checking maximize button order.

BUG=132061

Review URL: https://codereview.chromium.org/229783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262839 0039d316-1c4b-4281-b951-d872f2087c98

ContentViewRenderView's usage of ContentView is historical. Everything
just forwards to ContentViewCore. Cleaning this up, allows further
distinction between the two.

Some misc changes in TabUtils.java to appease presubmit.

BUG=360664

Use CVC as appropriate in content shell

Review URL: https://codereview.chromium.org/227803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262838 0039d316-1c4b-4281-b951-d872f2087c98

- fixes ui::Layer::SetTextureMailbox to not be hard-coded for software
  frames.
- adds a ui::Layer::SetTextureSize to update the size without sending a
  new mailbox (since it doesn't change).
- entirely removes ui::Layer::SetExternalTexture and ui::Texture, and
  derived classes.
- significantly changes the ReflectorImpl implementation:
  * an OwnedMailbox is created on the main thread, using the shared main
    thread context.
  * the mailbox is passed to the impl thread, that creates a texture out
    of it with the OutputSurface context, and does operations on that.
  * the mailbox is passed to the layer.
  * if the OutputSurface is recreated (assuming, after a lost context),
    the OwnedMailbox is recreated, and passed to the impl side again,
    together with the new surface.
  * the OwnedMailbox takes care of deleting the texture, whether because
    of a lost context, or when the ReflectorImpl is shut down.

BUG=333408
R=danakj@chromium.org, oshima@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/228083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262836 0039d316-1c4b-4281-b951-d872f2087c98

We already do this in the non-udev case, and X11 does this as well.
We only want the evdev devices, which are named /dev/input/eventN.

BUG=none
TEST=content_shell --ozone-platform=test

Review URL: https://codereview.chromium.org/230883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262830 0039d316-1c4b-4281-b951-d872f2087c98

Also now we always use WriteToStderr and move comments to
appropriate positions.

TEST=trybots
BUG=359285

Review URL: https://codereview.chromium.org/231423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262829 0039d316-1c4b-4281-b951-d872f2087c98

This CL relands r262568 with NO additional changes. The original CL was reverted to help investigate some test failure, which turned out to be unrelated to this CL.

Android MediaDrm API supports container mime type check in
isCryptoSchemeSupported (UUID uuid, String mimeType):

http://developer.android.com/reference/android/media/MediaDrm.html#isCryptoSchemeSupported(java.util.UUID, java.lang.String)

This CL hook this API up in MediaDrmBridge.

Also, Chromium will always query the codec/container type it
is interested in (e.g. MP4 and WebM).

TBR=ddorwin@chromium.org,qinmin@chromium.org,dmazzoni@chromium.org
BUG=350481

Review URL: https://codereview.chromium.org/230843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262828 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361359
TBR=wolenetz@chromium.org

Review URL: https://codereview.chromium.org/231123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262827 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=Existing unit tests.

Review URL: https://codereview.chromium.org/229163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262826 0039d316-1c4b-4281-b951-d872f2087c98

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3816
TEST= trybots

Review URL: https://codereview.chromium.org/229283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262825 0039d316-1c4b-4281-b951-d872f2087c98

In OmniboxEditModel::OpenMatch, the difference between
popup_model->selected_index() and index is confusing.
This change removes references to the former from
within that function.

BUG=

Review URL: https://codereview.chromium.org/229583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262824 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361685
TEST=TouchDispositionFilterTest.ConsumedScrollUpdateMakesFlingScrollEnd

Review URL: https://codereview.chromium.org/231333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262823 0039d316-1c4b-4281-b951-d872f2087c98

The flicker was introduced in https://codereview.chromium.org/217373003/
Sometimes the overlay would get dismissed based on the paint event from the
previous page which happens just before the navigation.
This CL addressed the problem by ensuring
 a. The navigation is initiated before the overlay starts listening to events.
 b. We keep track of the pending id of the loading page and the paiting page.

BUG=357751

Review URL: https://codereview.chromium.org/224253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262822 0039d316-1c4b-4281-b951-d872f2087c98

R=binji@chromium.org

Review URL: https://codereview.chromium.org/225293010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262821 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354405,346626

Review URL: https://codereview.chromium.org/229653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262820 0039d316-1c4b-4281-b951-d872f2087c98

> Implement a source for remote video tracks.
> MediaStreamRemoteVideoSource implements the MediaStreamVideoSource interface
> for video tracks received on a PeerConnection. The purpose of the class is
> to make sure there is no difference between a video track where the source is
> a local source and a video track where the source is a remote video track.
> 
> BUG=334243
> 
> Review URL: https://codereview.chromium.org/201583003

This caused remote video to appear unexpectedly zoomed and cropped.

BUG=334243,361770
TBR=perkj@chromium.org

Review URL: https://codereview.chromium.org/231963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262819 0039d316-1c4b-4281-b951-d872f2087c98

Broken in the sense that it no longer gets shown :)

BUG=NONE
TEST=With --new-profile-management enabled, create a new profile, and
press the "Not X" button. The user manager should show up, and it should
display a tutorial.

Review URL: https://codereview.chromium.org/229333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262818 0039d316-1c4b-4281-b951-d872f2087c98

Specifically counts only the first CertVerifer job in order to capture any
initialization costs.

BUG=361166

Review URL: https://codereview.chromium.org/225583009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262816 0039d316-1c4b-4281-b951-d872f2087c98

osmesa.so is now a required dependency for this test to pass.

R=danakj@chromium.org
BUG=361362

Review URL: https://codereview.chromium.org/227673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262815 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262813 0039d316-1c4b-4281-b951-d872f2087c98

With the blink fixes for layer squashing in in  https://src.chromium.org/viewvc/blink?view=rev&revision=171103, there's no longer any reason to disable cc touch hit testing when squashing is enabled.

BUG=336560

Review URL: https://codereview.chromium.org/224803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262810 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes IsHigherPriorityThan to return correct values. It
also adds a unittest.

R=enne

Review URL: https://codereview.chromium.org/230983004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262809 0039d316-1c4b-4281-b951-d872f2087c98

This CL allows displaying to user and selection of country-specific language
codes for which we do not have actual translation. A base language locale
will be used instead.

BUG=357481
TEST=browsertest

To test manually:

1) Set VPD value of initial_locale to country-specific language codes, for which only the translation to base language exist. For example:
"fr-CH,it-CH,de-CH"

2) Start OOBE and check they are displayed and selectable like any other languages.

Review URL: https://codereview.chromium.org/224093013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262808 0039d316-1c4b-4281-b951-d872f2087c98

This is required for Aura to use ui::GestureProvider.

BUG=360790
TEST=GestureProviderTest.{GestureBeginAndEnd, GestureTapTap, ...}

Review URL: https://codereview.chromium.org/227743007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262807 0039d316-1c4b-4281-b951-d872f2087c98

The warning -Wshorten-64-to-32 is automatically enabled by Xcode 5.1
when building for 64-bit architecture. Disable when the generator is
Xcode, not ninja.

BUG=359107

Review URL: https://codereview.chromium.org/231023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262805 0039d316-1c4b-4281-b951-d872f2087c98

See mock at slide 19 https://docs.google.com/a/google.com/presentation/d/1UMAexroivw01osOXpnEqbQcE3FMyDkc9eZoIszm4DP4/edit#slide=id.g12716c62f_012

BUG=345075

Review URL: https://codereview.chromium.org/225963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262804 0039d316-1c4b-4281-b951-d872f2087c98

Don't enable the DCHECK, since it blows things up. Note that this
doesn't actually fix the bug.

Also fix RemoteMessagePipeTest.Multiplex, which is actually currently
broken[3]. (Though one might think that MessagePipe's destructor would
detect the missing Close()s, one would be wrong: Without closing, the
reference cycle wouldn't get broken (by design[4]), so nothing gets
destroyed. Oops.)

[1] Currently, usually (always?) one side will leak. The problem is that
    we (only) detach on receiving a kSubtypeMessagePipePeerClosed
    control message. But then we won't send one of our own.[2]
[2] The solution is probably to send an ack for these messages, and
    detach on receiving the ack instead. This is tricky since you have
    to handle the case when both sides simultaneously send the
    peer-closed control message.
[3] That is, when this bug is fixed and the DCHECK enabled, the test
    would still blow up.
[4] Possibly a bad design.

R=sky@chromium.org
BUG=360081

Review URL: https://codereview.chromium.org/231483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262803 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation for bringing the bookmark undo manager to ios.

BUG=NONE

Review URL: https://codereview.chromium.org/230003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262802 0039d316-1c4b-4281-b951-d872f2087c98