- 04 Mar, 2015 40 commits
-
-
knn authored
Added a layer for Supervised Users in the HostContentSettingsMap. As this only needs functionality to block the entire content setting (for now), it is similar to the existing OverrideProvider. Reorganized the common code between the two providers. Updated the helper methods in PrefServiceBridge to check the HostContentSettingsMap instead of Preferences when checking whether it is managed by the custodian. BUG=455646 BUG=455640 Review URL: https://codereview.chromium.org/902833003 Cr-Commit-Position: refs/heads/master@{#319121}
-
sclittle authored
This change makes the DataReductionProxyInterceptor intercept redirects as well as responses. This will cause clients on captive portal networks that cause redirect loops when trying to use Data Saver bypass immediately instead of waiting for 21 redirects. BUG=460346 Review URL: https://codereview.chromium.org/958163004 Cr-Commit-Position: refs/heads/master@{#319120}
-
scottmg authored
Otherwise, on Windows when 'All' is built the no-op build is broken -- no files are included in the .lib so none is generated, which means on subsequent builds ninja always reruns that step. This is currently breaking win_chromium_compile_dbg_ng trybots. R=pasko@chromium.org, thakis@chromium.org BUG=424562 Review URL: https://codereview.chromium.org/981623002 Cr-Commit-Position: refs/heads/master@{#319119}
-
thestig authored
WebRtcBrowserTest.CallAndModifyStream RenderFrameHostImplBrowserTest.IsFocused_AtLoad RenderFrameHostImplBrowserTest.IsFocused_Widget BUG=464029,464033 TBR=mlamouri@chromium.org,phoglund@chromium.org Review URL: https://codereview.chromium.org/977183002 Cr-Commit-Position: refs/heads/master@{#319118}
-
skyostil authored
Refactor the way options are passed to ChildThreadImpl to make the call sites easier to read and to make it easier to add a task runner parameter later. BUG=444764 Review URL: https://codereview.chromium.org/974933002 Cr-Commit-Position: refs/heads/master@{#319117}
-
thestig authored
BUG=464019 TBR=rockot@chromium.org Review URL: https://codereview.chromium.org/977853003 Cr-Commit-Position: refs/heads/master@{#319116}
-
newt authored
This moves the Lollipop-specific code in BatteryStatusManager into a separate method and annotates it with @TargetApi(LOLLIPOP) so appease Android lint. BUG=411461 Review URL: https://codereview.chromium.org/975963003 Cr-Commit-Position: refs/heads/master@{#319115}
-
jshin authored
v8 still uses the data dll (icudt.dll) on Windows. While building the Windows data dll, a few issues were discovered in the ICU data that were overlooked. Only one of them (the display name for Moldovan in Moldovan) is user-visible. ICU ( eda9e75b1fa17f57ffa369ee3543a2301b68d0a9 ) has fixes for them. In addition, fix the display name for 'mo' (which is actually 'ro-MD') and add a test. It's "broken" ever since ICU upgrade to 54.1. (See http://bugs.icu-project.org/trac/ticket/11563 ) BUG=428145 TEST=See https://codereview.chromium.org/878723002 for the list of tests. TEST=ui_base_unittests --gtest_filter=*Display* TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/971653005 Cr-Commit-Position: refs/heads/master@{#319114}
-
yoshiki authored
This is the first implementation of Download Notification for ChromeOS. This feature is behind a flag and disabled by default as for now. The major changes of the patch are: - Add DownloadNotificationManager, which replaces DefaultUIControllerDelegate - Add DownloadNotificationItem, which represents each notification - Add DownloadCommands, which is extracted from DownloadShelfContextMenu::ContextMenuCommands - Rename DefaultUIControllerDelegate -> DownloadShelfUIControllerDelegate - Rename: DefaultUIControllerDelegateAndroid -> AndroidUIControllerDelegate BUG=446112 TEST=browser_test passes Review URL: https://codereview.chromium.org/852043002 Cr-Commit-Position: refs/heads/master@{#319113}
-
boliu authored
Calling the visual state API when the container view is dettached must draw the contents correctly when the callback is received. We add a test for that. We also fix a possible crash if the container view is dettached after insertVisualStateCallback has been called but before the callback has been received. Original author igsolla@chromium.org BUG=461369, 457184 Review URL: https://codereview.chromium.org/972013003 Cr-Commit-Position: refs/heads/master@{#319112}
-
mcasas authored
Including: - use auto, const auto, range based for loops. - loop variable renaming due to this change. - gfx::Size() has a GetArea() method, use it. - removal of unnnecessary {} - argument formatting when it fits in one line - VideoTrackAdapter::VideoFrameResolutionAdapter::DoDeliverFrame() is not virtual. BUG= Review URL: https://codereview.chromium.org/964293002 Cr-Commit-Position: refs/heads/master@{#319111}
-
watk authored
Previously vp9 video was assumed to be in BT601. Now the vp9 color space flag is used to support BT709 as well. BUG=447716 TEST=media_unittests --gtest_filter='PipelineIntegrationTest*' Review URL: https://codereview.chromium.org/978483002 Cr-Commit-Position: refs/heads/master@{#319110}
-
rvargas authored
BUG=none NOPRESUBMIT=true Review URL: https://codereview.chromium.org/963163004 Cr-Commit-Position: refs/heads/master@{#319109}
-
stuartmorgan authored
This is used in iOS tests to serve test content without relying on network-layer interception. BUG=None Review URL: https://codereview.chromium.org/927463003 Cr-Commit-Position: refs/heads/master@{#319108}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/96cd5bb..235b088 TBR=samli@chromium.org,aboxhall@chromium.org Review URL: https://codereview.chromium.org/979933002 Cr-Commit-Position: refs/heads/master@{#319107}
-
mnaganov authored
It's not used any longer. Was added in https://codereview.chromium.org/551793003/ as temporary solution to use WebRTC from android service. In following CLs we've moved to native API: https://codereview.chromium.org/704613003 https://codereview.chromium.org/716433003 https://codereview.chromium.org/719043002 https://codereview.chromium.org/734313002 There is no plan to use Java API for DevTools bridge again. BUG=383418 Review URL: https://codereview.chromium.org/982563002 Cr-Commit-Position: refs/heads/master@{#319106}
-
lukasza authored
I want to reuse ScopedMockLog from unittests under src/remoting/host. To do that, I am moving this class from net/test to base/test. When doing the move, I also wanted to ensure thread-safety in the case when logging is happening on a thread different from where StartCapturingLogs or StopCapturingLogs are called. Having proper locks (and memory barriers implied by the locks) should ensure that 1) LogMessageHandler won't see a half-way executed StartCapturingLogs or StopCapturingLogs and 2) that a log write in-progress won't get a rug pulled from underneath by destroying of gMock's structures embedded in ScopedMockLog's Log mock method. BUG= TEST=net_unittests Review URL: https://codereview.chromium.org/966423003 Cr-Commit-Position: refs/heads/master@{#319105}
-
zhenw authored
Disable TabTest:testTabIsAlive on Android because it fails on FYI bot Android Tests (K N5, user build)(dbg). Re-enable it after the test on Android is fixed. See details in https://crbug.com/463933 BUG=463933 Review URL: https://codereview.chromium.org/971613004 Cr-Commit-Position: refs/heads/master@{#319104}
-
zhenw authored
The tests should only run when tab control is supported. See log on FYI bot Android Tests (K N5, user build)(dbg): http://build.chromium.org/p/chromium.fyi/builders/Android%20Tests%20%28K%20N5%2C%20user%20build%29%28dbg%29/builds/3050/steps/telemetry_unittests/logs/stdio BUG=437881 Review URL: https://codereview.chromium.org/979833003 Cr-Commit-Position: refs/heads/master@{#319103}
-
miletus authored
We have shader compilation caching but telemetry can't benefit from it since pages are tested with cache cleared. We want to reflect the caching impact in our metrics. To enable the cache, after the initial load of the page, we wait for a while for the page to build some cache, and then reload the page and test the user interaction. Linkedin and Wowwiki in key_mobile_sites_smooth are selected for this since they are found to have expensive initial shader compilation cost. BUG=430631,453861,451216 Review URL: https://codereview.chromium.org/959063002 Cr-Commit-Position: refs/heads/master@{#319102}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/7ab4277..b841060 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=joshualitt@google.com Review URL: https://codereview.chromium.org/971463003 Cr-Commit-Position: refs/heads/master@{#319101}
-
jdduke authored
A good portion of the current WebContentsObserver instances for any given tab are Java-based. Each of these require separate JNI hops, as well as repeated string conversions, for each observer callback. Avoid such costs by having just one Java-based WebContentsObserverProxy that bridges from native and allows multiple Java-based WebContentsObserver subscribers. BUG=440134 Review URL: https://codereview.chromium.org/786933005 Cr-Commit-Position: refs/heads/master@{#319100}
-
finnur authored
Fixes crash found when toggling the state. BUG=463062 Review URL: https://codereview.chromium.org/969033004 Cr-Commit-Position: refs/heads/master@{#319099}
-
Abhishek Arya authored
R=mbarbella@chromium.org BUG= Review URL: https://codereview.chromium.org/978523004 Cr-Commit-Position: refs/heads/master@{#319098}
-
maxbogue authored
Removing GSM.setupSessionSyncId() part 3/4. Generate the sync sessions ID in SyncController and cleanup ChromeShellActivity. BUG=428882 Review URL: https://codereview.chromium.org/951773003 Cr-Commit-Position: refs/heads/master@{#319097}
-
ianwen authored
Enhanced Bookmark feature may need to be turned on by some java instrumental tests. Therefore the flag should be added to the java command line class. BUG=458632 Review URL: https://codereview.chromium.org/973283002 Cr-Commit-Position: refs/heads/master@{#319096}
-
rockot authored
BUG=463769 R=kalman@chromium.org Review URL: https://codereview.chromium.org/976983003 Cr-Commit-Position: refs/heads/master@{#319095}
-
daplatz authored
Previously, the update_rect() of the LayerImpl was used for the repaint regions in the DebugRectHistory; now the base LayerImpl class defines a virtual method giving back an invalidation Region that is overwritten by PictureLayerImpl to use the already existent invalidations_ Region. Regions give a more tighter bound on the invalidations than the single conservative rect that was used before on a per-layer basis. BUG=424682 Review URL: https://codereview.chromium.org/958843004 Cr-Commit-Position: refs/heads/master@{#319094}
-
boliu authored
New APIs can be more strict about enforcing not being called after destroy. BUG=457184 Review URL: https://codereview.chromium.org/974143002 Cr-Commit-Position: refs/heads/master@{#319093}
-
sergeyu authored
GYP wasn't generating correct list of dependencies when base.gypi was included after untrusted.gypi. As result libbase_nacl.a wasn't always rebuilt when the sources it depends on were changed. BUG=461422 Review URL: https://codereview.chromium.org/976863002 Cr-Commit-Position: refs/heads/master@{#319092}
-
maxbogue authored
Previously owned by GSM downstream. Note that there will be two SigninNotificationControllers in existence between this landing and the downstream patch landing, but the only call its listener makes (cancelNotification) appears to be idempotent so it shouldn't matter. BUG=428882 Review URL: https://codereview.chromium.org/952083002 Cr-Commit-Position: refs/heads/master@{#319091}
-
Brett Wilson authored
TBR=dpranke Review URL: https://codereview.chromium.org/977943003 Cr-Commit-Position: refs/heads/master@{#319090}
-
b.kelemen authored
Push messaging is a client of gcm and not a part of it. To improve layering it should live in a seperate directory. This CL moves files matching chrome/browser/services/gcm/push_messaging_* into chrome/browser/push_messaging/, move the classes out of the gcm namespace. It also restrains GCMProfileService to be the owner of PushMessagingServiceImpl. Instead it became a KeyedService. By making it such it became easy to clean up the dependencies and ownership concerns between push messaging and gcm. BUG=402486 Review URL: https://codereview.chromium.org/955673004 Cr-Commit-Position: refs/heads/master@{#319089}
-
dongseong.hwang authored
Build failed due to uninitialied values. ../../chrome/browser/media/protected_media_identifier_permission_context.cc:187:8: error: 'persist' may be used uninitialized in this function [-Werror=maybe-uninitialized] ../../chrome/browser/media/protected_media_identifier_permission_context.cc:205:32: error: 'content_setting' may be used uninitialized in this function [-Werror=maybe-uninitialized] Review URL: https://codereview.chromium.org/974223002 Cr-Commit-Position: refs/heads/master@{#319088}
-
jfb authored
TBR= bradnelson@chromium.org BUG= none Review URL: https://codereview.chromium.org/976053003 Cr-Commit-Position: refs/heads/master@{#319087}
-
treib authored
BUG=397951 Review URL: https://codereview.chromium.org/971733003 Cr-Commit-Position: refs/heads/master@{#319086}
-
blundell authored
This script takes advantage of the fact that Mojo binaries are published in the cloud to add functionality for viewing a URL in HTMLViewer embedded in the kiosk window manager. Review URL: https://codereview.chromium.org/982523004 Cr-Commit-Position: refs/heads/master@{#319085}
-
dconnelly authored
Depends on https://codereview.chromium.org/901493003/ BUG=448011 Review URL: https://codereview.chromium.org/878743007 Cr-Commit-Position: refs/heads/master@{#319084}
-
boliu authored
Test is racy by design, and testing this properly is not worth the effort required to add the proper hooks into initialization. BUG= Review URL: https://codereview.chromium.org/971103003 Cr-Commit-Position: refs/heads/master@{#319083}
-
gunsch authored
Double-revert seems to have deleted the fixes: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/9ufqvcvv_DU R=lcwu@chromium.org,servolk@chromium.org BUG=None Review URL: https://codereview.chromium.org/979913002 Cr-Commit-Position: refs/heads/master@{#319082}
-