- 08 Oct, 2018 40 commits
-
-
Wei Li authored
This is to prepare for removing ShouldHideUIForFullscreen() and the entire Cocoa integration of FullscreenControlHost. BUG=890455 Change-Id: If743e9c4d51312222d3dce1406040f5ad3b1e4f7 Reviewed-on: https://chromium-review.googlesource.com/c/1266118Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#597599}
-
Emily Hanley authored
on android nexus5x webview TBR=charliea@chromium.org NOTRY=True Bug: 893209 Change-Id: Iff61f9daf5b3e092eefb3cf86638014643685e62 Reviewed-on: https://chromium-review.googlesource.com/c/1268669Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#597598}
-
Carlos Knippschild authored
* Update content, prioritization and order of offline content to comply with the latest design decisions: * Require minimum of 4 "interesting" items to show anything in the dino page. * Stop prioritizing unread prefetched pages over read ones. * Stop treating a prefetched page also as representing a general page. * Stop treating "Document" downloaded items the same way as "Page". * Fix a potential crash when converting text using higher unicode characters. * Update tests to the conform to the changes above and improve some internal naming. * Do not call dino page Javasscript code when content list is empty. * Do not present the summary view if items count is zero. * Added missing UMA enum value for a previously added case. * Improved/fixed some doc comments. Bug: 852872 Change-Id: I01856e09016e2027b7034ba82b22a8b22922be9d Reviewed-on: https://chromium-review.googlesource.com/c/1260487 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#597597}
-
Joshua Pawlicki authored
TBR=olka@chromium.org Bug: 893015 Change-Id: Ida8106cf8d29659b3a66ed7d85d007302acfc5f6 Reviewed-on: https://chromium-review.googlesource.com/c/1268518 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#597596}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a81322039bb8..39a66e9fc8df git log a81322039bb8..39a66e9fc8df --date=short --no-merges --format='%ad %ae %s' 2018-10-08 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@39a66e9fc8df The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I2ac5d3056a1dbda08dc91fd178325def02a77254 Reviewed-on: https://chromium-review.googlesource.com/c/1268696Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597595}
-
Tommy C. Li authored
After this CL, when the user presses Ctrl+L twice, we will reveal the full URL. Technically speaking, when the user issues a command to focus the Omnibox while it's already focused, we will interpret it as a signal that the user wants to see the full editable URL. So it works for Alt+D and F6 as well. This is gated behind the Query in Omnibox flag since it's still under active experimentation. Bug: 874592 Change-Id: I4d4a8944e4435a57be5e909f94ed65ff303be642 Reviewed-on: https://chromium-review.googlesource.com/c/1265825Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#597594}
-
Evan Stade authored
Bug: 887663 Change-Id: I0e5d3e16d59cf3459fde94f3ed2edb23c2ea9f0e Reviewed-on: https://chromium-review.googlesource.com/c/1260002Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#597593}
-
Eugene But authored
This reverts commit 8719721a. Reason for revert: These tests were not flaky on iOS 10 and 11. Flakiness on iOS 12 should be fixed in crrev.com/c/1267347 If flakiness persist on iOS 12 we should disable the tests only for iOS 12. Original change's description: > Mark DownloadManagerTestCase tests as flaky. > > TBR=eugenebut@chromium.org > > Bug: 892883 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs > Change-Id: Idd01581265d46e17f2812c1456ebe93f0d521389 > Reviewed-on: https://chromium-review.googlesource.com/c/1266879 > Reviewed-by: Mike Dougherty <michaeldo@chromium.org> > Commit-Queue: Mike Dougherty <michaeldo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597415} TBR=michaeldo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 892883 Change-Id: I90a84f0606e1a97b96a27475c5b810828b37756e Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/c/1268677Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#597592}
-
Ben Kelly authored
R=mek@chromium.org Bug: 892971 Change-Id: Iede30d552e737cacc0b85ccfa1575c43f0b82917 Reviewed-on: https://chromium-review.googlesource.com/c/1268535Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#597591}
-
Emily Hanley authored
TBR=charliea@chromium.org NOTRY=True Bug: 893197 Change-Id: I374eb840b6a6f375b27a6a9c8974200099cbb09b Reviewed-on: https://chromium-review.googlesource.com/c/1268664Reviewed-by:
-
Mike Tsao authored
R=michaelpg@chromium.org Change-Id: Ib00ea0c25a0069cf266306a96445d509698725b8 Reviewed-on: https://chromium-review.googlesource.com/c/1265505 Commit-Queue: Mike Tsao <miket@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#597589}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6f591c9706e6..3f21fcb9bd26 git log 6f591c9706e6..3f21fcb9bd26 --date=short --no-merges --format='%ad %ae %s' 2018-10-08 courtneygo@google.com Set ANGLE default backend to Vulkan Created with: gclient setdep -r src/third_party/angle@3f21fcb9bd26 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I8a68472b8aa45e90c0d490b2ec78768f105de00b Reviewed-on: https://chromium-review.googlesource.com/c/1268557Reviewed-by:
-
jdoerrie authored
This change adds GetAllLoginsWithAffiliationAndBrandingInformation() to the PasswordStore. Prior to this change clients had to call both GetAutofillableLoginsWithAffiliationAndBrandingInformation() and GetBlacklistLoginsWithAffiliationAndBrandingInformation() to obtain the same information. This was unnecessarily complex, in particular if knowledge about which response corresponds to which request was required. As a result of this change the password population logic in PasswordManagerPresenter can be greatly simplified. Bug: 892260, 778146 Change-Id: Ic0773c4d0337bc3be1fded6f22bda8d8ac2927bb Reviewed-on: https://chromium-review.googlesource.com/c/1268198 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#597587}
-
Mikel Astiz authored
We have multiple flaky tests that complain with: java.lang.IllegalArgumentException: Can not find AccountHolder for account Account {name=test@gmail.com, type=com.google} at org.chromium.components.signin.test.util.FakeAccountManagerDelegate.getAccountHolder(FakeAccountManagerDelegate.java:341) at org.chromium.components.signin.test.util.FakeAccountManagerDelegate.getAuthToken(FakeAccountManagerDelegate.java:259) at org.chromium.components.signin.AccountManagerFacade$3.run(AccountManagerFacade.java:492) at org.chromium.components.signin.AccountManagerFacade$3.run(AccountManagerFacade.java:489) at org.chromium.components.signin.AccountManagerFacade$ConnectionRetry$1.doInBackground(AccountManagerFacade.java:829) at org.chromium.base.task.AsyncTask$1.call(AsyncTask.java:99) at java.util.concurrent.FutureTask.run(FutureTask.java:237) ... 3 more One hypothesis is that GetAccountHolder() fails during teardown of the test. Hence, let's treat it as auth error such that AccountManagerFacade.getAuthToken() treats it as a regular failed attempt (but doesn't necessarily make the test fail). Bug: 879246 Change-Id: I47c69af1af2579ec70ece468e6701f67ef065992 Reviewed-on: https://chromium-review.googlesource.com/c/1264678Reviewed-by:Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#597586}
-
Devlin Cronin authored
The platform apps api_registration target builds the generated registration for all the Apps-related API functions. This results in a dependency on those API functions, defined in the chrome/browser/apps/platform_apps/api target. Add an explicit dependency from c/b/a/platform_apps/api_registration on chrome/browser/apps/platform_apps/api. This results in circular dependencies from c/b/chromeos and c/b/ui; allow these circular includes as we do for extensions. (Ideally, we can cull some of these, but for now, let's get the compile working again). Bug: 893153 TBR=dominickn@chromium.org Change-Id: Ia43c135ab6c642e47e04aa3c7f7eecedbc7b871e Reviewed-on: https://chromium-review.googlesource.com/c/1268517Reviewed-by:
-
Dominik Röttsches authored
Wait for fonts to be loaded completely, simplify test output logging code by using map() instead of loop. Bug: 708604 Change-Id: Icdca037eb20badb249d10c71b1d98bd6aaae0419 Reviewed-on: https://chromium-review.googlesource.com/c/1268275 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#597584}
-
Philip Rogers authored
A sticky transform node was added in https://crrev.com/590578 but the paint property tree printer was not updated to dump this value. This patch also synchronizes the effect node printing which was missing some values. Bug: 877196 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I26f887e12ecef4eee94b66de57c6edfa3af59648 Reviewed-on: https://chromium-review.googlesource.com/c/1268245 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#597583}
-
Stefan Zager authored
BUG=880388 Change-Id: Ie1a1c4fcf3ee6dbf7a058fdfdf88c3e84417097c Reviewed-on: https://chromium-review.googlesource.com/c/1265831Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#597582}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6a8327fc823d..3a7423909164 git log 6a8327fc823d..3a7423909164 --date=short --no-merges --format='%ad %ae %s' 2018-10-08 nisse@webrtc.org Fix compilation issues on media_transport_interface.h 2018-10-08 terelius@webrtc.org Pass HeaderExtensionMap by reference in rtc_event_log2rtp_dump. 2018-10-08 yvesg@webrtc.org Fix race condition for GetContributingSources test. 2018-10-08 titovartem@webrtc.org Rename DefaultNetworkSimulationConfig into BuiltInNetworkBehaviorConfig. Created with: gclient setdep -r src/third_party/webrtc@3a7423909164 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1a3f95ac06f2fe41709733d18d97a6186b6481fd Reviewed-on: https://chromium-review.googlesource.com/c/1268555Reviewed-by:
-
Dmitry Gozman authored
This is dead code, since "statsCollectionObserver.tabLoadTiming" is not used anywhere. Bug: none Change-Id: Ie9891679a2e2f4987ec11c40f31b7a172535569e Reviewed-on: https://chromium-review.googlesource.com/c/1267349Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#597580}
-
Harald Alvestrand authored
Bug: 893112 Change-Id: Ieb111c7bfb25d298881ed6945f74d51dc9ad07db Reviewed-on: https://chromium-review.googlesource.com/c/1268244Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#597579}
-
Joshua Pawlicki authored
TBR=olka@chromium.org Bug: 888161 Change-Id: Ie6fa29f04d0b6e129c86b6866faa5629c369d9d5 Reviewed-on: https://chromium-review.googlesource.com/c/1268595Reviewed-by:
-
John Budorick authored
Bug: 790265 Change-Id: I86aa0233e66af6ee8a98775356124e827317b5de Reviewed-on: https://chromium-review.googlesource.com/c/1263881Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#597577}
-
Yao Xiao authored
It allows us to observe mainframe download in PageLoadMetricsObserver. Bug: 881345 Change-Id: Icc5a3fb9dd645b9bdc291b64030789312614b74d Reviewed-on: https://chromium-review.googlesource.com/c/1260566Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#597576}
-
Eugene But authored
Wait until Download button is shown up before tapping it. The timeout for the button should be the same as page load timeout, because the button is shown when the server responds. Bug: 892883 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I9cc3b687a9ff8029f411e8eee02689719f1ac0ca Reviewed-on: https://chromium-review.googlesource.com/c/1267347Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#597575}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/63ee73a37124..3c5695530095 Created with: gclient setdep -r src-internal@3c5695530095 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4a11da9cfcc8b9e1710ca9c29052b90ccb2fb1c3 Reviewed-on: https://chromium-review.googlesource.com/c/1268556Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597574}
-
Yuri Wiitala authored
The current theory (see bug) is that somehow the member set between audio::LoopbackStream and media::LoopbackGroupCoordinator became out-of- sync. This change tests that theory by modifying the destructor to ensure the exact set of SnooperNode instances that could be in-use by LoopbackStream::FlowNetwork are cleanly "disconnected" before shutdown (with further object destruction) proceeds. Bug: 888478, 867886 Change-Id: I7b34fe168a80302c43a4333b9a181342f7b79912 Reviewed-on: https://chromium-review.googlesource.com/c/1266875 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#597573}
-
Maks Orlovich authored
Both calls can't be invoked on the same step with the state machine as the callback, as two asynchronous (net::ERR_IO_PENDING) returns mean that the callback would be invoked twice, and it's not meant for that (what with one invocation queuing self-deletion...) Also improve testing somewhat to actually make sure the wasm stuff is deleted as well. Longer-term, this should probably be elsewhere, this method isn't generally used with NetworkService (see: crbug.com/892652) Bug: 892583 Change-Id: I61be72c19f4ec713a2c27e5c4be963f603f3df20 Reviewed-on: https://chromium-review.googlesource.com/c/1264917Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#597572}
-
Philip Rogers authored
This patch updates PropertyTreeManager::EnsureCompositorTransformNode to set the should_be_snapped bit on cc::TransformNode. This matches the behavior of cc's PropertyTreeBuilder (done in AddTransformNodeIfNeeded). Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I47e0f59dc3d1b3e2bd1bb92cc9086a18308a3342 Reviewed-on: https://chromium-review.googlesource.com/c/1267077 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Yuri Wiitala authored
Modifies the legacy media::AudioOutputController to start/stop diverting without using the shared "OnDeviceChange()" code path. This blatant code duplication (sans UMAs) should allow us to evaluate whether certain metrics are okay (or have regressed) with the upcoming transition to the new Audio Service. See bug for details. Bug: 866455 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I56aaeeff8412d132a27a2a9fd6dae476160b4d20 Reviewed-on: https://chromium-review.googlesource.com/c/1266715 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d42baee1..9f7f390a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I89bae23507a1710e55b8661348d3f96d8a6edba5 Reviewed-on: https://chromium-review.googlesource.com/c/1268515Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597569}
-
Marc Treib authored
There's a C++ version and a Java equivalent of GoogleServiceAuthError. The Java version was missing a few entries that were added over the last years; this CL adds them and so brings the two back in sync. Longer-term, it'd be better to automatically generate the Java version from the C++ one using GENERATED_JAVA_ENUM_PACKAGE, but that's left for a future CL. Bug: 866329 Change-Id: Iaed8a9d10c4824bca3f2f828828f5934c0c2845e Reviewed-on: https://chromium-review.googlesource.com/c/1268335Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#597568}
-
Mario Sanchez Prada authored
This new API will provide access to the account ID of the latest cached information for the user's primary account, which is conceptually not the same than getting an AccountInfo with GetPrimaryAccountInfo() and then accessing the account_id member, since that won't return any ID when the account has been removed from the AccountTrackerService. Bug: 887264 Change-Id: Id87e58fbe86e2a048067d4ede8d9621e2d430cff Reviewed-on: https://chromium-review.googlesource.com/c/1264162 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#597567}
-
Joshua Pawlicki authored
Previous sheriff attempted disable but forgot the MAYBE_. TBR=ortuno@chromium.org Bug: 892004 Change-Id: I98ebef818d3e270f277f9f61be0090af9a0a195a Reviewed-on: https://chromium-review.googlesource.com/c/1268516Reviewed-by:
-
Vasilii Sukhanov authored
The CL changes the layout of the "Save username?" bubble. It is used for federated credentials. The "Save password/username?" bubble has always a footer for the signed-in users. The footer is now shown in the account chooser for the signed-in users. Bug: 890336 Change-Id: I7133cb15c6377e82e971e793886f8520b5bfd4eb Reviewed-on: https://chromium-review.googlesource.com/c/1265259Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#597565}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ae06125bdbdf..63ee73a37124 Created with: gclient setdep -r src-internal@63ee73a37124 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Icd4e5499cf71d5c657953e9e39adf68f62b105e8 Reviewed-on: https://chromium-review.googlesource.com/c/1268455Reviewed-by:
-
Mihai Sardarescu authored
There was always a risk that account information was left on the device if the tokens of the account was not loaded. This was not an issue in the application as the token service is the the source of truth for the list of accounts present in the browser. However, there is a small risk that we leave PII information on disk (e.g. email, ful name etc). This CL stop tracking the accounts for which tokens are no longer persent in the token DB. Bug: 891665 Change-Id: I3a9f17bc32efaccb00688108b731bc9337a83f68 Reviewed-on: https://chromium-review.googlesource.com/c/1257914Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#597563}
-
David Tseng authored
Currently, ChromeVox recovers to ancestors when nodes are deleted from the accessibility tree. This often times does not do exactly what we want. For example, when a page quickly removes and re-inserts a the same or similar node, ChromeVox loses its place. This also can lead to ChromeVox getting "stuck" in a navigational loop. Tree path based recovery is already used within editable text, so has good coverage. TreePathRecoveryStrategy (the class) is also a subclass of AncestorRecoveryStrategy, so it falls back to ancestry-based recovery when the tree path is invalid. An alternate approach was tried in: https://chromium-review.googlesource.com/c/chromium/src/+/1234856 Test: the new Google.com accessibility menu now does not loop when navigating with ChromeVox. Bug: 869914,885244 Change-Id: I129e2b31250c2f3169feb662b042e6900f61e424 Reviewed-on: https://chromium-review.googlesource.com/c/1262435Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#597562}
-
Vaclav Brozek authored
When Chrome parses FormData of password forms into PasswordForm structures, it omits, under certain conditions, password fields marked as readonly. To understand the potential impact of removing this special handling, this CL adds a UKM metric to report when this occurs. This will provide both the frequency and some sample sites to understand the usage of readonly password fields. Privacy review of this metric: The whole UKM event "PasswordForm" has been reviewed in crbug.com/728707 and go/gkmnc, where the privacy TL agreed that adding new metrics for this event is OK under certain conditions (see the linked doc). The new twin metrics for the readonly attribute satisfy such conditions, in the opinion of the CL author, and hence are covered by that review. The new metrics have been added to the requested spreadsheet listing all passwords-related metrics. Choice of metrics: The core of the metrics is the ReadonlyPasswordFields enum, which describes different situations which can happen wrt. readonly fields during parsing. Those are in the UKM combined with the bit indicating whether the parsing overall was successful, because this is also relevant to the issue. Further, the metrics can be collected at two stages: when a form is parsed to be filled, and when it is parsed to be saved. Here there was a choice to either record this as an additional bit in one metric, or create two "twin" metrics. The advantage of the former is the ability to study how these two events correlate. The advantage of the latter is easier reading of the particular metrics and a lower range of values per metric. Because the correlation is unlikely to be of significant use, the latter approach was chosen. Bug: 883633 Change-Id: Ib63e52908ae3a257546646c1b255a6cd8fd48b6b Reviewed-on: https://chromium-review.googlesource.com/c/1261984Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#597561}
-
Owen Min authored
When the GetConnectionType returns asynchronously, verification request is never sent because the default network type is CONNECTION_NONE and there is no network change notification later either. Resolves the issue by handling the callback from the API. Also 1) Separate network check from others so that we don't fetch network type again when we know it. 2) Rewrite the unittest to use more fake services instead of stun value. It increase the code coverage. Including SigninManager, ProfileOAuth2TokenService and TestNetworkConnectionTracker. Bug: 891817 Change-Id: Iebdc5bbc30e699b347d6a343bb6f4c979fbe1596 Reviewed-on: https://chromium-review.googlesource.com/c/1259542Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#597560}
-
