- 17 Aug, 2020 40 commits
-
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.57-1597053344-benchmark-86.0.4232.0-r1 to 86-4183.59-1597659923-benchmark-86.0.4232.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I48162ae3c8d57702f9a924aa8da0ad7895352546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360259Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798708}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.57-1597055597-benchmark-86.0.4232.0-r1 to 86-4183.59-1597657121-benchmark-86.0.4232.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If2e8c35f1f41d02464479dc4be66a5ac2df8041e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360260Reviewed-by:
-
Alexander Dunaev authored
The recently landed change [1] has introduced a pure virtual method for ui::Clipboard on Ozone, which has broken the hybrid build that has USE_OZONE and USE_X11 set together. This CL fixes that by adding a stub implementation of that method to ui::ClipboardX11 with Ozone enabled. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2307234 Change-Id: Ia93c8b488f7ffd2009200f894acd6d77ccdb1351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346671Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#798706}
-
Daniel Cheng authored
Change-Id: Id6929dd6a8e36813bdfa480ff227409cc3a1f760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359154 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#798705}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3bd3c99b4d5c..b93d82c4c5a8 2020-08-17 pfagerburg@google.com my_activity.py: add coreboot gerrit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: Ib0ecb837876e08087b8c8332e3b5f65a66fc3dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360255Reviewed-by:
-
Matthias Körber authored
Adds logic to merge the names stored in a local and remote profile. Adepts the bridge util tests to work with structured names. Change-Id: Ide42931f3f36809b9f72a666e2941ce1418f040d Bug: 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358672 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#798703}
-
Peter Kasting authored
Mostly these want to be OnceCallbackList, which didn't use to exist. Bug: none Change-Id: I5ff42f68fb391ce7cee6fe02cf3aed508e1e89e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354805 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#798702}
-
Malay Keshav authored
This patch adds trace events using GPU timer queries to measure the composite time per frame. The trace events are per quads and uses the ready timestamp to synchronize with the trace timeline. NOTE: This only works on intel mesa based devices. Other drivers may not work as expected. Bug: 1092700 Test: Manually ran trace events on atlas device. Change-Id: I1c8ee41e2c769129e28a9a3d28bfe77dd1ddd8fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284010Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#798701}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/866d2894ebd1..5cfa7194d55e 2020-08-17 nigeltao@google.com Drop support for Wuffs v0.2 2020-08-17 johnstiles@google.com Simplify SkSL::String by removing unused parts. 2020-08-17 reed@google.com Migrate to using SkPathBuilder 2020-08-17 robertphillips@google.com Better encapsulate the GrDrawOpAtlas w/in the GrSmallPathAtlasMgr If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: I9dc02d126f35440c23f1d537c54aae16b89b4f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360215Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib89e59df47b8994a269fe4fe33bd8fda718f473b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360256Reviewed-by:
-
Roman Aleksandrov authored
This is a reland of 67a4df6f CL was reverted cause of failing chromeos-betty-pi-arc-cfi-thin-lto-chrome due to reaching deadline on one of the tests. This is gonna be fixed by increasing time limit. See details here: https://crbug.com/1116379 Original change's description: > LoginScreen: Show TPM lock status. > > If TPM is locked show banner with steps on how to fix this issue. > > Bug: 1114656 > Change-Id: I85dab0f4ce003ac3dad61c318efb3333457993ac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346266 > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> > Cr-Commit-Position: refs/heads/master@{#797992} Bug: 1114656 Change-Id: Iba50daf1d1b892539e00d9be04fc2b8c0a5a279e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359992Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#798698}
-
Peter Kasting authored
* Use base:: functions to convert float->int * Rounding is more accurate for percentages than truncating * Shorten code Bug: none Change-Id: Ie968f402c44dd5f7739e11cb29bb32d866bc4fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359003 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#798697}
-
Sundoo Kim authored
Explicitly remove the copy constructor and assignment operator with the delete keyword. Bug: 1010217 Change-Id: I7440c2f934c5556249365a2637cedc2517aa91e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359310Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#798696}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/39fbb307bc9a..12c6d67a4298 2020-08-15 vapier@chromium.org sysroot_lib: add arm64-generic prebuilt fallback for arm64 2020-08-14 mikenichols@chromium.org chromeos_config: Move the oldest branch to trigger only from uprev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ic130b52bd20a44f4b15ddebbfddec5043a1440c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360250Reviewed-by:
-
Daniel Rubery authored
This CL changes the ChromeBrowsingDataRemoverDelegate to use a per- profile network context when clearing the Safe Browsing cookie, since that cookie will be profile-scoped, going forward. Bug: 1049833 Change-Id: Ifa09b8b89dc36efa37705223369f3fac162977d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357425Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#798694}
-
Jun Mukai authored
This test is failing due to the same reason we discussed at crbug.com/1115622, test scenario fails to load important data because the test running environment is missing the data files. Until resolved, this test should be disabled here, otherwise further ChromeOS LKGM update will be blocked. Bug: 1115622 Test: none Change-Id: I56ea90e2cb39ccc164145ac108bbcddebbbce2b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360271Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#798693}
-
Victor Costan authored
BookmarkExpandedStateTrackerTest passes an empty path into BookmarkModel::Load(), which causes the loader to look for a "Bookmarks" file in the current directory. Asides from the attached issue, this means the test behavior may change if the current directory does happen to have a "Bookmarks" file. This CL adds a base::ScopedTempDir to the test, making it not depend on the current directory. Bug: 1116809 Change-Id: I18db1ffdbdb2ae29aa17fef8920dde1ba8638f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359389 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Robert Ma authored
And remove unused mojom.js files. Bug: 1094512 Change-Id: Ibe8503d72fff30b96248c14647b65481c06c7b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350482 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#798691}
-
Henrique Nakashima authored
Need some arbitrary defaults to showcase the tool instead of an empty canvas. Bug: 1111056 Change-Id: Iaf5ba899a8223114c08acac5bbd5f7a728e2c2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357755Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#798690}
-
Joe Mason authored
Use a sorted vector and lower_bound instead of flat_map to associate frame tokens with V8PerFrameMemory results, since flat_map's erase is O(N). This turns an accidental O(N^2) loop into the expected O(NlogN), without allocating any extra memory for helper structs. R=chrisha Bug: 1080672 Change-Id: I69057aa27c8e647bcc1a6967de62c81f0d9af82b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335802 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#798689}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c2bd4cfa7063..4c7d5ed732ae 2020-08-17 patrick.brosset@microsoft.com Layout: Remove the Grid Border setting from the layout pane If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1116367 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1d00866c8847c796b2928401992646bc0a00e51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360214Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/22e7f7a0d7d7..699711c7e3cd 2020-08-17 fmayer@google.com Do not mix up callstacks in pprof output. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:164995430 Tbr: perfetto-bugs@google.com Change-Id: I543712d542a2c36d4ee878e69af8c862515ba628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360251Reviewed-by:
-
Alexander Dunaev authored
This CL completes the cleanup started in [1]. No changes to any behaviour are intented. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2352803 Bug: 1105892 Change-Id: Ieb2fe38fb54339d7a24e3ced6c30aea9991e1701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352897Reviewed-by:
-
Azeem Arshad authored
This CL adds ESimManager class and mojo interface. ESimManager communicates with Hermes, the ChromeOS eSIM LPA daemon, to provide eSIM management methods over mojo. See http://go/cros-esim-design-doc for details. An in-process instance of ESimManager is owned in Ash in the same way as network_config service. Bug: 1093185 Change-Id: I444ae644d020c7df7eea68025d1cb479cdec7c11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315925 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#798685}
-
James Long authored
In the physics simulation, "phantom" nodes have been added approximately where node label text will be rendered. Longer labels consist of more phantom nodes. These phantom nodes do not appear in the final visualization, but emit a weak repulsive force in order to help prevent node labels from overlapping with each other. Bug: 1109275 Change-Id: I59a941a89298d2937c368263c81feb16fffd692a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357631 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
-
dizg authored
in the profile creation flow Bug: 1115056 Change-Id: If6daa52923e55c775a3a5067e701d591e3ed700a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352737 Commit-Queue: Diana Zagidullina <dizg@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#798683}
-
Xiaoqian Dai authored
The spec was wrong before. Now update the two colors according to the corrected spec. Bug: 972162 Change-Id: I898c33b186af5d8543c2516eb44db85c504aae48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354726Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#798682}
-
Mason Freed authored
These tests describe new behavior for <select> with appearance: button, which Chromium does not (yet?) implement. Bug: 1108797 Change-Id: I9f8d9bd653754945eead4a4e8ddc2a3930f1b295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357130 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#798681}
-
Luke Zielinski authored
This will skip the various metadata .ini files that are currently checked-in upstream (like for infrastructure tests). It will also avoid exporting any chromium-specific metadata.ini files that we create in the near future. Bug: 1116091 Change-Id: I69389cd8410416d9b0e58789edb3bac84a886397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354517 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#798680}
-
Jonathan Ross authored
In vulkan_content_browsertests the newly added BackForwardCacheBrowserTest.ReplacedNavigationEntry is timing out consistently. This updates the filter to skip that test until the root cause can be addressed. TBR=backer@chromium.org TEST=BackForwardCacheBrowserTest.ReplacedNavigationEntry vulkan_content_browsertests Change-Id: I64aec31540e6db0af257d858dfa585d1d10a02a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358893Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#798679}
-
Jonathan Mengedoht authored
Integrate the WellKnownChangePasswordState in the WellKnownChangePasswordNavigationThrottle. Bug: 927473 Change-Id: I376d9f51cf3c06d253aaa28c692e0fcca58e0be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346424 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#798678}
-
Yuki Shiino authored
It looks that the issue is already resolved and we can enable Dromaeo perf again. The following pinpoint job succeeded. https://pinpoint-dot-chromeperf.appspot.com/job/1274d41e920000 Bug: 984578 Change-Id: Icb7c3573842ac40a8764205e2803273d96c4a9e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360055Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#798677}
-
Ian Wells authored
This change makes it possible to stop capabilities from being added to feed requests by setting "enable_CAPABILITY_NAME = false" to InterestFeedV2's Finch config. Note that "enable_... = true" has no effect. Bug: 1044139 Change-Id: I5a5122affa355d4d30d15b9004554c64b7777d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357449 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#798676}
-
sczs authored
Adds specificProductData dictionary to UserFeedbackProvider, this is needed in order to send card data as part of sending user feedback. This is transparent and its show in the UI along the other product specific data the user is sending. Screenshot: https://drive.google.com/file/d/1Js0zW7-tNZwAPtfZRvI24OwuUSeab-8N/view?usp=sharing Bug: 1085419 Change-Id: I716345b61f87c78c7ebbfc7ce07479b84f93bde5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358482Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#798675}
-
Philip Jägenstedt authored
There were harness errors in Edge, Firefox and Safari: https://wpt.fyi/results/html/canvas/element/manual/wide-gamut-canvas/canvas-createImageBitmap-e_srgb.html?run_id=657990001&run_id=659880001&run_id=633480001&run_id=663850001 The cause for that was the convertToBlob call not correctly wrapped in a step in testCreateImageBitmapFromColorManagedBlob. That was only the first of multiple errors fixed here: - not handling image or video decode failures, causing timeouts - failures at the end of testCreateImageBitmapFromColorManagedBlob would not have failed the test because promise rejections were not handled - failing in cryptic ways if ImageData dataUnion isn't supported These issues were fixed while also modernizing the tests to use more modern APIs where available, like img.decode() and fetch(). Change-Id: Ia8d0086a2d216dd291c9429460f8a79f8f4fd1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359991Reviewed-by:
Wan-Teh Chang <wtc@google.com> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#798674}
-
Jose Dapena Paz authored
This fixes this build error: ./../components/payments/core/android_app_description.h:51:20: error: ‘unique_ptr’ is not a member of ‘std’ 51 | std::vector<std::unique_ptr<AndroidActivityDescription>> activities; | ^~~~~~~~~~ Bug: 957519 Change-Id: I63cd3c3caa743c5b8a8ec0d91706d8655a1bbea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360080Reviewed-by:Sahel Sharify <sahel@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#798673}
-
Jose Dapena Paz authored
Fix the error found compiling with libstdc++: ../../chrome/browser/policy/messaging_layer/public/report_client.cc:174:38: required from here /usr/include/c++/9/bits/stl_vector.h:398:66: error: static assertion failed: std::vector must have a non-const, non-volatile value_type Bug: 957519 Change-Id: I8b8a306d841636882c7563edf9cdfc58464bc545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358737Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#798672}
-
Yunke Zhou authored
Bug: 1101318 Change-Id: I47864f53018fb7b6ca1fd675953247a6dadc1f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352824Reviewed-by:
-
Dan Harrington authored
Bug: 1116919 Change-Id: I96bd5bd3e69433639550d997847d6a2bf0540744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360231 Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#798670}
-
Xianzhu Wang authored
This reverts commit c5c632e5. Reason for revert: Revert the temporary CL after several canary builds. Original change's description: > Temporarily disable composited scrolling optimization for css-clip/clip-path > > This is to evaluate the performance improvement of the optimization in > 1 or 2 canary builds. Will revert after that. > > This disables the optimization for composited scrolling added in > crrev.com/774232. > > Bug 1113269 > > Change-Id: I2cf85fd5e550c1fef7d29f76b90e5d1b7219d579 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353066 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797532} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: If867168bea1f3adbe2b5e23d80b19377763db027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359367Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798669}
-
