- 29 Jan, 2019 38 commits
-
-
Daniel Rubery authored
In preparation for pinging on unknown file types, start tracking the most common known safe file types. This is a no-op (except for some metrics) since the files used to fall into the default case, which is SAMPLED_PING. Bug: 918991 Change-Id: I7f599bae29f6bb4b2a9e3fc6033c890c26c97861 Reviewed-on: https://chromium-review.googlesource.com/c/1440911Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#626828}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/556d7714fda3..eae881c2a8ba git log 556d7714fda3..eae881c2a8ba --date=short --no-merges --format='%ad %ae %s' 2019-01-28 lakshmana@google.com Add APIs to cros interface and cros platform backend class. 2019-01-28 benjhayden@chromium.org Add api handler to assign alerts to existing bug. Created with: gclient setdep -r src/third_party/catapult@eae881c2a8ba The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193 TBR=sullivan@chromium.org Change-Id: I3d01173ac5457d5c4911a7491041c3cb58ad7609 Reviewed-on: https://chromium-review.googlesource.com/c/1440747Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626827}
-
Luciano Pacheco authored
Fix moving files/folders to MyFiles: it was failing because it was passing VolumeEntry to |moveTo| API, so unwrap to get the native Entry before passing to this API. Fix test to use "cut" command for moving files because this is the right name for "move" so the final "paste" works. Change DirectoryTree to add attribute volume-type-icon for MyFiles to be able to use the same testing helper |selectVolume|. Once we remove the MyFilesVolume flag we can remove this thus the TODO. Change transfer tests to ignore file size and modified time when comparing files in the file list, because LinuxFiles and PlayFiles don't work for these properties. Also fix a problem in waitForFiles which was mutating the expected value. In many cases that's a global variable and was interfering with subsequent tests. Bug: 925175 Change-Id: I13a12191491a648867d6d28cae09143da86763a7 Reviewed-on: https://chromium-review.googlesource.com/c/1436468 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#626826}
-
Daniel Rubery authored
With one exception, we now pass: gn check //chrome/browser/safe_browsing/* The exception is that the advanced_protection target depends on //chrome/browser, but explicitly declaring that creates a new circular dependency. This will be fixed by future refactoring work. Change-Id: I8966e877a699444417d45980068e4a9d04ff2cb3 Reviewed-on: https://chromium-review.googlesource.com/c/1439963 Commit-Queue: Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
-
Steven Bennetts authored
The test relies on the size of fullscreen windows matching the screen size immediately after creation which is not reliable with the WindowService. TBR=benwells@chromium.org Bug: 926007 Change-Id: I164c184dfbae6b3e6d5a7beaa7789ce73fb382de Reviewed-on: https://chromium-review.googlesource.com/c/1441271 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#626824}
-
Victor Costan authored
test: Replace _TEST_CASE_ with _TEST_SUITE_ in /content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc. Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=chfremer@chromium.org Bug: 925652 Change-Id: I706bb529e302b1b61058ebe75a12af794b75b29c Reviewed-on: https://chromium-review.googlesource.com/c/1438264Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#626823}
-
Bret Sepulveda authored
To support Tab-shaped group headers, this patch moves Tab's instance of GlowHoverController into TabStyle to share it with the new View (coming in a later patch). Bug: 905491 Change-Id: I679ddccd77840b25a09c871a132afee390116295 Reviewed-on: https://chromium-review.googlesource.com/c/1423338Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
-
Avery Musbach authored
On entering tablet mode, recently added functionality uses split view to represent windows that were snapped in desktop mode, but it does not work well with ARC. The ARC window is neither maximized nor involved in split view. As a temporary solution, it shall be maximized. Test: TabletModeControllerTest.StartTablet*Arc* Bug: 922282 Change-Id: I5246be23ad7f1f742a84ee44335007186a96b014 Reviewed-on: https://chromium-review.googlesource.com/c/1435437Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#626821}
-
Jamie Madill authored
deqp/data/gles2/shaders/swizzles.html is running out of memory objects. Bug: angleproject:3111 Change-Id: I664ca6ad75cb136e3ac570855621ce4c6b24f6d4 Tbr: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1440721Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#626820}
-
Suman Nelson Kancherla authored
Change-Id: I5a6ca3c1ace3b1d743cf63e6aec034ccbc950f10 Reviewed-on: https://chromium-review.googlesource.com/c/1440727Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Cr-Commit-Position: refs/heads/master@{#626819}
-
Christopher Cameron authored
Create an infinite loop of once-per-day PostDelayedTasks. This fixes the following bugs that happen if a PostDelayedTask has been posted but no PostDelayedTasks remain: - Menu items remain hilighted after selection via hotkeys. - Menu doesn't show up in fullscreen when mouse moves to the top of the screen. - NSAlerts don't show up. Because it came up during investigation, and while we're in the neighborhood, ensure that we are precise about when our NSApplication is created and what subclass it has. Bug: 920795 Change-Id: I45772bd8cf65899e27ce22a0787db5be454b81be Reviewed-on: https://chromium-review.googlesource.com/c/1440662 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#626818}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=ajwong@chromium.org Bug: 925652 Change-Id: I05cd3be7a5c92083522f9c774665483f9d7cbaf8 Reviewed-on: https://chromium-review.googlesource.com/c/1438375 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#626817}
-
Matt Reynolds authored
The previous HID report descriptor parser was designed to only extract the maximum size of each type of report and did not preserve information about the individual fields within a report. This CL adds a new parser that builds a hierarchical representation of the reports supported by the HID device. BUG=890096 Change-Id: I4ac3bf883a843bec00576bfad78958d42f53abc7 Reviewed-on: https://chromium-review.googlesource.com/c/1257897 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#626816}
-
Michael Spang authored
Add explicit runtime dependencies on runtime libraries so that they don't need special handling at packaging time. Bug: 925040 Change-Id: I520d4638a1bf9e00b75b0f83c1ea9c456665c01e Reviewed-on: https://chromium-review.googlesource.com/c/1435535Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#626815}
-
CJ DiMeglio authored
This CL removes entires in media_control_element_type.h that do not actually provide strings for aria. This a part of the effort to get rid of this file completely. Bug: 836549 Change-Id: Ie701dc11007f5b04b8ddcdc5367b11c6ab1de23a Reviewed-on: https://chromium-review.googlesource.com/c/1437836 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#626814}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d403a66dc72a..2900d34d5975 git log d403a66dc72a..2900d34d5975 --date=short --no-merges --format='%ad %ae %s' 2019-01-28 saklein@chromium.org build api: Local protobuf version warning 2019-01-28 khmel@google.com chrome_update_extension_cache: use Json user type filter for default app. 2019-01-28 ahassani@chromium.org paygen: Add an unofficial signer 2019-01-28 saklein@chromium.org build api: add autotest HW Test tarball endpoint 2019-01-28 evanhernandez@chromium.org cros branch: Implement local rename. 2019-01-28 evanhernandez@chromium.org cros branch: Bump branch version. Created with: gclient setdep -r src/third_party/chromite@2900d34d5975 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7b831004791e2d6f2ca251d8a9bcf8df55612e2a Reviewed-on: https://chromium-review.googlesource.com/c/1440744Reviewed-by:
-
Vladimir Levin authored
This reverts commit 544bd17c. In other words it relands the updateAndCommit() functionality with a fix to not change the used budget. The accidental change to the strict yielding budget revealed a use-after-free bug, which is being fixed in a separate patch. The original updateAndCommit() description: """ This patch adds updateAndCommit() which updates the subtree cooperatively and then commits. """ R=chrishtr@chromium.org Bug: 882663 Change-Id: Ib62989ee51cd7da143d2f81a9ba674659365a20e Reviewed-on: https://chromium-review.googlesource.com/c/1440830Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#626812}
-
Stephen Chenney authored
The bulk of the uncaptured main frame time metrics are due to input handling and JS callbacks for rAF. This patch add metrics for those and cleans up the signalling for main frame start. There's a lot of plumbing here but I tried to go only as deep as necessary to access the LocalFrameView. Some metrics will change due to this patch. For example, we will now include lifecycle update times induced by hit testing for event handling. Manually verified that metrics are emitted for the new categories. Bug: 869966 Change-Id: Ic569b4ad9871c47147bac94bcdea14fa94d691be Reviewed-on: https://chromium-review.googlesource.com/c/1407629 Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#626811}
-
Caleb Rouleau authored
This reverts commit 4aec08a8. Reland changes: Base to patchset 1 is the original commit. patchset 2 fixes passthrough_command_buffer_perftests and validating_command_buffer_perftests patchset 3 fixes angle_perftests I checked base_perftests, gpu_perftests, media_perftests, tracing_perftests, net_perftests, and load_library_perf_tests, and performance_browser_tests, and they only run on chromium.perf, so I didn't change them. components_perftests and views_perftests and vr_common_perftests were already fixed. I checked for functional tests of these by running src/testing/buildbot$ grep views_perftests . -r -C 4 , etc for other isolate names. BUG=925750, 920002, 739863, 757933 TBR=jbudorick@chromium.org TBR reason: reland. Code mostly already reviewed. Change-Id: I08b658d48806187d2ad78ffc9f30e67e55a00b4e Reviewed-on: https://chromium-review.googlesource.com/c/1440242Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4c94788c9c85..0f073667daf0 git log 4c94788c9c85..0f073667daf0 --date=short --no-merges --format='%ad %ae %s' 2019-01-28 jmadill@chromium.org Update docs on wrangling and standalone infra. 2019-01-28 syoussefi@chromium.org Add possibility to track GPU time in perf tests Created with: gclient setdep -r src/third_party/angle@0f073667daf0 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I1dd61fd17aea80b6d5b7037855beee046a6ce228 Reviewed-on: https://chromium-review.googlesource.com/c/1440743Reviewed-by:
-
Jacob Dufault authored
Eliminate unnecessary heap allocations and make it easier to reuse in a different test base. Bug: 912704 Change-Id: I5bd5fcfcb568d77645a0a7c988953db39689d716 Reviewed-on: https://chromium-review.googlesource.com/c/1366303 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#626808}
-
Mitsuru Oshima authored
in OverviewSession::OnKeyEvent Bug: 925878 Test: covered by unittest Change-Id: I712acfcc7127e86e30d5d1be3ef8f86831c12368 Reviewed-on: https://chromium-review.googlesource.com/c/1440913Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#626807}
-
Wez authored
The ZX_VM_FLAG_PERM_* names have been deprecated in favour of the ZX_VM_PERM_* form, and will shortly be removed from the Fuchsia SDK. Bug: 925597 Change-Id: I61d69877f5af352294669d5ca87d9b4841e03440 Reviewed-on: https://chromium-review.googlesource.com/c/1437998Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Katie D authored
No behavior change if they are not both available. Test: Tested with espeak and Chrome OS built-in TTS engine. For the latter, tested both with and without plumbing word start indexes (cl/204334646) Bug: 815378 Change-Id: I3ad931c6bce6acbf8d76e7272741d7dc07ee9278 Reviewed-on: https://chromium-review.googlesource.com/c/1385846 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=ajwong@chromium.org Bug: 925652 Change-Id: Ic9a957ef55bb0c89f51783af0ad375e2d1d020c7 Reviewed-on: https://chromium-review.googlesource.com/c/1438406 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
-
Victor Costan authored
test: Replace _TEST_CASE_ with _TEST_SUITE_ in /gpu/ipc/common/gpu_memory_buffer_impl_io_surface_unittest.cc. Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=dcastagna@chromium.org Bug: 925652 Change-Id: I42aa840b81b1c944a02cdeee94408f03aacf6a4c Reviewed-on: https://chromium-review.googlesource.com/c/1438336 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
-
Ken Rockot authored
JSON manifests are deprecated. This also converts the test_ws manifest, as it and ash were the last remaining uses of service_manifest() GN rules' support for packaged services. Bug: 895616 Change-Id: I3bd329e4536bc7356e49977299e19944babb77b7 Reviewed-on: https://chromium-review.googlesource.com/c/1437707 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#626802}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/39cd98cedd91..a482e1f9802d git log 39cd98cedd91..a482e1f9802d --date=short --no-merges --format='%ad %ae %s' 2019-01-28 tsepez@chromium.org Remove unreachable null checks for CXFA_Document::GetScriptContext(). 2019-01-28 tsepez@chromium.org Remove unused gs_XFADefaultFreeData 2019-01-28 thestig@chromium.org Updated libtiff from 4.0.9 to 4.0.10. 2019-01-28 thestig@chromium.org Remove unreachable CJBig2_Context code. 2019-01-28 thestig@chromium.org Remove a parameter from CBC_OneDimWriter::RenderVerticalBars(). 2019-01-28 thestig@chromium.org Fix nits in CCodec_JpegModule. Created with: gclient setdep -r src/third_party/pdfium@a482e1f9802d The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5448bf4e0444a16160d12340fd5719a215c578c5 Reviewed-on: https://chromium-review.googlesource.com/c/1440745Reviewed-by:
-
Melissa Zhang authored
This CL implements the App Service SetPermission method. BUG=916380 Change-Id: Ib2e0f2e199da0c4c060a27055401e0cf803cbe3b Reviewed-on: https://chromium-review.googlesource.com/c/1436781Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Commit-Queue: Melissa Zhang <melzhang@google.com> Cr-Commit-Position: refs/heads/master@{#626800}
-
Khushal authored
The notable changes from using the updated ABI are the use of read fences returned by the framework to synchronize release of resources in transaction acks. The current code has some shortcomings in terms of potentially reading the media buffers from GL (display compositor) and/or the framework (system compositor). We currently always bind every new buffer to a texture with an EGL fence wait, which is unnecessary if the buffer will be passed to the system compositor. On the other end, we always and only generate a read fence from GL that the AImageReader_deleteasync uses if the current image has no external refs when a new image is acquired. Ideally we should wait on read fences from GL and the framework if the buffer was read by both (possible since the overlay decision could change every frame), and only generate a read fence from GL if the buffer was used by the display compositor. All the above fence synchronization is meant to be correctly handled using SharedImages, which can handle a buffer being imported by different consumers and generating/synchronizing read fences bases on which API the buffer is read by. Ensuring that these cases are handled correctly is left until media is switched to Shared Images. TBR=nyquist@chromium.org R=liberato@chromium.org, piman@chromium.org Bug: 889328 Change-Id: Ic9f49420540249c06943fd62f6fcba8830c6ccac Reviewed-on: https://chromium-review.googlesource.com/c/1434918 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#626799}
-
Jacob Dufault authored
Some methods had only one caller so inline them directly. Bug: 897226 Change-Id: I654162372223e743adb1d3459c6821f05be821ce Reviewed-on: https://chromium-review.googlesource.com/c/1347042 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
-
Yulun Wu authored
Bug: 881624 Change-Id: Ic2efd91bbccc891f98c5e5e7563996cd8fd138cc Reviewed-on: https://chromium-review.googlesource.com/c/1440069Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#626797}
-
Allen Webb authored
This simplifies tests and upstart scripts that check if features are enabled. BUG=chromium:915754 Change-Id: I35b5d1fb91a55dbde3e540a3d1dd8321dd12335a Reviewed-on: https://chromium-review.googlesource.com/c/1440125Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Allen Webb <allenwebb@google.com> Cr-Commit-Position: refs/heads/master@{#626796}
-
John Abd-El-Malek authored
This reverts commit 6296e827. Reason for revert: don't need this data anymore. Original change's description: > URLLoader: add debug info to catch a leak again. > > This time with a DumpWithoutCrashing > > Bug: 901405 > Change-Id: Ie2a075afe384e3dc13fde076a558d5d90591ab92 > Reviewed-on: https://chromium-review.googlesource.com/c/1330076 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606987} TBR=jam@chromium.org,morlovich@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 901405 Change-Id: I82f5d55758a82a15072ee42b335071da36785521 Reviewed-on: https://chromium-review.googlesource.com/c/1440505Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#626795}
-
Doug Turner authored
Bug=None Change-Id: Iba56025ce9ba723b9304520059c5ca9ccb0ede89 Reviewed-on: https://chromium-review.googlesource.com/c/1436206Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
-
Weidong Guo authored
Remove the flag since it is enabled for more than two milestones. Bug: 774795 Change-Id: I1c3bf8d13bf6a2578bf80bf859a79df64ac61808 Reviewed-on: https://chromium-review.googlesource.com/c/1437518 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
The missing null check caused a crash when there were rem units in use and the root element display changed to 'none'. Bug: 925844 Change-Id: Ia83f8e4e43779fabf621f72e2fa3d9a07d9c6d83 Reviewed-on: https://chromium-review.googlesource.com/c/1440781 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Auto-Submit: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#626792}
-
Xiaocheng Hu authored
Bug: 894651 Change-Id: I6810720e90876b80197bb2491d14a612012279da Reviewed-on: https://chromium-review.googlesource.com/c/1440467 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
- 28 Jan, 2019 2 commits
-
-
Xiaocheng Hu authored
The function is a general function for probing NGInlineItemsData. Hence, this patch moves it to NGInlineItemsData, where it better resides. This patch follows from kojii's comments in crrev.com/c/1436486 Bug: 894651 Change-Id: Icdc625c0dbddb219d484e987f4ea02076045a4c8 Reviewed-on: https://chromium-review.googlesource.com/c/1440501 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
David Tseng authored
This reverts commit 1367a8cc. Reason for revert: <INSERT REASONING HERE> Rolled back upstream. Original change's description: > Remove duplicate bluetooth_private externs from chrome_extensions.js > > Change-Id: I7ac749bfa0115479b133e9e9f53390b9ebf4022a > Reviewed-on: https://chromium-review.googlesource.com/c/1435114 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#626318} TBR=dtseng@chromium.org,rdevlin.cronin@chromium.org,devlin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I7463eb309c1c63926743c51189abe2df9f10f361 Reviewed-on: https://chromium-review.googlesource.com/c/1440511Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#626789}
-
