GitLab

This fixes the following error in components builds on chromecast:

ld.lld: error: undefined symbol: media::mojom::kMediaRendererServiceName
>>> referenced by shell_content_browser_client.cc:301 (../../content/shell/browser/shell_content_browser_client.cc:301)
>>>               content_shell_lib/shell_content_browser_client.o:(content::ShellContentBrowserClient::RunServiceInstance(service_manager::Identity const&, mojo::PendingReceiver<service_manager::mojom::Service>*)) in archive obj/content/shell/libcontent_shell_lib.a
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Change-Id: I4fa28fead6e003b1bfc9fe0448c53acf56864b6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874331Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708680}

Starts from Android O MR1, Android code may resize the large icon. We
don't need to check equality on the large icon bitmap.

Bug: 999357
Change-Id: I65f38a0fb120608ea9d23611f6e93db5ec674bc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864385Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708679}

Ports ash usage of the Data Decoder service to use the service interface
directly rather than going through a Service Manager Connector.

Bug: 977637
Change-Id: I3cf24b34ab0eeff6665055b5add7fb1d90c591bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872918Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#708678}

This is an implementation of CryptAuthV2DeviceManager used for tests.
It queues DeviceSync requests made via ForceDeviceSyncNow(). These
requests are sequentially processed by calls to
FinishNextForcedDeviceSync(), which also updates parameters such as
the last DeviceSync time.

Bug: 951969
Change-Id: I964425fcab12a25d58082f882d344146f324bacf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874196Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708677}

With the new parser in place, FormData should be used to check empty
fields instead of PasswordForm

Change-Id: I8242cc82524d14de4a82c2ffde6d8c059c7d3ee2
Bug: 949519,1017129, 1008798
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849894
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708676}

The tests were flaky because of inconsistent forcus status.

Change-Id: Idb494efcc489a441446c4a9b12968cde86faf8e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872991Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708675}

This change adds different types with which CookieAccessDelegateImpl
can be constructed. One type, USE_CONTENT_SETTINGS is the default
behavior of checking the CookieSettings to determine whether a given
cookie is Legacy or Nonlegacy. The other type, ALWAYS_LEGACY, always
returns Legacy access semantics for every cookie.

The ALWAYS_LEGACY type of CookieAccessDelegate is used for Android
WebView, for compatibility reasons. (The SameSite cookie changes would
break too much stuff, so we treat every cookie as Legacy to maintain
compatibility.)

Bug: 986319
Change-Id: I68384da121b025525da5fd2ef6f9dff25a8a2ff5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872782Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708674}

The method is only used in tests, so move the implementation to the
test suites that need it.

Bug: none
Change-Id: I5dbdca6a56e4d753a85e3bba4ea816fe215eb749
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875027
Commit-Queue: James Cook <jamescook@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708673}

In this patch:
- add skeleton classes such as UrlCheckerDelegateImpl, UI manager,
- add safebrowsing for weblayer feature,
- add safebrowsing throttle,
- add build configs, deps and owners files.

In the skeleton classes most methods are not implemented yet and
will be implemented where necessary in further CLs. Also proper
init sequence will be implemented separately.

BUG=1015418

Change-Id: I80a9a40b18204e760289c7f01a48c69370f6d7c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866832
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708672}

This reverts commit d3d72b4f.

Reason for revert: crbug/1017263

Original change's description:
> Fix cmd+w closing the browser window instead of just the dictionary popover.
> 
> It's been said before and will be said again: keyboard event handling in
> Chrome is a monster. Several things came together to make this happen:
> 
> First, in most Mac apps, cmd+w closes the dictionary popover if it's
> visible. This specifically happens through the `performClose:` action
> sent by the main menu. But, in Chrome, cmd+w closes the tab and not the
> window, so cmd+w sends a different action. This meant that cmd+w
> originally closed the tab and left the dictionary popover floating. This
> was fixed many years ago (see r118131 and r322075) by making
> `-[AppController menuNeedsUpdate:]` check the current target of
> `performClose:` and only map cmd+w to "close tab" when the target is a
> browser window.
> 
> This would work but for another layer of keyboard shortcut handling
> trickery. For a number of reasons (see comment beginning "If this
> keyEquivalent" added in r565490), Chrome doesn't actually let
> `NSMenuItem`s send their own actions. Instead,
> ChromeCommandDispatcherDelegate determines which menu item *would* have
> been targeted by a given event, then handles the event itself.
> 
> The end result is that, when the dictionary popover is visible, the menu
> items are successfully remapped so that cmd+w means "Close Window". But,
> any actual cmd+w event is grabbed by ChromeCommandDispatcherDelegate and
> sent directly to Chrome's own keyboard shortcut handling… so the browser
> window closes.
> 
> This change adds a check that was proposed back in r322075, and makes
> ChromeCommandDispatcherDelegate only grab the event when the found menu
> item's action would be sent to its own window.
> 
> Bug: 947752
> Change-Id: Ib32988d5fb69c79f899069feb02f7529ea05225f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849431
> Commit-Queue: Sidney San Martín <sdy@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#705275}

TBR=avi@chromium.org,sdy@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 947752
Change-Id: I4d2aef624e111d4e14c4a0d36e7f6a08f2fa08cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876690Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708671}

This is a reland of 3a9215b3

DevTools tests are slow and need to be marked as such, including adding
Timeout as an expected result to fix the fails/flakiness on WebKit Linux
MSAN.

Original change's description:
> Adapt isolated-code-cache web tests to partitioned HTTP Cache
>
> The not-site-per-process isolated-code-cache web tests currently assume
> that cross-origin resources are cached when code cache site isolation is
> not active. This causes them to fail when the HTTP Cache is partitioned
> by Network Isolation Key. We thus disable the partitioned HTTP Cache for
> those tests and add a new test for when site isolation is not active,
> but the HTTP Cache is still partitioned.
>
> Bug: 1009628
> Change-Id: I0d5d438d9564d3f659b93484a5bcc8aa56d2cd26
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865421
> Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Alex Turner <alexmt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#707360}

Bug: 1009628
Change-Id: I28a0df6d2751f7ac0463d9cb03c488e70ebe034e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873109Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708670}

R=dmazzoni,meredithl

Change-Id: I96a67a64371aec7e005429eda668223fd12ab02f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874409
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708669}

This only affects debug builds.

Turns a console error like

  FATAL:web_ui_data_source_impl.cc(296)] Check failed:
      resource_id != -1 (-1 vs. -1)

into something a like

  FATAL:web_ui_data_source_impl.cc(296)] Check failed:
      resource_id != -1 (-1 vs. -1) for assets/02_west.png

Change-Id: Iac2ffb57ef7fe734b165edabb1cc2ddd00660f14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874748
Auto-Submit: Trent Apted <tapted@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708668}

Bug: chromedriver:3179
Change-Id: If5d9ad3884411d7c42307793d28e88ccd33538e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874243Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708667}

Bug: 944625
Change-Id: Iccee30e7a2da35fc22ee895cf59dc129c0e8298f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865592
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708666}

Bug: 965089
Change-Id: Ib2161502c7e5c2a6051c66b43b911f2f9fdd7115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874688
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708665}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ie518520073986d8350b787f94d239f8759ca6776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875317Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#708664}

This change adds function GetUserDataSuffix(), which returns the install
suffix (e.g. "" for the primary install mode, " SxS", " Beta", or
" Dev") given a path in the User Data folder.

It is based on GetInstallSuffix(), which does the same given a path in
the Application folder.

This new function is the first part of finding the location of
chrome.exe from within the User Data directory, where Progressive Web
App (PWA) launchers are planned to be. The next step will be a function
that uses the install mode from FindInstallMode(GetUserDataSuffix()) to
get the full path of chrome.exe, which PWAs can then use to launch.

Change-Id: If69859fc5f36b7d2d2c4262a1955bd432d983597
Bug: 960245
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866977
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708663}

Bug: 984550, 860403
Change-Id: Id41142246f83fa05153e97b93bee8ffaf73215d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854185Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708662}

When serializing grid-template-rows/columns of a grid container, we need
to handle auto repeat() specially in order to insert the line names at
the correct places.

Before this patch, this was skipped for indices before the insertion
point of the auto repeat, and in case the auto repeat had no line name.
The latter logic was wrong, if there is an auto repeat we still need the
special code after the insertion point, even if it has no line names.
The proper condition to check is whether there is no auto repeat.

The patch also avoids a 2nd call to GridAutoRepeatRows/Columns since we
already have the value in a variable.

BUG=1011329

TEST=external/wpt/css/css-grid/parsing/grid-template-columns-computed-nogrid.html
TEST=external/wpt/css/css-grid/parsing/grid-template-columns-computed.html
TEST=external/wpt/css/css-grid/parsing/grid-template-rows-computed-nogrid.html
TEST=external/wpt/css/css-grid/parsing/grid-template-rows-computed-withcontent.html
TEST=external/wpt/css/css-grid/parsing/grid-template-rows-computed.html

There are some test failures because integer repeat() is still expanded
at computed-value time (http://crbug.com/989004).

Change-Id: I16d06275384ab8c7866b4981ba8dcc665258b29d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857125Reviewed-by: Manuel Rego <rego@igalia.com>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#708661}

I've received enough questions regarding led & chromium bots to warrant
a small doc, I think. This isn't meant to be a full overview of what's
possible with led, but might be a good starting point for someone that's
not familiar with it. (ie: The target audience is someone that's not very
familiar with our infra/bots.)

Change-Id: I629f3872aa5f0b2da0ec4821ba1befea47bdd3da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518458Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708660}

We are adding a very basic fuzzer architecture for canvas.
We are adding the seed_corpuses of all of the tests implemented for
canvas and inserting them blindly into the canvas_fuzzer.

A nice to_do would be to use the random input from the fuzzer to
guide a creation of a proper test for canvas related stuff only.

Change-Id: I79ae58ace3b9c2835367ab3d53153b8b8d11885d
Bug: 1016869
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865352
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708659}

When building Chromecast unit tests on a component build, I see link
errors like:

ld.lld: error: undefined symbol: mojo::StructTraits<bluetooth::mojom::UUIDDataView, WTF::String>::Read(bluetooth::mojom::UUIDDataView, WTF::String*)
>>> referenced by uuid.mojom-shared.h:129 (gen/device/bluetooth/public/mojom/uuid.mojom-shared.h:129)
>>>               obj/third_party/blink/public/mojom/web_bluetooth_mojo_bindings_blink/web_bluetooth.mojom-blink.o:(mojo::internal::Serializer<bluetooth::mojom::UUIDDataView, WTF::String>::Deserialize(bluetooth::mojom::internal::UUID_Data*, WTF::String*, mojo::internal::SerializationContext*))

This CL fixes those errors.

Change-Id: I2f9fabd66013c33461c76d5e6306c600569da9c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866626Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708658}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea58518db3b8..4900f195bb83


Created with:
  gclient setdep -r src-internal@4900f195bb83

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I43ef3c7b7ab8d4be04e2eca4fe5c64207ccdb8e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875315Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#708657}

This is to make sure that starting the proxy in UpgradeInstance()
will always succeed even after Chrome crashes and restarting.

Once b/142140355 is fixed, the proxy will detect Chrome crashes by
itself and exit, but in theory, the proxy may exit after restarted
Chrome calls UpgradeInstance(). This CL is to prevent the race.

BUG=b:143175381
TEST=kill Chrome, verify restarted Chrome can start ARCVM

Change-Id: Id408c6525f5b7a53d095ce36777a4300ec313cb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874788Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708656}

NigoriSyncBridgeImpl puts pending commit with keystore initialization
if it received default Nigori in MergeSyncData(). There is no guarantee
that this commit will be successfully processed before the browser
restart. The state is persisted regardless of commit completeness.

In old implementation, non-initialized state loaded from the storage
can't transit to initialized. The fix is to trigger keystore
initialization after loading the state.

Bug: 1016706, 922900
Change-Id: I8e38a1c9e925971b9023078fb28d561d3c1c538a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875753
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708655}

Bug: 1012629
Change-Id: Iac0c0492356159598055acf15ef27aad008bf43e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876351Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708654}

- Create InfobarSaveCardTableVC class and configures it on its Coordinator.
- Implements InfobarSaveCardTableVC Cancel button.
- Implements infobarModalHeightForWidth on InfobarSaveCardCoordinator,
this is using the same code as InfobarPasswordCoordinator for now. It might
be worth creating a util file that all subclassed Coordinators can use but
I want to make sure its really needed first.

Screenshot:
https://drive.google.com/open?id=1sNsb5OhfsgNOvom4OqvumJt7ChNwVVDG

Bug: 1014652
Change-Id: I704ee0c047b8bb12e58dfd0a45fdd8f6348131e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872769Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708653}

Use the max time any device feature was modified as the
CryptAuthDevice's last_update_time.

Bug: 990441, 951969
Change-Id: I96fd92611ddfb535070fa421bf78b1a77a64e655
Fixed: 990441
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865659
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708652}

Bug: 839343
Change-Id: I166ce93bd88f5e5939fe345259f6efd558459b8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872812
Auto-Submit: Lucas Gadani <lfg@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708651}

This CL is only renaming the methods

PasswordFormManager: :UpdateUsername()
PasswordFormManager: :UpdatePasswordValue()
Change-Id: I093cc06d994ee06af039af7e6202589b5fdda754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876412
Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708650}

Log tags are automatically prefixed with "cr_" by the logging system,
and may not contain dots as this often causes them to be stripped by
our log sanitizers. This is now checked by presubmit, but there were
many cases that predated the check.

Therefore:

- remove any "cr." and "cr_" prefixes from TAG values.
- replace any remaining dots in TAG values with underscores.

Change-Id: Ife8709d2b1631483bbacbed0babc54b7f6da3662
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873158
Auto-Submit: Richard Coles <torne@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708649}

TBR=sky@chromium.org

Bug: 1017206
Change-Id: I4a9524309a8d1452f9fd8af26ee143fbb07d7956
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876022Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708648}

Bug: 1016864
Change-Id: I285a3ff74b620b2d1ddc4800929094b25cb06178
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873962Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708647}

This CL fixes the issue in which the bottom toolbar covers
over the last row of tabs. This was caused by the inset not being
properly reset when rotating between portrait and landscape.

The TabGridBottomToolbar is smart about rotation changes. It
automatically adjusts it's intrinsicContentSize, so this does
not need to be adjusted by the TabGridViewController. The user
of TabGridBottomToolbar just needs to set insets to the
intrinsicContentSize given by TabGridBottomToolbar.

Bug: 1003768
Change-Id: Ib61039bf7d872ebe27d1971ba5848afafa643af0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874611Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708646}

They are moved from BrowserObserver to NavigationObserver

Bug: none
Change-Id: Ic84eb9be76e5f5018ea4da82331b3b982dcd8dde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831995
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708645}

https://android.googlesource.com/platform/external/perfetto.git/+log/3c660b0e0c31..0cdd39db4443

git log 3c660b0e0c31..0cdd39db4443 --date=short --no-merges --format='%ad %ae %s'
2019-10-23 lalitm@google.com Merge "perfetto: bump trace_processor and traceconv to faebe62"

Created with:
  gclient setdep -r src/third_party/perfetto@0cdd39db4443

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I569545d75974e8db27318af3c44468a90e40a38c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875313Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#708644}

Also perform an extra null check when the frame is converted to a
WebFrame.

Bug: 1017121
Change-Id: I2e85f8db9917076a6865b4411e69dc81230764c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876410Reviewed-by: Armando Miraglia <armax@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708643}

https://chromium.googlesource.com/angle/angle.git/+log/a9f11bf14bce..a1ed9d1a8492

git log a9f11bf14bce..a1ed9d1a8492 --date=short --no-merges --format='%ad %ae %s'
2019-10-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader a68a80a4dbf9..7738ed713e7b (6 commits)

Created with:
  gclient setdep -r src/third_party/angle@a1ed9d1a8492

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jonahr@google.com

Bug: None
Change-Id: Ibe146b2cb2333cfa10eb75f8a2485d220ccbf65d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876072Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#708642}

This adds compress="gzip" to:
* App Management in OS Settings
* Crostini installer
* Mobile setup page
* Guest session tab
* SMB share dialog
* Debugging UI: chrome://cryptohome, chrome://drive-internals

R=melzhang@google.com,lxj@google.com,khorimoto@chromium.org,baileyberro@chromium.org

Bug: 965089
Change-Id: I37ab9f9773216a8ea2172879f05643bf6c74d5ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874807Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Anand Mistry <amistry@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708641}