Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 09 Feb, 2019 29 commits
  3. 08 Feb, 2019 11 commits
    • Collin Baker's avatar
      Animate in-product help app menu button highlight · 07f47ea3
      Collin Baker authored 
      This implements an animated app menu button highlight when an
in-product help promo is showing. A custom InkDropMask is used.

Bug: 909755
Change-Id: Ib282525c8af1cdda416002641332164ba64942e5
Reviewed-on: https://chromium-review.googlesource.com/c/1450671
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: default avatarPeter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630552}
      07f47ea3
    • chromium-autoroll's avatar
      Roll src/third_party/angle f256339a1959..2b0553ce59c3 (2 commits) · cf3d5b9e
      chromium-autoroll authored 
      https://chromium.googlesource.com/angle/angle.git/+log/f256339a1959..2b0553ce59c3


git log f256339a1959..2b0553ce59c3 --date=short --no-merges --format='%ad %ae %s'
2019-02-08 jonahr@google.com Implement EXT_instanced_arrays
2019-02-08 jmadill@chromium.org Refine Ozone suppression.


Created with:
  gclient setdep -r src/third_party/angle@2b0553ce59c3

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I64dc2fdf02da599d30aadd5d0142fb79eb72573b
Reviewed-on: https://chromium-review.googlesource.com/c/1461456Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630551}
      cf3d5b9e
    • Karan Bhatia's avatar
      Revert "Picture-in-Picture: move key methods into a service." · 9a3eafe4
      Karan Bhatia authored 
      This reverts commit 45675d0d.

Reason for revert: Speculative revert for crbug.com/930338

Original change's description:
> Picture-in-Picture: move key methods into a service.
> 
> This is moving most of the Picture-in-Picture feature into a service.
> Follow-up CLs will move the remaining methods and some Android auto-pip
> code. It will also include further cleanups.
> 
> This CL was meant to be the smallest CL that could move the core feature
> set without breaking compilation or tests. It's larger than expected.
> 
> Bug: 919860, 908400
> Change-Id: I72c5faad9a14de6645a7cd1565b29d6a353e24a3
> Binary-Size: cause unknown, landing approved by agrieve@
> Reviewed-on: https://chromium-review.googlesource.com/c/1379049
> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#630361}

TBR=dcheng@chromium.org,dalecurtis@chromium.org,beaufort.francois@gmail.com,mlamouri@chromium.org,agrieve@chromium.org,jochen@chromium.org

Change-Id: I88efa31a23ab1c55b256e5813fa20fd2d8776a21
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 919860, 908400, 930338
Reviewed-on: https://chromium-review.googlesource.com/c/1461546Reviewed-by: default avatarKaran Bhatia <karandeepb@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630550}
      9a3eafe4
    • Xing Liu's avatar
      Enable NotificationIntentInterceptorTest on certain version of Android. · 067ac219
      Xing Liu authored 
      NotificationIntentInterceptorTest is flaky on kitkat, this CL enables
it on post Android K versions.

TBR=dtrainor@chromium.org, peter@chromium.org


Bug: 910870
Change-Id: I8643bee6718dc05e73e0f62f481e9150a0f38d75
Reviewed-on: https://chromium-review.googlesource.com/c/1459520Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630549}
      067ac219
    • Majid Valipour's avatar
      [animation-worklet] Basic pause implementation (reland) · 35c2a0c0
      Majid Valipour authored 
      Pausing worklet animation now holds the time. This works as expected for main
thread animations. Implementing this for composited worklet animations will be
done in a follow up patch.

Major changes:
 - Add and expose pause() method pausing the animation.
 - Introduce hold_time that is used when animation is paused.
 - Rework how current time is computed, it is now closer to
   regular animations i.e., we either compute it based on "start time and
   timeline.currentTime" or use "hold time".
 - Instead of setting start time we now set the current time
   which then works backward to compute either the start time or the hold time
   based on the animation state.
 - When transitioning animation play state, we now always set
   the current time. Previously this was adhoc and inconsistent.
 - Introduce has_started_ to differentiate when playing an
   animation for the first time vs playing it from pause.
 - Update playback_rate related calculation to use new logic.



Relanding: Original CL was reverted here [1]. Took the following steps to
address this:

  - Address flakiness in unit test by using more accurate error
    value matching other tests.
  - Fix flakiness in layout test (worklet-animation-pause.https.html)
    by using startTime and waiting for time to actually advance working around
    pre-existing animation clock issue [2]. Also got rid of an invalid state
    transition from pause->idle.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1434815
[2] http://crbug.com/785940

TEST:

  - wpt/animation-worklet/worklet-animation-pause.https.html: js test for basic
    current time calculations
  - wpt/animation-worklet/worklet-animation-pause-immediately.https.html:
    reftest for basic pause
  - wpt/animation-worklet/worklet-animation-pause-result.https.html: reftest for
    pause/resume.
  - WorkletAnimationTest.PausePlay: unit test for basic state
    transition and time calc

Bug: 821910,
Change-Id: I11fd2960443081be81055904d6d56a2abc3282f5
Reviewed-on: https://chromium-review.googlesource.com/c/1456640Reviewed-by: default avatarMajid Valipour <majidvp@chromium.org>
Reviewed-by: default avatarYi Gu <yigu@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630548}
      35c2a0c0
    • Danan S's avatar
      Record DemoMode.ActiveApp when ARC package name is delayed. · 545a25e8
      Danan S authored 
      Bug: 929570
Change-Id: I027130d4301bd9d3a6c2e19f5ac56d9600c16af2
Reviewed-on: https://chromium-review.googlesource.com/c/1457920Reviewed-by: default avatarDan Erat <derat@chromium.org>
Commit-Queue: Danan S <danan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630547}
      545a25e8
    • Jeff Fisher's avatar
      DevTools: Add DOMDebugger test · 9898212f
      Jeff Fisher authored 
      Adds a new test for DOMDebugger.setInstrumentationBreakpoint

Change-Id: Icb420733979c8ba3dad0aafd33b8c8cb744cae45
Reviewed-on: https://chromium-review.googlesource.com/c/1461340Reviewed-by: default avatarDmitry Gozman <dgozman@chromium.org>
Commit-Queue: Jeff Fisher <jeffish@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#630546}
      9898212f
    • Tibor Goldschwendt's avatar
      Fix detection of UI language, measure Chrome resumes in wrong language · 8806e8a4
      Tibor Goldschwendt authored 
      Having all translations for webview strings in the base module breaks
the use of current_detected_ui_locale_name as an indicator for the
current UI language. To fix this, move current_detected_ui_locale_name
into Chrome resources and, thus, prevent its translations being added
to base.

Furthermore, use the fixed current_detected_ui_locale_name to record
via UMA whether Chrome resumes in the wrong language. I.e. we support
the current system language but Chrome is not displayed in it. That can
happen if the user changes the language but the language split is not
installed in time.

Bug: 906082
Change-Id: I084220643e864329360463ef47e84e8632fc6f24
Reviewed-on: https://chromium-review.googlesource.com/c/1460176
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: default avatarJesse Doherty <jwd@chromium.org>
Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630545}
      8806e8a4
    • Khushal's avatar
      cc: Fix unnecessary additional damage to layer from pending tiles. · 72302d68
      Khushal authored 
      Once a tile is done rasterizing, we inform the layer associated with the
tile. In the case of pending layer tiles, no additional damage needs to
be added from this update, since it is already accounted for in the
invalidation on the pending layer which contributes to this layer's
overall damage. However, on the active tree, where this raster may be
for content previously checkerboarded and its update will be driven by
cc, we ensure that the damage from this update is added to this layer's
damage at this step. The complete tile's area is assumed to be damaged.

Currently LayerTreeHostImpl dispatches the notification for tile raster
complete to both the twin (active and pending) layers. This was creating
a scenario where when an update which partially invalidates a tile is
received on the pending tree, the notification for its raster finishing
was being processed by its active and pending layer. The active layer
would then damage the complete tile, and the frame damage would
unnecessarily include this full tile damage instead of the partial
invalidation receieved on the pending tree.

Fix the above by routing the tile raster finished notification to only
the layer that tile belongs to. Note that this means that if a pending
tile finishes after activation, we might still be doing additional
damage. But since we only activate after all visible content has been
rasterized, those pending tiles are likely not visible anyway.

R=danakj@chromium.org,enne@chromium.org

Change-Id: I721480af0d7ea3889ef1de2bd5bbee693062f671
Reviewed-on: https://chromium-review.googlesource.com/c/1460181Reviewed-by: default avatarenne <enne@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630544}
      72302d68
    • Vlad Tsyrklevich's avatar
      GWP-ASan: Silence unnecessary warnings · 3f3cd96d
      Vlad Tsyrklevich authored 
      When GWP-ASan is enabled with use_allocator_shim=false (e.g. Windows
component builds) it prints a diagnostic warning. Only enable GWP-ASan
if it can actually be initialized to avoid printing unnecessary
warnings.

This means we can't use enable_gwp_asan to enable running tests, as the
tests already test for use_allocator_shim=true when necessary.

Bug: 929878
Change-Id: I4a8aaaca80c0185fd1c5e07bd7692437665407d3
Reviewed-on: https://chromium-review.googlesource.com/c/1460192
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: default avatarVitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630543}
      3f3cd96d
    • Raul Tambre's avatar
      //testing: Convert base::(U)Int(64)ToString(16) to NumberToString(16) · 47dd9b1f
      Raul Tambre authored 
      The former non-overloaded variants are deprecated.
Removed casts where they are now unnecessary.

This is a mechanical change; there is no intended behavior change.

Bug: 929827
Change-Id: Ib064163c5cbdc2a1d596ec26457eb0f41e0d39c2
Reviewed-on: https://chromium-review.googlesource.com/c/1461129
Commit-Queue: Raul Tambre <raul@tambre.ee>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: default avatarJohn Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630542}
      47dd9b1f