- 31 Jul, 2020 40 commits
-
-
Clark DuVall authored
std::transform requires using something like std::back_inserter, and not just .begin() to insert items (unless the container is already sized correctly). std::transform is confusing, so better to just use a loop. Bug: 1111405 Change-Id: I68080feeff23cee86a71df19838972f3b9b9d511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329919 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#793510}
-
Sean McAllister authored
This migrates is_linux (which is also set for chromeos) to explicitly include chromeos as is_linux || is_chromeos in preparation for separating those flags. Bug: 1110266 Change-Id: I93991bfe0647a6b280b9fb9531474ae70f6c4cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325766 Commit-Queue: Sean McAllister <smcallis@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#793509}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bd3ffa43d23f..f8869a24e77e 2020-07-31 johnstiles@google.com Remove SK_REQUIRE_LOCAL_VAR macro. 2020-07-31 csmartdalton@google.com Rename GrTessellateStroke* -> GrStrokeTessellate* and friends 2020-07-31 reed@google.com Switch over to SkPathBuilder 2020-07-31 johnstiles@google.com Enable ClangTidy check performance-for-range-copy. 2020-07-31 csmartdalton@google.com Add view matrix support to tessellated stroking If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Ie4b867378bdd4b5dc4852847a1bec9bbeede9bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331278Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793508}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic82e64da670c7210a2ab11af8db02f05fa623b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331280Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793507}
-
Haiyang Pan authored
And disable the feature GLMDA for android-23. This is to support disabling or enabling certain features during AVD create. Command line option will invalidate the emulator snapshot and cause timeout when launching the emulator. Bug: 1093602, 1110997 Change-Id: Idbbb1b5f08dd64d663392f2a55e166d7dab91eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321088 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#793506}
-
Hiroshige Hayashizaki authored
Bug: 1111134 Change-Id: I8e53e4a642ca70937966b1d6ce056f6a8093491c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331397Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#793505}
-
Alan Cutter authored
This CL fixes the following warnings when running browser_tests: UninstantiatedParamaterizedTestSuite<ResourceLoadingHintsBrowserTestWithExperimentEnabled> UninstantiatedParamaterizedTestSuite<ResourceLoadingHintsBrowserTestWithExperimentDisabled> These tests were removed in: https://chromium-review.googlesource.com/c/chromium/src/+/2316835 Bug: 1045846 Change-Id: I1368bbb925ae8c213d2ba3a0bfed724e894cc6e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331251 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#793504}
-
Alan Cutter authored
This CL fixes the following warning in browser_tests on non Chrome OS: UninstantiatedParamaterizedTestSuite<SystemWebAppManagerUpgradeBrowserTest> Bug: 1045846 Change-Id: I26aff6a78626ad899237e62ef0eb1081a0d07bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331253 Commit-Queue: Alan Cutter <alancutter@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#793503}
-
Virender Singh authored
This change introduces the PPAPI structures required to send the focus information from plugin to PdfAccessibilityTree. Bug: 1015350 Change-Id: I5bfd78b6d34e2ebcf78d9051207fcbc830694678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230586Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Virender Singh <virens@microsoft.com> Cr-Commit-Position: refs/heads/master@{#793502}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/05863e62f3dc..fada50119020 2020-07-31 jiawei.shao@intel.com Metal: Add shader compilation error message to DAWN_VALIDATION_ERROR 2020-07-30 bryan.bernhart@intel.com D3D12: Dynamic shader-visible heap allocation. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ia6dbca06e2939cd1a891342ddef7df84928b2700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331271Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793501}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I06f032442ed7f2f09d02ef3fa9eaceb19a6011a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330874 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#793500}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596139195-1e6f24fe599857a5d76e1ba28ac7e9b1f562f5e8.profdata to chrome-win32-master-1596146232-f6e45641b67a67dc23d75883ed15404f325382fd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I93ef1dd00681608a44c011018b4f02f34348fd55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331273Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793499}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5a58acd2d744..f6c424bb5923 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I264f877ef8649c2e89121dc86b85d75267f7027e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331476Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793498}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e8c99cbbdd42..26d2e8aa289b 2020-07-31 fancl@chromium.org auto-triage: Use legacy test key to query Row 2020-07-31 abennetts@google.com chromeperf: Add upload timestamp to Histogram entities. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1106244 Tbr: rmhasan@google.com Change-Id: If0e7fdeaf2a3cb436a5e5572994d30d2549e3ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331276Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793497}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: I283310c7c98d4f85d5cc9cd2b281520e17a90a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331075Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793496}
-
Kuo Jen Wei authored
Originally, the RECORDING starts right after MediaRecorder.start() is called which makes test include delay between this timing and MediaRecorder start event triggered when chipping video duration. This CL delays the start of RECORDING after start event triggered for mitigating this delay. Bug: 1111215 Test: Pass 'tast run <DUT> "camera.CCAUIRecordVideo"' on ultima Change-Id: I84191d324c85f14a93573354dcf1f9e017bad0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329124 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#793495}
-
Avi Drissman authored
Bug: 1105907 Change-Id: Id2fd4b8763304fbe260c363c3c4dc77056d09c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328331 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#793494}
-
Chih-Hsuan Kuo authored
RPC response doesn't have 'result' field and it makes all RPC responses invalid and lead to failing at media remoting. So, the valid value should set true if parsing the response for RPC message successfully. Bug: 1106100 Test: Tested with Chromecast Change-Id: I850a8c82727ff560fcaa9c6904c2f4cf6da1705c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326370 Commit-Queue: Chih-Hsuan Kuo <chkuo@google.com> Auto-Submit: Chih-Hsuan Kuo <chkuo@google.com> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#793493}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f02c0489c9c8..bd3ffa43d23f 2020-07-31 johnstiles@google.com Fix range-based for loops which copy the loop variable unnecessarily. 2020-07-31 bsalomon@google.com Fix ducky_yuv_blend in preabandoned context mode 2020-07-30 bungeman@google.com Fix UB in SkString::equal(nullptr) when empty. 2020-07-30 fmalita@chromium.org [skottie] Avoid image data duplication when pre-decoding 2020-07-30 reed@google.com mark SkPathBuilder as SK_API 2020-07-30 jvanverth@google.com Hoist up uniform GrRingBuffer to GrGpu If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I43a146060f3b8ee204c688a6abc3371887a52448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331272Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793492}
-
Alice Boxhall authored
Bug: 1087801 Change-Id: I8567f579967a86ccdcd567b94a61b0fb297f6ed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289174 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#793491}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7d4d01fbf84f..c33ca42ea990 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yoichio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1001667 Tbr: yoichio@google.com Change-Id: I6c3918e51a65c750a675e0e8ae1f7578cec76f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330912Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793490}
-
Kent Tamura authored
Bug: 875235 Change-Id: I6d226abf9b0e6be11cce0c4abc211699fc92fb59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322408 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#793489}
-
David Grogan authored
Even if we have to disable FlexNG via finch, we won't be changing the runtime feature to less than 'experimental', which means layout tests are still run with FlexNG. Bug: 845235 Change-Id: Ia88b647cf3f79ac95b16b3142bbae5de9e618028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330616Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#793488}
-
Ryo Hashimoto authored
This is a follow-up for http://crrev.com/c/2322426 BUG=None TEST=build Change-Id: Ib7f073356c7949b5eb01e9bba2b06b10d39fc4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327359Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#793487}
-
Zain Afzal authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/QNVB74wkfoNjZ6cyfuBZDeeNGU4V9H3O7pzdyS84MN4C Release notes: http://go/media_app-x20/relnotes/Stable/media_app_20200729_RC00.html Bug: b/161193547, b/162283554, b/161374196 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Ieff6b7391eda531d8abdaf6a9e3f1575c66f6480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328372Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Zain Afzal <zafzal@google.com> Cr-Commit-Position: refs/heads/master@{#793486}
-
Xing Liu authored
The space between the checkbox drawable and the text is adjusted to 16dp. TBR=dtrainor@chromium.org Bug: 1110521 Change-Id: Id63feab7063908697dcb74a25475af914be674f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330745Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#793485}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d7d79de3af6e..f3a38d978faa 2020-07-30 jmadill@chromium.org Add a custom trace tests loader. 2020-07-30 nguyenmh@google.com Batch-compile and batch-run-replay multiple tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: Idfc9922d87df7326b3894fc19778b1a11f9199bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331190Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793484}
-
Miguel Casas authored
I was just whipping up a CL to remove the unused |va_vendor_string| param from IsBlockedDriver() when I noticed that there's quite a bit of dance among classes to fill this value: The pre-sandbox singleton VADisplay reads and keeps it as a string (but only valid between InitializeOnce() and Deinitialize()); its client VASupportedProfiles parses it into a VAImplementation enum and holds on to it, and further classes use the enum value. This CL just pushes the enum down to the VADisplay class, removing this info from VASupportedProfiles entirely and simplifying the callsites. Once parsed, it's kept for the lifetime of VADisplay. No new functionality intended. Bug: 1040291 Change-Id: I6f15cdc01977325faf37eada49404b8e0b7222da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329736 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#793483}
-
Tomasz Tylenda authored
The new expiration is M92 release. BUG=b:161834744 TEST=not applicable Change-Id: I57e23d14d6d43471164da0032f072b222d060358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325298Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Tomasz Tylenda <ttylenda@chromium.org> Auto-Submit: Tomasz Tylenda <ttylenda@chromium.org> Cr-Commit-Position: refs/heads/master@{#793482}
-
Etienne Bergeron authored
There is no behavior change. R=msw@chromium.org Bug: 1025561 Change-Id: I2165cb218cb0fcee4286becc52c95b57f317b904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331331 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#793481}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/edf39aef..c07c0c93 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I09bede6b40615330b70afa02329dd03be1e26390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330950Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793480}
-
Jinsuk Kim authored
There are several classes accessing BrowserControlsManager on Chrome- Activity already (being) destroyed. These are abnormal situations where previously BCM has never been instantiated. Rather than letting the flow go through and an exception be thrown, this CL adds the check against the state of the Activity before getting BrowserControlsManager, to prevent the crash in all the reported cases. Bug: 990987 Change-Id: I5fb26495c80af471eeef1929573bd9ede8d3bd09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326551Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#793479}
-
John Delaney authored
These metrics are still in use as heavy ads is still under experimentation and these will be necessary for monitoring post rollout. Bug: 1097939,1097938,1097937,1097929 Change-Id: Ibb2577186bb8dbfb35116290254625c9220065a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329997Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#793478}
-
Etienne Bergeron authored
This CL is changing unicode literal in unittests to follow this order: 1) Ascii only : ASCIIToUTF6(...) 2) Unicode utf8 : UTF8ToUTF16("\u1234") 3) Unicode Wide : WideToUTF16(L"\U12345678") There is no behavior change. R=msw@chromium.org Bug: 1025561 Change-Id: I7b9f15d1cf5a82b3b4ba7a7d23dcac4c6c788e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330892Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#793477}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/29cb43d47b7a..bd9fea3cfc8e 2020-07-30 nigi@chromium.org Add a test of rendering with no flags in FPDFViewEmbedderTest.RenderBug664284WithNoNativeText. 2020-07-30 nigi@chromium.org Enable FPDFEditEmbedderTest.SetTextRenderMode for Skia/SkiaPaths. 2020-07-30 thestig@chromium.org Remove |CPDF_RenderOptions::bBGRStripe|. 2020-07-30 thestig@chromium.org Forward declare CFX_TextRenderOptions when possible. 2020-07-30 thestig@chromium.org Remove |CPDF_RenderOptions::bPrintPreview|. 2020-07-30 tsepez@chromium.org Add FXGC_ForceGarbageCollection(). 2020-07-30 thestig@chromium.org Update references to Mac OS X in comments. 2020-07-30 thestig@chromium.org Convert from FPDF_TEXTPAGE to CPDF_TextPage earlier in fpdf_text.cpp. 2020-07-30 thestig@chromium.org Build with -Wc++11-narrowing. 2020-07-30 thestig@chromium.org Move CPDF_CIDFont::LoadMetricsArray() into an anonymous namespace. 2020-07-30 thestig@chromium.org Migrate from OS_MACOSX to OS_APPLE. 2020-07-30 thestig@chromium.org Consistently use defined() with _SKIA_SUPPORT_* macros. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I3af4daabe177fe9377a714821ff1f2498fc175e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330911Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793476}
-
Alexey Baskakov authored
Previously ImageSkia had unscaled ImageSkiaRep inside but MaybeResizeAndPadIconForMd() doesn't understand that. Bug: 1108889 Change-Id: Ic6cbd85c02f93d5fdd527e58c639a2440cf89d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325349Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#793475}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0c9204c1839e..ee8c246be71e 2020-07-30 deadbeef@webrtc.org Reland "sdp: parse and serialize b=TIAS" 2020-07-30 deadbeef@webrtc.org Pass NetworkMonitorFactory through PeerConnectionFactory. 2020-07-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f4c74ea1..88f89d7a (792888:793251) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ief99eefa9d9a2d04ab2e36312eaf5008c033a141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330996 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793474}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I274012335ba27fc77762f79fcd6e6479b5872de4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331074Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793473}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e6061a5922fb..e8c99cbbdd42 2020-07-31 nednguyen@google.com Remove TODO(nednguyen) from the code base If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: rmhasan@google.com Change-Id: I0fd5949619dd01f710cf0123bfcee6ff18d0039f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331191Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793472}
-
Avi Drissman authored
Right now, all flavors of Mac Chrome say “Chrome” in the menu bar. Given that the idea of SxS is to run multiple Chrome instances at once, make that text specify which flavor of Chrome is the active one. The CFBundleName and CFBundleDisplayName in the strings files are always the same as the value in the main Info.plist, so remove them. Those override the value in the Info.plist, and the Info.plist value is modified in packaging to have the “ Dev” and “ Beta” suffixes. Bug: 1111461 Change-Id: I793172d182b7bf6d680136cb357ef2cd627d3cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330075 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#793471}
-