- 30 Mar, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/46de36f99362..6e2af5c326c4 git log 46de36f99362..6e2af5c326c4 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 egdaniel@google.com Remove alpha versions of constant blend coeffs. 2020-03-30 bsalomon@google.com Revert "Assert that all GrCaps colortype/format -> swizzle queries are legal." 2020-03-30 jvanverth@google.com Fill in some D3D texture creation routines. 2020-03-30 bsalomon@google.com Assert that all GrCaps colortype/format -> swizzle queries are legal. 2020-03-30 sgilhuly@chromium.org Roll Dawn and add dependencies 2020-03-30 bsalomon@google.com Revert "Remove GrCaps::isFormatTexturableAndUploadable" 2020-03-30 csmartdalton@google.com Use GL_ANGLE_base_vertex_base_instance 2020-03-30 mtklein@google.com remove Builder inheritance 2020-03-30 mtklein@google.com fix unpremul() 2020-03-30 fmalita@chromium.org [skottie] Lazy adapter sync 2020-03-30 bsalomon@google.com Make memcmps in GrResourceKey::op== safe. 2020-03-30 brianosman@google.com Remove some legacy GN defines for Flutter 2020-03-30 mtklein@google.com don't run clang-tidy on third_party 2020-03-30 mtklein@google.com way more p-> inference 2020-03-30 bsalomon@google.com Remove GrCaps::isFormatTexturableAndUploadable 2020-03-30 mtklein@google.com remove negate() 2020-03-30 mtklein@google.com remove inv() Created with: gclient setdep -r src/third_party/skia@6e2af5c326c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1064563 Tbr: michaelludwig@google.com Change-Id: I7e952e8ba7448553ad0b768431813fff2178dde9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128376Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754685}
-
Ian Kilpatrick authored
Instead of returning by value - this makes ComputePartialAbsoluteWithChildInlineSize mutable an in parameter. This is so in a subsequent patch the block dimensions can be computed before the inline dimensions. This also performs some renames: ComputePartialAbsoluteWithChildInlineSize -> ComputeOutOfFlowInlineDimensions ComputeFullAbsoluteWithChildBlockSize -> ComputeOutOfFlowBlockDimensions As "full"/"partial" don't particularly apply now. Change-Id: Id03b0ba8f923d72db12896d9955179953626c7b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122456Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#754684}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/012fbeb999c6..adc61409cbf9 Created with: gclient setdep -r src-internal@adc61409cbf9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1063851,chromium:760187,chromium:832124 Tbr: jbudorick@google.com Change-Id: I2803b71eb83df110de5c6207389dc30e9cd36b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128067 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754683}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I20677067ba79d53741071fd81f05f17ef4617549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128384Reviewed-by:
-
Peng Huang authored
Tested with --ozone-platform=x11. Bug: 1065499 Change-Id: I57299267c6c496f77a2004ca6017bc2c0c8dabf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126248 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#754681}
-
Xiyuan Xia authored
- Add FrameSequenceTrackerType::kCustom; - Add FrameSequenceTrackerCollection::StartCustomSequence to create a kCustom typed tracker to represent a sequence; - Add FrameSequenceTrackerCollection::StopCustomSequence to schedule termination of a tracker for a sequence; - Data collected by custom trackers are reported via the return value of FrameSequenceTrackerCollection::TakeCustomTrackerResults; Bug: 1021774 Change-Id: I62d9c2eb833e1d40e01b3b452d515ce361233a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007937 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Toni Barzic authored
ContentsView::ResetForShow was resetting the contents view state to match the closed app list view state, unless the contents view state already was set for the closed app list view (so if ResetForShow is called mid closing animation the contents view contents doesn't jump to the closed state, which would make show animation seem janky). Additionally, the contents view state was not updated if the contents view state was not previously updated for app list view state. This meant that on initial app list show, the app list contents view elements were animating from 1.0 opacity, instead of 0.0 opacity (i.e. the opacity for closed app list view) - specifically, this made search box view visible behind the shelf when the app list view was initially shown. This cl changes ResetForShow to reset the contents view state to closed app list view state in the latter case (so the initial app list view show animation looks smoother). BUG=1066249 Change-Id: Icb27965cdf635c76bd910f249ce3d613dd59b223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125454 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#754679}
-
Josh Karlin authored
This reverts commit b818b458. Reason for revert: My measurement was wrong. The call to v8::Isolate isn't nearly as slow as previously though. Reverting the optimization as it just adds unnecessary complexity. Original change's description: > Optimize SourceLocation::Capture > > Determining the v8::Isolate can take ~25% of the time > required to capture the top of the stack. This CL gets the Isolate > from the ExecutionContext when it's available to speed things up. > > Bug: 851531 > Change-Id: Ia823fbb0643c62f1a4da3cc289b23ca6fb43da2b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122568 > Commit-Queue: Josh Karlin <jkarlin@chromium.org> > Reviewed-by: Nate Chapin <japhet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754054} TBR=japhet@chromium.org,jkarlin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 851531 Change-Id: I36e9be81b06598ed29484df2997c22cbd4dc170f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128090Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754678}
-
Tibor Dusnoki authored
MediaCanPlayTypeTest.CodecSupportTest_NewVp9Variants test fails on Windows on ARM64 currently. The test expects ARM platforms (excluding specific android versions) not to support Profile 2 and 3 Vp9 codecs but they are supported on WoA. Bug: 1058748 Change-Id: Ie2157ccd453c052d5ba11240f337798a22f1dbf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104467 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#754677}
-
Chris Mumford authored
The [Badging API](https://wicg.github.io/badging/) is a new API allowing the setting of application/document badges. This change converts the Badging API web tests into Web Platform Tests. This change adds a no-op MockBadgeService to the content_shell. This is necessary because the RenderProcessHostImpl will terminate the render process if unknown Mojo messages are received. Bug: 1051684 Change-Id: I61e29b8f197a754fea489ebb2d0dcd41484f6cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088297Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#754676}
-
Alison Maher authored
When the legend is smaller than the fieldset border-top, the legend's margin box gets pushed down. In the case of fragmentation, allow this adjustment if the legend fits inside the first fragment. Otherwise, don't adjust the legend block offset. Bug: 875235 Change-Id: Id93474cf0ee94975093391e71b87250f547852b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125230 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
-
Tom Anderson authored
Needs build-side CL: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2125157 BUG=1060273 R=estaab Change-Id: I0171772e75df4b71536ba955e973859c8d793439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125234 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#754674}
-
Rebekah Potter authored
This reverts commit ae260266. Reason for revert: breaks deterministic bots, see https://bugs.chromium.org/p/chromium/issues/detail?id=1066246 Original change's description: > [tools/perf] Make upload_trace_processor build target visible > > BUILD.gn files are read by ninja only if something depends on targets > defined in them. So to make targets in perfetto_binary_roller folder > visible, we provide a special group with a dependency on a target > from it. > > Bug: 1050517 > Change-Id: I99ca73f11c2a00f70eade250ae9dff93d3c9d3af > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124378 > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> > Cr-Commit-Position: refs/heads/master@{#754594} TBR=johnchen@chromium.org,khokhlov@google.com,wenbinzhang@google.com Change-Id: If31ba360d91f100664e51c1ff0186bc8030882cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128828Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#754673}
-
Peter Kasting authored
Bug: none Change-Id: I00e2fbff9d876d4daa134bada783d4f8cddff8d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127888 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#754672}
-
Chris Cunningham authored
Module was historically pretty simple boilerplate. Recently we've added new ML backends and complicated logic to organize all the backend callbacks. New unit tests cover all orderings and combinations of backend behavior. This also adds a unit test against floating point truncation. Bug: 1024399, 1049339 Change-Id: I9b9f90f3ba7cc799d0294ddb1ee3ac116399ad4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088494 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#754671}
-
Tao Bai authored
Only pull the coordinates where the focused field's coordinates already required, this change will not trigger any new layout, so there is no performance regression. Bug: 1064420 Change-Id: I67c3e5bbafcc4852b471b22a9d8d4edcb527187a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125608Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#754670}
-
Ted Meyer authored
this new name is more descriptive of the error. Bug: 1043289 Change-Id: If4f095410e162f989c1e5f8c533ae8e49722adbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121423Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#754669}
-
Nick Diego Yamane authored
Delegate GtkEventLoopX11 initialization to platform code so that we can get rid of the ugly hack to start it, during GtkUi initialization, for both ozone and legacy X11. Bug: 963419, 1002674 Change-Id: Ib9e9d635bed5095fb730f778cc54d8cd3c71e07c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093252Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#754668}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/29d712f9de99..4da46462d786 git log 29d712f9de99..4da46462d786 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 rharrison@chromium.org Rolling 4 dependencies Created with: gclient setdep -r src/third_party/dawn@4da46462d786 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I55dcc7d375acfef9be903efb6e140c84aa4f4d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128366Reviewed-by:
-
adamta authored
When long-pressing an image element that is not a link, context menu title should be "[<alt-text> – ]<src>". Alt text was never used before so it is now retrieved in the js to make this possible. A function was created to get the context menu title since the logic was too coupled with the context menu dictionary function. Bug: 1064569 Change-Id: I726b8066116426df3d51e89a65f906f77d739900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122752Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#754666}
-
David Bienvenu authored
I looked into the crashes that this debugging code was added for, and ~99.9% of them were because of malware, so it doesn't seem worthwhile to keep the debugging code. More info in crbug.com/614753. Bug: 614753 Change-Id: Ifc4b1e19e8041b684cfc5402f085870956f8fa35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125036 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#754665}
-
Eric Robinson authored
This CL removes the option in the subresource filter code that considered the redirect chain for safebrowsing from the codebase. That logic is now performed elsewhere, and internally, only the final CL in the chain is now considered. The metrics for measuring where in the chain an intervention would occur, however, remain in place. Change-Id: Iad5a771db275424255829d32804b9d2f4d2299f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024473Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#754664}
-
Devlin Cronin authored
Bug: None Change-Id: I468c119b936cf1c4848593cf6b2cc5a244acb3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127629Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754663}
-
Pavel Feldman authored
We are now managing download behavior on the broweser context, not the web contents level. This simplified logic a lot. This change also deprecates the Page.setDownloadBehavior and moves it to the Browser.setDownloadBehavior level. Change-Id: I0e8e11fb8fe86052dadd2df178406b8c5262f20d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121741Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#754662}
-
Aaron Krajeski authored
Idle tasks take much longer on worker threads because requestAnimationFrame isn't there. For this test: https://chromium-review.googlesource.com/c/chromium/src/+/2124971 Without this change worker convertToBlob takes ~400ms With this change worker convertToBlob takes ~10ms Bug: 1053477 Change-Id: I3367e4b7ce73aec34acc9dbf084d226aa1b52093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124703 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#754661}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3fffd0d4592e..17111b3e43c3 git log 3fffd0d4592e..17111b3e43c3 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 michael.liao@microsoft.com [Elements - Styles Pane]: Fixing SR behavior for element state pane Created with: gclient setdep -r src/third_party/devtools-frontend/src@17111b3e43c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1065913 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic97d2c3576b98b688d31c8a6735afcb23bd70db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127423Reviewed-by:
-
Devlin Cronin authored
The NTP overridden bubble prompts the user post-installation to ensure an extension that overrides the NTP was desired. It is currently enabled on ChromeOS and Windows; this CL enables it on MacOS as well. Already-installed extensions will be auto-acknowledged for the user so as to not be disruptive. Only newly-installed extensions will trigger the bubble. Bug: 10646707 Change-Id: I58d8ff4f610def99c28dda7c8ee4d19933870e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120744Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754659}
-
Sadrul Habib Chowdhury authored
We currently report the 'slower thread' metric in the aggregated top-level metrics (AllInteractions and AllSequences). But now that we have a 'scrolling thread' metric, report that instead. BUG=1035460 Change-Id: Ide012ecf9c92aeeaba86fcdfeb812958e85a0656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128370Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#754658}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/11f4a84bb1b3..df70c8152767 git log 11f4a84bb1b3..df70c8152767 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 ehmaldonado@google.com depot_tools: Simplify MinGW check. 2020-03-30 ehmaldonado@google.com Reland "git-cl: Remove unused and duplicate functions." 2020-03-30 ehmaldonado@google.com Add quotes around paths in bash scripts Created with: gclient setdep -r src/third_party/depot_tools@df70c8152767 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I3dce2f422e50f65bd6b74652c458e97ac1acae3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128371Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 59d5ceda. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 9e853511 "Remove broken icon rendering for loading="lazy" images while loading" aa91d8cd "[COEP] Make WPT testing reporting to have a long timeout." 06949117 "Isolate activation-gated APIs from user-activation WPTs." 8c86fa01 "[mathml] Fix logic errors in linethickness interpretation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I67ee1f3d45e7740429e4bcd53b4b5aa5437ae078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128246Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754656}
-
Klaus Weidner authored
It's illegal to destroy mojo callbacks that haven't been run while their message pipe is still open. Since ArCoreGlThread's destructor shuts down the task runner, this was causing DCHECK failures if the task runner owned a closure with a pending GetFrameData mojo callback. To fix this, have ArCoreGl retain ownership of the closure containing a mojo callback, and call it through a helper method. Bug: 1065572 Change-Id: Ice2340906da470ff2b5b69554e9e7755dd040b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127420 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#754655}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/50a47bd99229..7939e367fa53 git log 50a47bd99229..7939e367fa53 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 cwallez@chromium.org Revert "Enable blob cache when debugging" 2020-03-30 cnorthrop@google.com Vulkan: Expose extension for ETC1 usage with subimage updates 2020-03-30 courtneygo@google.com Enable blob cache when debugging Created with: gclient setdep -r src/third_party/angle@7939e367fa53 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: Iab1326e198ec7d61236f8a42298e18440bc3a0f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127762Reviewed-by:
-
danakj authored
Objects are all set up in a reasonable state at construction time already. No need to do a Reset, which also involves some IPCs back up to the browser. Change-Id: Ic4522f40bce99178c838d268af8499d36b0e5325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128240Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#754653}
-
chrome://flagsbttk authored
A new configuration source of the default homepage and bookmarks. Bug: 1063948 Change-Id: Ic940ff4a0ac8b27ccf27311427557563542cf936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127890Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#754652}
-
Tommy C. Li authored
Currently, we don't pass the provider-populated (generally server-provided) subtype_identifier field into the aqs= CGI parameter. We just statically make one in the AutocompleteController AutocompleteMatchToAssistedQuery static method. This more or less works, but in our ideal system, we would have these qualities: 1. We decentralize this provider-specific logic into the providers themselves, rather than having a centralized switch statement that handles all these per-provider cases. 2. If the server passes us some special subtype_identifier, we can pass it along in our aqs= parameter without updating the Chrome binary. This CL makes AutocompleteMatchToAssistedQuery start with the provider-populated integer. It also adds a test. Ideally in the future, all of the logic within that static method could be migrated into the individual provider classes. Bug: 1064327 Change-Id: I8b56a6623f61520218f2f4001787171c300fb192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118221Reviewed-by:Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#754651}
-
Natalie Chouinard authored
Bug: 1044401 Change-Id: I7b8c69a390f47e86b864360d1913bf593c8b69ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124969Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#754650}
-
Antonio Gomes authored
This CL moves flexbox-with-multi-column-property.html from css3/flexbox/ to external/wpt/css/css-flexbox/. It also adds links and references to the related spec, and expected behavior. Last, it replaces uses of -webkit-column-* by their respective column-* counterparts. Relevant spec change: https://github.com/w3c/csswg-drafts/issues/1364 ([css-multicol-1][css-flexbox-1][css-grid-1] Clarify that column-* properties only apply to block containers). BUG=1063749 R=dgrogan@chromium.org Change-Id: Icd31c1974af431bd8cd6de94970e4e29137a669e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127294 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#754649}
-
Justin Cohen authored
Use GetLastCommittedItemInCurrentOrRestoredSession() instead of GetLastCommittedItem() so restore session URL's aren't suppressed. Otherwise a cancelled/stopped navigation during the first post-restore navigation will always return early from Reload. Bug: 1050518 Change-Id: I352e430abcf888ae8488150b6511e8a7fd9bd4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125870Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Mustafa Emre Acer authored
The tests were using chrome:// URLs to trigger SafeBrowsing warnings. They also wait until the pages are ready which is done by running JavaScript. In some cases, WebUI bindings aren't yet ready for the loaded page so executing JS fails, causing the tests to crash. This CL switches to HTTP pages instead. Bug: 1065742, 1057157 Change-Id: Ie3302e7c63bf8d4d7c9db687c95ce1e9e8da483c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127733Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#754647}
-
Charlie Hu authored
This CL renames FeaturePolicyDisposition to PolicyDisposition, because it is now used for both feature policy and document policy. Change-Id: I2ff2f0a9a167ca56f5aeac14adff660f8504a949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127734Reviewed-by:
-
