GitLab

R=michaelpg@chromium.org, dzhioev@chromium.org

Review URL: https://codereview.chromium.org/1011993002

Cr-Commit-Position: refs/heads/master@{#320961}

R=dfalcantara@chromium.org
BUG=466421

Review URL: https://codereview.chromium.org/1006483004

Cr-Commit-Position: refs/heads/master@{#320960}

BUG=437865

Review URL: https://codereview.chromium.org/999073002

Cr-Commit-Position: refs/heads/master@{#320959}

BUG=448219
TEST=new test passes

Review URL: https://codereview.chromium.org/1002193005

Cr-Commit-Position: refs/heads/master@{#320958}

Fix IndexedDBBrowserTest.ConnectionsClosedOnTabClose to ensure that the
first tab holds a reference to the DB after it does setVersion to ensure
that if a GC happens before the second tab is loaded, the second tab still
get's blocked from doing it's version update. Previously if a GC happened at
this time then the test would hang as the second tab would set it's title
immediately to "setVersion(3) complete" bypassing the "setVersion(3) blocked"
title.

This was failing when long idle times were enabled because the long idle
times caused more GC when the tab went idle.

BUG=467655

Review URL: https://codereview.chromium.org/1012153002

Cr-Commit-Position: refs/heads/master@{#320957}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/cdeca44..706d98e

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1017593004

Cr-Commit-Position: refs/heads/master@{#320956}

Revert of Do not allow asan_symbolize.py to fall back to addr2line/atos. (patchset #1 id:1 of https://codereview.chromium.org/983083004/)

Reason for revert:
Turns out the fall back to addr2line happens routinely. We need to fix that before proceeding with this change.

Original issue's description:
> Do not allow asan_symbolize.py to fall back to addr2line/atos.
>
> For performance reasons we want to stick to llvm-symbolizer.
> This also rolls the third-party asan_symbolize.py to r231492.
>
> BUG=415179
> TBR=glider@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/2ee9a8ae1e39433fc8df07c27256963715747bbb
> Cr-Commit-Position: refs/heads/master@{#319460}

TBR=glider@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=415179

Review URL: https://codereview.chromium.org/1017793002

Cr-Commit-Position: refs/heads/master@{#320955}

This method is required in order to upstream CookieStoreIOS.

CookieStoreIOS can periodically synchronize the iOS system
cookie store (NSHTTPCookieStorage) to CookieMonster.

It is not possible to simply delete all the cookies and re-add
the new version of the cookies, because this can lead to cookie
loss if the application crashes right after deleting all cookies.
For this reason, this CL introduces a new SetAllCookies method
that computes the exact difference between the exiting cookies and
the new cookies, and does only the minimum of operations needed.

Review URL: https://codereview.chromium.org/1000103002

Cr-Commit-Position: refs/heads/master@{#320954}

This refactoring would allow the creation of capturing devices without having a
DesktopMediaID. This change pulls the DesktopVideoCaptureMachine class out from
DesktopCaptureDeviceAura and renames it to AuraWindowCaptureMachine. The class
is also refactored to take the target window (rather than a DesktopMediaID)
after construction through a SetWindow method.

BUG=425060
TEST=Using Chrome Cast beta extension and capture both screen and window
and observe that the capture works correctly and that histogram values
are updated.

Review URL: https://codereview.chromium.org/974513002

Cr-Commit-Position: refs/heads/master@{#320953}

The documentation for NESTABLE_ASYNC events is not quite right. It does not say
that we use "id" to match events, and it is not accurate about the parsing rule
for unmatched events. This CL makes changes to the comments, so it will be
clearer to future users of the API.

Review URL: https://codereview.chromium.org/1016753003

Cr-Commit-Position: refs/heads/master@{#320952}

This pulls in the following Native Client changes:

cdbbbe0: (jfb@chromium.org) PNaCl: Update compiler-rt revision in pnacl/COMPONENT_REVISIONS
67685d6: (kschimpf@google.com) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
a47cbb5: (jfb@chromium.org) Update revision for PNaCl
00ba720: (stichnot@chromium.org) Enable ccache in the cmake builds of LLVM and libcxx.
d3dc925: (sbc@chromium.org) pnacl/driver: Allow -whole-archive as well as --whole-archive
7eefe5f: (jfb@chromium.org) Test overflow builtins.
84b4c32: (jfb@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
92ab4d5: (jfb@chromium.org) Revert of PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS (patchset #1 id:1 of https://codereview.chromium.org/1008693005/)
8f963fb: (jfb@chromium.org) Revert of Revert of PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS (patchset #1 id:1 of https://codereview.chromium.org/1002423002/)
a1aac24: (bradnelson@google.com) Return zero for segment registers accessed via the debug stub
f418b37: (jfb@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS

Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/71515be08f1b0993ad0cd96f991266169a3a003e..f418b37b22393d82c08d28ce1c151bed933d2c9b

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/1011183002

Cr-Commit-Position: refs/heads/master@{#320951}

R=hcarmona@chromium.org
BUG=467513

Review URL: https://codereview.chromium.org/1018543005

Cr-Commit-Position: refs/heads/master@{#320950}

BUG=461032

Review URL: https://codereview.chromium.org/996313002

Cr-Commit-Position: refs/heads/master@{#320949}

This change gives consumers of ZipReader a way to have the current entry
streamed to them via a Delegate interface. It also:

- Reduces duplication in the ExtractCurrentEntry* functions.
- Uses the heap rather than the stack for intermediate buffers.
- Changes ExtractCurrentEntryToFd to ExtractCurrentEntryToFile, making
  it cross-platform in the process.

BUG=462584

Review URL: https://codereview.chromium.org/1014653002

Cr-Commit-Position: refs/heads/master@{#320948}

... provided categories that cause layer tree snapshots to be traced
are enabled. We need this so that we can show owner nodes for layers
that were not updated on the main thread side for a while.

BUG=

Review URL: https://codereview.chromium.org/924973003

Cr-Commit-Position: refs/heads/master@{#320947}

The web speech synthesis API was correctly passing through an utterance's
rate, pitch, and volume to native TTS, but not to extension-based speech.
This fixes the bug, and I filed another bug to clean up the redundancy that
led to this bug being there.

BUG=376280

Review URL: https://codereview.chromium.org/969913002

Cr-Commit-Position: refs/heads/master@{#320946}

Adding an example multi-machine test for Chromoting. This example starts a test controller machine which then starts a dedicated task machine to run the browser_tests_launcher on. The output is then streamed back to the test controller to be logged and the output (pass or fail) is mirrored on the test controller. This is a simple example of how to write and run multi-machine tests using the Legion framework.

BUG=467620

Review URL: https://codereview.chromium.org/1012883002

Cr-Commit-Position: refs/heads/master@{#320945}

BUG=437865

Review URL: https://codereview.chromium.org/1018613002

Cr-Commit-Position: refs/heads/master@{#320944}

The current focus rectangle logic is wrong -- it's always drawn
outside of local bounds, which is not drawn actually. The expected
behavior is to draw the focus rectangle around the actual text.

BUG=467510
R=sky@chromium.org
TEST=the new test case covers

Review URL: https://codereview.chromium.org/1018463004

Cr-Commit-Position: refs/heads/master@{#320943}

BUG=456004
TEST=gpu_unittests, about:gpu page
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/1018463002

Cr-Commit-Position: refs/heads/master@{#320942}

Current string: Signed in as [email]. Manage your synced data on Google Dashboard
New strings: Signed in as [email]. Manage your synced data and devices on Chrome Dashboard

BUG=402615

Manual test:
launch chrome by chrome --force-fieldtrials="ChromeDashboard/Enabled/"
log in chrome, and then go to settings, on the top of settings, there should be the new string, click the "Chrome Dashboard", it should bring you to URL("https://google.com/settings/chrome/sync").

Review URL: https://codereview.chromium.org/998413003

Cr-Commit-Position: refs/heads/master@{#320941}

Events exposed through inputMethodPrivate extension API.

BUG=455026

Review URL: https://codereview.chromium.org/973213003

Cr-Commit-Position: refs/heads/master@{#320940}

This CL is the first step toward support for third-party VPNs in ash UI.
t adds a delegate interface that ash UI will use to retrieve the list
of available VPN providers and request that a VPN provider show its "add
network" dialog.

The CL was tested together with follow-up CLs which wire up the actual
UI.

BUG=460428
TEST=Manual, together with follow-ups that wire up the UI

Review URL: https://codereview.chromium.org/984863005

Cr-Commit-Position: refs/heads/master@{#320939}

Revert of Enable Surfaces on Android (try #3)  (patchset #1 id:1 of https://codereview.chromium.org/1001203002/)

Reason for revert:
Speculative revert as it seems to be causing a big regression in input_latency/thread_time_cpu_per_frame

BUG=467978

Original issue's description:
> Enable Surfaces on Android (try #3)
>
> The browser compositor contents and renderer contents are each put into separate Surfaces which are aggregated together by a Display.
>
> BUG=449319
>
> Committed: https://crrev.com/8da5f9f03e955304716977004fd4ba1168869aca
> Cr-Commit-Position: refs/heads/master@{#320826}

TBR=sievers@chromium.org,jbauman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=449319

Review URL: https://codereview.chromium.org/1015813002

Cr-Commit-Position: refs/heads/master@{#320938}

If we don't do this, then we have a race condition between unloading
this extension, and trying to use it because we have manually
navigated to it.

BUG=460431

Committed: https://crrev.com/1805c4c5c4b5292cca51a54f379cde498db7238b
Cr-Commit-Position: refs/heads/master@{#318140}

Review URL: https://codereview.chromium.org/961443003

Cr-Commit-Position: refs/heads/master@{#320937}

Add a "clear-data-reduction-proxy-data-savings" flag, which when
enabled will clear out data savings statistics on startup.

BUG=461022

Review URL: https://codereview.chromium.org/1010083002

Cr-Commit-Position: refs/heads/master@{#320936}

Also
 - makes the callback to finishAuthentication optional
 - adds the "Important: This API works only on Chrome OS."
   banner to the documentation page.

BUG=432280

Review URL: https://codereview.chromium.org/1002243002

Cr-Commit-Position: refs/heads/master@{#320935}

Refactor history loading, eliminating the obsolete (and even obstructionist) ChromeSyncFileEntryProvider.
This CL updates the entire stack with support for multiple history files, but doesn't yet load all history files. That support will come in a subsequent change.
Remove extra "." qualifier in most instance of "Promise.<" and "Array.<" in affected files only.

TEST=*ImportHistory*

Review URL: https://codereview.chromium.org/1013893002

Cr-Commit-Position: refs/heads/master@{#320934}

1. VideoCaptureControllerID is a struct inside VCCEventHandler, just
to wrap an int. It also defines operator< and operator== to enable
using it in std::map. This is not needed, so I replaced it with a
typedef int VideoCaptureControllerID;

And s/const VideoCaptureControllerID&/VideoCaptureControllerID/

This enabled VideoCaptureControllerEventHandler to become a
pure interface. Removed video_capture_controller_event_handler.cc.

2. VideoCaptureHost lives 100% in IO Thread, except ctor in UI thread.
There's this idiom on IPC message sending where there's two
methods OnBla() -> PostTask to DoBla() on IO -> Send msg.
But all methods are living on IO and Send is asynchronous anyway,
so those DoBla() dealing with Send() are folded into OnBla()
methods -- trhose remain they mean basically a sophisticated
DeleteLater().

3. A few methods use base::TimeTicks as param, when they can
use const base::TimeTicks&, replaced them (one less copy in the
critical capture path).

BUG=440843

Review URL: https://codereview.chromium.org/1017503002

Cr-Commit-Position: refs/heads/master@{#320933}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a537ab2..2f002c7

TBR=rtoy@chromium.org,pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1008343005

Cr-Commit-Position: refs/heads/master@{#320932}

Cr-Commit-Position: refs/heads/master@{#320931}

Should fix the "D-Bus library appears to be incorrectly set up; failed to read
machine uuid" messages.

BUG=467901
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1008873004

Cr-Commit-Position: refs/heads/master@{#320930}

BUG=369661
TEST=none

Review URL: https://codereview.chromium.org/1013203002

Cr-Commit-Position: refs/heads/master@{#320929}

The origin now is included, and Blink has been updated to pass it in.

This is part of a three-sided patch:
  [1] https://codereview.chromium.org/982313002/
  [2] https://codereview.chromium.org/985063002/
  [3] This patch.

BUG=447628

Review URL: https://codereview.chromium.org/985693004

Cr-Commit-Position: refs/heads/master@{#320928}

It does enable Permissions.query() in Document and Worker context.

It is using the mojo pipe associated to the RenderFrameImpl or BlinkPlatformImpl
so the PermissionManager doesn't need to know in which context it lives.
However, it needs to do some thread jumping to be back in the main thread.

This is based on top of https://codereview.chromium.org/804553003

BUG=437770

Review URL: https://codereview.chromium.org/801613004

Cr-Commit-Position: refs/heads/master@{#320927}

BUG=

Review URL: https://codereview.chromium.org/912863002

Cr-Commit-Position: refs/heads/master@{#320926}

Make HttpStreamFactoryImpl::GetAlternateProtocolRequestFor() return
AlternativeService instead of AlternateProtocolInfo, and rename it to
GetAlternativeServiceRequestFor.  Also change the type and name of
HttpStreamFactoryImplJob.{,other_job_}alternate_protocol_.

BUG=392576

Review URL: https://codereview.chromium.org/1011013002

Cr-Commit-Position: refs/heads/master@{#320925}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/493c1ce..cdeca44

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1012043003

Cr-Commit-Position: refs/heads/master@{#320924}

The new callback (aptly named OnReceivedError2) is also called for
subresource load failures and provides more information about
the failed request.

Note that calling OnReceivedError2 is not yet implemented for requests
blocked due to security considerations by Blink. This will be
implemented separately.

BUG=456782

Review URL: https://codereview.chromium.org/1001003004

Cr-Commit-Position: refs/heads/master@{#320923}

GetSuccessorId and GetPredecessorId access all children of the
current node's parent in order to get to the next/previous node.
With implicit parent ID these functions can't get to the parent.
The reasons we didn't run into this problem before are
a) The server feature that will stop setting parent ID isn't
   enabled yet so there wasn't a chance to expose this yet.
b) There wasn't enough test coverage.

The fix is to use the ParentChildIndex to resolve the implicit
(unset) parent ID. Added a new method called GetSiblings at
the Directory level that does just that. Also added some
unit test coverage.

BUG=438313

Review URL: https://codereview.chromium.org/1008993004

Cr-Commit-Position: refs/heads/master@{#320922}