GitLab

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10703130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146042 0039d316-1c4b-4281-b951-d872f2087c98

The MessagePumpLibeventTest.StopWatcher and MessagePumpLibeventTest.DeleteWatcher
use fd 0, which is not permitted in apk test while calling 'epoll_ctl', and cause
failure on Android. Fix this by using fd created from pipe.

Also remove them from Android disabled case list.

BUG=None
TEST=base_unittests


Review URL: https://chromiumcodereview.appspot.com/10698112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146041 0039d316-1c4b-4281-b951-d872f2087c98

Favicon updates are per-url, and originate from a different thread. It's possible
by the time we receive an update notification we've already deleted that bookmark,
and should handle that situation gracefully.

BUG=121587
TEST=


Review URL: https://chromiumcodereview.appspot.com/10696163

TBR=zea@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10694126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146040 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98716
Review URL: https://chromiumcodereview.appspot.com/10545021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146039 0039d316-1c4b-4281-b951-d872f2087c98

Make eventArgumentMassagers asynchronous so custom bindings don't need to override chrome.Event.prototype.dispatch.


BUG=121479


Review URL: https://chromiumcodereview.appspot.com/10704073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146038 0039d316-1c4b-4281-b951-d872f2087c98

It turns out we had two bugs in our non-HTTP code path:
  1) Connection retries used the wrong start callback, which caused the loader to never get created
  2) The start position for non-HTTP resources is kPositionNotSpecified, which caused us to report [-1, file size) instead of [0, file size) for buffered status

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10698139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146035 0039d316-1c4b-4281-b951-d872f2087c98

Complete the TODO for native unittests apk to place used
jars into ${out.dir}/java/libs. Add the conditional check
if there is no jar in that directory.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10701113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146034 0039d316-1c4b-4281-b951-d872f2087c98

Use this flag for the period of migration from Document List API
to Drive v2 API for file browser / filesystem APIs etc.
Code for using this flag will follow separately.

BUG=chromium:127728
TEST=compile

Review URL: https://chromiumcodereview.appspot.com/10753024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146033 0039d316-1c4b-4281-b951-d872f2087c98

Favicon updates are per-url, and originate from a different thread. It's possible
by the time we receive an update notification we've already deleted that bookmark,
and should handle that situation gracefully.

BUG=121587
TEST=


Review URL: https://chromiumcodereview.appspot.com/10696163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146032 0039d316-1c4b-4281-b951-d872f2087c98

Rename it so it can contain code to set other power manager settings,
not just for screen locker.

BUG=chromium-os:32240
TEST=Build successfully.

Change-Id: I412b775c8679386262791e84e0b2575fe182872a
Signed-off-by: Simon Que <sque@chromium.org>

R=stevenjb@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10689101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146031 0039d316-1c4b-4281-b951-d872f2087c98

ShutdownTest.SimpleWindowClose

BUG=136644
TEST=
TBR=ananta

Review URL: https://chromiumcodereview.appspot.com/10703136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146030 0039d316-1c4b-4281-b951-d872f2087c98

On android, ENABLE_THEMES and ENABLE_PROTECTOR_SERVICE are not defined.
This fixes some link errors for unit_tests.

BUG=117407
TEST=

Review URL: https://chromiumcodereview.appspot.com/10704148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146028 0039d316-1c4b-4281-b951-d872f2087c98

Previous fix r144228 does not fix the crash. It seems the crash is more likely
to be caused by user closing the app window in a nested message that runs by
synchronous session restore. Add an WebContentsCloseObserver to monitor the app
contents and skip focusing logic if it is closed.

BUG=134478
TEST=Verify the crash in 134478 no longer happens.


Review URL: https://chromiumcodereview.appspot.com/10700145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146027 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10690081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146026 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10692146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146025 0039d316-1c4b-4281-b951-d872f2087c98

If we call DoSeek() without a demuxer we've clearly got issues as we shouldn't be seeking without a demuxer so crashing is preferable.

BUG=none
TEST=none
TBR=acolwell

Review URL: https://chromiumcodereview.appspot.com/10694125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146024 0039d316-1c4b-4281-b951-d872f2087c98

BUG=135487
TEST=alt [ and alt ] won't do anything in fullscreen mode.


Review URL: https://chromiumcodereview.appspot.com/10700151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146023 0039d316-1c4b-4281-b951-d872f2087c98

Bug=None
Test=Compiles
R=ben,oshima
TBR=sadrul

Review URL: https://chromiumcodereview.appspot.com/10696130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146022 0039d316-1c4b-4281-b951-d872f2087c98

remove autofill impl from upstream

Autofill involves calls to native view, so the dependency is not correct.
If we want to upstream autofill_external_delegate_android, we have to introduce another delegate.
Remove the code from upstream for now.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10701058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146021 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134821, 134820
TEST=both base_unittests:FileUtilTest.*, VerifyPathControlledByUserTest.* and unit_tests:Gdata* pass

Review URL: https://chromiumcodereview.appspot.com/10756020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146020 0039d316-1c4b-4281-b951-d872f2087c98

This removes the dependency in chrome/browser/ui/views/web_dialog_view.h from
chromeos.

BUG=125846
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10695122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146019 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125875
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/10758015

TBR=varunjain@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10694121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146018 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146017 0039d316-1c4b-4281-b951-d872f2087c98

We were expecting to receive GTK+ events in the following order:
  drag-motion
  drag-data-received
  drag-leave
but in some cases, we don't get the drag-data-received event (e.g.,
if the user is moving the mouse quickly). If that happens, don't send
a DragLeave event to the renderer since it doesn't think we're in a
drag.

BUG=129446
TEST=Open 2 chrome windows, quickly drag a file from the desktop over both
  windows. This should not crash.


Review URL: https://chromiumcodereview.appspot.com/10704144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146016 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10695135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146015 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10681003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146014 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10689149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146013 0039d316-1c4b-4281-b951-d872f2087c98

The crashes that it was hoped this patch would prevent didn't stop, and the actual bug was fixed in r145842.

BUG=136232
TBR=kalman@chomium.org

Review URL: https://chromiumcodereview.appspot.com/10701134

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146012 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125875
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/10758015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146011 0039d316-1c4b-4281-b951-d872f2087c98

TEST=passes new webgl conformance test
BUG=136538


Review URL: https://chromiumcodereview.appspot.com/10735038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146010 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=unit tests.

Review URL: https://chromiumcodereview.appspot.com/10704143

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146009 0039d316-1c4b-4281-b951-d872f2087c98

As long as touch-events are processed correctly for modal windows, the
gesture-events should automatically do the right thing. So gesture-events should
not need similar treatment.

BUG=136360
TEST=ash_unittests

Review URL: https://chromiumcodereview.appspot.com/10763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146008 0039d316-1c4b-4281-b951-d872f2087c98

These defined constants are not used in this file.
They are defined and used in c/b/chromeos/gdata/gdata_operations.cc.

BUG=none
TEST=compile


Review URL: https://chromiumcodereview.appspot.com/10752021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146007 0039d316-1c4b-4281-b951-d872f2087c98

Connect is called on the thread where Channel::Send will be invoked (and where messages should be dispatched). But Channel might be _created_ on some other thread. Therefore, we need to post data that we read to the thread on which Connect is called. NOT the thread where the Channel was created.

This fixes an issue where sync messages were never getting their replies, because the DidRecvMsg task was being run on the thread where ChannelProxy::Send was called, not the Channel thread (which is the IO thread in this case).

BUG=116317
TEST=


Review URL: https://chromiumcodereview.appspot.com/10698138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146006 0039d316-1c4b-4281-b951-d872f2087c98

Some embedders do not want the additional view added by using ContentView,
so we are splitting out ContentViewCore so the functionality can be used
without forcing an additional FrameLayout.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10704049

TBR=tedchoc@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10693134

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146005 0039d316-1c4b-4281-b951-d872f2087c98

- Add a delegate interface for controlling keyboard brightness.
- Call the interface on Alt+F6 and Alt+F7.

BUG=135482
TEST=added some tests to aura_shell_unittests


Review URL: https://chromiumcodereview.appspot.com/10694118

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146004 0039d316-1c4b-4281-b951-d872f2087c98

Fix a bug which caused the cutoff the status area right edge in vertical alignment.
Adjust ash tray status area and bubble position in vertical alignment.
Adjust layout and text color of vertical clock UI.

BUG=127577
TEST=Ash tray status and bubble should look right for left/right launcher.


Review URL: https://chromiumcodereview.appspot.com/10668009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146003 0039d316-1c4b-4281-b951-d872f2087c98

- F3 and Shift+F3 cycle windows forward and backward, respectively.
- F4 opens the app list.

BUG=123739
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/10735035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146002 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123295
TEST=existing unittests


Review URL: https://chromiumcodereview.appspot.com/10694111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146001 0039d316-1c4b-4281-b951-d872f2087c98

Some embedders do not want the additional view added by using ContentView,
so we are splitting out ContentViewCore so the functionality can be used
without forcing an additional FrameLayout.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10704049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146000 0039d316-1c4b-4281-b951-d872f2087c98